KS
← All projectsKeystone

Keystone 3 firmware

Open-source device firmware for Keystone 3 hardware wallets.

BitcoinHardware walletsNormal
Repository coverage

553 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

119security candidates294second-pass queue551AI analyses
9commits · 30 days
37commits · 60 days
279commits · 180 days
504commits · 365 days
Backfill bands
Aug 5 → Feb 6260 seen14 candidatesComplete
Feb 6 → Jun 6117 seen7 candidatesComplete
Jun 6 → Jul 639 seen4 candidatesComplete
Jul 6 → Aug 5115 seen4 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

42/100 average clarity
35Strong · 80–100
72Adequate · 60–79
211Thin · 40–59
235Opaque · 0–39
39security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
soralit11634116248
Adam Tucker931193263
aaron30430248
Soralit959154
ww351268717652176026
willwang15215025
John Boyd626088
github-actions[bot]323076
Aaron Chen222068
Qkin-Keystone26126036
qkin12112050
Greg Pfeil414071
Analysis record

Published AI watches

Last scanned 17 minutes ago

Low 42 AI analysisMessage 58 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2293 from KeystoneHQ/merge/v3.1.0

This is a large firmware release merge (v3.1.0) for the Keystone 3 hardware wallet. The visible changes are mostly a major FreeRTOS kernel upgrade (from v10.x to v11.3.0), build-system improvements, and user-facing feature tweaks such as b…

FreeRTOS kernel major version upgrade (10.x -> 11.3.0) with MPU hardeningSwitch from ARM_CM4F non-MPU port to ARM_CM4_MPU portNew MPU configuration flags: configTOTAL_MPU_REGIONS=8, configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1, configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0
0c0ae467by stone+59616−26981300 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 48 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci (#2292)

This commit only updates a Git submodule pointer in a release-tracking file. The actual code change is a one-line pointer update from one commit hash to another in a file named 'keystone3-firmware-release'. There is no visible security-rel…

90d1c789by Soralit+1−11 file
No security note in commit
Informational 15 AI analysisMessage 40 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. No source code, build scripts, CI configuration, or security-related files are changed in the visible diff. There is no evidence…

a7f6db29by Soralit+1−11 file
No security note in commit
Moderate 58 AI analysisMessage 28 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

release 3.1.0

This is a large firmware release commit (version 3.1.0) for the Keystone 3 hardware wallet. The most significant change visible in the diff is a major upgrade of the FreeRTOS real-time operating system kernel from version 10.x to 11.3.0, c…

FreeRTOS major version upgrade (10.x → 11.3.0) with MPU port enabledNew MPU sandbox task/runtime/validator files addedconfigENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1 and configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0 set
2b007a29by Soralit+59615−26980300 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.8 (#2291)

This commit is a routine version-bump merge for release v3.0.8. It only updates changelogs, a Git submodule pointer, and a build version number. There is no code change visible in the diff and nothing that suggests a security fix or vulner…

b5e8f9fcby github-actions[bot]+18−24 files
No security note in commit
Low 47 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.6 (#2290)

This firmware update adds support for Solana's new V1 transaction format and changes how oversized or malformed transaction details are displayed. The code introduces a dedicated parser for V1 messages with strict size and structure checks…

New parser enforces hard limits on V1 message fields and rejects malformed 0x81-prefix payloads instead of falling back to message signingCompute-budget instructions in V1 are explicitly ignored to prevent fee-display spoofingUI pagination change for large transaction details reduces truncation risk
87b78ae1by github-actions[bot]+564−2812 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

pin to new release config (#2285)

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. There is no code change visible in the diff, no description of what the new release config contains, and no security-related inf…

bc01c889by Aaron Chen+1−11 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

update the release repo (#2282)

This commit simply updates a Git submodule pointer for the project's release repository. There is no visible code change, no description of any security issue, and no indication this is anything other than a routine release-tracking update.

3ac7e802by Aaron Chen+1−11 file
No security note in commit
Moderate 59 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.4 (#2279)

This is a routine firmware release merge (v3.0.4) for the Keystone 3 hardware wallet. The bulk of the changes are UI tweaks, new feature support (Solana CLI, Lace Wallet), and hardening fixes found during an internal 'regular AI review'. T…

NUL-byte rejection in EIP-712 typed data parsingC-string conversion hardening against NUL bytesNull-pointer and UTF-8 validation added to UR parsing entry points
6ab436a2by github-actions[bot]+4960−548845 files
No security note in commit
Informational 13 AI analysisMessage 59 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Build fix (#2273)

This commit is a routine build-system and code-formatting fix. It resets cached CMake build options so each build starts from known defaults, makes cbindgen header-generation failures visible instead of silently ignored, runs Rust formatti…

8568a657by stone wang+8−145 files
No security note in commit
Low 44 AI analysisMessage 36 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

limit file count (#2272)

This commit adds a hard cap on how many files the device will list from its SD card when loading multi-signature Bitcoin wallet data. It also tightens up null-pointer and length checks while scanning directories. The likely goal is to prev…

Unbounded directory listing now bounded by FATFS_MAX_FILE_NUMBERNull-pointer guards added for fileName, number, and path parametersLength checks added before copying filenames into caller buffers
de6879c3by stone wang+31−146 files
No security note in commit
Low 46 AI analysisMessage 73 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2268 from KeystoneHQ/regular-review-fix

This commit tightens which old-style Bitcoin-like transactions the Keystone hardware wallet will accept. It now rejects raw protobuf Bitcoin (BTC) and Dogecoin (DOGE) legacy UTXO transactions, allowing only Bitcoin Cash (BCH), Dash (DASH),…

Deprecation of raw-protobuf Bitcoin transaction handlingRejection of unsupported legacy UTXO variants at multiple entry pointsShift from coin_code string matching to protobuf variant matching for legacy path eligibility
1c70d3d4by Soralit+134−166 files
No security note in commit
Moderate 61 AI analysisMessage 62 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

fix: mark legacy utxo transaction as deprecated and disable btc legacy transactions

This commit disables the older, raw-protobuf signing path for Bitcoin and Dogecoin transactions in the Keystone 3 hardware wallet firmware. It keeps the legacy path active only for Bitcoin Cash (BCH), Dash (DASH), and Litecoin (LTC). The c…

Disables a legacy transaction parsing/signing code path for Bitcoin and DogecoinAdds explicit rejection checks before raw transaction parsing, checking, signing, and view routingSwitches discriminator from coin_code string to protobuf transaction variant to prevent spoofing
1fcd2346by Soralit+134−166 files
No security note in commit
Moderate 63 AI analysisMessage 58 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2264 from KeystoneHQ/regular-review-fix

This firmware update is a routine 'regular review fix' that hardens how the Keystone 3 hardware wallet checks and displays several cryptocurrency transactions before signing. The most important security changes are: (1) the sign button is …

Sign slider disabled until parse success prevents premature approvalArweave DataItem tag-count mismatch now rejected in pre-checkAvalanche transaction re-validated by type in pre-check, tampered asset ID rejected
87c7e7e2by Soralit+623−20423 files
No security note in commit
Moderate 67 AI analysisMessage 58 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2263 from KeystoneHQ/driver-optimize

This commit updates the hardware random number generator (TRNG) driver in a cryptocurrency hardware wallet firmware. It adds detection for a physical fault/attack signal from the TRNG and, if triggered, wipes the random data and aborts via…

Added TRNG fault/attack status detection (TRNG_IT_RNG0_ATTACK)Zeroization of sensitive local buffer and output buffer on TRNG failureAssertion abort on detected TRNG attack condition
a409efe0by Soralit+29−51 file
No security note in commit
Moderate 59 AI analysisMessage 18 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

driver optimzie

This commit updates the hardware random number generator (TRNG) driver in a cryptocurrency hardware wallet firmware. It adds detection for a physical tamper/attack signal from the TRNG chip and, if an attack is detected, wipes the random d…

New check of TRNG_IT_RNG0_ATTACK tamper/attack interrupt statusFailure path now zeroes output and local buffer before abortingAddition of ASSERT guards and secure memset_s usage
25f3d951by ww3512687+29−51 file
No security note in commit
Moderate 61 AI analysisMessage 57 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

fix: regular ai review fix

This firmware update for the Keystone 3 hardware wallet fixes several security and safety issues found during an internal AI-assisted review. The most important changes are: (1) the signing slider is now disabled until a transaction is ful…

Signing slider disabled until parse success prevents approval of malformed transactionsArweave DataItem tag-count mismatch rejected in pre-check before confirmation pageAvalanche transaction re-validated by type during fingerprint check
edbeae79by soralit+623−20423 files
No security note in commit
High 76 AI analysisMessage 58 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2262 from KeystoneHQ/regular-review-fix

This firmware update fixes several security and safety issues found during a regular AI-assisted code review. The most important changes are: (1) Zcash wallet data is now encrypted with a key derived from the wallet seed and a fresh random…

Zcash UFVK encryption key changed from sha256(password) to seed-derived BIP32 keyZcash UFVK IV changed from deterministic seed-derived value to fresh TRNG-generated IV per blobZcash UFVK storage format now uses magic-prefixed blob with embedded IV and rejects legacy blobs
04d942ffby Soralit+1852−52633 files
No security note in commit
High 80 AI analysisMessage 57 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

fix: regular AI review and fix

This firmware update fixes several security and safety issues found during an internal AI-assisted review. The most important changes are: (1) Zcash wallet data was being encrypted with a key derived from the user's login password and a fi…

Zcash UFVK encryption key changed from sha256(login password) to seed-derived BIP32 keyZcash UFVK IV changed from deterministic seed-derived value to fresh TRNG-generated IV per encryptionNew 'z2' UFVK blob format stores IV with ciphertext; legacy blobs rejected/migrated
776d8832by soralit+1852−52633 files
Vendor flagged security relevance
Moderate 59 AI analysisMessage 58 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2260 from KeystoneHQ/replace-lvgl-rand

This commit replaces the on-screen keyboard shuffle and a word-list randomizer so they use the device's true random-number generator (TRNG) instead of LVGL's weaker pseudo-random function. The change is defensive: it removes a source of pr…

Replaced pseudo-random generator with hardware TRNG in security-sensitive shuffle operationsRemoved fixed-range modulo reduction bias source (`lv_rand(0, 2048) % n`)Changed include from LVGL UI library to device TRNG driver in utility code
230abd77by Soralit+8−32 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritydocs(zcash): rename preflight FUTURE marker to omitted-field-recomputeby Adam Tucker · 0ace2edc · Jul 7, 2026 · 1 fileMessage 85 · StrongInformational 15Details
Commit message · Adam Tucker

docs(zcash): rename preflight FUTURE marker to omitted-field-recompute

The previous tag "qr-v2-omitted-fields" collided with this project's
established use of "QR" for quantum-recoverable notes and referenced an
unpinned "v2". Rename to describe the step plainly.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit only renames a future-work comment marker in the Zcash code from 'qr-v2-omitted-fields' to 'omitted-field-recompute'. No actual code behavior changes; it is purely a documentation-style edit to avoid confusing terminology. There is no security issue present.

Lower-prioritystyle(zcash): rustfmt the checked-PCZT additionsby Adam Tucker · a808c11b · Jul 7, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Adam Tucker

style(zcash): rustfmt the checked-PCZT additions

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only reformats existing Rust code to match the project's style rules (rustfmt). No behavior, logic, or security properties of the Zcash PCZT handling changed.

Lower-priorityrefactor(zcash): drop ufvk from sign FFI and retire byte-level postflightsby Adam Tucker · 4f0442e6 · Jul 7, 2026 · 4 filesMessage 62 · AdequateLow 27Details
Commit message · Adam Tucker

refactor(zcash): drop ufvk from sign FFI and retire byte-level postflights

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 27/100

This commit refactors how Keystone's Zcash signing code handles shielded transactions. It removes several old byte-level 'preflight' and 'postflight' checks and no longer passes a full viewing key (ufvk) into the final signing functions. The change appears to be a cleanup that moves verification earlier in the workflow, but the commit message and diff alone do not clearly state whether any security bug is being fixed. Without external references, it is hard to tell if this is a hardening change or just routine refactoring.

Lower-priorityfeat(zcash): drive batch display/sign from the checked batch containerby Adam Tucker · 843d4513 · Jul 7, 2026 · 1 fileMessage 62 · AdequateLow 31Details
Commit message · Adam Tucker

feat(zcash): drive batch display/sign from the checked batch container

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 31/100

This commit changes how a Zcash hardware wallet handles batches of transactions. Previously, the signing and display code used the raw, unchecked batch data directly. After the patch, the code first runs a checking function that produces a validated 'checked batch' object, stores it, and then uses only that validated object for parsing details shown to the user and for signing. This is a defensive refactor that reduces the risk of signing a transaction that differs from what was reviewed on screen, but the commit itself does not claim to fix a specific reported vulnerability.

Lower-priorityrefactor(zcash): route batch FFI through per-message checked preflightby Adam Tucker · a776ed69 · Jul 7, 2026 · 1 fileMessage 62 · AdequateLow 32Details
Commit message · Adam Tucker

refactor(zcash): route batch FFI through per-message checked preflight

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 32/100

This commit rewrites how the Keystone hardware wallet handles Zcash batch transactions. Instead of checking each transaction message separately at every step, it now runs a single 'preflight' check that normalizes the messages, stores the checked result in a new container, and then requires that exact checked container for parsing and signing. The goal is to make sure the device signs only what it already inspected, reducing the chance that a malicious or malformed transaction slips through. The change is gated behind the 'cypherpunk' feature and only affects Zcash batch signing.

Lower-priorityfeat(zcash): add batch-policy preflight for checked batch messagesby Adam Tucker · 1753fe42 · Jul 7, 2026 · 1 fileMessage 62 · AdequateInformational 12Details
Commit message · Adam Tucker

feat(zcash): add batch-policy preflight for checked batch messages

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 12/100

This commit adds a new Rust function for Zcash that pre-checks a batch of private (shielded) transaction data before signing. It is a feature addition with explicit safety checks and tests; the diff itself does not show a vulnerability being fixed.

Lower-priorityfeat(zcash): store checked_PCZT in C and drive display/sign from itby Adam Tucker · d88c86ec · Jul 7, 2026 · 1 fileMessage 62 · AdequateLow 26Details
Commit message · Adam Tucker

feat(zcash): store checked_PCZT in C and drive display/sign from it

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 26/100

This commit refactors how the Keystone hardware wallet handles Zcash transaction data. Previously, the wallet parsed and signed directly from the raw incoming transaction data. Now it first runs a 'check' function that produces a validated intermediate object (checked_PCZT), stores that object, and uses it for both on-screen display and signing. The change also adds cleanup logic to free that stored object. This is a defensive code-quality improvement that reduces the chance the wallet will display one version of a transaction but sign a different one.

Lower-priorityrefactor(zcash): route single-tx FFI through checked-PCZT preflight/signby Adam Tucker · 15f21756 · Jul 7, 2026 · 1 fileMessage 62 · AdequateLow 32Details
Commit message · Adam Tucker

refactor(zcash): route single-tx FFI through checked-PCZT preflight/sign

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 32/100

This commit changes how the Keystone hardware wallet handles Zcash transactions. Previously, the wallet checked a transaction and then signed it in separate steps, with the signing step accepting any raw transaction object. Now, the check step produces a verified, normalized transaction object (a 'checked PCZT'), and the signing and parsing steps require that verified object. This is a defensive refactor designed to prevent a malicious or malformed transaction from bypassing the check step and being signed or displayed. It is a security-hardening change, not an active bug fix for a known exploit.

AI review queuedfeat(zcash): sign checked PCZTs with a single parse and in-memory postflightby Adam Tucker · 5354d2cf · Jul 7, 2026 · 2 filesMessage 62 · AdequateLow 29Details
Commit message · Adam Tucker

feat(zcash): sign checked PCZTs with a single parse and in-memory postflight

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 29/100

This commit adds a new, more efficient way to sign Zcash shielded transactions on Keystone hardware wallets. Instead of parsing and serializing the transaction multiple times, it parses once, signs in memory, and verifies signatures before returning the result. The change also preserves the checked/verified transaction data through the signing process rather than discarding it. There is no clear security bug being fixed; it appears to be a hardening and performance improvement for the Zcash cypherpunk feature.

Lower-priorityfeat(zcash): add single-parse preflight that normalizes checked PCZTsby Adam Tucker · eb999d5f · Jul 7, 2026 · 1 fileMessage 62 · AdequateInformational 18Details
Commit message · Adam Tucker

feat(zcash): add single-parse preflight that normalizes checked PCZTs

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 18/100

This commit refactors Zcash PCZT (Partially-Created Zcash Transaction) handling in the Keystone hardware wallet firmware so that parsing, security checks, and re-serialization can happen in a single pass. It does not remove any existing checks; it mainly adds helper functions and a new public 'preflight' API that returns a normalized, checked version of the transaction bytes. The change appears to be a defensive code-quality improvement rather than a fix for an active vulnerability.

Lower-priorityfeat(zcash): add ZcashCheckedPczt FFI container with digest bindingby Adam Tucker · 3b0ac590 · Jul 7, 2026 · 2 filesMessage 62 · AdequateInformational 12Details
Commit message · Adam Tucker

feat(zcash): add ZcashCheckedPczt FFI container with digest binding

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 12/100

This commit adds a new Rust data container called ZcashCheckedPczt for the Zcash cryptocurrency support in the Keystone 3 hardware wallet firmware. It stores preflight-checked transaction bytes and a SHA-256 fingerprint (digest) so that later signing steps can verify the data has not been swapped or corrupted. It also adds a matching memory-free function for C callers. There is no bug fix or security patch here; it is a new defensive feature.

Security candidateenhance the data content checking on the boot update logicby aaron · b10a29b0 · Jul 7, 2026 · 1 fileMessage 50 · ThinHigh 71Details
Commit message · aaron

enhance the data content checking on the boot update logic

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
boot or update path
AI analysis · High 71/100

This commit adds safety checks to the bootloader update code in a cryptocurrency hardware wallet. Before the change, the firmware could trust attacker-controlled length values read from a staged update image, potentially allowing a malicious or malformed update to copy too much data, loop too many times, or write past a fixed-size buffer. The patch validates the boot image length and caps the per-loop copy size, which reduces the risk of memory corruption or unauthorized flash writes during a boot update.

Lower-priorityenhance the fp data checking logicby aaron · 7d5f456b · Jul 6, 2026 · 1 fileMessage 45 · ThinHigh 71Details
Commit message · aaron

enhance the fp data checking logic

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · High 71/100

This commit tightens how the Keystone hardware wallet's fingerprint sensor driver checks incoming data lengths. Before the change, the code could be tricked into reading or writing past the end of a fixed-size buffer if a malformed fingerprint message claimed a bogus length, or it could misread the length bytes and act too early. The patch adds bounds checks, resets state on bad input, and fixes a timing issue when deciding whether both length bytes have arrived. This is a defensive hardening fix for a likely buffer overflow / out-of-bounds access in interrupt-driven fingerprint UART traffic.

Lower-priorityshow the se gen version on the about the welcome UI pageby aaron · 36e1d3a6 · Jul 6, 2026 · 3 filesMessage 50 · ThinInformational 15Details
Commit message · aaron

show the se gen version on the about the welcome UI page

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply adds the secure-element generation number (for example, a chip revision identifier) next to the firmware version string on three user-interface screens: the About page, the device-info page, and the welcome/setup page. It is a cosmetic display change with no security effect.

Security candidatefeat(se): Move 2 W1 — SE generation detection, gen-isolated backend, gen-1 page-8 gateby aaron · 57a92dcd · Jul 3, 2026 · 36 filesMessage 100 · StrongModerate 59Details
Commit message · aaron

feat(se): Move 2 W1 — SE generation detection, gen-isolated backend, gen-1 page-8 gate

- SeGen_t + GetSeGen(): classify the SE generation from the IMMUTABLE locked config manifest only (countMatch/chipOptions/slotConfig[8,13]/keyConfig[4,7,8,11,13]); fail-closed on UNPROVISIONED/INVALID. match_count is NOT used for classification (mutable; a transient slot-8 read must not flip a healthy device to INVALID).

- SeAccountBackend vtable + SeBackend() dispatcher: gen-1 wrappers map to the existing legacy derivation (derive_608/provision_608/on_unlock_success no-op); gen-2 stubs (filled in W2-W9); SeBackend() returns NULL for UNPROVISIONED/INVALID (fail closed).

- Gate the legacy page-8 wipe to SE_GEN_1 at the caller (AccountManagerInit) so it can never erase a gen-2 R_wrapped.

Scaffolding only: vtables in se_manager.c for now (physical split to src/managers/se/ during the gen-1 extraction); no callers wired -> zero runtime change.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>

add the function seCounter, matchCounter, rearm etc for se gen2

tmp

refactor the gen2 functions and add some functions in the driver

add the function for the gen2 R and K608 related usage

Gen2Provision608

change Gen2Provision608 and clear the secret K608

refactor the 608b logic and set add gen1 and gen2 backend logic

fix the building issues

fix the paras issues

update the solt/key config

show the se gen version in the device info

get the exsiting pwd to get R when adding the 2/3 wallet

check the device bricked in init on gen2

destroy the account and wipe device setting

add the se account status checking logic and change pwd logic

unset the pwd after change pwd and for gen2 use new way to get the existing account number

disable lock on add wallet and change password/pin

adjust current wallet limit and clear the r passs value as required

add the feature for forget password

fix the wrong pin limit issue and remove the logs

feat: add the weak pin modal

fix simulator and disable boot checking for dev build

fix: the weak-passcode modal free issue

clear the pw for R when lock the device

add data checking function when provision608 before R generation

init the view with g_proveOwnershipDone to false

roll kdf_i in the data check failed

set the state after all passed zero

fix the possible save account issues

prevent the pin dup try when reached back to lock view

add log for desstory account

fix the initail value issue on KeyboardWidget

fix: remove bump on the counter to enlarge the lifetime

refactor the code to move gen decision into the se backend

default to gen2 config in the blank chip

check the operation result to avoid mutation issue

fix the simulator

reorder the wipe function steps

add 10 limit on the password check try

drop the current working flow(add-wallet, change-pin etc) to home view if the password try reached limit and fix the memory leak issue

fix the R Recovery issue for nav back and forth on adding wallet view

fix the issue of drop forget pw flow

protect test R_wrapped value to prevent zero value caculation

remove the ForceLockScreen and fix create-wallet missing R issue

R protect: when forget pass, retype the same wallet pw and seed return not pass

clean the comment and salt value

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
access controlcryptography-sensitive pathsigning or wallet path
AI analysis · Moderate 59/100

This is a large firmware commit for the Keystone 3 hardware wallet that restructures how the secure element (SE) chip is used. It introduces a generation-aware backend so the firmware can support two different SE configurations (gen-1, the current fielded design, and gen-2, a new production design) in one binary. The patch moves legacy gen-1 key derivation into its own file, adds a gen-2 backend with a different key-derivation scheme, adds lifecycle status pages so interrupted wallet create/change-PIN/delete operations can be safely resumed or erased at boot, and adds UI flows for weak-passcode warnings and a 'forget password' ownership-proof step. It also gates the legacy page-8 wipe to gen-1 only so it cannot accidentally erase gen-2 data. The commit is described by its authors as scaffolding with no runtime change for current gen-1 devices, but it does add substantial new crypto and state-machine code.

Lower-prioritychore(zcash): bump orchard to 0.15.0-pre.1, repoint librustzcashby Adam Tucker · 242daed7 · Jun 30, 2026 · 5 filesMessage 95 · StrongLow 33Details
Commit message · Adam Tucker

chore(zcash): bump orchard to 0.15.0-pre.1, repoint librustzcash

Move orchard from the git-pinned b2af0a11 (BundleProtocol API) to the
published crates.io 0.15.0-pre.1 (BundleVersion API), drop the
[patch.crates-io] orchard git pin, and repoint the librustzcash patches
from dc95dcef to ironwood-integration (644b1ecf), which already builds
against orchard 0.15.0-pre.1. zcash_vendor's orchard constraint moves from
0.14 to 0.15.0-pre.1; the graph resolves to a single orchard 0.15.0-pre.1.

0.15.0-pre.1 splits note encryption by version, which required two changes:

- decode_output_enc_ciphertext (the PCZT trial-decrypt path) hardcoded
OrchardDomain (V2) and could not decrypt Ironwood (V3) actions. It now
selects IronwoodDomain for V3 notes and OrchardDomain for V2, keyed on the
action's note version.

- The sample-PCZT test fixtures had the same V2/V3 domain issue for the
Ironwood note, and minted their V2 Orchard source notes via an orchard_v3
coinbase, which 0.15.0-pre.1 now prohibits (the cross-address-restricted
Orchard pool forbids coinbase bundles). They now use IronwoodDomain for the
Ironwood note and mint the Orchard notes via orchard_v2, producing the same
V2 note.

Verified: cargo test -p app_zcash (cypherpunk) 90 passed incl. the
lean-sighash oracle and Ironwood verify/sign/parse tests; multi_coins 38
passed; clippy clean.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Low 33/100

This commit updates the Zcash cryptography libraries inside the Keystone hardware wallet firmware. The main functional change is a bug fix: when the wallet tries to read encrypted Zcash note details, it now correctly chooses the decryption method for the newer 'Ironwood' (V3) notes instead of always using the older 'Orchard' (V2) method. Before this change, V3 notes could not be decrypted, which could break or mislead transactions involving the newer Zcash shielded pool. The rest of the change is dependency version bumps and test fixture adjustments.

Security candidatefix buildby ww3512687 · 5e26e323 · Jun 29, 2026 · 1 fileMessage 0 · OpaqueInformational 10Details
Commit message · ww3512687

fix build

0/100 · OpaqueMessage clarity
! Very short subject! Too few words to establish purpose! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
boot or update path
AI analysis · Informational 10/100

This is a one-line build fix that changes a padding length constant from 1 to 2 in a file used only for Bitcoin-only firmware builds. There is no indication in the commit of any security issue, vulnerability, or functional bug. It appears intended solely to resolve a compilation or linker error.

AI review queuedadd 2.5.0 changelogby bianminyan · 281163f3 · Jun 26, 2026 · 2 filesMessage 38 · OpaqueInformational 15Details
Commit message · bianminyan

add 2.5.0 changelog

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only adds text to two changelog files describing a new firmware version (2.5.0). It does not change any executable code, configuration, or security controls. The changelog mentions improvements to dice-roll entropy validation and unlock passcode verification, but no actual code changes are present in this commit, so it cannot introduce or fix a vulnerability on its own.

Lower-prioritychore: bump beta versionby soralit · 5bd12887 · Jun 26, 2026 · 1 fileMessage 40 · ThinInformational 15Details
Commit message · soralit

chore: bump beta version

40/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes a single number in a version header, increasing the beta version from 1 to 2. There is no code change that affects security, functionality, or behavior of the firmware.

Security candidatefix(zcash): sign shielded PCZTs without RoleSigner to fit the device stackby Adam Tucker · 11592ebc · Jun 26, 2026 · 3 filesMessage 100 · StrongModerate 54Details
Commit message · Adam Tucker

fix(zcash): sign shielded PCZTs without RoleSigner to fit the device stack

The cypherpunk shielded PCZT signing path used the upstream pczt RoleSigner,
which reconstructs a full TransactionData for every bundle just to compute the
32-byte ZIP-244 sighash. That setup alone needs ~61 KB of stack, well over the
26 KB UiDisplayTask budget, so signing an Orchard->Ironwood migration batch
overflowed the task stack and the device reset into firmware verification.

Replace RoleSigner with the lean signer used before Ironwood: low_level_signer
driven in place, with the sighash computed by the in-repo byte-level
pczt_ext::shielded_sig_commitment instead of a TransactionData rebuild. Extend
that hasher to the v6 (NU6.3) Orchard and Ironwood commitment domains so it
stays correct for migration transactions. This restores the pre-Ironwood
signing footprint (~45 KB on host, the same as the path that already signs
shielded Orchard on shipping Keystones) while supporting Ironwood.

pczt_ext (zcash_vendor):
- digest_orchard_v6 / digest_ironwood_v6 and a v6 branch in
shielded_sig_commitment: v6 bundle personalizations, anchor omitted from the
effects digest, the 5-node to_hash_v6 layout.
- sign_ironwood driver mirroring sign_orchard; a shared sign_orchard_action
that defers the sign/skip decision to the signer (wallet-controlled
zero-value spends are still signed; tx_modifiable is cleared only when a new
signature is added).

app_zcash:
- A lean SeedSigner (PcztSigner) deriving keys and signing actions in place,
preserving the strict per-action validation from the removed collect path
(ZIP 32 derivation shape, dummy_sk rules, already-signed skip, per-account
key cache, PcztNoMyInputs).
- validate_supported_pczt rejects v6 PCZTs carrying a Sapling spend: the lean
hasher implements the Orchard/Ironwood v6 domains but not the v6 Sapling-spend
domain (distinct noncompact personalization, anchor omitted). Keystone never
signs Sapling spends; Sapling outputs are version-independent and remain
supported.

Oracle tests assert the lean sighash is bit-exact against
RoleSigner::shielded_sighash for Orchard-only, dual-pool migration, and
Ironwood-spend shapes, so any upstream sighash change fails CI rather than
producing wrong on-device signatures.

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarymemory safetydefensive validationsigning or wallet path
AI analysis · Moderate 54/100

This commit fixes a crash in the Keystone hardware wallet when signing certain advanced Zcash transactions. The previous code used a heavy upstream signing helper that needed too much memory, causing the device to reset during an Orchard-to-Ironwood migration. The patch replaces it with a leaner, in-house signer and adds the new v6/Ironwood hash logic needed to keep signatures valid. It also rejects v6 transactions containing Sapling spends because the lean signer does not yet support that specific hash domain.

Lower-priorityfix: cypherpunk buildby soralit · 66939c74 · Jun 24, 2026 · 2 filesMessage 40 · ThinInformational 18Details
Commit message · soralit

fix: cypherpunk build

40/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 18/100

This is a tiny build-fix commit for a special feature flag called 'cypherpunk'. It changes the default Rust feature set used by developers and adds a missing 'Vec' import for Zcash code. There is nothing in the diff that alters how user funds, keys, or transactions are handled, and no security problem is visible.

Security candidatefix: remove duplicate SIG_BACKGROUND_UR_GENERATE_FAIL enumeratorby Adam Tucker · 1a8cfcb4 · Jun 24, 2026 · 1 fileMessage 85 · StrongInformational 15Details
Commit message · Adam Tucker

fix: remove duplicate SIG_BACKGROUND_UR_GENERATE_FAIL enumerator

The batch-signing change added a second SIG_BACKGROUND_UR_GENERATE_FAIL to
the GUI signal enum, which already defines it a few lines above. A duplicate
enumerator is a C redefinition error, and gui_views.h is included across the
UI layer, so the firmware would fail to build. Drop the duplicate.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit removes a duplicate entry in a list of internal software signal names used by the device's user interface. The duplicate would have caused the firmware to fail compilation, so the change is a straightforward build fix with no security relevance.

Security candidatechore: point ur-registry at upstream SDK revby Adam Tucker · ef575e15 · Jun 24, 2026 · 2 filesMessage 80 · StrongInformational 15Details
Commit message · Adam Tucker

chore: point ur-registry at upstream SDK rev

The Zcash batch registry types have merged into the upstream
keystone-sdk-rust repo, so the valargroup fork pin is no longer needed.
Repoint ur-registry to the upstream rev that carries them.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
access control
AI analysis · Informational 15/100

This commit simply switches a software dependency from a temporary community fork back to the project's own official upstream repository. The code being used is the same feature (Zcash batch registry support); it has just been merged into the official repo. There is no indication of a security problem, fix, or vulnerability.

Security candidateAdd Zcash batch signing for shielded PCZTsby Adam Tucker · 745330f6 · Jun 24, 2026 · 32 filesMessage 45 · ThinLow 37Details
Commit message · Adam Tucker

Add Zcash batch signing for shielded PCZTs

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet pathparser or protocol path
AI analysis · Low 37/100

This commit adds a new Zcash batch-signing feature for shielded transactions and fixes a UI bug where Zcash signing could freeze if the response QR code could not be generated. The changes introduce new Rust code to validate, parse, and sign batches of Zcash PCZT messages, plus new C UI screens to review and approve those batches. It also tightens error handling so that QR/USB generation failures are reported instead of leaving the device stuck. There is no direct evidence in the commit of an exploitable vulnerability, but the size and complexity of the new signing path means it should be reviewed carefully.

Lower-prioritychore: bump beta versionby soralit · 4e28d917 · Jun 24, 2026 · 1 fileMessage 40 · ThinInformational 15Details
Commit message · soralit

chore: bump beta version

40/100 · ThinMessage clarity
✓ Subject identifies a change✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes a software version number in a header file, lowering the minor version from 12.5.0 to 12.4.9 and keeping the beta flag. There is no functional code change and no security relevance visible in the diff.