test(zcash): trim legacy v6 rejection comments
What the developer wrote
Authored by Adam Tucker
test(zcash): trim legacy v6 rejection comments
What changed, and why it matters
This commit only removes explanatory comments from three Zcash test files. No code behavior, logic, or security checks were changed. It is a documentation cleanup inside test code and has no security relevance.
No action required; this is a non-functional comment-only cleanup in test code.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit deletes nine lines of inline comments from legacy_tests modules in rust/apps/zcash/src/lib.rs, parse.rs, and sign.rs. The comments explained why the tests did not set an Ironwood anchor when constructing a V6 PCZT. The actual test code, including the assertions that the legacy path rejects V6 PCZTs, remains unchanged. There are no functional modifications.
Changed components
rust/apps/zcash/src/lib.rsrust/apps/zcash/src/pczt/parse.rsrust/apps/zcash/src/pczt/sign.rsInspect captured patch +0 / −9
diff --git a/rust/apps/zcash/src/lib.rs b/rust/apps/zcash/src/lib.rs
index 4475028..d0c7c46 100644
--- a/rust/apps/zcash/src/lib.rs
+++ b/rust/apps/zcash/src/lib.rs
@@ -399,9 +399,6 @@ mod legacy_tests {
#[cfg(zcash_unstable = "nu6.3")]
#[test]
fn legacy_check_rejects_v6_pczt() {
- // `Creator::new(Nu6_3, ..)` alone yields a V6 PCZT (tx_version V6); the legacy
- // path rejects it on version, so no Ironwood anchor is needed (and
- // `with_ironwood_anchor` is orchard-feature-gated, unavailable in this build).
let pczt = Creator::new(
BranchId::Nu6_3.into(),
10,
diff --git a/rust/apps/zcash/src/pczt/parse.rs b/rust/apps/zcash/src/pczt/parse.rs
index e86b6af..aa9b5bb 100644
--- a/rust/apps/zcash/src/pczt/parse.rs
+++ b/rust/apps/zcash/src/pczt/parse.rs
@@ -813,9 +813,6 @@ mod legacy_tests {
#[cfg(zcash_unstable = "nu6.3")]
#[test]
fn legacy_parse_rejects_v6_pczt() {
- // `Creator::new(Nu6_3, ..)` alone yields a V6 PCZT (tx_version V6); the legacy
- // path rejects it on version, so no Ironwood anchor is needed (and
- // `with_ironwood_anchor` is orchard-feature-gated, unavailable in this build).
let pczt = Creator::new(
BranchId::Nu6_3.into(),
10,
diff --git a/rust/apps/zcash/src/pczt/sign.rs b/rust/apps/zcash/src/pczt/sign.rs
index 45e891e..f832752 100644
--- a/rust/apps/zcash/src/pczt/sign.rs
+++ b/rust/apps/zcash/src/pczt/sign.rs
@@ -756,9 +756,6 @@ mod legacy_tests {
#[cfg(zcash_unstable = "nu6.3")]
#[test]
fn legacy_signing_rejects_v6_pczt() {
- // `Creator::new(Nu6_3, ..)` alone yields a V6 PCZT (tx_version V6); the legacy
- // path rejects it on version, so no Ironwood anchor is needed (and
- // `with_ironwood_anchor` is orchard-feature-gated, unavailable in this build).
let pczt = Creator::new(
BranchId::Nu6_3.into(),
10,
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.