Stop the wallet-prep countdown when its label goes (#2324)
What changed, and why it matters
This commit fixes a firmware crash and a timer-doubling bug in a cryptocurrency hardware wallet. If a user scanned a transaction too quickly after unlocking, a countdown timer could keep running after its on-screen label was destroyed, causing the device to crash when the timer tried to update the missing label. A related bug could also start a second timer before the first was stopped, making later countdowns tick twice as fast. The fix stops the timer whenever its label is removed.
Treat as a reliability/stability fix with possible security side effects (denial of service via device crash). Review the actual diff to confirm whether the timer callback can be abused beyond the reported crash path, and consider whether a CVE is warranted if the crash can be triggered by an attacker-controlled workflow.
Security signals we found
Use-after-free/dangling reference in UI timer callback
Orphaned timer leak causing accelerated countdown behavior
Firmware crash triggered by user timing (quick unlock → scan)
UI lifecycle mismatch between widget and periodic timer
Evidence from the diff
The patch addresses a use-after-free/style dangling-pointer issue in the wallet-prep countdown UI: a periodic timer callback continued to reference a label widget after the overlay containing that label was destroyed, leading to a crash. It also fixes a timer-leak bug where a second timer could be started while the first was still active, orphaning the first and causing g_countDown to be incremented by multiple callbacks. The fix extracts timer-stop logic and invokes it on label deletion, using an event-based approach. No diff was available and no vendor security disclosure was provided, so the exact scope and exploitability cannot be fully verified.
Changed components
Keystone 3 firmware wallet-prep countdown UICountdown timer/label widgetUnlock-to-scan transaction flowInspect captured patch +0 / −0
Diff not available from the source API.Why this scored 56/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.