AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 56 Bitcoin

Stop the wallet-prep countdown when its label goes (#2324)

Public commit record

What the developer wrote

Authored by Greg Pfeil

81/100 · Strong
Stop the wallet-prep countdown when its label goes (#2324)

If the timer outlived the overlay containing the label, the firmware would
crash when it tried to update the label. I ran into this when trying to scan a
transaction too quickly after unlocking.

This extracts the code that stops the timer, so it also gets stopped whenever
the label is deleted.

The event approach also fixes a bug where a second timer could be started
before the first is stopped, which orphans the first (ticking on forever) and
causes `g_countDown` to increment twice as fast for all subsequent timers.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit fixes a firmware crash and a timer-doubling bug in a cryptocurrency hardware wallet. If a user scanned a transaction too quickly after unlocking, a countdown timer could keep running after its on-screen label was destroyed, causing the device to crash when the timer tried to update the missing label. A related bug could also start a second timer before the first was stopped, making later countdowns tick twice as fast. The fix stops the timer whenever its label is removed.

Recommended action

Treat as a reliability/stability fix with possible security side effects (denial of service via device crash). Review the actual diff to confirm whether the timer callback can be abused beyond the reported crash path, and consider whether a CVE is warranted if the crash can be triggered by an attacker-controlled workflow.

Security signals we found

01

Use-after-free/dangling reference in UI timer callback

02

Orphaned timer leak causing accelerated countdown behavior

03

Firmware crash triggered by user timing (quick unlock → scan)

04

UI lifecycle mismatch between widget and periodic timer

Risk score

Why this scored 56/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 6/10
Evidence quality 2/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.