docs(zcash): say the anchor-clearing test mirrors the wallet's batch redaction
What changed, and why it matters
This commit only rewords a code comment in a Zcash test file. No program logic, behavior, or security properties changed. It is a documentation-only edit.
No action needed; this is a non-functional documentation change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff updates a single inline comment in rust/apps/zcash/src/pczt/sign.rs within the test_sign_pczt_ironwood_spend test. The comment now explains that clearing the anchor mirrors the wallet’s batch redaction and uses the full-anchor PCZT as an oracle, while preserving the original facts about the v6 Ironwood sighash not committing the anchor and client-provided anchors possibly remaining on the wire. No executable code was modified.
Changed components
rust/apps/zcash/src/pczt/sign.rsInspect captured patch +5 / −4
diff --git a/rust/apps/zcash/src/pczt/sign.rs b/rust/apps/zcash/src/pczt/sign.rs
index 4b9d8f6..45e891e 100644
--- a/rust/apps/zcash/src/pczt/sign.rs
+++ b/rust/apps/zcash/src/pczt/sign.rs
@@ -547,10 +547,11 @@ mod tests {
let base_sighash = RoleSigner::new(pczt.clone())
.expect("Ironwood PCZT signer should initialize")
.shielded_sighash();
- // The v6 Ironwood sighash must not commit the anchor, so clearing it
- // (the elided wire form batch children use) must leave the shielded
- // sighash unchanged; a client-provided anchor may equally stay on the
- // wire.
+ // Mirror the wallet's batch redaction: clearing the anchor rebuilds the
+ // anchor-elided request the wallet sends for batch children, with the
+ // full-anchor PCZT as its own oracle. The v6 Ironwood sighash does not
+ // commit the anchor, so the elided form must leave the shielded sighash
+ // unchanged; a client-provided anchor may equally stay on the wire.
let cleared_anchor_pczt = Redactor::new(pczt.clone())
.redact_ironwood_with(|mut r| r.clear_anchor())
.finish();
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.