docs(zcash): fix stale anchor-redaction rationale in the Ironwood sign test
What the developer wrote
Authored by Adam Tucker
docs(zcash): fix stale anchor-redaction rationale in the Ironwood sign test
The comment predates the upstream-main repin: the pczt updater has
post-parse anchor setters again (set_ironwood_anchor and friends), and
parse no longer substitutes a placeholder for a missing anchor - the
field is simply optional. State the actual invariant: the v6 sighash
does not commit the anchor, so the elided form signs identically, and a
client-provided anchor is equally valid left on the wire.
What changed, and why it matters
This commit only updates a code comment in a Zcash test file. It corrects an outdated explanation about why an anchor value can be removed during signing. No code behavior was changed, and there is no security issue present in the diff.
No action needed. This is a non-functional documentation fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The change is a documentation-only edit in rust/apps/zcash/src/pczt/sign.rs within a test module. It replaces a stale comment about anchor redaction behavior with a current rationale: the v6 Ironwood shielded sighash does not commit the anchor, so clearing it or leaving a client-provided anchor on the wire both produce the same signature. No executable logic, parsing rules, or cryptographic operations were modified.
Changed components
rust/apps/zcash/src/pczt/sign.rsInspect captured patch +4 / −3
diff --git a/rust/apps/zcash/src/pczt/sign.rs b/rust/apps/zcash/src/pczt/sign.rs
index e9b4ad0..4b9d8f6 100644
--- a/rust/apps/zcash/src/pczt/sign.rs
+++ b/rust/apps/zcash/src/pczt/sign.rs
@@ -547,9 +547,10 @@ mod tests {
let base_sighash = RoleSigner::new(pczt.clone())
.expect("Ironwood PCZT signer should initialize")
.shielded_sighash();
- // The v6 Ironwood sighash must not commit the anchor. The new stack has no
- // post-parse anchor setter, so redact the anchor instead: parse substitutes a
- // version-gated placeholder, and the shielded sighash must be unchanged.
+ // The v6 Ironwood sighash must not commit the anchor, so clearing it
+ // (the elided wire form batch children use) must leave the shielded
+ // sighash unchanged; a client-provided anchor may equally stay on the
+ // wire.
let cleared_anchor_pczt = Redactor::new(pczt.clone())
.redact_ironwood_with(|mut r| r.clear_anchor())
.finish();
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.