AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Moderate 59 Bitcoin

Merge release v3.0.4 (#2279)

Public commit record

What the developer wrote

Authored by github-actions[bot]

76/100 · Adequate
Merge release v3.0.4 (#2279)

* fix: regular AI review and fix

* fix: solana transaction scroll

* fix: sol ui fix

* fix: eth ui font

* fix: fix UI issues (#2274)

* fix: fix UI issues (#2275)

* Regular review fix (#2276)

* fix: fix UI issues

* chore: fix font

* add 3.0.4 changelog (#2277)

* fix build (#2278)

---------

Co-authored-by: soralit <soralitria@gmail.com>
Co-authored-by: bianminyan <126669324+bianminyan@users.noreply.github.com>
Co-authored-by: stone wang <35837388+ww3512687@users.noreply.github.com>
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This is a routine firmware release merge (v3.0.4) for the Keystone 3 hardware wallet. The bulk of the changes are UI tweaks, new feature support (Solana CLI, Lace Wallet), and hardening fixes found during an internal 'regular AI review'. The security-relevant hardening includes: rejecting NUL bytes inside Ethereum EIP-712 typed-data messages, validating NUL bytes before converting Rust strings to C strings, adding null/UTF-8 checks when parsing UR payloads, replacing unsafe strcpy/sprintf with bounded versions, and fixing a format-string bug in a debug LCD print function. There is no public disclosure or CVE tied to this commit, and the vendor does not describe it as a security release.

Recommended action

Treat as a normal firmware update with embedded hardening fixes. Users should install v3.0.4 to benefit from the defensive improvements. Security teams may want to review the EIP-712 NUL-byte and C-string conversion changes for completeness, and confirm all call sites of PrintOnLcd now pre-format with snprintf.

Security signals we found

01

NUL-byte rejection in EIP-712 typed data parsing

02

C-string conversion hardening against NUL bytes

03

Null-pointer and UTF-8 validation added to UR parsing entry points

04

Bounded string copies (snprintf/strcpy_s) replacing unbounded sprintf/strcpy

05

Removal of variadic vsprintf in LCD debug print path

06

Key-derivation schema count limit added

07

Bitcoin fee-warning policy refinement for Dogecoin

Risk score

Why this scored 59/100

Our methodology →
Potential impact 18/30
Exploitability 12/25
Stealth signal 8/15
Affected reach 10/15
Confidence 7/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.