EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsActive incident
Repository coverage

1361 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

108security candidates322second-pass queue1084AI analyses
90commits · 30 days
200commits · 60 days
570commits · 180 days
1124commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
252Strong · 80–100
675Adequate · 60–79
388Thin · 40–59
46Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
SomberNight42533373163
ThomasV16511104163
ghost4376626170
f321x44128400070
Sander van Grieken12412112057
Felix54720070
user323062
ekzyis222053
accumulator28111072
Roman Zeyde515053
Sasha Zykov515075
Aaron Fiore414068
Analysis record

Published AI watches

Last scanned 34 minutes ago

Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11172 from accumulator/qml_crash_reporter_threading

This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…

Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
45ad42f7by Felix+4−11 file
No security note in commit
Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: crash reporter: handle threading.excepthook arguments

This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…

Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
2e7fe460by Sander van Grieken+4−11 file
No security note in commit
Low 40 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11154 from spesmilo/make_unsigned_tx_with_base_tx

This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…

Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
ff273162by ThomasV+4−11 file
No security note in commit
Low 29 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

wallet: make_unsigned_tx: follow-up prev

This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…

Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
462f631dby SomberNight+2−01 file
No security note in commit
Low 28 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11097 from SomberNight/202610_bump_deps

This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…

Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
84345fdcby ghost43+934−103048 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11139 from accumulator/consolidate_platform_checks

This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…

22e24580by ghost43+87−7619 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

consolidate platform checks into platform.py

This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…

9715f882by Sander van Grieken+87−7619 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

version: bump to 4.8.4

This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.

0c661eb8by f321x+1−11 file
No security note in commit
Low 29 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

make_unsigned_transaction: do not require coins if there is a base_tx

This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…

Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
876360deby ThomasV+2−11 file
No security note in commit
Informational 17 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11111 from accumulator/qml_bip39recovery_task_refactor

This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…

Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
896a68d7by Felix+44−332 files
No security note in commit
Informational 12 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: refactor BIP39 account scan to asyncio tasks.

This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…

00ed883aby Sander van Grieken+44−332 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: paytoedit: complete contacts to their key, not 'name <key>'

This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…

UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
dd1b50fbby f321x+47−132 files
No security note in commit
Informational 18 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11092 from f321x/qml_address_history_labels

This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…

No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
9242c505by Felix+334−8412 files
No security note in commit
Low 34 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: avoid potential Ok signal by tapping while dialog is closing,

This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…

Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
00f981edby Sander van Grieken+8−01 file
No security note in commit
Informational 21 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11091 from f321x/fix_num_parents_perf_simple

This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …

Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
4ec70746by ThomasV+82−463 files
No security note in commit
Informational 24 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11047 from fametrano/old-seed-odd-length

This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…

Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
fc31115eby ghost43+93−157 files
No security note in commit
Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11096 from f321x/followup_11094

This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…

Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
54c355feby Felix+9−75 files
No security note in commit
Informational 23 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11094 from devdavidejesus/fix-10760-storage-not-utf8

This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…

Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
2a20256fby Felix+10−12 files
No security note in commit
Informational 20 AI analysisMessage 65 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: show StorageReadWriteError to user instead of crash reporting it

This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…

No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
5a971b11by f321x+2−11 file
No security note in commit
Low 26 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

keystore: follow-up prev: small clean-up

This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…

Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
ead42d09by SomberNight+35−154 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedtest_checksum_non_asciiby Oren · 8c5af52c · Mar 15, 2026 · 1 fileMessage 18 · OpaqueInformational 12Details
Commit message · Oren

test_checksum_non_ascii

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 12/100

This commit adds a new automated test to verify that a checksum function correctly handles non-ASCII characters (like accented letters, Chinese, Japanese, Arabic, and Hebrew text). It does not change any production code. The test ensures that special characters are kept as-is rather than being converted to Unicode escape sequences before hashing. This is a quality-assurance change, not a security fix or vulnerability.

AI review queuedqml: rbf/cancel: fix type errorby f321x · d85985cd · Mar 9, 2026 · 1 fileMessage 68 · AdequateInformational 17Details
Commit message · f321x

qml: rbf/cancel: fix type error

self.oldfeeRate is initialized as int in `QETxRbfFeeBumper` and
`QETxCanceller`. However QML expects it to be a string. Initializing
it as string fixes the exception. Previously this didn't happen as
`Abstract_Wallet.add_info_from_wallet_and_network()` would never
return False, so the `get_tx()` method would immediately overwrite
the self.oldfeeRate variable with a string.

```
20.95 | D | gui.qml.qetxfinalizer | TxMonMixin.__init__
20.95 | E | gui.qml.qeapp.Exception_Hook | exception caught by crash reporter
TypeError: unable to convert a Python 'int' object to a C++ 'QString' instance
```

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 17/100

This commit fixes a type mismatch bug in Electrum's mobile/QML user interface. A fee rate value was stored as a number (0) but the QML interface expected text ('0'), causing a crash when certain code paths ran. The fix changes the initial value from a number to a string so the interface no longer crashes. There is no indication this could be used to steal funds or attack users remotely.

AI review queuedtransaction: re-raise NetworkException in add_info_from_networkby f321x · e8eee065 · Mar 9, 2026 · 1 fileMessage 81 · StrongInformational 21Details
Commit message · f321x

transaction: re-raise NetworkException in add_info_from_network

`Transaction.add_info_from_network` would swallow a `NetworkException`
even when `ignore_network_issues=False` is passed.
This causes `Transaction.add_info_from_wallet_and_network` to
incorrectly return True even if the operation failed.
If `QETxRbfFeeBumper` then incorrectly proceeds assuming the call was
successful `Abstract_Wallet.bump_fee()` would raise an `Exception("tx
missing info from network")`.
Should fix the traceback in
https://github.com/spesmilo/electrum/issues/5502#issuecomment-4021308427.

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 21/100

This is a bug-fix patch for the Electrum Bitcoin wallet. It corrects a logic error where a network failure was being silently swallowed instead of being reported, which could cause the wallet's fee-bumping feature to crash later with a confusing error. There is no indication this allows theft, remote code execution, or unauthorized access; it is a reliability and user-experience fix.

AI review queuedtests: lnpeer: make mpp_cleanup_after_expiry more robustby SomberNight · db003257 · Mar 4, 2026 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · SomberNight

tests: lnpeer: make mpp_cleanup_after_expiry more robust

As there are two htlcs, the `alice_htlc_resolved` Event might get set either once or twice by the time `alice_htlc_resolved.wait()` returns. The previous code was assuming that both htlcs are resolved by then, but it could happen that only one htlc was resolved, due to timing.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This commit only changes a test file. It makes an existing automated test more reliable by waiting for both payment parts to finish before checking the result, instead of assuming both finished at once. There is no change to the actual Electrum wallet or Lightning code that users run.

AI review queuedplugin: nwc: do budget accounting in msatby f321x · 3956bff0 · Mar 3, 2026 · 3 filesMessage 80 · StrongLow 48Details
Commit message · f321x

plugin: nwc: do budget accounting in msat

Keep track of the spent amount in msat instead of sat to prevent
issues due to rounding.
The budget is still specified in sat.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 48/100

This commit fixes a rounding bug in Electrum's NWC (Nostr Wallet Connect) plugin. The plugin lets users set a daily spending limit in satoshis, but it was internally tracking spent amounts in whole satoshis. Because Lightning invoices are priced in millisatoshis (one-thousandth of a satoshi), rounding down to satoshis could let a user or service spend slightly more than the intended daily limit over many small payments. The patch now tracks the budget in millisatoshis and converts the limit to millisatoshis for comparison, closing the rounding gap. It also migrates existing saved budget data from satoshis to millisatoshis.

AI review queuedcommon_qt: move QtEventListener and qt_event_listener decorator to common_qtby Sander van Grieken · 91efb3e1 · Mar 3, 2026 · 24 filesMessage 50 · ThinInformational 15Details
Commit message · Sander van Grieken

common_qt: move QtEventListener and qt_event_listener decorator to common_qt

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a straightforward internal code cleanup: it moves two shared pieces of Qt GUI plumbing (QtEventListener and the qt_event_listener decorator) from separate QML and Qt GUI utility files into a single common_qt utility file, then updates all the import statements across the project. There is no change to user-facing behavior, no bug fix, and no security-related change.

AI review queuedwallet_db: convert PaymentInfo amounts from 0 to Noneby SomberNight · fe5cb09e · Mar 2, 2026 · 4 filesMessage 93 · StrongInformational 22Details
Commit message · SomberNight

wallet_db: convert PaymentInfo amounts from 0 to None

When creating a "zero-amount" payment request, currently we save a PaymentInfo with a "None" amount.
I think there were a few releases in 2023 that saved PaymentInfos with a `0` amount instead. This was changed in #8659 [0], but as said there [1], a DB upgrade was not done.
Now an assert added in [2] is failing due to this inconsistency, for affected old wallets.
- I think to trigger that, one needs a wallet that has a payment request (with a `0` amount) created around that time, which is still unpaid.

This patch tries to restore consistency by enforcing None amounts.

fixes https://github.com/spesmilo/electrum/issues/10501

[0]: https://github.com/spesmilo/electrum/pull/8659
[1]: https://github.com/spesmilo/electrum/pull/8659#issuecomment-1777101285
[2]: https://github.com/spesmilo/electrum/commit/286fc4b86e4d23cb9af15b9061b3d709e7592bcb

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 22/100

This commit fixes a wallet-crash bug, not a security vulnerability. Some older Electrum wallets created 'zero-amount' Lightning payment requests in 2023 that were stored with an amount of 0 instead of the special 'no amount' marker (None). A later code change added a rule that received payment amounts cannot be 0, causing those older wallets to crash or fail to open. The patch converts the stored 0 values back to None during wallet database upgrade and prevents new 0 values from being created.

AI review queuedupdate block header checkpointsby SomberNight · d72b7411 · Feb 26, 2026 · 4 filesMessage 35 · OpaqueInformational 15Details
Commit message · SomberNight

update block header checkpoints

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit simply adds new Bitcoin block header checkpoints to Electrum's data files for mainnet, signet, testnet, and testnet4. Checkpoints are hardcoded reference points that help the wallet verify it is following the correct blockchain. There is no code change, no bug fix, and no security vulnerability visible in this diff.

AI review queuedfollow-up RELEASE-NOTESby SomberNight · 57bf8c89 · Feb 26, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · SomberNight

follow-up RELEASE-NOTES

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only edits the project's RELEASE-NOTES text file. It rephrases a sentence about how translators can apply to become proofreaders. There is no code change, no security fix, and no functional change to Electrum.

AI review queuedbump version to 4.7.1by f321x · eee2e858 · Feb 26, 2026 · 1 fileMessage 38 · OpaqueInformational 15Details
Commit message · f321x

bump version to 4.7.1

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only changes the software version number from 4.7.0 to 4.7.1 in a single file. It contains no security-related code changes and no functional changes at all.

AI review queuedsimplify prevby SomberNight · 10274c1c · Feb 24, 2026 · 1 fileMessage 18 · OpaqueLow 32Details
Commit message · SomberNight

simplify prev

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 32/100

This commit simplifies how Electrum stores secret Lightning payment preimages. It removes a code path that let callers leave a privacy flag unset (which previously kept the old value), and instead always defaults to not marking the preimage as public while still preventing a previously public preimage from becoming private. The change is a cleanup, but it slightly alters behavior: callers who used to rely on 'keep the old value' now get 'False' if no old value exists, and any old public mark is preserved. There is no clear security bug in the diff itself, but it touches sensitive secret-handling code.

AI review queuedlnsweep: safer maybe_reveal_preimage_for_htlc, add "is_preimage_public"by SomberNight · 0b2c7a8a · Feb 24, 2026 · 8 filesMessage 73 · AdequateModerate 58Details
Commit message · SomberNight

lnsweep: safer maybe_reveal_preimage_for_htlc, add "is_preimage_public"

"When should we reveal preimages onchain?"
This commit tries to simplify the thinking by making the observation:
- we can reveal preimages (actually in any context) if they are already public
- a preimage is public if any other lightning node knows it besides us
- if we learn the preimage from another LN node, it is public
- if we send update_fulfill_htlc, it becomes public
- if we see a preimage onchain, it is public

- in lnsweep._maybe_reveal_preimage_for_htlc:
- partial mpp check is not relevant if preimage is already public
- let's just always do KeepWatchingTXO, for sanity/safety

Co-authored-by: ThomasV <thomasv@electrum.org>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 58/100

This commit hardens how Electrum decides when to reveal secret payment proof values (called preimages) on the Bitcoin blockchain during Lightning channel force-closes. Previously, the wallet might have revealed a preimage too early if a multi-part payment was incomplete, which could let a sender pay less than the invoice asked for. The change tracks whether a preimage is already 'public' (known to other nodes or seen on-chain) and only reveals it on-chain when it is safe. It also makes sure Electrum keeps watching the relevant transaction output until the timeout, even if it cannot reveal the preimage yet.

AI review queuedtransaction: extend estimated_size() docstringby f321x · 3133148a · Feb 24, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · f321x

transaction: extend estimated_size() docstring

Extends the docstring of Transaction.estimated_size().

Co-Authored-By: SomberNight <somber.night@protonmail.com>

50/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds explanatory text to a code comment (docstring). It does not change any program logic, transaction calculations, or security behavior. There is no security issue here.

AI review queuedtest_wallet_vertical: test bump_fee raises for too low feeby f321x · f1e792cc · Feb 24, 2026 · 1 fileMessage 83 · StrongInformational 12Details
Commit message · f321x

test_wallet_vertical: test bump_fee raises for too low fee

Test that Abstract_Wallet.bump_fee() raises if the given feerate
of the replacement is equal to the feerate of the tx to bump as this
wouldn't be accepted to the mempool.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit only adds a new automated test to Electrum. The test checks that the wallet's 'bump fee' feature correctly refuses to create a replacement Bitcoin transaction when the new fee rate is not high enough to be accepted by the network. It does not change any production wallet code, so it cannot by itself introduce a security vulnerability or fix one in shipped software. It may, however, be regression coverage for an earlier behavioral fix.

AI review queuedtest_wallet_vertical: add test for dscancel fee estimateby f321x · 6c143fa9 · Feb 24, 2026 · 1 fileMessage 83 · StrongInformational 12Details
Commit message · f321x

test_wallet_vertical: add test for dscancel fee estimate

Check that dscancel properly raises CannotDoubleSpendTx if the
feerate of the new tx is lower than the tx to be cancelled.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit only adds a new automated test to Electrum. The test checks that the wallet correctly refuses to cancel a transaction if the replacement transaction does not pay a higher fee rate than the original. It does not change any production wallet code, so it cannot directly introduce or fix a security vulnerability in running software.

AI review queuedtest_wallet_vertical: add test for batch tx fee increaseby f321x · 6e1bf7c4 · Feb 24, 2026 · 1 fileMessage 95 · StrongInformational 12Details
Commit message · f321x

test_wallet_vertical: add test for batch tx fee increase

Adds unittest to check the fee increase when adding outputs to a base
tx. Supposed to prevent creating transactions that don't get accepted
like in this traceback:
```
broadcast_transaction error [DO NOT TRUST THIS MESSAGE]: "RPCError(1, 'the transaction was rejected by network rules.\\n\\ninsufficient fee, rejecting replacement ceeaef5ac7f82286e42ebd530e965fa4c7a6c11933d6b89d6d6f0ee2c69db839; new feerate 0.00001109 BTC/kvB <= old feerate 0.00001110 BTC/kvB
```

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit only adds a new automated test to Electrum. It does not change any production wallet code. The test checks that when a user adds extra outputs to an existing RBF (replace-by-fee) transaction, the new transaction's fee is high enough to be accepted by Bitcoin network relay rules. The commit message mentions a past broadcast error where a replacement transaction was rejected because its fee rate was not higher than the original's. This is a regression test, not a fix.

AI review queuedwallet_db: assert WalletDBUpgrader.storage is dictby f321x · a1f1b393 · Feb 20, 2026 · 1 fileMessage 73 · AdequateModerate 53Details
Commit message · f321x

wallet_db: assert WalletDBUpgrader.storage is dict

Assert `WalletDBUpgrader.data` is a regular in-memory dict and not
some StoredDict, so if an exception would happen during a wallet
db upgrade the partial changes don't get commited to disk.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 53/100

This commit adds a safety check to Electrum's wallet database upgrade code. It ensures that when the wallet file format is being upgraded, the data being modified is a plain in-memory copy, not a live disk-backed structure. The goal is to prevent a failed or partial upgrade from accidentally being written to disk, which could corrupt the wallet file.

AI review queuedwallet_db: handle non-existing parent_set_key in v65by f321x · 73a03249 · Feb 20, 2026 · 1 fileMessage 73 · AdequateLow 30Details
Commit message · f321x

wallet_db: handle non-existing parent_set_key in v65

Handles non-existing parent_set_key in _convert_version_65.

Fixes #10487

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 30/100

This commit fixes a bug in Electrum's wallet database upgrade code. When opening an older wallet file, the upgrade routine could crash because it expected a database field (parent_set_key) that wasn't always present. The fix makes the upgrade tolerate missing data. This is a reliability fix for wallet migration, not a remote attack vector.

AI review queuedqt: fix toolbar action exc in offline modeby f321x · 907fff46 · Feb 16, 2026 · 1 fileMessage 68 · AdequateInformational 20Details
Commit message · f321x

qt: fix toolbar action exc in offline mode

Fix exception when clicking on "Donate to server" in offline mode by not
showing the "Donate to server" menu action when no network is set.

Raise CancelledError in `fetch_bitcoin_paper` as
`_fetch_tx_from_network` already shows an according error message so the
second, subsequent error message shown by `on_error` is not useful if
`_fetch_tx_from_network` already failed.

```
63.53 | E | gui.qt.exception_window.Exception_Hook | exception caught by crash reporter
Traceback (most recent call last):
 File "/home/user/Documents/electrum/electrum/gui/qt/main_window.py", line 864, in donate_to_server
   d = self.network.get_donation_address()
       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute 'get_donation_address'
```

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 20/100

This commit fixes a harmless user-interface bug in Electrum's Qt desktop wallet. When running in offline mode, clicking 'Donate to server' in the Help menu caused a crash because the program tried to use a network connection that didn't exist. The fix simply hides that menu item when there is no network. A second small change prevents an extra, unhelpful error message when fetching the built-in Bitcoin whitepaper fails offline.

AI review queuedwizard: fix exception when loading new tc walletby f321x · 3905f8d9 · Feb 11, 2026 · 2 filesMessage 88 · StrongInformational 19Details
Commit message · f321x

wizard: fix exception when loading new tc wallet

I tried to reproduce:
https://github.com/spesmilo/electrum/issues/8815#issuecomment-2094259186
which triggered the following exception for me:

```
Traceback (most recent call last):
File "/home/user/code/electrum-fork/electrum/gui/qt/__init__.py", line 409, in start_new_window
window = self._create_window_for_wallet(wallet)
File "/home/user/code/electrum-fork/electrum/gui/qt/__init__.py", line 329, in _create_window_for_wallet
w = ElectrumWindow(self, wallet)
File "/home/user/code/electrum-fork/electrum/gui/qt/main_window.py", line 290, in __init__
self.load_wallet(wallet)
~~~~~~~~~~~~~~~~^^^^^^^^
File "/home/user/code/electrum-fork/electrum/util.py", line 495, in do_profile
o = func(*args, **kw_args)
File "/home/user/code/electrum-fork/electrum/gui/qt/main_window.py", line 589, in load_wallet
self.update_recently_opened_menu()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/home/user/code/electrum-fork/electrum/gui/qt/main_window.py", line 741, in update_recently_opened_menu
for i, k in enumerate(recent):
~~~~~~~~~^^^^^^^^
TypeError: 'NoneType' object is not iterable
```

This happens because the trustedcoin wallet is loaded outside of
Daemon.load_wallet() so Daemon.update_recently_opened_wallets()
is not getting called and config.RECENTLY:_OPEN_WALLET_FILES is
still None when we try to iterate through it.
As fix i now use load_wallet() instead of manually
instantiating the Wallet
and additionally handle
RECENTLY_OPEN_WALLET_FILES being None in
ElectrumWindow.update_recently_opened_menu().

My pull request https://github.com/spesmilo/electrum/pull/10121
would have sent this exception to the crash reporter so we
might have noticed it earlier. I think we should not just catch
all exceptions in the wizard like on master as it causes us to
repeatedly miss regressions in the wizard that could be sent to
the crash reporter.

88/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 19/100

This commit fixes a crash that occurred when creating or loading a special type of Electrum wallet (a trustedcoin two-factor wallet) through the setup wizard. The crash was caused by the wallet being loaded in a way that skipped normal bookkeeping, leaving a menu list as 'None' instead of empty. The fix makes the wizard use the standard wallet-loading path and also defensively treats a missing recent-wallets list as empty. It is a bug-fix for a user-visible crash, not a security vulnerability.

AI review queuedtests: add unittest for Abstract_Wallet.export_history_to_fileby f321x · a6a57f0f · Feb 3, 2026 · 8 filesMessage 95 · StrongInformational 15Details
Commit message · f321x

tests: add unittest for Abstract_Wallet.export_history_to_file

Adds unittest for Abstract_Wallet.export_history_to_file that
compares the output against reference files. This
should help to prevent regressions and ensure the layout
of the export stays static over time.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new unit tests and reference data files for Electrum's wallet history export feature. It does not change any production wallet code, network handling, or user-facing behavior. There is no security issue here.

AI review queuedhistory export: make fees bitcoin, add hook, rm local txby f321x · e1dac558 · Feb 3, 2026 · 2 filesMessage 81 · StrongInformational 19Details
Commit message · f321x

history export: make fees bitcoin, add hook, rm local tx

Change fees from sats to bitcoin so the fee value is consistent with the
other values.
Fixes #10445

Also adds a plugin hook so plugins can create fancy history exports.

And stops adding unconfirmed/local transactions to the history as they
are unordered and make the export non-deterministic. Also transactions
that haven't happened yet don't seem useful for accounting.

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit changes how Electrum exports a wallet's transaction history to a CSV or JSON file. It switches the fee column from satoshis (tiny Bitcoin units) to whole bitcoin units so it matches other amount columns, lets plugins take over history export entirely, and removes unconfirmed/local transactions from the export because their order isn't stable and they aren't useful for accounting. There is no direct security fix here; it is a usability/consistency improvement for exported reports.

AI review queuedmove history export from HistoryList to Abstract_Walletby f321x · 68144588 · Feb 3, 2026 · 2 filesMessage 73 · AdequateInformational 15Details
Commit message · f321x

move history export from HistoryList to Abstract_Wallet

Moves the history export function to Abstract_wallet so it can be
unittested and called from other places like the cli or QML too.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit simply moves an existing wallet history export feature from the Qt graphical user interface code into the core wallet code. The actual export logic is copied almost unchanged, so users will see no difference in behavior. It is a code cleanup/refactoring change, not a security fix or vulnerability.

AI review queuedlnhtlc: remove unneeded non-initiator fee_update in logby ThomasV · 5767913e · Jan 28, 2026 · 3 filesMessage 50 · ThinLow 43Details
Commit message · ThomasV

lnhtlc: remove unneeded non-initiator fee_update in log

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 43/100

This commit cleans up how Electrum stores initial Bitcoin transaction fee information for Lightning payment channels. Previously, both sides of a channel got a starting fee entry in the internal log, even though only the channel initiator is allowed to change fees later. The patch now records the initial fee only for the initiator and includes a database upgrade routine to remove the duplicate entry from existing wallets. The change is described by the developer as a cleanup, not a security fix, but it touches code that decides which fee rate is used in commitment transactions, which matters for channel safety.

AI review queuedcontrib: minor clean-up shell usageby SomberNight · ceadcac9 · Jan 23, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · SomberNight

contrib: minor clean-up shell usage

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a minor shell-script cleanup. It removes an unnecessary 'ls' call in a loop and adds missing double quotes around variables. These are best-practice hygiene changes that prevent filename-word-splitting bugs, but they do not introduce or fix any active security vulnerability in the shipped Electrum wallet software itself.