wizard: fix exception when loading new tc wallet
What the developer wrote
Authored by f321x
wizard: fix exception when loading new tc wallet
I tried to reproduce:
https://github.com/spesmilo/electrum/issues/8815#issuecomment-2094259186
which triggered the following exception for me:
```
Traceback (most recent call last):
File "/home/user/code/electrum-fork/electrum/gui/qt/__init__.py", line 409, in start_new_window
window = self._create_window_for_wallet(wallet)
File "/home/user/code/electrum-fork/electrum/gui/qt/__init__.py", line 329, in _create_window_for_wallet
w = ElectrumWindow(self, wallet)
File "/home/user/code/electrum-fork/electrum/gui/qt/main_window.py", line 290, in __init__
self.load_wallet(wallet)
~~~~~~~~~~~~~~~~^^^^^^^^
File "/home/user/code/electrum-fork/electrum/util.py", line 495, in do_profile
o = func(*args, **kw_args)
File "/home/user/code/electrum-fork/electrum/gui/qt/main_window.py", line 589, in load_wallet
self.update_recently_opened_menu()
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
File "/home/user/code/electrum-fork/electrum/gui/qt/main_window.py", line 741, in update_recently_opened_menu
for i, k in enumerate(recent):
~~~~~~~~~^^^^^^^^
TypeError: 'NoneType' object is not iterable
```
This happens because the trustedcoin wallet is loaded outside of
Daemon.load_wallet() so Daemon.update_recently_opened_wallets()
is not getting called and config.RECENTLY:_OPEN_WALLET_FILES is
still None when we try to iterate through it.
As fix i now use load_wallet() instead of manually
instantiating the Wallet
and additionally handle
RECENTLY_OPEN_WALLET_FILES being None in
ElectrumWindow.update_recently_opened_menu().
My pull request https://github.com/spesmilo/electrum/pull/10121
would have sent this exception to the crash reporter so we
might have noticed it earlier. I think we should not just catch
all exceptions in the wizard like on master as it causes us to
repeatedly miss regressions in the wizard that could be sent to
the crash reporter.
What changed, and why it matters
This commit fixes a crash that occurred when creating or loading a special type of Electrum wallet (a trustedcoin two-factor wallet) through the setup wizard. The crash was caused by the wallet being loaded in a way that skipped normal bookkeeping, leaving a menu list as 'None' instead of empty. The fix makes the wizard use the standard wallet-loading path and also defensively treats a missing recent-wallets list as empty. It is a bug-fix for a user-visible crash, not a security vulnerability.
No security action required; treat as a normal stability bug fix. Users on affected versions may experience a crash when setting up a trustedcoin wallet, so updating is advisable for reliability.
Security signals we found
No security-relevant signals present
Crash/DoS-like symptom (unhandled TypeError) fixed
Code path normalization (using standard load_wallet instead of manual instantiation)
Evidence from the diff
The patch resolves a TypeError in ElectrumWindow.update_recently_opened_menu() because self.config.RECENTLY_OPEN_WALLET_FILES was None for trustedcoin wallets created via the wizard. The root cause was that the wizard manually instantiated Wallet and called add_wallet(), bypassing Daemon.load_wallet(), which is responsible for updating RECENTLY_OPEN_WALLET_FILES. The fix changes the wizard to use self.daemon.load_wallet(wallet_file, password, upgrade=True) and adds a defensive ‘or []’ fallback in update_recently_opened_menu().
Changed components
electrum/gui/qt/__init__.pyelectrum/gui/qt/main_window.pyTrustedcoin wallet wizard flowDaemon wallet loading / recently-opened menuInspect captured patch +3 / −5
diff --git a/electrum/gui/qt/__init__.py b/electrum/gui/qt/__init__.py
index 4a37fb1..a17d613 100644
--- a/electrum/gui/qt/__init__.py
+++ b/electrum/gui/qt/__init__.py
@@ -502,11 +502,9 @@ class ElectrumGui(BaseElectrumGui, Logger):
self.logger.info('wizard dialog cancelled by user')
return
db.put('x3', wizard.get_wizard_data()['x3'])
- db.write()
+ db.write_and_force_consolidation() # TODO API for db is a bit weird: there should be a close method
- wallet = Wallet(db, config=self.config)
- wallet.start_network(self.daemon.network)
- self.daemon.add_wallet(wallet)
+ wallet = self.daemon.load_wallet(wallet_file, password, upgrade=True)
return wallet
def close_window(self, window: ElectrumWindow):
diff --git a/electrum/gui/qt/main_window.py b/electrum/gui/qt/main_window.py
index fe4e7fb..ab58d30 100644
--- a/electrum/gui/qt/main_window.py
+++ b/electrum/gui/qt/main_window.py
@@ -736,7 +736,7 @@ class ElectrumWindow(QMainWindow, MessageBoxMixin, Logger, QtEventListener):
return True
def update_recently_opened_menu(self):
- recent = self.config.RECENTLY_OPEN_WALLET_FILES
+ recent = self.config.RECENTLY_OPEN_WALLET_FILES or []
self.recently_visited_menu.clear()
for i, k in enumerate(recent):
b = os.path.basename(k)
Why this scored 19/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.