Electrum

This commit only adds explanatory comments and a developer TODO note. It does not change any actual encryption logic, access controls, or behavior of the Electrum wallet. There is no security fix or vulnerability introduced by this change.

This commit fixes a simple crash bug in Electrum's settings window. When the user toggled a Lightning network option while running offline (no network connection), the program tried to use a non-existent network object and crashed with an error. The fix adds a safety check to skip network calls when there is no network connection.

This is a tiny code cleanup that removes an unused 'self' parameter from a static method. It does not change what the code does or fix any security problem. It is a follow-up to a previous commit.

This commit changes how Electrum calculates fees for 'just-in-time' (JIT) Lightning channels. Previously the channel size and opening fee were hardcoded; now they are configurable settings. More importantly, the code now adds the actual Bitcoin mining fee for the funding transaction on top of the service fee, so the Lightning Service Provider (LSP) does not accidentally open channels at a loss when on-chain fees are high. It also rejects payments that would be too small after deducting those fees. This is a business-logic/economic fix rather than a remote code-execution vulnerability.

This commit only adds new automated tests for an existing Lightning Network feature called 'just-in-time channel opening.' It does not change the actual wallet or payment-handling code that users run. There is no security fix or vulnerability introduced here.

This commit fixes a configuration check in Electrum's Lightning Network code. Previously, when forwarding payments through a trampoline node, the software ignored a setting meant to control whether it opens special 'zeroconf' channels. The patch makes the code check that setting consistently and renames it from 'accept' to 'open' to better reflect that it controls opening channels in both directions. This is a defensive fix to prevent unintended channel opens.

This commit only adds a new automated test for Electrum's Lightning wallet. It checks that when creating a Lightning invoice, the wallet correctly decides whether to advertise 'trampoline routing' support and which routing hints to include based on the types of channels the user has open. It does not change any production wallet code, so it cannot directly introduce or fix a security vulnerability on its own.

This commit removes the BIP70 payment protocol from Electrum. BIP70 was the feature that let users pay merchants who sent signed payment requests (like BitPay invoices). The change deletes the code that fetched, verified, and sent those requests, along with the RSA and protobuf code that only BIP70 used. It is a feature-removal cleanup, not a security patch, and it does not introduce a vulnerability.

This is a tiny one-line code cleanup. It adds quote marks around a type hint name so the code does not need that class to be imported at module load time. It does not change what the program does or fix any security problem.

This commit is a user-interface cleanup, not a security fix. It changes how Electrum's desktop and mobile-style GUIs describe new transactions in pop-up notifications: instead of showing a positive or negative number with a plus/minus sign, the notification now explicitly says 'sent' or 'received'. It also moves duplicated notification-building code from the two GUI layers into a shared wallet method. There is no evidence this change addresses a vulnerability.

This commit only reorganizes test files. It moves QML-related unit tests from the tests/ folder into a new tests/qml/ subfolder and updates import paths accordingly. No production code, user-facing behavior, or security-sensitive logic was changed.

This commit only moves existing test files for two Electrum plugins (Revealer and Timelock Recovery) into a new tests/plugins/ directory. The code itself is unchanged; it is purely a reorganization of the project's test suite.

This commit adds a new automated test to verify that a checksum function correctly handles non-ASCII characters (like accented letters, Chinese, Japanese, Arabic, and Hebrew text). It does not change any production code. The test ensures that special characters are kept as-is rather than being converted to Unicode escape sequences before hashing. This is a quality-assurance change, not a security fix or vulnerability.

This commit fixes a type mismatch bug in Electrum's mobile/QML user interface. A fee rate value was stored as a number (0) but the QML interface expected text ('0'), causing a crash when certain code paths ran. The fix changes the initial value from a number to a string so the interface no longer crashes. There is no indication this could be used to steal funds or attack users remotely.

This is a bug-fix patch for the Electrum Bitcoin wallet. It corrects a logic error where a network failure was being silently swallowed instead of being reported, which could cause the wallet's fee-bumping feature to crash later with a confusing error. There is no indication this allows theft, remote code execution, or unauthorized access; it is a reliability and user-experience fix.

This commit only changes a test file. It makes an existing automated test more reliable by waiting for both payment parts to finish before checking the result, instead of assuming both finished at once. There is no change to the actual Electrum wallet or Lightning code that users run.

This commit fixes a rounding bug in Electrum's NWC (Nostr Wallet Connect) plugin. The plugin lets users set a daily spending limit in satoshis, but it was internally tracking spent amounts in whole satoshis. Because Lightning invoices are priced in millisatoshis (one-thousandth of a satoshi), rounding down to satoshis could let a user or service spend slightly more than the intended daily limit over many small payments. The patch now tracks the budget in millisatoshis and converts the limit to millisatoshis for comparison, closing the rounding gap. It also migrates existing saved budget data from satoshis to millisatoshis.

This commit is a straightforward internal code cleanup: it moves two shared pieces of Qt GUI plumbing (QtEventListener and the qt_event_listener decorator) from separate QML and Qt GUI utility files into a single common_qt utility file, then updates all the import statements across the project. There is no change to user-facing behavior, no bug fix, and no security-related change.

This commit fixes a wallet-crash bug, not a security vulnerability. Some older Electrum wallets created 'zero-amount' Lightning payment requests in 2023 that were stored with an amount of 0 instead of the special 'no amount' marker (None). A later code change added a rule that received payment amounts cannot be 0, causing those older wallets to crash or fail to open. The patch converts the stored 0 values back to None during wallet database upgrade and prevents new 0 values from being created.

This commit simply adds new Bitcoin block header checkpoints to Electrum's data files for mainnet, signet, testnet, and testnet4. Checkpoints are hardcoded reference points that help the wallet verify it is following the correct blockchain. There is no code change, no bug fix, and no security vulnerability visible in this diff.

This commit only edits the project's RELEASE-NOTES text file. It rephrases a sentence about how translators can apply to become proofreaders. There is no code change, no security fix, and no functional change to Electrum.

This commit only changes the software version number from 4.7.0 to 4.7.1 in a single file. It contains no security-related code changes and no functional changes at all.

This commit simplifies how Electrum stores secret Lightning payment preimages. It removes a code path that let callers leave a privacy flag unset (which previously kept the old value), and instead always defaults to not marking the preimage as public while still preventing a previously public preimage from becoming private. The change is a cleanup, but it slightly alters behavior: callers who used to rely on 'keep the old value' now get 'False' if no old value exists, and any old public mark is preserved. There is no clear security bug in the diff itself, but it touches sensitive secret-handling code.

This commit hardens how Electrum decides when to reveal secret payment proof values (called preimages) on the Bitcoin blockchain during Lightning channel force-closes. Previously, the wallet might have revealed a preimage too early if a multi-part payment was incomplete, which could let a sender pay less than the invoice asked for. The change tracks whether a preimage is already 'public' (known to other nodes or seen on-chain) and only reveals it on-chain when it is safe. It also makes sure Electrum keeps watching the relevant transaction output until the timeout, even if it cannot reveal the preimage yet.

This commit only adds explanatory text to a code comment (docstring). It does not change any program logic, transaction calculations, or security behavior. There is no security issue here.