(trivial) wallet: fix stale comment on on_event_invoice_status
What the developer wrote
Authored by Sasha Zykov
(trivial) wallet: fix stale comment on on_event_invoice_status
The followup rename (_paid_invoice_keys -> _paid_invoice_keys_cache) and
the de-sloppify left this comment referring to the old name and claiming
the listener only tracks LN-driven changes; it is now the population path
for onchain invoices too.
What changed, and why it matters
This commit only updates a stale code comment to match a recent variable rename and to correctly describe what the function now does. No actual code behavior was changed, so there is no security impact.
No action needed; this is a non-functional documentation-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff changes a single inline comment in electrum/wallet.py. The comment previously referenced _paid_invoice_keys and said it kept state in sync with LN-driven status changes; it now references _paid_invoice_keys_cache and says it keeps state in sync with all invoice status changes. No executable code was modified.
Changed components
electrum/wallet.pyInspect captured patch +1 / −1
diff --git a/electrum/wallet.py b/electrum/wallet.py
index 601879a..f64110c 100644
--- a/electrum/wallet.py
+++ b/electrum/wallet.py
@@ -662,7 +662,7 @@ class Abstract_Wallet(ABC, Logger, EventListener):
@event_listener
def on_event_invoice_status(self, wallet, key, status):
- # keep _paid_invoice_keys in sync with LN-driven status changes
+ # keep _paid_invoice_keys_cache in sync with all invoice status changes
if wallet != self:
return
if status == PR_PAID:
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.