Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…
Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…
Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…
Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…
Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…
Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…
This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…
This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.
This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…
Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…
Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…
This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…
UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…
No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…
Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …
Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…
Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…
Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…
Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…
No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…
Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedwizard: handle UserFacingException in WCWalletPasswordHardwareby f321x · 47124179 · Dec 10, 2025 · 1 fileMessage 73 · AdequateLow 29Details
Commit message · f321x
wizard: handle UserFacingException in WCWalletPasswordHardware
Handles `UserFacingException` in the `WCWalletPasswordHardware` step of the hardware wallet wizard flow. This fixes the previous FIXME and prevents the crash reporter from getting triggered if the the user e.g. disconnects his hardware wallet during the wallet encryption step.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 29/100
This commit fixes a bug in Electrum's wallet setup wizard where unplugging a hardware wallet during the encryption step could crash the application by opening an error-report dialog. The fix catches the expected error gracefully, shows a friendly message, and lets the user retry instead of triggering the crash reporter.
AI review queuedwallet_db: convert_version_66: trivial simplificationby SomberNight · 745318d1 · Dec 10, 2025 · 1 fileMessage 40 · ThinInformational 15Details
✓ Specific, descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This is a one-line code cleanup that changes how a constant number is written. The value 147712 is rewritten as 0x24100, which is the exact same number in hexadecimal notation. A comment is also slightly reordered. There is no functional change and no security relevance.
AI review queuedledger: throw UserFacingException for OSErrorby f321x · aa47a960 · Dec 10, 2025 · 1 fileMessage 80 · StrongInformational 18Details
Commit message · f321x
ledger: throw UserFacingException for OSError
Throws UserFacingException if the communication with the ledger fails due to an OSError. This happens e.g. if the Bitcoin app has been closed. We shouldn't get crash reports for errors due to disconnection.
80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 18/100
This is a small user-experience fix for Electrum's Ledger hardware wallet plugin. When the Ledger device disconnects or its Bitcoin app is closed during use, the software previously generated an internal crash report. Now it shows a friendly on-screen message instead. There is no indication this change fixes a security vulnerability or introduces one.
AI review queuedlnworker: add invoice features to PaymentInfo classby f321x · 125a921c · Dec 10, 2025 · 3 filesMessage 73 · AdequateLow 34Details
Commit message · f321x
lnworker: add invoice features to PaymentInfo class
Adds the invoice features to the `PaymentInfo` class so we can check if the sender respects our requested features (e.g. if they tried to send mpp if we requested no mpp).
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 34/100
This commit changes how Electrum stores and uses Lightning invoice features. It records which features (like multi-part payments, or MPP) were advertised in an invoice, so the wallet can later check whether the sender followed those rules. The change also fixes a minor bug where the wallet read from the wrong config object. There is no direct evidence in the commit that this fixes an active exploit, but it is a defensive hardening change that prevents a sender from ignoring the receiver's invoice rules.
AI review queuedlnworker: use channel_id instead of scid in ReceivedMPPHtlcby f321x · 5be598b8 · Dec 9, 2025 · 4 filesMessage 73 · AdequateLow 32Details
Commit message · f321x
lnworker: use channel_id instead of scid in ReceivedMPPHtlc
Store the channel id instead of the scid in ReceivedMPPHtlc. The scid can be None, in theory even for multiple channels at the same time. Using the channel_id which is always available and unique seems less error prone at the cost of temporarily higher storage requirements in the db for the duration of the pending htlcs.
Alternatively we could use the local scid alias however using the channel_id seems less complex and leaves less room for ambiguity.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 32/100
This commit changes how Electrum's Lightning wallet internally tracks incoming multi-part payments. Instead of using the short channel ID (which can be missing or ambiguous), it now uses the permanent channel ID. The change includes a database upgrade to convert old stored data. The commit message frames this as a robustness improvement, not a security fix, but the scenario it addresses—multiple channels lacking short IDs—could theoretically lead to mis-routing or incorrect handling of pending payments.
AI review queueddnssec: log warning if dependency is missingby SomberNight · cf8c243b · Dec 5, 2025 · 1 fileMessage 68 · AdequateInformational 18Details
Commit message · SomberNight
dnssec: log warning if dependency is missing
Calling dnssec.query() with missing "cryptography" dep behaves the same as if DNSSEC validation failed: validated=False will be returned. When used for openalias, we mandate validated=True.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
This commit only changes how Electrum logs a message when the optional 'cryptography' Python package is missing. It does not change any actual security behavior: DNSSEC validation still fails and falls back to plain DNS, and OpenAlias still rejects unvalidated results. The change simply makes the missing-dependency warning more visible in logs.
AI review queuedtxbatcher: add TODOs re nLocktime block-height vs timestamp confusionby SomberNight · ef0e4e02 · Dec 4, 2025 · 3 filesMessage 65 · AdequateLow 32Details
Commit message · SomberNight
txbatcher: add TODOs re nLocktime block-height vs timestamp confusion
seems harmless atm but some rethinking is needed and checks should be added
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 32/100
This commit adds comments and TODOs warning that the wallet code may be mixing up two different kinds of Bitcoin time locks: block heights and wall-clock timestamps. It also fixes some helper functions to explicitly return None instead of implicitly returning nothing. The commit itself says the issue 'seems harmless atm' but needs rethinking. There is no actual exploit shown, only a note that future checks are needed.
AI review queuedQt wizard: bugfix: standardize_path in WCWalletNameby ThomasV · 32c677be · Dec 3, 2025 · 1 fileMessage 65 · AdequateInformational 18Details
Commit message · ThomasV
Qt wizard: bugfix: standardize_path in WCWalletName
without this, any wallet that is not in the config wallet_path cannot be open.
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This is a small bugfix in Electrum's Qt wallet creation wizard. It makes sure wallet paths are stored in a consistent format so wallets located outside the default wallets folder can be opened. The change also renames a variable and updates comments, but does not add new security checks. It is a routine fix, not a security patch.
AI review queuedfollow-up prev commitby ThomasV · cb7e550a · Dec 2, 2025 · 1 fileMessage 28 · OpaqueLow 27Details
Commit message · ThomasV
follow-up prev commit
28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 27/100
This is a tiny follow-up patch that widens a type check in Electrum's wallet database code. When deleting or removing an item from a stored dictionary, the code now clears the parent pointer for any 'base stored object' rather than only for nested dictionaries. Without this fix, other stored object types (such as lists) might keep a stale reference to their former parent, which could lead to inconsistent database state or unexpected behavior when the data is later modified and saved.
AI review queuedlnworker: differentiate PaymentInfo by directionby f321x · 923d48f9 · Dec 1, 2025 · 12 filesMessage 68 · AdequateLow 36Details
Commit message · f321x
lnworker: differentiate PaymentInfo by direction
Allows storing two different payment info of the same payment hash by including the direction into the db key. We create and store PaymentInfo for sending attempts and for requests (receiving), if we try to pay ourself (e.g. through a channel rebalance) the checks in `save_payment_info` would prevent this and throw an exception. By storing the PaymentInfos of outgoing and incoming payments separately in the db this collision is avoided and it makes it easier to reason about which PaymentInfo belongs where.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 36/100
This commit changes how Electrum stores Lightning payment records. Previously, outgoing and incoming payments sharing the same payment hash (for example, when rebalancing your own channels) could collide in the database and cause errors. The fix adds a direction flag to the database key so both sides can be stored separately. It is a bug-fix and robustness improvement, not an obvious security vulnerability, though the original collision could have caused crashes or inconsistent state in self-payment scenarios.
AI review queuedlnpeer: report htlc_switch exceptions to crash reporterby f321x · 95729a08 · Nov 27, 2025 · 1 fileMessage 73 · AdequateInformational 18Details
Commit message · f321x
lnpeer: report htlc_switch exceptions to crash reporter
It seems useful to report exceptions happening in the htlc_switch to the crash reporter as it shouldn't raise exceptions in theory and this could help catch subtle bugs.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 18/100
This commit adds automatic crash reporting for a specific internal Lightning payment-routing function. When that function hits an unexpected error, the app now sends a redacted copy of the error to Electrum's crash reporter before re-raising it. It is a diagnostic/logging improvement, not a fix for a known security flaw, and it does not change how errors are handled.
AI review queuedlnpeer/lnworker: refactor htlc_switchby f321x · 0f314d1d · Nov 27, 2025 · 11 filesMessage 58 · ThinModerate 59Details
Commit message · f321x
lnpeer/lnworker: refactor htlc_switch
refactor `htlc_switch` to new architecture to make it more robust against partial settlement of htlc sets and increase maintainability. Htlcs are now processed in two steps, first the htlcs are collected into sets from the channels, and potentially failed on their own already. Then a second loop iterates over the htlc sets and finalizes only on whole sets.
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This is a large internal refactor of Electrum's Lightning code that handles incoming multi-part payments (MPP). The change restructures how individual HTLCs are collected into sets and how those sets are validated, forwarded, or settled. The commit message frames it as improving robustness and maintainability, not as a security fix. The diff shows new consistency checks for trampoline onions, stricter state transitions for payment sets, and a wallet database upgrade to migrate old state. There is no vendor statement that this fixes a known vulnerability, and no CVE or researcher attribution is present in the supplied materials.
AI review queuedswaps: allow reverse swaps to external addressby f321x · a0455f83 · Nov 27, 2025 · 3 filesMessage 68 · AdequateLow 29Details
Commit message · f321x
swaps: allow reverse swaps to external address
Implement logic to claim a reverse swap funding output to any given address. This allows to do onchain payments to external recipients through a submarine swap.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 29/100
This commit adds a feature to Electrum that lets users route reverse submarine swaps to an external Bitcoin address, effectively turning a Lightning payment into an on-chain payment to someone else. The change renames a database field, adds wallet-upgrade logic, and introduces a new code path that builds and broadcasts a claim transaction. There is no direct evidence in the commit of a security vulnerability, but the new code handles private keys, transaction signing, and broadcasting, so it is a sensitive area worth reviewing carefully.
AI review queuedadd helper method: run_htlc_switch_iterationby f321x · c65ec6b2 · Nov 25, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · f321x
add helper method: run_htlc_switch_iteration
no code modification, indent-only
35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit is a pure code restructure: it extracts the inner body of Electrum's Lightning HTLC switching loop into a new private helper method named `_run_htlc_switch_iteration`. The commit message explicitly says 'no code modification, indent-only', and the diff matches that claim. There are no functional changes, no security fixes, and no new behavior introduced.
AI review queuedtest_wallet_vertical: add case spending mixed segwit/non-segwit UTXOsby SomberNight · e52ed507 · Nov 17, 2025 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · SomberNight
test_wallet_vertical: add case spending mixed segwit/non-segwit UTXOs
I needed such a tx to test something in electrumx and wanted to copy-paste one from the electrum unit tests. Weird that we were lacking such a test case, I was fairly certain there was one already...
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adds a new automated test to Electrum's test suite. It creates a sample Bitcoin transaction that mixes older-style (non-SegWit) and newer-style (SegWit) inputs, then verifies that the wallet can sign it correctly offline. There is no change to the actual wallet or server code, and nothing is being fixed or patched.
AI review queuedfollowup prevby Sander van Grieken · 9481f4f6 · Nov 10, 2025 · 1 fileMessage 18 · OpaqueInformational 12Details
Commit message · Sander van Grieken
followup prev
18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 12/100
This is a one-line change in a test file, renaming a dictionary key from 'blinding' to 'path_key' to match what the production code now expects. It does not change any production code and has no direct security impact on users.
AI review queuedjson_db: move json to python conversion logic from StoredDict to json_db.by ThomasV · 7aeef920 · Nov 7, 2025 · 2 filesMessage 73 · AdequateLow 25Details
Commit message · ThomasV
json_db: move json to python conversion logic from StoredDict to json_db.
convert_key, convert_value are used to convert json objects to python classes, do not call them in StoredDict.__setitem__
This makes StoredDict agnostic about the type of database we use.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 25/100
This commit is a code cleanup that moves data-conversion logic out of a low-level dictionary class and into a dedicated database module. It also changes one place where metadata is stored so it is first converted to plain JSON. The changes appear to be architectural refactoring rather than a fix for an active security bug, but the patch is partial and the commit message does not explain the full motivation.
AI review queuedconfig/regtest: add config to disable automatic fee updatesby f321x · 76f69676 · Oct 31, 2025 · 4 filesMessage 83 · StrongInformational 15Details
Commit message · f321x
config/regtest: add config to disable automatic fee updates
Some regtest tests depend on manual fee injection to simulate certain mempool conditions (e.g. lnwatcher_waits_until_fees_go_down). This is done by manually injecting fee estimates into the `Network` object using the `test_inject_fee_etas` cli command. However it can still happen that the Network automatically updates its fee estimates from the connected electrum server in the time between injecting the fee and the actual tested logic making decisions based on the fee. This causes the test to fail sometimes. By setting the `test_disable_automatic_fee_eta_update` true the Network will stop automatically updating the fee estimates and the test will behave as expected.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit adds a hidden test-only setting that prevents Electrum from automatically updating fee estimates during certain automated regtest tests. It is purely a testing helper and does not change any behavior unless the user explicitly sets the new config flag. There is no security issue visible in the change.
AI review queuedsynchronizer: small refactor _on_address_statusby SomberNight · 5212d20f · Oct 29, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · SomberNight
synchronizer: small refactor _on_address_status
35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit is a minor internal cleanup in Electrum's synchronizer code. It renames a variable, adds type hints, extracts a small helper method, and fixes a log message to display transaction byte length correctly. There is no security-relevant change visible in the diff.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a minor code cleanup that adds Python type-hints and slightly refactors two helper methods. It does not change program behavior or fix any security issue.
AI review queuedtransaction: (move-only) move some methods from Tx to PartialTx clsby SomberNight · f1ad5bc2 · Oct 9, 2025 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · SomberNight
transaction: (move-only) move some methods from Tx to PartialTx cls
these were already assuming `isinstance(self, PartialTransaction)`
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a pure code reorganization: four helper methods were moved from the base Transaction class to the more specific PartialTransaction subclass. The code itself is unchanged, and the commit message explicitly states it is 'move-only'. There is no security fix or behavior change visible in the diff.
AI review queuedwallet: (trivial) mark calc_unused_change_addresses as privateby SomberNight · 58676219 · Oct 7, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · SomberNight
wallet: (trivial) mark calc_unused_change_addresses as private
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit simply renames a wallet method by adding an underscore prefix, which is a Python convention for 'this is intended for internal use only.' No behavior, logic, or security properties of the code change. It is a cosmetic/private-API marking.
..also export preimage in check_hold_invoice return value if available.
I intentionally did not return the preimage in the returned dict of wallet.export_requests as this seems risky to do considering some users of the cli might forward the response to a payer and the payserver exposes it too.
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 21/100
This commit adds a new command-line feature to export the secret 'preimage' for a settled Lightning invoice, and also includes the preimage in the result of checking a held invoice. The preimage is the cryptographic proof that a Lightning payment was received; anyone who knows it can claim the payment. The developers deliberately avoided exposing the preimage in some other command outputs because it could be accidentally shared with a payer or exposed via the payment server. The change itself is a feature addition, not a fix for an active vulnerability, but it touches sensitive secret material.
AI review queuedlnworker: enforce creation of PaymentInfo for b11by f321x · 286fc4b8 · Sep 30, 2025 · 9 filesMessage 68 · AdequateLow 46Details
Commit message · f321x
lnworker: enforce creation of PaymentInfo for b11
Enforce that the information used to create a bolt11 invoice using `get_bolt11_invoice()` is similar to the related instance of PaymentInfo by requiring a PaymentInfo as argument for `get_bolt11_invoice()`. This way the invoice cannot differ from the created PaymentInfo. This allows to use the information in PaymentInfo for validation of incoming htlcs more reliably.
To cover all required information for the creation of a b11 invoice the PaymentInfo class has to be extended with a expiry and min_final_cltv_expiry. This requires a db upgrade.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 46/100
This commit tightens how Electrum creates Lightning invoices so the stored payment record and the generated invoice always match. Previously, callers passed invoice details separately, creating a risk that the invoice could differ from what Electrum later used to validate incoming payments. Now a single PaymentInfo object is required, and it stores extra fields (expiry and minimum locktime) so validation can rely on it. This is a defensive hardening change, not a fix for a known active exploit.
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100
This commit simply tidies up Python import statements in one file. It removes unused imports and merges some import lines. There is no change to program logic, no bug fix, and no security relevance.