Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…
Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…
Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…
Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…
Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…
Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…
This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…
This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.
This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…
Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…
Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…
This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…
UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…
No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…
Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …
Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…
Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…
Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…
Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…
No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…
Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
Merge pull request #10829 from nrobi144/coldcard-firmware-range-fix
docs: correct Coldcard firmware range in seed-entropy notice
78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
entropy or randomnessdocumentation-only discountmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit only updates a documentation file (a README) to correct the range of Coldcard hardware wallet firmware versions affected by a previously disclosed security issue. It does not change any executable code, cryptographic logic, or wallet behavior in Electrum itself. The underlying security problem exists in Coldcard firmware, not in Electrum.
AI review queuedMerge pull request #10833 from SomberNight/202608_swaps_dm_repliesby ThomasV · cb4fe3a3 · Aug 10, 2026 · 1 fileMessage 73 · AdequateLow 46Details
Commit message · ThomasV
Merge pull request #10833 from SomberNight/202608_swaps_dm_replies
swaps: nostr: check_dms: duplicate replies from server could crash transport
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
This patch fixes a crash in Electrum's submarine swap feature when using Nostr direct messages. If a Nostr server sent the same reply twice, the code tried to complete an already-completed 'future' object, which raises an exception in Python's asyncio. The fix ignores duplicate or unknown replies instead of crashing. A malicious or misbehaving swap server could potentially trigger this to disrupt a user's swap transport/connection.
AI review queuedcontrib: drop protobuf requirementby f321x · 5f6e9102 · Aug 10, 2026 · 4 filesMessage 66 · AdequateInformational 15Details
Commit message · f321x
contrib: drop protobuf requirement
The protobuf dependency was introduced with bip 70 payment requests in commits 4120678df / c44427d33e but not removed with the bip 70 removal in https://github.com/spesmilo/electrum/pull/10535
Currently it fails the installation of the deterministic requirements as newer setuptools doesn't seem to have the `pkg_resources` module anymore: ``` Collecting protobuf==3.20.3 (from -r /tmp/requirements.txt (line 39)) Downloading protobuf-3.20.3.tar.gz (216 kB) Installing build dependencies: started Installing build dependencies: finished with status 'done' Getting requirements to build wheel: started Getting requirements to build wheel: finished with status 'error' error: subprocess-exited-with-error
× Getting requirements to build wheel did not run successfully. │ exit code: 1 ╰─> [23 lines of output] Traceback (most recent call last): File "/usr/local/lib/python3.14/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 389, in <module> main() ~~~~^^ File "/usr/local/lib/python3.14/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 373, in main json_out["return_val"] = hook(**hook_input["kwargs"]) ~~~~^^^^^^^^^^^^^^^^^^^^^^^^ File "/usr/local/lib/python3.14/site-packages/pip/_vendor/pyproject_hooks/_in_process/_in_process.py", line 143, in get_requires_for_build_wheel return hook(config_settings) File "/tmp/pip-build-env-b04pv17_/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 333, in get_requires_for_build_wheel return self._get_build_requires(config_settings, requirements=[]) ~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/tmp/pip-build-env-b04pv17_/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 301, in _get_build_requires self.run_setup() ~~~~~~~~~~~~~~^^ File "/tmp/pip-build-env-b04pv17_/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 520, in run_setup super().run_setup(setup_script=setup_script) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/tmp/pip-build-env-b04pv17_/overlay/lib/python3.14/site-packages/setuptools/build_meta.py", line 317, in run_setup exec(code, locals()) ~~~~^^^^^^^^^^^^^^^^ File "<string>", line 11, in <module> ModuleNotFoundError: No module named 'pkg_resources' [end of output] ```
66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit removes an unused software dependency called protobuf. The dependency was originally added years ago to support a Bitcoin payment protocol feature (BIP 70) that has since been removed from Electrum. Keeping protobuf in the requirements list was causing installation failures on newer systems because an old version of protobuf cannot build with current Python packaging tools. There is no security vulnerability here—this is a cleanup fix for a broken build/install process.
AI review queuedMerge pull request #10808 from SomberNight/202608_wallet_checksighash_handle_unknownby ThomasV · cdf24305 · Aug 9, 2026 · 1 fileMessage 73 · AdequateLow 39Details
Commit message · ThomasV
Merge pull request #10808 from SomberNight/202608_wallet_checksighash_handle_unknown
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 39/100
This change makes Electrum's wallet handle unusual or unrecognized Bitcoin signature hash types without crashing. Previously, if a transaction input used a sighash value not in the hardcoded list, the code would throw a KeyError exception. The patch now maps unknown sighash values to a warning labeled 'INSANE_SIGHASH'. This is a defensive hardening fix: it prevents an unexpected transaction from causing an unhandled error and instead reports it as a dangerous condition.
Merge pull request #10816 from accumulator/qml_auth_log_improvement
qml: improve auth logging
63/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly! No meaningful explanatory body
This commit is a minor logging cleanup in the mobile/QML authentication helper. It changes the wording and placement of debug/error log messages so they reveal the function name only after safely retrieving it, and avoids logging a raw tuple that could contain sensitive arguments. There is no security fix, behavior change, or vulnerability patch here.
AI review queuedMerge pull request #10798 from SomberNight/202608_base43by Felix · 0e9f1a0d · Aug 7, 2026 · 2 filesMessage 73 · AdequateModerate 51Details
Commit message · Felix
Merge pull request #10798 from SomberNight/202608_base43
transaction: cap max tx size we allow for base43
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 51/100
This commit fixes a performance weakness in Electrum's handling of large Bitcoin transactions encoded in 'base43'. The base43 encoding and decoding functions run in quadratic time, meaning the work grows much faster than the input size. An attacker could send or feed Electrum a very large base43 transaction string and cause the program to freeze or become unresponsive for a noticeable period (a denial-of-service effect). The patch limits how large a base43 string Electrum will try to decode and also makes the encoder slightly faster. It does not fix the underlying quadratic algorithm.
AI review queuedMerge pull request #10799 from SomberNight/202608_android_secure_windowby accumulator · 4622390c · Aug 7, 2026 · 5 filesMessage 73 · AdequateLow 41Details
Commit message · accumulator
Merge pull request #10799 from SomberNight/202608_android_secure_window
qml/android: protect WIF keys from screenshots in more places
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 41/100
This update tightens a privacy feature on Electrum's Android app that prevents the screen from being captured while sensitive Bitcoin private keys or seed phrases are visible. Before, the protection could be accidentally turned off when multiple wallet windows overlapped, potentially letting malware or a malicious screenshot grab secret key material. The fix makes sure protection stays active whenever any sensitive screen is actually visible.
Security candidatedocs: add Coldcard Mk3 seed-entropy security notice to plugin README (#10805)by Róbert Nagy · 2c2a40b6 · Aug 6, 2026 · 1 fileMessage 98 · StrongInformational 15Details
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
entropy or randomnessdocumentation-only discount
AI analysis · Informational 15/100
This commit only adds a documentation warning to Electrum's Coldcard plugin README. It does not change any executable code, cryptographic logic, or wallet behavior. The warning tells users that Coldcard/Coinkite disclosed a firmware bug in certain Coldcard devices that could make on-device seeds easier to guess, and advises updating firmware and moving funds. Because Electrum itself is not being patched for a vulnerability, this commit is not a security fix for Electrum.
AI review queuedqml/android: protect WIF keys from screenshots in more placesby SomberNight · 739cba5d · Aug 5, 2026 · 5 filesMessage 81 · StrongLow 48Details
Commit message · SomberNight
qml/android: protect WIF keys from screenshots in more places
also fix bug in AddressDetails where we were never unsetting the secure flag
notes re dialog stacking: - if we stack two "secure" dialogs and then pop one of them, the remaining "secure" dialog should still have secureWindow == true. - we could either impl some refcounting for the number of alive "secure" dialogs - or perhaps simpler but less robust, qml binding magic using the "when" as done here might work? - ref https://doc.qt.io/qt-6/qml-qtqml-binding.html#restoreMode-prop - the default restoreMode (Binding.RestoreBindingOrValue) seems to do what we want here - I don't explicitly set it as the Qt docs have this note: > Note: This property exists for backwards compatibility with earlier versions of Qt. Don't use it in new code. - seems to work on my phone
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 48/100
This commit tightens screen-shot protection for private Bitcoin wallet keys (WIF keys and seed phrases) in Electrum's Android/QML user interface. It also fixes a bug where one screen (AddressDetails) was leaving the 'secure window' flag permanently on, which could leave the app in a protected state at the wrong time. The change makes sure the secure flag follows whether the dialog is actually visible, and adds the same protection to two more dialogs that handle private keys.
lnpeer: chan_reest: ctn overflow: force-close instead of disconnect
(was DC-ing due to assert failing in RevocationStore)
also add a test case
92/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
memory safety
AI analysis · Moderate 60/100
This commit fixes a bug in Electrum's Lightning Network code. Previously, if a malicious or malfunctioning peer sent a channel re-establishment message with extremely large commitment numbers (over 2^48), the local program would hit an internal assertion failure and simply disconnect. Now, it treats this as misbehavior and force-closes the channel instead, which is the safer response. The commit also adds tests to confirm this behavior.
AI review queuedMerge pull request #10791 from SomberNight/202608_wallet_sign_message2by ghost43 · b1aa52d7 · Aug 3, 2026 · 5 filesMessage 73 · AdequateInformational 18Details
Commit message · ghost43
Merge pull request #10791 from SomberNight/202608_wallet_sign_message2
wallet: sign_message: strip whitespaces in GUis, do not strip in CLI
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This change moves the trimming of leading/trailing spaces in message-signing fields from the user-interface code into the shared wallet code. For the graphical interfaces (Qt and QML), spaces are still stripped automatically for convenience. For the command-line interface, a new option disables that stripping so that exact user input is preserved. It is a usability/behavior consistency fix, not a fix for an active security vulnerability.
Security candidatewallet: sign_message: strip whitespaces in GUIs, do not strip in CLIby SomberNight · 4c3064f5 · Aug 3, 2026 · 5 filesMessage 96 · StrongInformational 19Details
Commit message · SomberNight
wallet: sign_message: strip whitespaces in GUIs, do not strip in CLI
- stripping whitespaces leads to better UX for GUIs IMO, but it's counter-productive for CLI - our previous behaviour was unintentionally inconsistent: - qt stripped the message in both sign and verify - qml stripped the message in verify but not in sign (until #10787) - cli stripped the message in both sign and verify - qml also stripped the signature in verify, which was not done anywhere else - now this code is de-duped, and the default becomes stripping both message and signature; with the CLI explicitly opting out of that
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 19/100
This commit tidies up how Electrum handles extra spaces around Bitcoin addresses, messages, and signatures when signing or verifying messages. Previously, different parts of the program (desktop GUI, mobile-style GUI, command line) behaved inconsistently—some trimmed spaces automatically, others did not. The change moves the trimming into the shared wallet code and makes it the default for GUIs, while the command-line tool now explicitly keeps spaces untouched. It is a user-experience and consistency fix, not a patch for an active security vulnerability.
AI review queuedwallet: decrypt_message: nicer error msg if pubkey is unrelatedby SomberNight · 92e938f4 · Aug 3, 2026 · 1 fileMessage 50 · ThinInformational 22Details
Commit message · SomberNight
wallet: decrypt_message: nicer error msg if pubkey is unrelated
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 22/100
This commit improves the error handling in Electrum's message decryption feature. Previously, if a user tried to decrypt a message using a public key that did not belong to their wallet, the code could proceed and likely fail with a confusing internal error. Now it explicitly checks whether the public key is wallet-related and shows a clear, user-friendly error message ('Pubkey unrelated to wallet.'). This is a defensive hardening change, not a fix for an active security vulnerability.
Lower-priorityqt: main_window: use TaskThread for each of sign/verify/encrypt/decryptby SomberNight · 4a9a199f · Aug 3, 2026 · 1 fileMessage 83 · StrongInformational 16Details
Commit message · SomberNight
qt: main_window: use TaskThread for each of sign/verify/encrypt/decrypt
To make them homogeneous. Also note: window.on_error handles UserFacingException, which the wallet methods can now raise.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 16/100
This commit moves four message-crypto operations (sign, verify, encrypt, decrypt) in Electrum's Qt wallet window onto a background worker thread so they all behave the same way. It also lets the background thread surface user-facing errors through the existing error handler. The change is a UI refactor, not a fix for a known exploit, but it removes a direct synchronous call that previously swallowed exceptions and could briefly freeze the GUI.
AI review queuedwallet: sign_message: force kwargsby SomberNight · e1eb2a34 · Aug 3, 2026 · 4 filesMessage 35 · OpaqueLow 29Details
Commit message · SomberNight
wallet: sign_message: force kwargs
35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Low 29/100
This commit changes how Electrum's message-signing function is called so that callers must explicitly name each argument (address, message, password) rather than passing them by position. The main practical effect is to prevent accidental mix-ups of argument order, which could lead to signing the wrong message or using the wrong credentials. There is no direct evidence in the commit that this fixes an active security bug or reported vulnerability.
AI review queuedwallet: sign_message: consolidate checks from UIsby SomberNight · 48893760 · Aug 3, 2026 · 6 filesMessage 45 · ThinLow 39Details
Commit message · SomberNight
wallet: sign_message: consolidate checks from UIs
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 39/100
This commit moves input-validation checks for signing, verifying, encrypting, and decrypting messages out of the user-interface code and into the shared wallet logic. It also adds type checks so that non-text inputs are rejected earlier. The change is a defensive hardening/refactoring patch: it reduces the chance that different Electrum interfaces (command line, desktop Qt, mobile QML) handle errors inconsistently or skip checks, and it makes the code easier to maintain safely. There is no direct evidence in the commit of an active vulnerability being fixed, but consolidating security checks is a security-relevant improvement.
AI review queuedwallet: decrypt_message: consolidate checks from UIsby SomberNight · 9a0cc0d6 · Aug 3, 2026 · 3 filesMessage 50 · ThinLow 27Details
Commit message · SomberNight
wallet: decrypt_message: consolidate checks from UIs
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 27/100
This commit moves input-validation and wallet-type checks for message decryption out of the user-interface and command-line layers and into the core wallet code. It also removes a faster, separate decryption path for imported wallets so all wallet types now go through the same central check. The change is a defensive consolidation: it makes it harder for future user interfaces or scripts to accidentally skip the watching-only, multisig, type, and hex-pubkey checks. There is no direct evidence in the diff of an exploitable bug being fixed, but the consolidation reduces the chance that a missing check in one UI could lead to a confusing error or unexpected behavior.
AI review queuedwallet: refactor: add encrypt_message method, consolidated from UIsby SomberNight · 5e9c8df0 · Aug 3, 2026 · 3 filesMessage 50 · ThinInformational 15Details
Commit message · SomberNight
wallet: refactor: add encrypt_message method, consolidated from UIs
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a simple code cleanup: it moves the message-encryption logic from two separate places (the command-line tool and the Qt graphical interface) into a single shared method on the wallet class. The actual encryption behavior is unchanged, and no security vulnerability is introduced or fixed.
AI review queuedwallet: refactor: add verify_message method, consolidated from UIsby SomberNight · ff5bbb04 · Aug 3, 2026 · 4 filesMessage 50 · ThinInformational 13Details
Commit message · SomberNight
wallet: refactor: add verify_message method, consolidated from UIs
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 13/100
This commit is a routine code cleanup: it moves message-signature verification out of three user-interface files into a single shared helper method in the wallet module. There is no security-relevant behavior change visible in the diff. The new helper behaves the same as the old inline code, and the remaining edits only tighten some unrelated error messages.
Lower-priorityqt: main_window: add type hints to sign/verify, encrypt/decryptby SomberNight · 0906fc20 · Aug 3, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · SomberNight
qt: main_window: add type hints to sign/verify, encrypt/decrypt
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100
This commit only adds Python type hints and renames some function parameters for clarity in the Electrum desktop wallet's sign/verify and encrypt/decrypt message dialogs. It does not change what the code actually does, how it processes user input, or any security behavior. It is a routine code-quality improvement with no security relevance.
Lower-prioritycoldcard: fix get_soft_device_id() discarding its return valueby Felipe Micaroni Lalli · d7500508 · Aug 2, 2026 · 1 fileMessage 50 · ThinInformational 18Details
Commit message · Felipe Micaroni Lalli
coldcard: fix get_soft_device_id() discarding its return value
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 18/100
This is a tiny one-line bug fix in Electrum's Coldcard hardware wallet plugin. A helper method that is supposed to fetch a software-based device identifier was calling the parent implementation but accidentally throwing away the result instead of returning it. The fix simply adds 'return'. On its own this is a routine correctness bug with very limited security implications; it could cause Electrum to fail to recognize or distinguish a Coldcard device, but it does not let an attacker steal funds or bypass protections directly.
Security candidateqml: strip whitespace from message before signing, as in qt guiby Ferdinando Ametrano · 72507328 · Aug 1, 2026 · 1 fileMessage 96 · StrongInformational 19Details
Commit message · Ferdinando Ametrano
qml: strip whitespace from message before signing, as in qt gui
The qt gui strips leading/trailing whitespace from the message (and address) both when signing and when verifying (see #4327). The qml gui already strips in verifyMessage (qedaemon.py), but not in signMessage: a message with leading/trailing whitespace signed in the qml gui would produce a signature that fails verification even in the same dialog.
Strip in signMessage too, replicating the qt gui behaviour.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarydefensive validationsigning or wallet path
AI analysis · Informational 19/100
This commit fixes a minor consistency bug in Electrum's newer QML (mobile-style) user interface. When signing a message, the app now removes accidental spaces at the start or end of the message and address, just like the older desktop Qt interface already did. Without this fix, a message signed in the QML interface could fail verification because of stray whitespace. It is a usability/reliability fix, not a serious security vulnerability.
config: don't save "hidden wallet" paths in CURRENT_WALLET cv
otherwise if the android app is launched and the last opened wallet was a hidden wallet, it would get automatically opened
similarly, don't add it into the recents list (though that's not exposed in qml atm)
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Low 48/100
This commit fixes a privacy leak in the Electrum wallet app. Previously, if a user opened a 'hidden wallet' (one whose filename starts with a dot, like a secret file), Electrum would remember it as the last-used wallet and could reopen it automatically on Android startup. It would also appear in the recent wallets list. The change makes Electrum forget these hidden wallets so they don't resurface automatically or show up in recents, protecting the user's choice to keep them discreet.
Lower-prioritylnrouter: liquidity hints: add extra penalty if amt near cannot_sendby SomberNight · ee75ea31 · Jul 30, 2026 · 1 fileMessage 73 · AdequateLow 28Details
Commit message · SomberNight
lnrouter: liquidity hints: add extra penalty if amt near cannot_send
We guide LNPathFinder away from channels where there is a known cannot_send amount just barely above the HTLC value.
Somewhat follows 6a97e74ce82b9e2055b1ccf31f43288c9becfa02, as before that commit, we were often (unintentionally) blacklisting chans with liquidity failures but now we allow retrying them. Without current change, the liqudity-based penalty would disallow sending an HTLC over the the known "cannot_send" but it would basically not distinguish between 0.999*cannot_send and 0. Instead, just as a completely naive bandaid, I propose penalising HTLC values greater than 80% of the known cannot_send.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 28/100
This commit tweaks how Electrum's Lightning Network payment routing avoids channels where a previous payment attempt already failed. Previously, the router would treat a channel almost at its known failure limit almost the same as a channel far below it. The change adds an extra routing penalty when a payment amount gets within 80% of a previously seen 'cannot send' limit, steering future payments away from likely-stuck channels. It is a hardening/robustness improvement, not a fix for a clear exploitable vulnerability, and it also adds two safety checks (assertions) on internal counters.
lnwallet: don't blacklist htlc failures without channel update
The lightning spec changed so that htlc failures don't have to include a channel_update message anymore (https://github.com/lightning/bolts/pull/1173). We shouldn't blacklist a channel for not including a channel_update if the error code signals a liquidity issue (TEMPORARY_CHANNEL_FAILURE), instead it is sufficient to just record the liquidity hint and try with a smaller part.
93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 52/100
This change fixes how Electrum's Lightning wallet reacts when a payment route fails but the failing node no longer provides a channel update message, as now allowed by the Lightning protocol spec. Previously, Electrum would permanently blacklist the channel, which could make payments fail unnecessarily and degrade routing reliability. Now it records a liquidity hint and retries with a smaller amount instead, but only for liquidity-related failures. For other failure types without an update, it still blacklists the channel.