Electrum

This commit changes the Android two-factor authentication setup flow in Electrum's mobile app. Previously, tapping the QR code would open an external authenticator app directly, but on Android this caused Electrum to be killed by the system, losing the user's progress in the setup wizard. The fix simply copies the secret code to the clipboard instead and tells the user to enter or scan it manually. This is a usability/reliability fix, not a security vulnerability patch.

This commit only updates a stale code comment to match a recent variable rename and to correctly describe what the function now does. No actual code behavior was changed, so there is no security impact.

This commit is a cleanup of a previous change that added a cache for paid invoices. The developer admits the earlier code was sloppy ('arghhhhhh'). The patch removes redundant logic that tried to update the paid-invoice cache in multiple places and instead lets a single method, get_invoice_status, decide whether an invoice is paid. The risk is that if the cache is not updated correctly, Electrum might wrongly report an invoice as paid or unpaid, which could mislead users or merchants about whether money was actually received. There is no direct evidence this is exploitable by an attacker, but it is a correctness fix in payment handling.

This commit fixes a flaky automated test, not a security bug in the Electrum wallet. It adds a wait step so the test script doesn't check log files before background payment commands have finished writing to them. There is no change to production code or user-facing behavior.

This commit only adds a new test case and a test helper. It does not change any production wallet code. The test checks that Electrum can correctly upgrade an old wallet database that contains unfinished Lightning payment data ('unfulfilled HTLCs') from version 4.6.0 to the current format. There is no security fix or vulnerability being patched here.

This commit simply removes the CoinDesk exchange-rate provider from Electrum because CoinDesk's old API no longer works and its new API requires a paid authorization token. It is a routine cleanup, not a security fix.

This commit is a user-interface performance and polish fix for Electrum's hardware wallet integration. It stops the app from destroying and recreating the same on-screen prompt every time a hardware wallet asks the user to confirm a transaction output. Instead, it keeps the existing dialog open and just updates its text. This removes visible flicker/animation on macOS and reduces delays caused by repeatedly creating windows. There is no security vulnerability being fixed here.

This commit only adds comments to the code. It does not fix anything. The comments warn that when Electrum resolves OpenAlias or Lightning Address payment identifiers, it sends DNS queries directly to Google's DNS server (8.8.8.8) instead of routing them through the user's configured network proxy (such as Tor). This could leak the user's real IP address and the fact that they are looking up a particular payment recipient. The commit itself is a documentation of a known privacy weakness, not a security patch.

This commit only adds a comment explaining that a race condition is theoretically possible in the callback manager. It does not change any code behavior, fix a bug, or introduce a vulnerability. No action is needed beyond normal awareness.

This commit stops users of Electrum's mobile-style QML interface from giving a wallet a name that begins with a dot (like '.secret'). Such 'hidden' files are normally invisible in the wallet list, so a user could create a wallet and then be unable to see or open it again. The change is a simple guard that rejects these names when creating or renaming wallets.

This is a tiny follow-up patch that changes how error messages from Trezor hardware wallets are displayed in Electrum's setup wizard. It switches from showing a programmer-style representation (repr) to a more readable plain-text message (str). There is no indication this fixes a security vulnerability; it is a user-experience cleanup.

This is a small internal cleanup commit for the Electrum Bitcoin wallet. It renames an in-memory cache used to remember which outgoing invoices have been paid, moves where the cache is initialized, simplifies some related logic, and makes sure the cache is also updated when a transaction is removed. There is no indication this fixes a security vulnerability or introduces a new security risk.

This commit makes Electrum refuse LNURL-pay payments when the payment service includes a 'successAction' response. The change is a temporary safety measure: Electrum does not yet know how to display these follow-up actions to the user, so it blocks the payment rather than silently ignore the action. This prevents a scenario where a user might believe a payment completed successfully but miss an important post-payment message or instruction.

This commit removes the ability for users to manually set a transaction locktime when creating a Lightning channel funding transaction in Electrum's Qt desktop GUI. A locktime can delay when a transaction becomes valid or spendable. For channel funding transactions, allowing users to tweak this setting could lead to funds being stuck or channel setup failing, so the developers are treating it as a 'footgun'—a feature that is more likely to harm the user than help them. It is a UI restriction, not a fix for an active exploit.

This commit adds support for the new Trezor Safe 7 hardware wallet to Electrum. It introduces a pairing step where the user enters a 6-digit code shown on their device to establish an encrypted, authenticated connection. The change is a feature addition for compatibility, not a fix for a known security flaw.

This commit is a user-experience fix, not a security fix. It changes the mobile/QML wallet's invoice screen so that, if Lightning channels are still reconnecting right after the app starts, the user sees a 'Connecting to Lightning peers...' message instead of a misleading 'insufficient balance' error. There is no indication this resolves an exploitable vulnerability.

This is a tiny UI bug fix in Electrum's mobile/QML wallet interface. The original code accidentally checked the wrong condition when opening an invoice dialog, due to operator precedence: `!invoice.status == Invoice.Expired` was interpreted as `(!invoice.status) == Invoice.Expired` rather than `!(invoice.status == Invoice.Expired)`. The fix rewrites it to the intended meaning. The effect is at most a minor user-interface glitch when viewing certain invoices, not a security vulnerability.

This is a user-interface bug fix for Electrum's mobile/QML app. When opening a payment invoice quickly after starting the app, the fiat (local currency) value label could stay stuck showing 'quotes unavailable' even after exchange-rate quotes arrived. The patch makes the label refresh automatically once quotes are updated. There is no security issue here.

This commit only adds a new test case and a test wallet file to Electrum's test suite. It does not change any production code, so it cannot introduce a security vulnerability or fix one. The test wallet contains a publicly exposed seed phrase, but it appears to be a deliberately created test wallet with no real funds, used to verify that old wallet files upgrade correctly.

This commit adds a type check to ensure a transaction fee value coming from an external server is either a valid whole number or absent. Without the check, an unexpected type (such as a string or special object) could later cause errors or unusual behavior inside the wallet when it stores or compares fee data. The change is defensive and narrows the range of bad inputs the wallet will accept.

This commit simply removes two obsolete comment lines from the top of a source file: a Python 2 shebang and an Emacs editor mode hint. It does not change any executable code, behavior, or security properties of the Electrum wallet.

This change is a bug-fix-style refactor for Electrum's submarine swap feature. It separates in-memory cached swap data from data saved to disk, so temporary fields used while a swap is running don't get lost or behave inconsistently when the code reads from storage. The commit itself does not describe a security vulnerability, but the underlying bug it fixes—relying on disk storage for fields that were never persisted—could in theory cause swap state confusion, such as duplicate processing or stale indexing.

This commit only adds explanatory comments to existing code. It does not change any behavior. The new comments describe how encrypted lightning channel backups work in Electrum and note that the wallet's public key (xpub) is somewhat sensitive because someone with both the xpub and an encrypted backup could force-close a channel. This is documentation, not a fix.

This commit is a minor code cleanup following a previous change. It renames a parameter, adds type hints, switches some function calls to use keyword arguments, and adds a couple of safety assertions. There is no indication it fixes a security bug or introduces a vulnerability.

This commit only adds a detailed code comment explaining how a constant named SWAP_TX_SIZE is used to estimate Bitcoin mining fees for submarine swaps. No program logic, numbers, or behavior were changed. It is purely documentation.