Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit simplifies the seed-validation logic in Electrum's Qt wallet wizard by replacing a local copy of the rules with a call to an existing shared validation method. The change appears to be a code-cleanup refactor that removes dupli…
Refactor of seed-validation logic in wallet creation wizardRemoval of duplicated seed-type checks in favor of centralized validationAdded assertion constraining seed type to 'electrum'
This commit changes Electrum's wallet creation wizard so that if a user tries to restore a normal 'standard' wallet but pastes a seed phrase that actually belongs to a two-factor authentication (2FA) wallet, the wizard automatically redire…
UX-level safety fix preventing wallet-type/seed mismatchState mutation: wizard_data['wallet_type'] changed from 'standard' to '2fa' based on seed typeNo cryptographic, network, or privilege changes
This commit is a small code cleanup in Electrum's wallet setup wizard. It removes a duplicate copy of the rules used to check whether a recovery seed is valid and instead reuses an existing method. There is no indication this fixes a secur…
This commit only adds and reorganizes automated test code for Electrum's wallet creation wizard. It does not change any production wallet logic, cryptography, or network handling. The tests verify that when a user tries to restore a 'stand…
This commit updates Electrum's internal CI (continuous integration) script that runs an automated security review using Anthropic's Claude Code tool. It changes the AI model version used for reviews from 'claude-opus-5' to 'claude-opus-5-5…
CI hardening: detects and reports AI model downgrades during automated security reviewNo changes to application code, cryptography, network protocol, or build artifactsNo privilege escalation, injection, or data-exfiltration vectors introduced by the diff
This commit updates Electrum's own CI security-review script. It adds detection and warnings when the automated code reviewer (Claude Code) silently falls back to a different AI model, for example after a content-policy refusal. It does no…
CI-only changeNo modification of wallet, crypto, networking, or build artifactsAdds detection for AI model fallback/downgrade in automated security review
This commit fixes a bug where Electrum failed to recognize certain already-signed Bitcoin transactions as complete. Specifically, for native SegWit inputs, Bitcoin Core can produce a finalized PSBT with a valid witness but an empty scriptS…
Logic error in transaction completeness detectionNative SegWit witness handling edge casePSBT interoperability issue with Bitcoin Core
This commit fixes a bug where Electrum incorrectly treated finalized Bitcoin transactions as incomplete. Some wallet software (like Bitcoin Core and Sparrow) creates native SegWit transactions that omit an empty placeholder field Electrum …
Logic error in transaction completeness detectionPotential denial of service / user funds stuck due to refusal to broadcast valid finalized transactionInteroperability failure with Bitcoin Core and Sparrow PSBT output
This change prevents Electrum from re-signing Bitcoin transaction inputs that already contain a witness (the data proving the input was authorized). The patch fixes a bug where Electrum could incorrectly sign a non-SegWit input as if it we…
Incorrect signature algorithm selection for non-SegWit inputs when witness data is presentPSBT handling edge case where pre-existing witness data influences signing pathPotential invalid signature production during transaction signing
This commit only adds a long code comment explaining a design choice in Electrum's PSBT-over-Nostr plugin. It does not change any program behavior. The comment documents that the plugin derives each cosigner's Nostr secret key from their B…
Documentation-only changeExplicit design tradeoff disclosure: cosigners can derive each other's Nostr secret keys from shared xpubsNo functional code change
This is a one-line bugfix in Electrum's transaction handling. Previously, the code accidentally swallowed (hid) almost all exceptions when fetching extra transaction data from the network, only re-raising errors that were both network-rela…
This commit fixes several bugs in Electrum's handling of BOLT11 Lightning invoices. The most user-visible fixes are: stricter validation of invoice amounts (rejecting zero, negative, sub-millisatoshi, and leading-zero amounts), correct pad…
Stricter BOLT11 amount validation prevents acceptance of zero, negative, sub-millisatoshi, and leading-zero amountsFixed int_to_data5 padding bug that corrupted small timestamp values during invoice round-tripMalformed 'r' routing tags now raise exceptions instead of being silently skipped
Electrum's transaction builder had a bug where it would ignore certain consistency errors when fetching extra transaction data from the network. A malicious or misbehaving server could supply a wrong input amount, and Electrum would silent…
Swallowed exception leading to use of attacker-controlled input valuePSBT input consistency check bypassedPotential malicious Electrum server influence on transaction signing
This is a small code cleanup change. A function that reads routing hints from Lightning invoices no longer takes a tag argument because only one type of routing hint ('r') is now supported. All callers are updated accordingly. There is no …
This commit tightens how Electrum parses Bitcoin payment requests (BOLT11 lightning invoices and BIP21 URIs). It turns previously uncaught internal errors into proper validation failures, rejects malformed invoice fields that used to be si…
Stricter input validation for externally supplied BOLT11 invoices and BIP21 URIsPreviously uncaught exceptions (ValueError, UnicodeDecodeError, ecc errors) are now wrapped in domain-specific decode exceptionsMalformed fallback addresses are skipped rather than aborting or crashing
This commit tightens how Electrum parses BOLT11 Lightning invoices. It now rejects duplicate 'n' (node pubkey) tags instead of silently keeping only the first one, and it rejects invoice timestamps that are negative or too far in the futur…
Stricter validation of invoice timestamp boundsDuplicate 'n' tag now raises an exception instead of being silently droppedFollow-up to prior PR #10940, indicating a recent area of security-sensitive review
This commit fixes a shutdown bug in Electrum's hardware wallet support. Previously, if disconnecting from a hardware wallet failed, the cleanup thread could keep running, which could crash the application when closing. The fix stops the th…
Process abort/crash at shutdown due to leaked QThreadException during cleanup not handled, potentially causing abnormal terminationHardware wallet client close made best-effort with error logging
This commit is a routine dependency update for the Electrum Bitcoin wallet. It bumps versions of Python, OpenSSL, secp256k1, and various Python packages used in builds and runtime. The commit itself does not fix any known security bug in E…
Dependency version bumps for cryptographic libraries (OpenSSL, libsecp256k1, electrum-ecc)Routine maintenance commit with no explicit security claimHash-only changes in deterministic requirements files
This commit only adds new Bitcoin block header checkpoints to Electrum's built-in chain data files. Checkpoints are hardcoded reference points that help the wallet verify it is following the real blockchain and not a fake one. Updating the…
Hardcoded blockchain checkpoints extended for all supported networksNo executable code or cryptographic logic changedNo bug fix, privilege change, or input validation change present
This commit simply refreshes Electrum's built-in list of Bitcoin blockchain checkpoints. Checkpoints are known-good block hashes that help the wallet verify it is following the real chain. The update adds newer checkpoints for mainnet, sig…
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Lower-prioritytests: lnchannel: rewrite create_test_channels to use LNWalletby SomberNight · dfeb9918 · Jan 5, 2026 · 4 filesMessage 60 · AdequateInformational 12Details
Commit message · SomberNight
tests: lnchannel: rewrite create_test_channels to use LNWallet
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100
This commit is a test-code refactor that rewrites how fake Lightning channels are created for unit tests so they go through the real wallet code path. It also re-enables a safety assertion in production code that checks a channel's remote payout address belongs to the wallet. There is no direct security fix for end users; it is infrastructure work to make tests more realistic and catch configuration mistakes during development.
These better hold, lol: wallet.lnworker.wallet == wallet lnworker.wallet.lnworker == lnworker
75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a test-only refactor in the Electrum Bitcoin wallet. It fixes how mock Lightning Network wallets are created in unit tests so that the test objects match the real structure (wallet.lnworker.wallet == wallet and lnworker.wallet.lnworker == lnworker). It does not change production wallet behavior or fix a security vulnerability in shipped code.
tests: simplify MockLNWallet, add fixme for cyclic inconsistency
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 11/100
This commit is a test-code cleanup and a small defensive guard in non-production code. It removes an unused mock helper class, simplifies a test wallet constructor, and adds a null check before cancelling an onion-message task group. There is no user-facing security fix here.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body! Contains work-in-progress language
AI analysis · Informational 15/100
This commit is a test-only cleanup. It removes a temporary workaround in Electrum's Lightning test suite where test channel objects had their node IDs manually overwritten after creation. The change makes the test helper create channels with the correct wallet/node keys from the start, instead of patching them afterward. There is no change to the actual wallet or Lightning code that users run.
tests: lnpeer: mostly unify prepare_peers and prepare_graph
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100
This commit only changes test code. It refactors how Lightning Network peer tests set up their simulated channels and peers, merging two similar helper functions into one. There is no change to the actual Electrum wallet or Lightning code that users run, so it cannot directly affect security of real funds or operations.
Lower-prioritytests: lnpeer: (move-only) towards unifying prepare_{peers,graph}by SomberNight · 024f9b98 · Jan 5, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · SomberNight
tests: lnpeer: (move-only) towards unifying prepare_{peers,graph}
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100
This commit simply moves a helper method used only in tests from one test class to another. No real user-facing code was changed, and there is no security impact.
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100
This commit only changes internal test code for the Electrum Bitcoin wallet. It simplifies how mock transaction queues are created and passed around in Lightning Network peer tests. There is no change to the actual wallet or network code that real users run, so it has no security impact on end users.
Lower-prioritylnpeer: move make_local_config to LNWalletby SomberNight · b292c027 · Jan 5, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · SomberNight
lnpeer: move make_local_config to LNWallet
no functional changes
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100
This commit simply moves a helper method that builds settings for new Lightning channels from one internal file to another. The commit message says 'no functional changes' and the diff confirms that: the same code, same values, and same checks are preserved. There is no user-visible change and no security fix or vulnerability introduced.
AI review queuedlnworker: split LNWallet and LNWorker: LNWallet "has an" LNWorkerby SomberNight · 1006e809 · Jan 5, 2026 · 17 filesMessage 83 · StrongInformational 18Details
Commit message · SomberNight
lnworker: split LNWallet and LNWorker: LNWallet "has an" LNWorker
- LNWallet no longer "is-an" LNWorker, instead LNWallet "has-an" LNWorker - the motivation is to make the unit tests nicer, and allow writing unit tests for more things - I hope this makes it possible to e.g. test lnsweep in the unit tests - some stuff we would previously have to write a regtest for, maybe we can write a unit test for, now - in unit tests, MockLNWallet now - inherits LNWallet - the Wallet is no longer being mocked
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This commit is a large internal refactoring of Electrum's Lightning code. It changes the relationship between a wallet and its Lightning worker so that the wallet 'has' a separate peer manager instead of 'being' one. The main goal is to make unit tests easier and more realistic. There is no obvious security vulnerability introduced, but one safety assertion about wallet ownership of a channel's remote output address was commented out with a 'FIXME' note, which is a small red flag.
on_event_channels_updated doesn't get fired if channels change their state to OPEN. TxEditor needs to use on_event_channel to notice channels coming online.
This is a small bug fix in Electrum's Qt transaction editor. The dialog was listening for the wrong event when watching Lightning channels come online, so it could fail to refresh its submarine-swap tab promptly. The fix changes the callback to the correct event. There is no direct evidence this is a security vulnerability; it appears to be a UI responsiveness bug.
psbt_nostr: add EventListener comment to CosignerWallet
I got confused how on_event_proxy_set can even work if CosignerWallet doesn't inherit from EventListener until i figured out its children use the EventListener too. To avoid this confusion i added two comments.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This commit only adds two explanatory comments to the code. It does not change any behavior, fix any bug, or alter any security mechanism. One comment clarifies that child classes of CosignerWallet must inherit from EventListener and register callbacks; the other notes that callbacks are registered in child classes. It is a documentation-only change.
Security candidatebug: psbt_nostr: set CosignerWallet.pending on aio loopby f321x · 0d380218 · Jan 5, 2026 · 1 fileMessage 73 · AdequateInformational 17Details
Commit message · f321x
bug: psbt_nostr: set CosignerWallet.pending on aio loop
Fixes: ``` Traceback (most recent call last): File "/home/user/code/electrum-fork/electrum/plugins/psbt_nostr/qt.py", line 149, in on_receive self.mark_pending_event_rcvd(event_id) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^ File "/home/user/code/electrum-fork/electrum/plugins/psbt_nostr/psbt_nostr.py", line 254, in mark_pending_event_rcvd self.pending.set() ~~~~~~~~~~~~~~~~^^ File "/usr/lib64/python3.14/asyncio/locks.py", line 192, in set fut.set_result(True) ~~~~~~~~~~~~~~^^^^^^ File "/usr/lib64/python3.14/asyncio/base_events.py", line 829, in call_soon self._check_thread() ~~~~~~~~~~~~~~~~~~^^ File "/usr/lib64/python3.14/asyncio/base_events.py", line 866, in _check_thread raise RuntimeError( "Non-thread-safe operation invoked on an event loop other " "than the current one") RuntimeError: Non-thread-safe operation invoked on an event loop other than the current one ```
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 17/100
This is a bug-fix patch for a crash in Electrum's optional PSBT-over-Nostr plugin. The plugin helps co-signers exchange partially-signed Bitcoin transactions. The crash happened because a background thread tried to update an asyncio synchronization object on the wrong event loop, triggering a RuntimeError. The fix routes that update to the correct asyncio loop. It is a reliability fix, not a security vulnerability, and there is no evidence it can be exploited by an attacker.
Lower-priorityandroid build: bump python version (3.10.18->3.11.14)by SomberNight · adb4f6f2 · Dec 27, 2025 · 3 filesMessage 91 · StrongInformational 15Details
Commit message · SomberNight
android build: bump python version (3.10.18->3.11.14)
Bump the python version used on Android from 3.10 to 3.11. The substance is the backport of the corresponding commit [0] from upstream p4a.
Tested that apk is still reproducible by doing two full builds. I also used the apk a bit and it seems to work at runtime. :)
[0]: https://github.com/kivy/python-for-android/pull/2850/commits/78db83223f4f481598343237a6b8788fb4731a00 (which got squashed into https://github.com/kivy/python-for-android/commit/83e74cac0fa230231f63b7d7e4f1e8581fd9e2ce)
91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100
This commit simply updates the version of Python used to build the Electrum Android app from 3.10.18 to 3.11.14. It changes version numbers and cryptographic checksums in build files, and switches to a newer version of the python-for-android build tool. There is no indication of a security vulnerability being fixed or introduced.
Lower-prioritypi: allow emaillike pi with 'lightning:' prefixby f321x · dd1d98e3 · Dec 22, 2025 · 2 filesMessage 68 · AdequateInformational 21Details
Commit message · f321x
pi: allow emaillike pi with 'lightning:' prefix
Lightning addresses with 'lightning:' do occur in the wild and make sense (how else would e.g. the smartphone know to open a lightning wallet instead of the e-mail client). So we should allow this.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 21/100
This commit lets Electrum recognize email-style payment identifiers (like user@domain.com) even when they have a 'lightning:' prefix in front. Previously, 'lightning:user@domain.com' would not be treated as a resolvable Lightning address. The change simply strips the prefix before checking if the rest looks like an email address. It is a small usability improvement, not a fix for a known security flaw.
pi: fix incorrectly parsing emaillike with 'ln' prefix
Fixes a bug where we incorrectly parsed emaillike payment identifiers as bech32 lightning payment identifier if they start with a 'ln' prefix.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 46/100
This commit fixes a bug in Electrum where certain email-like or domain-like payment identifiers that happened to start with the letters 'ln' (such as 'lnbcuser@some.domain') were wrongly treated as Lightning Network invoices. The fix makes the parser check whether the string is actually valid bech32 format before classifying it as a Lightning payment. This could have caused users to send payments to the wrong destination or prevented them from resolving legitimate email/domain payment identifiers.
Lower-priorityandroid: qr scanner: allow tap to focusby f321x · d1368db3 · Dec 22, 2025 · 1 fileMessage 68 · AdequateInformational 20Details
Commit message · f321x
android: qr scanner: allow tap to focus
Allow tap to focus in the android qr scanner as some devices don't support autofocus. This should allow them to focus on some qr code.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 20/100
This commit adds a 'tap to focus' feature to Electrum's Android QR code scanner. It is a usability improvement for users whose phones lack automatic focus, not a security fix or vulnerability. There are no security signals in the code or commit message.
Bumps the BarcodeScannerView and zxing++ version which allows us to remove the 16kb page alignment patch as this is now done upstream. Ref https://github.com/spesmilo/electrum/commit/87d82f38c559ef27c7f749dac565a92d984148da
76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 18/100
This commit updates the versions of two open-source barcode scanning libraries used in Electrum's Android app and removes a local workaround patch. The removed patch forced the compiled barcode scanner library to use a specific memory page size (16 KB) so it would work on newer Android devices. The upstream library now handles this automatically, so the patch is no longer needed. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a routine dependency maintenance change.
Updates the submarine payments tab if the channels get updated so the user isn't stuck with a liquidity warning if they open the tab before the channels are initialized (e.g. on wallet startup).
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 18/100
This is a small user-interface fix for the Electrum Bitcoin wallet's Qt desktop app. It makes the 'Submarine Payments' tab refresh itself once the user's Lightning channels finish loading, so an outdated liquidity warning doesn't stay on screen. There is no security vulnerability here.
Lower-priorityqt: Add help button to submarine payments tabby f321x · d233e4ff · Dec 22, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · f321x
qt: Add help button to submarine payments tab
Adds a help button with explanation to the submarine payments tab.
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100
This commit only adds a help button with explanatory text to a user interface screen about 'submarine payments' in the Electrum wallet. It is a documentation/user-experience change, not a security fix or vulnerability.
Lower-priorityqt: ConfirmTxDialog: also show Tools textby f321x · 4c44620d · Dec 22, 2025 · 1 fileMessage 88 · StrongInformational 15Details
Commit message · f321x
qt: ConfirmTxDialog: also show Tools text
Also show the `Tools` text besides the preferences icon so it looks equal to the main window. Originally this was a followup part of #10300 which got closed due to other reasons.
88/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100
This commit is a purely cosmetic user-interface change. It adds the word 'Tools' next to the preferences icon in a transaction confirmation dialog so the button matches the main window's appearance. There is no security relevance.
Lower-priorityqt: disable ln configs in ConfirmTxDialog if no lnby f321x · db456062 · Dec 22, 2025 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · f321x
qt: disable ln configs in ConfirmTxDialog if no ln
Disables the lightning related config options in the ConfirmTxDialog tools and shows an according tooltip if lightning is not available in the wallet. This should prevent confusion of users.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100
This commit is a user-interface improvement, not a security fix. It simply grays out two Lightning-related options in the transaction confirmation dialog when the wallet does not support Lightning, and shows a tooltip explaining why. There is no vulnerability being patched.
Lower-priorityqt: disable Submarine Payment tab if not swap_managerby f321x · 93d85a0b · Dec 22, 2025 · 1 fileMessage 65 · AdequateInformational 16Details
Commit message · f321x
qt: disable Submarine Payment tab if not swap_manager
Disable the `Submarine Payments` tab if the swap_manager is None (the wallet has no lightning support).
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 16/100
This commit is a small hardening change in Electrum's Qt wallet interface. It hides the 'Submarine Payment' tab when the wallet does not have Lightning support (swap_manager is missing). Without this guard, the tab could be shown in a state where the underlying swap service is unavailable, which might lead to a confusing or broken user experience rather than a direct theft-of-funds bug.
Lower-priorityqt: channels_list: add tooltip to New Channel btnby f321x · 71bc9af5 · Dec 22, 2025 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · f321x
qt: channels_list: add tooltip to New Channel btn
Adds tooltips to the "New Channel" button so users understand why it is disabled and what it does when it is enabled.
72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Explains rationale or failure mode
AI analysis · Informational 15/100
This commit only adds helpful hover text (tooltips) to the 'New Channel' button in Electrum's user interface. It explains why the button is disabled when Lightning isn't available and what the button does when it is enabled. There is no security change.
Lower-prioritylnpeer: fix callback type hintby f321x · 14977e4c · Dec 19, 2025 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · f321x
lnpeer: fix callback type hint
asyncio.create_task expects a Coroutine, not all Awaitables are Coroutines.
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100
This commit changes only a Python type hint in the Lightning Network peer code. It replaces 'Awaitable' with 'Coroutine' in a function signature annotation to better match what asyncio.create_task expects. Type hints do not affect runtime behavior, so this cannot by itself introduce or fix a security vulnerability. It is a code-quality/correctness improvement for static analysis tools and developers.
The done_callback for the callback tasks in _run_htlc_switch_iteration tried to access mpp_sets by key but they might already have been deleted when the callback is called, causing an KeyError. Instead forward the exceptions to the crash reporter so we get notice of them and they get logged correctly.
``` 20251219T131356.946565Z | ERROR | asyncio | Exception in callback Peer._run_htlc_switch_iteration.<locals>.<lambda>(<Task finishe.../util.py:1773>) at /home/user/code/electrum-fork/electrum/lnpeer.py:2907 handle: <Handle Peer._run_htlc_switch_iteration.<locals>.<lambda>(<Task finishe.../util.py:1773>) at /home/user/code/electrum-fork/electrum/lnpeer.py:2907 created at /usr/lib64/python3.14/asyncio/events.py:94> source_traceback: Object created at (most recent call last): File "/usr/lib64/python3.14/threading.py", line 1082, in _bootstrap_inner self._context.run(self.run) File "/home/user/code/electrum-fork/electrum/util.py", line 1145, in run_with_except_hook run_original(*args2, **kwargs2) File "/usr/lib64/python3.14/threading.py", line 1024, in run self._target(*self._args, **self._kwargs) File "/home/user/code/electrum-fork/electrum/util.py", line 1705, in run_event_loop loop.run_until_complete(stopping_fut) File "/usr/lib64/python3.14/asyncio/base_events.py", line 706, in run_until_complete self.run_forever() File "/usr/lib64/python3.14/asyncio/base_events.py", line 677, in run_forever self._run_once() File "/usr/lib64/python3.14/asyncio/base_events.py", line 2038, in _run_once handle._run() File "/usr/lib64/python3.14/asyncio/events.py", line 94, in _run self._context.run(self._callback, *self._args) Traceback (most recent call last): File "/usr/lib64/python3.14/asyncio/events.py", line 94, in _run self._context.run(self._callback, *self._args) ~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/home/user/code/electrum-fork/electrum/lnpeer.py", line 2909, in <lambda> f"{self.lnworker.received_mpp_htlcs[pk]=}", exc_info=t.exception()) if t.exception() else None ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^ KeyError: '0000980000010001:1' ```
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Low 25/100
This commit fixes a bug in Electrum's Lightning payment handling. When a background callback task finished, the code tried to read a payment record that might already have been deleted, causing a KeyError. The fix removes that unsafe lookup and instead sends any callback failure to the crash reporter. It is a robustness fix rather than a security vulnerability; the error was noisy and could hide real callback failures, but there is no evidence it could be exploited to steal funds or bypass protections.
