EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsNormal
Repository coverage

1153 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

92security candidates261second-pass queue1007AI analyses
127commits · 30 days
262commits · 60 days
545commits · 180 days
1002commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
220Strong · 80–100
549Adequate · 60–79
340Thin · 40–59
44Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
ThomasV137891162
SomberNight39330362063
f321x40325387070
Sander van Grieken10910101057
ghost4342517069
Felix25410072
user323062
ekzyis222053
accumulator613071
Roman Zeyde515053
Sasha Zykov515075
Aaron Fiore414068
Analysis record

Published AI watches

Last scanned 55 minutes ago

Low 29 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10992 from f321x/dedup_is_seed_wizard

This commit simplifies the seed-validation logic in Electrum's Qt wallet wizard by replacing a local copy of the rules with a call to an existing shared validation method. The change appears to be a code-cleanup refactor that removes dupli…

Refactor of seed-validation logic in wallet creation wizardRemoval of duplicated seed-type checks in favor of centralized validationAdded assertion constraining seed type to 'electrum'
554daca6by ghost43+2−81 file
No security note in commit
Low 29 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10982 from spesmilo/wizard_2fa_seed_redirect

This commit changes Electrum's wallet creation wizard so that if a user tries to restore a normal 'standard' wallet but pastes a seed phrase that actually belongs to a two-factor authentication (2FA) wallet, the wizard automatically redire…

UX-level safety fix preventing wallet-type/seed mismatchState mutation: wizard_data['wallet_type'] changed from 'standard' to '2fa' based on seed typeNo cryptographic, network, or privilege changes
310c9dd0by Felix+102−133 files
No security note in commit
Informational 12 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: wizard: dedup seed validation rules

This commit is a small code cleanup in Electrum's wallet setup wizard. It removes a duplicate copy of the rules used to check whether a recovery seed is valid and instead reuses an existing method. There is no indication this fixes a secur…

89d0de06by f321x+2−81 file
No security note in commit
Informational 15 AI analysisMessage 70 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

tests: wizard: cover standard -> 2fa redirection

This commit only adds and reorganizes automated test code for Electrum's wallet creation wizard. It does not change any production wallet logic, cryptography, or network handling. The tests verify that when a user tries to restore a 'stand…

70b4d27cby f321x+68−91 file
No security note in commit
Informational 15 AI analysisMessage 78 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10988 from f321x/update_security_review_ci_model

This commit updates Electrum's internal CI (continuous integration) script that runs an automated security review using Anthropic's Claude Code tool. It changes the AI model version used for reviews from 'claude-opus-5' to 'claude-opus-5-5…

CI hardening: detects and reports AI model downgrades during automated security reviewNo changes to application code, cryptography, network protocol, or build artifactsNo privilege escalation, injection, or data-exfiltration vectors introduced by the diff
638fbba8by Felix+75−111 file
No security note in commit
Informational 12 AI analysisMessage 90 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

ci: security review: warn if the model got downgraded

This commit updates Electrum's own CI security-review script. It adds detection and warnings when the automated code reviewer (Claude Code) silently falls back to a different AI model, for example after a content-policy refusal. It does no…

CI-only changeNo modification of wallet, crypto, networking, or build artifactsAdds detection for AI model fallback/downgrade in automated security review
ace2ca7aby f321x+74−101 file
No security note in commit
Low 44 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10987 from spesmilo/fix_10986

This commit fixes a bug where Electrum failed to recognize certain already-signed Bitcoin transactions as complete. Specifically, for native SegWit inputs, Bitcoin Core can produce a finalized PSBT with a valid witness but an empty scriptS…

Logic error in transaction completeness detectionNative SegWit witness handling edge casePSBT interoperability issue with Bitcoin Core
bef80421by ghost43+11−02 files
No security note in commit
Low 35 AI analysisMessage 81 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

transaction: treat native segwit input with non-empty witness as complete

This commit fixes a bug where Electrum incorrectly treated finalized Bitcoin transactions as incomplete. Some wallet software (like Bitcoin Core and Sparrow) creates native SegWit transactions that omit an empty placeholder field Electrum …

Logic error in transaction completeness detectionPotential denial of service / user funds stuck due to refusal to broadcast valid finalized transactionInteroperability failure with Bitcoin Core and Sparrow PSBT output
e9bb42e6by ThomasV+11−02 files
No security note in commit
Moderate 68 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10981 from spesmilo/do_not_sign_txin_with_witness

This change prevents Electrum from re-signing Bitcoin transaction inputs that already contain a witness (the data proving the input was authorized). The patch fixes a bug where Electrum could incorrectly sign a non-SegWit input as if it we…

Incorrect signature algorithm selection for non-SegWit inputs when witness data is presentPSBT handling edge case where pre-existing witness data influences signing pathPotential invalid signature production during transaction signing
9da4c342by ThomasV+10−21 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10974 from SomberNight/202609_nostr_psbt_xpub

This commit only adds a long code comment explaining a design choice in Electrum's PSBT-over-Nostr plugin. It does not change any program behavior. The comment documents that the plugin derives each cosigner's Nostr secret key from their B…

Documentation-only changeExplicit design tradeoff disclosure: cosigners can derive each other's Nostr secret keys from shared xpubsNo functional code change
46408a78by ThomasV+13−01 file
No security note in commit
Low 42 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10980 from spesmilo/add_input_from_network_do_not_ignore_exceptions

This is a one-line bugfix in Electrum's transaction handling. Previously, the code accidentally swallowed (hid) almost all exceptions when fetching extra transaction data from the network, only re-raising errors that were both network-rela…

Exception swallowing bug fixedNetwork/transaction input enrichment logic changedSilent failure mode removed
bb9d3280by ghost43+1−11 file
No security note in commit
Moderate 60 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10970 from f321x/fix_bolt11_bugs_2

This commit fixes several bugs in Electrum's handling of BOLT11 Lightning invoices. The most user-visible fixes are: stricter validation of invoice amounts (rejecting zero, negative, sub-millisatoshi, and leading-zero amounts), correct pad…

Stricter BOLT11 amount validation prevents acceptance of zero, negative, sub-millisatoshi, and leading-zero amountsFixed int_to_data5 padding bug that corrupted small timestamp values during invoice round-tripMalformed 'r' routing tags now raise exceptions instead of being silently skipped
4b92c0f2by ghost43+82−939 files
No security note in commit
Moderate 61 AI analysisMessage 80 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

add_info_from_network: do not swallow exceptions

Electrum's transaction builder had a bug where it would ignore certain consistency errors when fetching extra transaction data from the network. A malicious or misbehaving server could supply a wrong input amount, and Electrum would silent…

Swallowed exception leading to use of attacker-controlled input valuePSBT input consistency check bypassedPotential malicious Electrum server influence on transaction signing
3f67b21bby ThomasV+1−11 file
Vendor flagged security relevance
Informational 15 AI analysisMessage 60 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

bolt11: remove tag arg from get_routing_info

This is a small code cleanup change. A function that reads routing hints from Lightning invoices no longer takes a tag argument because only one type of routing hint ('r') is now supported. All callers are updated accordingly. There is no …

e78fba28by f321x+12−127 files
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10940 from accumulator/fix_10937

This commit tightens how Electrum parses Bitcoin payment requests (BOLT11 lightning invoices and BIP21 URIs). It turns previously uncaught internal errors into proper validation failures, rejects malformed invoice fields that used to be si…

Stricter input validation for externally supplied BOLT11 invoices and BIP21 URIsPreviously uncaught exceptions (ValueError, UnicodeDecodeError, ecc errors) are now wrapped in domain-specific decode exceptionsMalformed fallback addresses are skipped rather than aborting or crashing
a57ef6e7by Felix+707−9610 files
No security note in commit
Low 40 AI analysisMessage 36 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

bolt11: followup #10940

This commit tightens how Electrum parses BOLT11 Lightning invoices. It now rejects duplicate 'n' (node pubkey) tags instead of silently keeping only the first one, and it rejects invoice timestamps that are negative or too far in the futur…

Stricter validation of invoice timestamp boundsDuplicate 'n' tag now raises an exception instead of being silently droppedFollow-up to prior PR #10940, indicating a recent area of security-sensitive review
3026fbdbby f321x+14−232 files
No security note in commit
Low 32 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10737 from sashazykov/hw-close-wallet-thread-leak

This commit fixes a shutdown bug in Electrum's hardware wallet support. Previously, if disconnecting from a hardware wallet failed, the cleanup thread could keep running, which could crash the application when closing. The fix stops the th…

Process abort/crash at shutdown due to leaked QThreadException during cleanup not handled, potentially causing abnormal terminationHardware wallet client close made best-effort with error logging
5b77ca46by Felix+9−22 files
No security note in commit
Informational 23 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10958 from SomberNight/202609_deps

This commit is a routine dependency update for the Electrum Bitcoin wallet. It bumps versions of Python, OpenSSL, secp256k1, and various Python packages used in builds and runtime. The commit itself does not fix any known security bug in E…

Dependency version bumps for cryptographic libraries (OpenSSL, libsecp256k1, electrum-ecc)Routine maintenance commit with no explicit security claimHash-only changes in deterministic requirements files
8bd8c3fbby ghost43+57−5612 files
No security note in commit
Informational 21 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10965 from SomberNight/202609_header_checkpoints

This commit only adds new Bitcoin block header checkpoints to Electrum's built-in chain data files. Checkpoints are hardcoded reference points that help the wallet verify it is following the real blockchain and not a fake one. Updating the…

Hardcoded blockchain checkpoints extended for all supported networksNo executable code or cryptographic logic changedNo bug fix, privilege change, or input validation change present
9e0b7e64by ghost43+276−04 files
No security note in commit
Informational 15 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

update block header checkpoints

This commit simply refreshes Electrum's built-in list of Bitcoin blockchain checkpoints. Checkpoints are known-good block hashes that help the wallet verify it is following the real chain. The update adds newer checkpoints for mainnet, sig…

e11c579bby SomberNight+276−04 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityconfig: allow setting "forgetconfig" option in file, not just on CLIby SomberNight · 21248817 · Jan 19, 2026 · 2 filesMessage 81 · StrongInformational 16Details
Commit message · SomberNight

config: allow setting "forgetconfig" option in file, not just on CLI

- by specifying "default=<VALUE>" in commands.py, <VALUE> would always overwrite what is in the config file
- note `$ ./run_electrum -o setconfig forget_config true` still does not work,
as that first sets forget_config in memory, and then - by virtue of the setting -
it refuses to write changes to the config file
- hence this option would have to be set manually by editing the json
(or as a CLI flag, as before)

ref https://github.com/spesmilo/electrum/pull/10421#issuecomment-3765862081

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 16/100

This is a small bug-fix for how Electrum handles a setting called 'forgetconfig'. Previously, the command-line default of 'false' always overrode the value stored in the user's config file, making it impossible to enable the setting inside the config file. The change lets users set it in the config file as intended. It is not a security vulnerability fix; it is a usability/config fix.

Lower-prioritylnpeer: followup #10413by user · e81ac4b7 · Jan 16, 2026 · 1 fileMessage 59 · ThinInformational 18Details
Commit message · user

lnpeer: followup #10413

Save the updated htlc set in `Peer._fulfill_htlc_set` and
`Peer._fail_htlc_set()` only after the loop iterated through all htlcs.
This potentially improves performance, especially considering that
writing the db can take >100 ms for larger wallets without partial
writes.

59/100 · ThinMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 18/100

This is a small performance cleanup in Electrum's Lightning code. It moves a save-to-database operation outside a loop so the wallet writes once instead of after every individual payment chunk. There is no direct security bug being fixed; the change reduces database writes and may make crashes during batch processing slightly cleaner, but it does not patch a vulnerability.

Lower-priorityaddr_sync: update "stored_height" db field immediately on wallet-openby SomberNight · a27e2cc6 · Jan 15, 2026 · 1 fileMessage 73 · AdequateInformational 23Details
Commit message · SomberNight

addr_sync: update "stored_height" db field immediately on wallet-open

Repro steps:
- in qt gui, with network enabled, open wallet1
- open wizard, create wallet2 (restore from seed something that has mined history)
- close both wallets, stop electrum
- start electrum with "-o" offline flag, open wallet2
- observe all txs in history tab show up as "unconfirmed"

The cause is that "stored_height" only gets updated ~on new blocks.
So if you created a wallet and closed it soon, its db would not contain "stored_height."

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 23/100

This commit fixes a display bug in the Electrum wallet. If a wallet was created or restored and then quickly closed, the database did not record the last known block height. Later, opening that wallet in offline mode made all transactions appear 'unconfirmed' because the wallet had no saved height to compare against. The fix immediately saves the current block height when a wallet is opened, not just when new blocks arrive.

Lower-prioritylnutil: change ReceivedMPPStatus.htlcs to frozenset, i.e. immutableby SomberNight · c37b844f · Jan 15, 2026 · 4 filesMessage 81 · StrongModerate 55Details
Commit message · SomberNight

lnutil: change ReceivedMPPStatus.htlcs to frozenset, i.e. immutable

As ThomasV says:

> ReceivedMPPStatus is a Namedtuple, which is immutable, but it contains
> a mutable field. Since ReceivedMPPStatus is not a StoredObject,
> no patch will be created when the htlcs list is modified, and we may
> end up not saving the change to disk if partial writes are enabled.

patch taken from https://github.com/spesmilo/electrum/pull/10395#pullrequestreview-3634244541
closes https://github.com/spesmilo/electrum/pull/10395

Co-authored-by: f321x <f@f321x.com>

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Moderate 55/100

This commit fixes a data-integrity bug in Electrum's Lightning payment handling. A particular data structure was supposed to be immutable, but it secretly contained a mutable list. When the list changed, Electrum's storage system did not notice, so the change might not be saved to disk—especially when partial writes are enabled. That could leave the wallet's record of incoming Lightning payments inconsistent after a restart or crash, potentially causing funds to appear stuck or payments to be mishandled. The fix makes the list truly immutable and updates the code to create new copies whenever it changes, so the storage layer reliably saves the state.

Lower-priorityqml: FeePicker: restrict abs/rate editing to mimic wallet.bump_fee/cpfpby SomberNight · 8a3d9fd7 · Jan 14, 2026 · 4 filesMessage 50 · ThinLow 35Details
Commit message · SomberNight

qml: FeePicker: restrict abs/rate editing to mimic wallet.bump_fee/cpfp

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 35/100

This commit tightens the user interface for fee editing in Electrum's mobile/QML wallet. Previously, users could freely type either a fee rate or a total absolute fee when bumping or cancelling transactions. Now, the app restricts which of those two inputs is shown depending on the operation, matching the rules already enforced by the underlying wallet code. This reduces the chance that a user accidentally creates an invalid or exploitable transaction by entering a fee value the wallet logic does not expect.

Lower-priorityqml: (trivial) qeinvoice: add type hintby SomberNight · ca597942 · Jan 14, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · SomberNight

qml: (trivial) qeinvoice: add type hint

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit adds a single type hint comment to a QML GUI file. It does not change any executable code, logic, or behavior. There is no security relevance.

Lower-priorityqml: fix invalid QEInvoiceParser stateby f321x · b599ae7d · Jan 14, 2026 · 1 fileMessage 88 · StrongLow 42Details
Commit message · f321x

qml: fix invalid QEInvoiceParser state

Fixes the issue described in #10406.
When scanning a lightning invoice we would pass it to
`QEInvoiceParser.fromResolvedPaymentIdentifier()`, however
`fromResolvedPaymentIdentifier()` doesn't reset the state of
`QEInvoiceParser._lnurlData` which is used in QML to evaluate
`payImmediately: invoiceParser.isLnurlPay` in the `onValidationSuccess`
connection.

This change calls `clear()` in `fromResolvedPaymentIdentifier()` to
ensure that `QEInvoiceParser` state gets reset when loading a new invoice.
However when retrieving a bolt11 from a lnurl-pay callback we don't
wan't to reset `QEInvoiceParser._lnurlData` so that `payImmediately` is
true when confirming the lnurl pay dialog, for that I skip calling
`fromResolvedPaymentIdentifier()` and instead call `validateRecipient()`
directly so the `QEInvoiceParser` state doesn't get reset in this case.

88/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validation
AI analysis · Low 42/100

This commit fixes a state-handling bug in Electrum's mobile/QML interface when scanning or processing payment invoices. Specifically, when a user scanned a Lightning invoice, leftover data from a previous LNURL-pay interaction could remain in the invoice parser, causing the app to think it should still act as an LNURL-pay and potentially pay immediately without showing the normal confirmation. The fix resets parser state when loading a new invoice, except when intentionally continuing an LNURL-pay flow.

Lower-priorityqeqrscanner: check requestCode on activity resultby f321x · 64501879 · Jan 13, 2026 · 1 fileMessage 45 · ThinLow 46Details
Commit message · f321x

qeqrscanner: check requestCode on activity result

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 46/100

This commit fixes the Android QR scanner in Electrum so it checks which app-request ID is returned before processing a scanned result. Previously the scanner used a hardcoded request code of 0, which could let a malicious or confused app feed fake QR scan results into Electrum by returning an activity result with the same default code. The fix gives Electrum a unique, randomly chosen request code and ignores any result that does not match it.

Security candidateandroid: implement biometric authenticationby user · 5dd3dda2 · Jan 13, 2026 · 10 filesMessage 55 · ThinLow 35Details
Commit message · user

android: implement biometric authentication

Allows to unlock the android app with the android biometric api (e.g.
fingerprint). Can be enabled in the settings.

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Names security-relevant behavior explicitly
Why it was queued
access controlsigning or wallet path
AI analysis · Low 35/100

This commit adds optional fingerprint unlock to the Electrum Android app. It stores an encrypted copy of the wallet password on the device, protected by Android's built-in biometric/keystore system. The change is a feature addition, not a fix for a known bug or attack. There are some design choices worth reviewing—such as how the encrypted password is stored and what happens if a user adds a new fingerprint—but nothing in the commit itself shows an active vulnerability being exploited.

Lower-priorityfix test_onion_message (follow-up previous commit)by ThomasV · fa575ab1 · Jan 13, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · ThomasV

fix test_onion_message (follow-up previous commit)

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds a missing stub method to a mock object used in unit tests. It does not change any production code, network behavior, or wallet security logic. It is a test-only follow-up fix with no security relevance.

Lower-prioritylnpeer: wait_for_received_pending_htlcs_to_get_removed: wait only if peer has been initializedby ThomasV · 18451437 · Jan 13, 2026 · 1 fileMessage 50 · ThinLow 31Details
Commit message · ThomasV

lnpeer: wait_for_received_pending_htlcs_to_get_removed: wait only if peer has been initialized

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 31/100

This commit fixes a Lightning Network code path where Electrum would try to wait on a peer that had not finished initial setup. The change skips uninitialized peers instead of calling a method on them. This likely prevents a hang or crash during channel operations, but the commit message does not frame it as a security fix and no exploit details are provided.

Lower-priorityExchangeRate: return NaN if rate is 0by f321x · 5199c6c7 · Jan 13, 2026 · 1 fileMessage 76 · AdequateLow 25Details
Commit message · f321x

ExchangeRate: return NaN if rate is 0

Prevent DivisionByZero exceptions by returning `Decimal('NaN')
instead of `Decimal(0)` if the exchange rate is 0.

Fixes https://github.com/spesmilo/electrum/issues/10403

```
>>> bool(Decimal(0))
False
```

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Low 25/100

This is a small defensive fix in Electrum's currency-conversion code. Previously, if an exchange rate was reported as zero, the code treated it the same as a missing rate and returned zero. Other parts of the program could then crash with a 'division by zero' error when converting amounts. The change makes zero rates return a special 'not a number' value instead, so callers can handle it safely. It is a robustness improvement rather than a clear-cut security vulnerability.

Lower-priorityqml: FeePicker: hide "Target" line in "Manual" modeby SomberNight · 65f245f4 · Jan 12, 2026 · 2 filesMessage 65 · AdequateInformational 15Details
Commit message · SomberNight

qml: FeePicker: hide "Target" line in "Manual" mode

instead use font colors to hint which textedit is being used for target

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit is a user-interface tweak for Electrum's mobile/QML fee selector. It hides a 'Target' label when the user is manually entering a fee, and uses text color to show which of the two manual inputs (fee rate vs absolute fee) was edited last. There is no security-relevant change.

Lower-priorityqml: FeePicker: use UI_UNIT_NAME constants, instead of hardcodingby SomberNight · f387300a · Jan 12, 2026 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · SomberNight

qml: FeePicker: use UI_UNIT_NAME constants, instead of hardcoding

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a minor code cleanup in Electrum's mobile-style QML user interface. It replaces two hardcoded text labels ('sat/vbyte' and 'sat') with references to centrally defined constants. There is no security relevance: no logic, calculations, permissions, or data handling changed.

Lower-prioritytest_lnpeer: use PeerInTests instead if Peerby f321x · dee23717 · Jan 8, 2026 · 1 fileMessage 90 · StrongInformational 15Details
Commit message · f321x

test_lnpeer: use PeerInTests instead if Peer

ec65c53 replaces the usage of `PeerInTest` with `Peer` in
test_lnpeer.py.
PeerInTests sets `Peer.DELAY_INC_MSG_PROCESSING_SLEEP` to 0 so all
incoming messages get processed immediately. Because `Peer` instead of
`TestInPeer` was used the delay caused `test_reestablish_with_old_state`
to fail regularly because bob receives the old channel state and kills
the OldTaskGroup of the unittest with GracefulDisconnect before Alice
processed the answer of Bob and is still in ChannelState.REESTABLISHING.

```
FAILED tests/test_lnpeer.py::TestPeerDirect::test_reestablish_with_old_state - AssertionError: <PeerState.REESTABLISHING: 1> != <PeerState.BAD: 3>
```

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100

This is a one-line fix in Electrum's test suite. A previous change accidentally used the real network Peer class instead of a special test-only version (PeerInTests) in a Lightning network test. The test-only version processes messages immediately, which a specific test needs to avoid timing-related failures. This commit restores the test-only class, fixing a flaky unit test. It is not a security fix and does not affect production code.

AI review queuedtests: add TestLNWallet to test lnwallet utilsby f321x · 562839c5 · Jan 8, 2026 · 1 fileMessage 70 · AdequateInformational 15Details
Commit message · f321x

tests: add TestLNWallet to test lnwallet utils

Adds new unittest file test_lnwallet.py to allow unittesting
utility functions of LNWallet.

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new automated test file for an existing Lightning wallet utility function. It does not change any production code, add new features, or fix any bugs. There is no security relevance.

Lower-priorityqml: add close no-op to QEQRScanner to fix type errorby f321x · 04b7b683 · Jan 8, 2026 · 1 fileMessage 85 · StrongInformational 17Details
Commit message · f321x

qml: add close no-op to QEQRScanner to fix type error

Adds close() no-op method to QEQRScanner to prevent type errors like
this:
```
01-02 17:28:09.645 10543 10565 I python  : 162.27 | W | gui.qml.qeapp | file:///data/data/org.electrum.electrum/files/app/electrum/gui/qml/components/SweepDialog.qml:123: TypeError: Property 'close' of object QEQRScanner(0xdd32f66fb600)
is not a function
```

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 17/100

This is a tiny user-interface fix for the Electrum mobile app's QR-code scanner. A QML screen was trying to call a 'close' method that did not exist, causing a harmless JavaScript type error in the log. The developer added an empty 'close' method so the call succeeds and no error is printed. There is no security issue here.

AI review queuedqt: WalletInfoDialog: sort keystores by root fingerprintby f321x · fb96ba41 · Jan 8, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · f321x

qt: WalletInfoDialog: sort keystores by root fingerprint

Sort the keystore tabs of the WalletInfoDialog by their root
fingerprints. This makes it less confusing when looking at different
wallet instances of the same multisig setup as the tabs will always have
the same order.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a minor user-interface improvement, not a security fix. It simply sorts the tabs shown in the wallet information window by the keystore's root fingerprint so that multi-signature wallet tabs appear in a consistent order across different computers. There is no vulnerability or security-relevant change here.

AI review queuedAddressSynchronizer: invalidate balance cache on spvby f321x · 663fcddc · Jan 7, 2026 · 1 fileMessage 85 · StrongInformational 24Details
Commit message · f321x

AddressSynchronizer: invalidate balance cache on spv

There was a race incorrectly counting transactions with one
confirmations to the unconfirmed balance instead of the confirmed
balance.
This happened because the balance cache of AddressSynchronizer got
invalidated after `on_event_blockchain_updated` and then again after
`receive_history_callback`->`add_transaction`, however when calling
`AddressSynchronizer.get_balance()` before the tx got spv verified the
height would still be counted as 0 (unconfirmed), populating the balance
cache again with the unconfirmed balance.
I noticed this only on QML due to timing differences to Qt.
Invalidating the cache in `AddressSynchronizer.add_verified_tx()` after
the tx got verified causes the balance to get recalculated and shown
correctly.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
defensive validationsecond-pass: broader security terminology
AI analysis · Informational 24/100

This commit fixes a display-only bug in Electrum where, under certain timing conditions, a transaction that already had one blockchain confirmation could briefly be shown as 'unconfirmed' in the wallet balance. The fix adds a cache refresh right after a transaction is SPV-verified, so the balance is recalculated with the correct confirmation count. It does not allow theft, transaction manipulation, or remote code execution.

Lower-priorityAddressSynchronizer: remove unneccessary loopby f321x · 72f083d2 · Jan 7, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · f321x

AddressSynchronizer: remove unneccessary loop

This loop seems like a leftover that is not useful anymore, clearing the
cache once has the same effect.

50/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body
AI analysis · Informational 15/100

This is a minor code cleanup in Electrum's transaction handling. A developer removed a redundant loop that was calling the same cache-clearing function multiple times, replacing it with a single call. There is no security issue visible in the change.

Lower-priorityhw plugins: coldcard: fix compat with ckcc-protocol v1.5.0by SomberNight · 2172dadf · Jan 5, 2026 · 1 fileMessage 73 · AdequateInformational 18Details
Commit message · SomberNight

hw plugins: coldcard: fix compat with ckcc-protocol v1.5.0

fixes https://github.com/spesmilo/electrum/issues/10386

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 18/100

This is a small compatibility fix for Electrum's Coldcard hardware wallet plugin. A newer version of the underlying Coldcard communication library (ckcc-protocol v1.5.0) renamed a constant used to locate the Coldcard simulator. Electrum now tries the new name first and falls back to the old name, so the plugin works with both old and new library versions. There is no indication this is a security vulnerability or that it introduces one.

Lower-priorityhw plugins: coldcard: log error when I forget to set udev rulesby SomberNight · f1f4fc09 · Jan 5, 2026 · 1 fileMessage 77 · AdequateInformational 16Details
Commit message · SomberNight

hw plugins: coldcard: log error when I forget to set udev rules

so that next time I check that before changing cables, usb hubs, and VMs o.O

77/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Explains rationale or failure mode
AI analysis · Informational 16/100

This commit only adds a more helpful error message when the Coldcard hardware wallet cannot be opened because of missing Linux USB device permissions (udev rules). It does not change any security behavior, permissions, or access controls; it simply logs a hint before re-raising the same error.

Lower-prioritytests: rm some more dead codeby SomberNight · 92772414 · Jan 5, 2026 · 1 fileMessage 55 · ThinInformational 15Details
Commit message · SomberNight

tests: rm some more dead code

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply removes an unused helper function from a test file. It does not change any production code, user-facing behavior, or security-sensitive logic. There is no security issue here.

Lower-prioritytests: properly clean-up MockLNWallets after tests finishby SomberNight · 0afd433c · Jan 5, 2026 · 4 filesMessage 60 · AdequateInformational 14Details
Commit message · SomberNight

tests: properly clean-up MockLNWallets after tests finish

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 14/100

This commit only changes the project's internal unit tests. It makes test-only mock Lightning wallets get created and cleaned up in a more centralized way so temporary files and background tasks are reliably removed after each test. There is no change to the actual Electrum wallet or Lightning code that end users run, so this does not affect real-world security.

Lower-prioritylnchannel: chan.lnworker must now always be set, even in unit testsby SomberNight · c3e373a3 · Jan 5, 2026 · 1 fileMessage 60 · AdequateInformational 16Details
Commit message · SomberNight

lnchannel: chan.lnworker must now always be set, even in unit tests

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 16/100

This is a code-cleanup change inside Electrum's Lightning channel handling. It removes the special case where a channel object could exist without a linked Lightning wallet worker (lnworker). Previously, unit tests and some code paths allowed lnworker to be None, which forced many methods to check 'if self.lnworker:' before doing anything. The patch makes lnworker mandatory, simplifies those checks, and adds a developer note that one related cleanup call is currently broken. There is no direct security fix for end users here; it is mostly defensive maintenance that reduces the chance of future bugs in test or edge-case code.