Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This commit fixes a bug in the Cake Wallet Litecoin wallet where, when renaming a wallet, stored MWEB (a privacy feature for Litecoin) transaction records were being copied to a new storage box by reusing the exact same object references. …
Data migration now clones objects instead of sharing referencesPrevents potential state corruption when renaming Litecoin walletsNo explicit input validation or cryptographic change present
This is a routine update to the project's automated iOS build pipeline. It changes which Apple computer (runner) and Xcode version are used to compile and upload the iPhone app, so the app meets Apple's upcoming App Store requirement to us…
This commit is a routine mix of small fixes and test-tool updates. It makes a UI key more specific to avoid list-item conflicts, adds a safety check before showing a post-transaction popup, updates a test helper to match new app settings, …
Flutter BuildContext used across async gap now guarded by context.mountedNo explicit security keywords, CVE references, or advisory links in commit or titleChanges are split across UI, test tooling, and fixture scripts with no coherent security theme
This is a large accessibility and test-automation improvement for the Cake Wallet Flutter app. It adds stable identifiers to buttons, text fields, lists, and dialogs so screen readers and automated UI tests can find them. The patch also re…
Removed user-data interpolation from accessibility identifiers (tx ids, wallet names, seed words, addresses)Added stable, index-based or enum-based semantics identifiers across UI componentsAdded custom lints and CI workflow to prevent future user-data interpolation in test keys
This commit adds three new automated testing pipelines for the Cake Wallet mobile app: one for Android, one for iOS, and a weekly overnight test. These are explicitly marked as 'reply-only' experiments, meaning a failure will not block rel…
New CI/CD pipeline handling wallet seed phrases and API keysUse of `NO_REPLY` / `continue-on-error: true` to avoid blocking mergesExplicit mitigation: avoids `npx` on macOS to prevent environment-variable leakage via process title
This is a large cleanup of how the app labels its on-screen buttons and fields for automated testing and accessibility tools. Previously, many test labels were accidentally built from private user data such as wallet names, transaction IDs…
Accessibility identifiers derived from PII/sensitive data (wallet names, transaction IDs, seed words, addresses) are replaced with static or index-based identifiersNew custom lint rule no_string_interpolation_in_test_key blocks string interpolation in test keys except for int indexes and enum .nameNew custom lint rule require_test_key_semantics_identifier ensures framework interactive widgets with _key keys expose a Semantics identifier
This is a very large code refactor of the cryptocurrency swap/exchange feature in Cake Wallet. It rewrites how exchange rates are fetched, how trades are created and tracked, and how trade history is stored in the local database. The commi…
Large-scale rewrite of trade creation, rate fetching, and status monitoringDatabase schema migration for Trade table with data reconstruction from old columnsNew amount parsing helper (Money.safeParse) and exchange-rate math (ExchangeRate.fromAmounts)
This commit expands Cake Wallet's Lightning Bitcoin feature so it works across multiple Bitcoin accounts instead of being locked to the primary account only. It also fixes address selection so the app picks an unused Segwit address that be…
Account isolation logic changed: Lightning and Segwit address selection now account-awarePrevious code could return a Segwit address from a different account than the one currently selectedRemoval of hard-coded account index checks suggests prior account-boundary assumptions were too restrictive
This commit is a large internal refactor of how Bitcoin-style wallets in Cake Wallet store and derive account keys. It replaces scattered maps of HD keys with a single shared 'ElectrumAccounts' model, initializes those keys earlier during …
Refactor of BIP32 HD key derivation and account key storage across multiple coin modulesWallet keys view model now exposes master xPrv and xPub instead of per-account private keyChange in how legacy change HDs are identified, with a new regression test for Litecoin MWEB change addresses
This commit deletes four leftover Android Java files that were no longer used. The app's namespace was already fixed to 'com.cakewallet.cake_wallet', so these old copies of the main activity and application class under different package na…
This commit fixes visual layout bugs in the Cake Wallet mobile app where long Tamil translations were being drawn off-screen or clipped. It also fixes a broken unit test by adding a missing mock object. There is no security vulnerability h…
This commit adds new language translations (Bengali, Marathi, Tamil, Telugu), fixes Hindi translations, and introduces automated tools to check translation quality. It also makes a small formatting fix so cryptocurrency amounts display wit…
No changes to cryptographic, authentication, networking, or storage codeNo permission changes or new entitlementsNo changes to dependency versions or external URL endpoints
This commit is a routine user-interface redesign for the Cake Wallet app. It adds a new 'More Actions' menu (a floating plus button), moves Contacts and Buy/Sell options into that menu, and introduces first-time explainer pop-ups for gift …
No security-relevant code changes identifiedUI-only refactor with no new network, storage, or crypto logicNew URL launch to cakepay.com in gift card explainer uses standard url_launcher external application mode
This commit improves accessibility for screen-reader users. It adds spoken labels to buttons that were previously unlabeled, announces which cryptocurrency each wallet holds, removes a duplicate invisible tap target, and makes the currentl…
This commit improves screen-reader accessibility in the Cake Wallet mobile app. It makes settings switches announce their name (e.g., 'Auto generate addresses, switch, off') and makes choice options like 'Enabled / Tor only / Disabled' tel…
This commit makes small GitHub workflow and documentation tweaks. It adds read-only permissions to four pull-request check workflows, deletes an already-commented-out lint workflow, and updates a Windows installer filename and release note…
Workflow least-privilege hardening: four PR workflows now declare read-only repository permissionsRemoval of an inactive lint workflow that contained commented-out build steps and external download commandsDocumentation-only update for Windows installer filename and release history
This commit is a routine version bump and changelog update for the Cake Wallet/Monero.com v6.5.4 release candidate. It updates translated changelog text, version/build numbers across Android, iOS, Linux, and macOS, and makes minor UI fixes…
This commit fixes a bug in how Cake Wallet signs Bitcoin-style messages. Previously, the app could not correctly sign messages with 'change addresses' (a special type of address used when sending leftover funds back to yourself). The fix m…
Refactor centralizes address validation and derivation-path construction for hardware signingChange addresses are now included in address lookup, fixing a functional signing bugTaproot and MWEB addresses are explicitly rejected for message signing
This commit fixes a bug in Cake Wallet's Bitcoin message signing. Previously, if a user chose a silent payment address (a newer privacy-focused Bitcoin address type), the app would still sign the message using the wallet's main key. That s…
Cryptographic signature produced for a different identifier than the one presented to the userSilent fallback to main wallet key when selected address cannot be derivedMessage signing bypass for silent payment / unheld addresses
This commit is a straightforward user-interface performance fix. It wraps each tab of the app's main dashboard in a Flutter widget called TickerMode, which pauses animations in tabs that are not currently visible. Before the change, a load…
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Lower-priorityfeat: keep the latest-version notice on releases older than Latest (#3856)by Omar Hatem · 45632108 · Nov 16, 2026 · 1 fileMessage 93 · StrongTriage 0Details
Commit message · Omar Hatem
feat: keep the latest-version notice on releases older than Latest (#3856)
When a release becomes a full release (published directly, or promoted from a pre-release), add the "Download the latest version" button and the "Always install the latest version" notice to every release published before the one marked Latest, so a link to an old release points people at the newest one. The Latest release, newer releases and drafts are never edited.
The job has only contents: write, uses no third-party actions and no checkout, reads no event data, and runs only in cake-tech/cake_wallet on a GitHub-hosted runner. It edits at most 5 releases per run, re-checks Latest before each edit and after the last one, never marks an edited release as Latest and verifies every saved body. An edit GitHub refuses with 403/404 (how it reports its workflow-file restriction) doesn't stop the others; the run lists it and fails.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
{ "title": "Zcash on Cupcake", "description": "Sign ZEC transactions offline with our air-gapped Cupcake app by scanning QR codes" }, { "title": "Easier Swaps", "description": "Swap from any asset without switching wallets first, plus the new WhyNot provider and more coins on Chainflip" }, { "title": "Tron Upgrades", "description": "Connect your Tron wallet to dApps with WalletConnect, and send USDT and other tokens using rented energy" }, { "title": "Bitcoin Cash on Ledger", "description": "Connect your Ledger to receive and send BCH" }, { "title": "Bug fixes & improvements", "description": "An option to hide the Charts and NFTs tabs, sending without waiting for sync on most wallets, a smoother app and more" }
76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100
This commit is a routine version bump and changelog update for the Cake Wallet/Monero.com v6.5.4 release candidate. It updates translated changelog text, version/build numbers across Android, iOS, Linux, and macOS, and makes minor UI fixes (refresh control padding, banner coloring). There is no code change that introduces or fixes a security vulnerability in the diff itself.
Lower-priorityfix: windows build (#3853)by Konstantin Ullrich · 30cd343f · Nov 15, 2026 · 2 filesMessage 55 · ThinTriage 0Details
Commit message · Konstantin Ullrich
fix: windows build (#3853)
55/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Security candidate- Fix signing messages to include change addresses as wellby Omar · 40ffab7d · Nov 15, 2026 · 8 filesMessage 50 · ThinModerate 51Details
Commit message · Omar
- Fix signing messages to include change addresses as well - cleanup signing messages logic
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 51/100
This commit fixes a bug in how Cake Wallet signs Bitcoin-style messages. Previously, the app could not correctly sign messages with 'change addresses' (a special type of address used when sending leftover funds back to yourself). The fix moves the address lookup logic into a shared helper so all wallet types use the same rules, and it adds tests proving that both regular and change addresses can now be signed. It also blocks signing with Taproot and MWEB addresses, which would otherwise produce misleading signatures. There is no direct evidence in the commit that this was exploited or reported as a security flaw.
Security candidatefix: refuse Bitcoin message signing for an address the wallet cannot derive (#3826)by Omid · a2e88dad · Nov 15, 2026 · 3 filesMessage 98 · StrongModerate 60Details
Commit message · Omid
fix: refuse Bitcoin message signing for an address the wallet cannot derive (#3826)
Selecting a silent payment address still signed with the main key, so the signature did not belong to the address on screen. A requested address that is not a held receive address now fails instead of falling back.
98/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 60/100
This commit fixes a bug in Cake Wallet's Bitcoin message signing. Previously, if a user chose a silent payment address (a newer privacy-focused Bitcoin address type), the app would still sign the message using the wallet's main key. That signature would not actually prove ownership of the silent payment address shown on screen, which could mislead someone verifying the signature. Now the app refuses to sign for any address the wallet cannot directly derive, including silent payment and Taproot addresses, instead of silently falling back to the main key.
fix: always send Onramper a payment method (#3850)
With "All Payment Methods" selected, which the buy/sell screen uses by default since v6.4.5, quotes went out with no paymentMethod, so Onramper picked one per ramp, sometimes one the ramp can't serve (Kraken + XMR checkouts broke). Onramper asked us to always send one.
- "All" now quotes with Onramper's recommended method from /supported/defaults/all, which was already fetched on every load but never used. If that call fails, buy falls back to creditcard and sell keeps sending none. - A quote whose method has no PaymentType mapping keeps Onramper's raw id, so checkout always passes txnPaymentMethod instead of dropping it.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI review queued[ui perf] pause animations in hidden dashboard tabs (#3806)by malik1004x · 95b8b05a · Nov 15, 2026 · 3 filesMessage 81 · StrongInformational 15Details
Commit message · malik1004x
[ui perf] pause animations in hidden dashboard tabs (#3806)
* pause animations in hidden dashboard tabs
IndexedStack keeps tickers running in its hidden children, so the Charts tab's loading spinner (the tab stays in ChartsInitial until it is first opened) redrew the whole dashboard at 120fps after every launch. Each tab is now wrapped in TickerMode, so its animations pause while another tab is shown.
Measured on a Redmi Note 12 (120Hz, profile build): idle Home went from ~120 frames/s to none, and the full jank scenario rendered 30% fewer frames with 31% fewer janky ones (2586 -> 1774).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* unwrap TickerMode in the integration robots' front-tab checks
The dashboard's IndexedStack children are now TickerMode wrappers, so HomePageRobot.isInFront and WalletListPageRobot._isShowing never matched NewHomePage / WalletListPage and every tier0 suite failed with "The home tab never came to the front".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: Omar <omarh.ismail1@gmail.com>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a straightforward user-interface performance fix. It wraps each tab of the app's main dashboard in a Flutter widget called TickerMode, which pauses animations in tabs that are not currently visible. Before the change, a loading spinner on the hidden Charts tab was continuously redrawing the whole dashboard at up to 120 frames per second, wasting battery and causing visual stutter. The change also updates two automated test helpers so they can still find the correct tabs now that each is wrapped in TickerMode. There is no security relevance in this change.
Security candidateAdd Bitcoin Cash Ledger wallet support (#3847)by Konstantin Ullrich · f90b4c60 · Nov 14, 2026 · 17 filesMessage 76 · AdequateInformational 15Details
Commit message · Konstantin Ullrich
Add Bitcoin Cash Ledger wallet support (#3847)
* feat: add Bitcoin Cash Ledger hardware wallet support
* feat: add Ledger message signing for Litecoin and Bitcoin Cash
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This commit adds support for using Ledger hardware wallets with Bitcoin Cash in Cake Wallet, and also enables message signing for Litecoin and Bitcoin Cash on Ledger devices. It is a feature addition, not a security fix. There is no indication in the commit or supplied references that this change addresses a vulnerability or security incident.
Lower-priorityrebuild only the price labels while scrubbing the chart (#3804)by malik1004x · 698ba29c · Nov 14, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · malik1004x
rebuild only the price labels while scrubbing the chart (#3804)
Every touch move on the chart called setState on ChartHeader, which rebuilt PriceChart: it re-parsed every price point and handed fl_chart a new LineChartData, restarting its implicit animation. The scrubbed price and time now live in ValueNotifiers that only the labels showing them listen to.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI review queuedstop keyboard animations rebuilding the hidden dashboard (#3805)by malik1004x · becb85dd · Nov 14, 2026 · 8 filesMessage 81 · StrongInformational 21Details
Commit message · malik1004x
stop keyboard animations rebuilding the hidden dashboard (#3805)
The dashboard stays mounted under every pushed route, and ChartsPage, NewHomePage, CardsView, the coin action row, the unconfirmed balance widget and the wallet list each read MediaQuery.of(context) for a single field. Every viewInsets change while the keyboard animated therefore rebuilt the charts grid, the home page and the wallet list behind the page being typed into. They now use sizeOf / viewPaddingOf, which don't change with keyboard insets.
Measured on the restore-from-seed page (Redmi Note 12, 120Hz, profile build): focusing the seed field went from 16-17 janky frames (build p90 15-19ms) to 1 (build p90 3.7-4.7ms); typing plus dismissing the keyboard went from build p90 11.5-12.5ms to 4.2-4.8ms.
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 21/100
This is a performance improvement, not a security fix. The developers noticed that every time the on-screen keyboard opened or closed, several background dashboard widgets were needlessly redrawing, causing stuttering (janky frames). They replaced broad MediaQuery lookups with narrower ones that only watch the specific values actually needed (screen size and top safe-area padding), so keyboard animations no longer trigger rebuilds. The change improves app smoothness but does not address any vulnerability or protect user data.
Lower-priority[ui perf] rasterize the dashboard once while a cupertino sheet animates over it (#3812)by malik1004x · c6cb39c2 · Nov 14, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · malik1004x
[ui perf] rasterize the dashboard once while a cupertino sheet animates over it (#3812)
* rasterize the dashboard once while a cupertino sheet animates over it
CupertinoScaffold scales and clips the dashboard behind every cupertino modal sheet (settings, send, receive, swap, history, ...). The scale changes every frame, so Skia re-rasterized the whole dashboard each frame, navbar blur included. While the sheet animation runs, the dashboard is now drawn from a SnapshotWidget image, the same approach Flutter's zoom page transition uses; it renders live again once the sheet settles.
Measured opening and closing Settings (Redmi Note 12, 120Hz, profile build): 40 of 41 raster frames over budget with a median of 27ms -> 30 of 79 over budget with a median of 16.4ms, and LayerTree::Paint time 390ms -> 103ms. Across the eight sheet open/close steps of the jank scenario, frames rendered went from 186 to 296 and the janky share from 75% to 50%.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* genericize
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI review queuedCW-1744: Redesign Display settings and add Charts and NFTs tab toggles (#3841)by Omar Hatem · 8136ec29 · Nov 14, 2026 · 47 filesMessage 81 · StrongInformational 15Details
Commit message · Omar Hatem
CW-1744: Redesign Display settings and add Charts and NFTs tab toggles (#3841)
* CW-1744: Redesign Display settings and add Charts and NFTs tab toggles
- Group Display settings into General, Theme, Show Tabs and Other Preferences - Add Charts and NFTs tab toggles, both on by default - Show the language flag and the currency symbol, e.g. "USD ($)" - Replace "Disable buy action" with "Show Buy/Sell options" (same saved setting) - Show the theme preview only when more than one theme fits the mode - Move Bitcoin amount display to Bitcoin Settings - Add 8 strings in all 31 locales
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* CW-1744: Fix theme switcher divider and black-theme off toggle colors
- Draw the System/Light/Dark divider in On Surface at 10% opacity - Off toggles on the black theme use #454148 (its Secondary Container), like the OLED mode toggle, instead of #2B292B
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100
This commit is a routine user-interface redesign for the Cake Wallet app's Display Settings screen. It reorganizes settings into groups (General, Theme, Show Tabs, Other Preferences), adds two new user-controlled toggles for showing/hiding the Charts and NFTs tabs, moves a Bitcoin-specific display option into Bitcoin Settings, and updates translations. There is no security-relevant change.
AI review queuedCW-1734: Show a scam warning while the user is on a call (#3842)by Omar Hatem · 482213c4 · Nov 14, 2026 · 40 filesMessage 81 · StrongInformational 15Details
Commit message · Omar Hatem
CW-1734: Show a scam warning while the user is on a call (#3842)
* CW-1734: Show a scam warning while the user is on a call
- Detect phone and VoIP calls natively: CallKit CXCallObserver on iOS, AudioManager mode on Android, through is_on_phone_call on native_utils and a new phone_call_status event channel - Add the cw_core wrapper phone_call_native.dart (false on desktop or error) - Add CallScamBanner: checks on open and resume, follows live changes, shows the banner above the wrapped page and gives the page no top padding - Add CallScamWarningSheet with the official support contacts - Show the banner on the Home tab, the seed page and Show seed/keys - Add the design's three icons and 8 strings in all 31 locales
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* CW-1734: Show the call warning on every screen
- Wrap the navigator once in MaterialApp.builder instead of the Home tab, seed page and keys page - Open the warning sheet through the app navigator key - Wrap the navigator in a semantics container during a call so screen readers reach the banner - Move Android call detection into PhoneCallStatusStreamHandler; leave the unused Monero.com MainActivity alone - Reuse the existing info icon and make the new SVGs white; colors are applied in code - Read theme and strings inline, as in the rest of lib/new-ui
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit adds a new safety feature to the Cake Wallet app that shows a warning banner when the user is on a phone or VoIP call. The goal is to protect users from phone scams where attackers pretend to be Cake Wallet support. The app now detects active calls on iOS and Android, displays a banner across all screens, and offers a help sheet with official support contacts. There is no security vulnerability in this change.
* feat: add Cake Pay maintenance screen when no cards are returned (CW-1739)
Show a maintenance screen (Cake Pay logo, warning icon, "Cake Pay is under maintenance" and "Please check back soon") in the Cake Pay Shop tab when the vendor list comes back empty and there is no search text. A search with no results still shows "No cards found".
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* feat: show the Cake Pay maintenance screen from /api/core/status (CW-1739)
Check GET /api/core/status once when the Cake Pay page opens and show the maintenance screen when it returns "maintenance": true, instead of when the vendor list is empty. An empty list shows "No cards found" again. While the check runs the Shop tab keeps its spinner, and if the check fails the page behaves as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: exclude the decorative Cake Pay maintenance icons from semantics (CW-1739)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
* fix: stop waiting for the Cake Pay status check after 10 seconds (CW-1739)
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 20/100
This commit adds a new user-facing feature: a maintenance screen for the Cake Pay gift-card service. When the app opens the Cake Pay section, it now asks Cake Pay's server whether the service is in maintenance mode. If the server says yes, the app shows a friendly 'under maintenance' message instead of the usual list of cards. The change also adds a 10-second timeout and translated strings for many languages. There is no security vulnerability visible in the diff.
Security candidatefix: don't leave a ghost WalletInfo row when wallet creation fails (#3830)by Omar Hatem · d3c74388 · Nov 14, 2026 · 4 filesMessage 98 · StrongLow 45Details
Commit message · Omar Hatem
fix: don't leave a ghost WalletInfo row when wallet creation fails (#3830)
* fix: don't leave a ghost WalletInfo row when wallet creation fails
EVM wallet init() saves the WalletInfo row (through saveAddressesInBox) before save() writes the wallet file, and WalletCreationVM only set a FailureState when process() threw. Any failure in that window left a row without a wallet file, so the wallet showed up in the list but could never be opened:
PathNotFoundException: Cannot open file, path = '.../wallets/polygon/<name>/<name>'
The reproducible trigger is "restore from private key" for an EVM chain: the keys form validates only the wallet name, so a non-hex or empty key reached EthPrivateKey.fromHex inside init(), after the row was saved.
- EVMChainWalletService.restoreFromKeys rejects an invalid private key with a BadKeysException before anything is persisted. EVMChainUtils.isValidPrivateKey accepts a 32-byte hex key, optionally 0x-prefixed, with 0 < k < secp256k1 order. - WalletCreationVM._create removes the WalletInfo row when process() throws, but only if the wallet directory holds no wallet file for that name. That is the same check _validateWalletInfoBoxData uses, so a row is dropped only when the startup validation would not re-create it. A failure after the wallet files exist keeps today's behaviour.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix: only drop the WalletInfo row when the wallet directory is empty
The cleanup gate matched the "<name>/<name>" path substring that _validateWalletInfoBoxData uses. Directory.listSync joins entries with the platform separator, so on Windows the substring never matches and the row was dropped on every failure, even with wallet files on disk (Cursor Bugbot). The check also assumed every coin names its on-disk files after the wallet, which Decred does not before save().
Delete the row only when the directory is missing or empty: a failed EVM restore writes nothing before the throw, so the ghost row still goes away, and any coin that got as far as writing a file keeps today's behaviour.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
* fix: accept every private key that restored before, reject only unusable ones
The first revision of isValidPrivateKey required exactly 32 bytes. The wallet never had that rule: EthPrivateKey.fromHex takes any even-length hex, the address and every signature derive from the integer value of the bytes, and the key is stored as entered, so a 62- or 128-character input produced a working wallet. Re-restoring such an input on a new device would have been refused.
Now the check rejects only what never produced a usable wallet: hex that does not parse (previously a throw inside init() after the WalletInfo row was saved) and keys that are zero modulo the secp256k1 order, which have no key pair.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
---------
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
98/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
secret or key materialsigning boundarydefensive validationsigning or wallet path
AI analysis · Low 45/100
This commit fixes a bug in Cake Wallet where creating or restoring an EVM wallet could leave a 'ghost' wallet entry in the app's list. The ghost appeared because the wallet's metadata was saved to the app's database before the actual wallet file was written. If the next step failed—for example, because the private key was invalid—the app showed a wallet that could never be opened. The fix validates the private key before saving anything, and cleans up the metadata row if the wallet file was never actually created. It also makes sure the cleanup only happens when the wallet directory is empty, so it doesn't accidentally delete real wallets.
Security candidatefeat(exchange): add cbBTC, BNB and USDT-on-BSC to Chainflip (#3840)by David Cumps · 4461119c · Nov 14, 2026 · 2 filesMessage 93 · StrongLow 34Details
Commit message · David Cumps
feat(exchange): add cbBTC, BNB and USDT-on-BSC to Chainflip (#3840)
Chainflip added cbBTC on Ethereum and BNB/USDT on BNB Smart Chain. Enable all three for swaps in the Chainflip provider.
- _supported: add cbbtc, bnb, usdtbsc - _toCurrency: reverse-map cbbtc.eth, bnb.bsc, usdt.bsc; also fix the missing usdt.sol -> usdtSol arm so USDT-on-Solana trades resolve - _amountToNative: convert with AmountConverter.toBaseUnits instead of double->int, fixing 18-decimal amounts (USDT-BSC minimum 10 is 1e19, above int max) and the live ETH/FLIP/ARB-ETH above-9.223 defect - crypto_currency.dart: add cbbtc to CryptoCurrency.all so it appears in the picker and deserialize(raw: 103) works; all is app-wide, so cbBTC also appears in buy/sell, contacts and charts (#3050 precedent)
93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive path
AI analysis · Low 34/100
This commit adds support for three new cryptocurrencies (cbBTC, BNB, and USDT-on-BSC) to the Chainflip exchange provider in Cake Wallet. It also fixes a numeric conversion bug where very large token amounts could be calculated incorrectly or even overflow, which could have caused swap quotes or trades to use the wrong amount. There is no direct evidence in the commit of an active security vulnerability being exploited.
AI review queuedfeat: cupcake zcash (#3704)by cyan · 854435b0 · Nov 14, 2026 · 21 filesMessage 55 · ThinLow 27Details
Commit message · cyan
feat: cupcake zcash (#3704)
55/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathparser or protocol pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Low 27/100
This commit adds support for a new Zcash air-gapped hardware wallet mode called 'Cupcake' (a QR-signer). It changes how Zcash wallets are restored from QR codes, how shielding transactions are committed, and how transparent address rotation is skipped for QR-signer wallets. There are no obvious security bugs in the diff, but the new code paths introduce areas where future mistakes could matter: restoring a wallet from a QR-encoded full viewing key, signing transactions via animated QR codes, and skipping address rotation for a new wallet type.
AI review queuedfix: t addr rotation rescan (#3827)by cyan · 18bca0f7 · Nov 14, 2026 · 2 filesMessage 65 · AdequateInformational 24Details
Commit message · cyan
fix: t addr rotation rescan (#3827)
65/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 24/100
This commit fixes a bug in Cake Wallet's Zcash wallet where rescanning the blockchain did not properly reset the wallet's rotated transparent (t-) addresses. Transparent addresses are public on the blockchain; when a wallet rotates to a new one, the old cache of transactions must be cleared during a rescan so the wallet doesn't show stale or incorrect balance/history. The fix adds a helper that updates the rotated account's birth height, resets its sync state, and clears cached transaction data so the rescan starts fresh for those addresses too.
Lower-priorityfix: recalculate estimated fees after payment flow errors (#3845)by Konstantin Ullrich · 0b82ea45 · Nov 14, 2026 · 1 fileMessage 70 · AdequateTriage 0Details
Commit message · Konstantin Ullrich
fix: recalculate estimated fees after payment flow errors (#3845)
70/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Security candidatefix ln invoice not configured correctly for applinksby Omar · 3713f80f · Nov 13, 2026 · 2 filesMessage 50 · ThinLow 32Details
Commit message · Omar
fix ln invoice not configured correctly for applinks gracefully handle monero subaddresses
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
privacy or spend-authorization protocol
AI analysis · Low 32/100
This commit fixes two separate bugs in a cryptocurrency wallet app. First, it corrects how Lightning Network invoice links are formatted so that Android/iOS 'applinks' open properly. Second, it adds a safety check so that if the Monero wallet isn't loaded yet, the app returns an empty list of subaddresses instead of crashing. Neither change appears to be a security vulnerability fix in the traditional sense; they are reliability/bug fixes.
Security candidateFix address search to match address or label case-insensitively (#3837)by claude[bot] · e0981df1 · Nov 11, 2026 · 2 filesMessage 81 · StrongInformational 20Details
Commit message · claude[bot]
Fix address search to match address or label case-insensitively (#3837)
* Fix address search to match address or label case-insensitively
The Receive > Addresses search only checked the label when an address had a non-empty name (always the case for Monero subaddresses), and compared the address case-sensitively against a lowercased query, which broke search for mixed-case address formats (Zcash t-addresses, EVM checksummed addresses, Solana, Tron, etc.).
Match either the address or the label, case-insensitively.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X8UF8vbBPx9f167TvAzjnk
* Restore print_verbose import in buy_sell_view_model
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01X8UF8vbBPx9f167TvAzjnk
---------
Co-authored-by: Claude <noreply@anthropic.com>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
privacy or spend-authorization protocol
AI analysis · Informational 20/100
This commit fixes a user-interface bug in the wallet's address search. Previously, searching for an address sometimes returned no results if the address contained uppercase letters (common for Zcash, Ethereum, Solana, Tron) because the search was comparing a lowercased query against the original mixed-case address. The fix makes the comparison case-insensitive and also allows searching by address even when the address has a label. There is no security vulnerability here—just a usability fix.
AI review queuedMerge pull request #3616 from cake-tech/fix/cw-1633-cakepay-lightning-balanceby malik1004x · 303e086a · Nov 10, 2026 · 1 fileMessage 73 · AdequateModerate 56Details
Commit message · malik1004x
Merge pull request #3616 from cake-tech/fix/cw-1633-cakepay-lightning-balance
fix: check Lightning balance before confirmation (CW-1633)
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 56/100
This commit adds a balance check before confirming a Lightning (CakePay) payment. Previously, the app may have allowed a user to confirm a payment even if their Lightning wallet did not hold enough funds to cover the amount plus fees. The fix fetches the current balance and throws an error if it is insufficient, preventing the transaction from proceeding.
Lower-priorityMerge pull request #3642 from cake-tech/cw-1476-cake-pay-failure-uxby malik1004x · 288ff08e · Nov 10, 2026 · 4 filesMessage 58 · ThinTriage 0Details
Commit message · malik1004x
Merge pull request #3642 from cake-tech/cw-1476-cake-pay-failure-ux
improve ux for errors in cake pay flow
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
merge-commit duplicate discount
Security candidateMerge branch 'dev' into cw-1476-cake-pay-failure-uxby Robert Malikowski · b4259b29 · Nov 10, 2026 · 300 filesMessage 65 · AdequateInformational 15Details
Commit message · Robert Malikowski
Merge branch 'dev' into cw-1476-cake-pay-failure-ux
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathauthentication pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This is a large routine merge from the 'dev' branch into a feature branch named 'cw-1476-cake-pay-failure-ux'. The visible changes are almost entirely build-system, CI/CD, asset, and translation updates. There is no direct evidence in the supplied diff of a security vulnerability being introduced or fixed.