AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Low 27 Monero

feat: cupcake zcash (#3704)

Public commit record

What the developer wrote

Authored by cyan

55/100 · Thin
feat: cupcake zcash (#3704)
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
The short version

What changed, and why it matters

This commit adds support for a new Zcash air-gapped hardware wallet mode called 'Cupcake' (a QR-signer). It changes how Zcash wallets are restored from QR codes, how shielding transactions are committed, and how transparent address rotation is skipped for QR-signer wallets. There are no obvious security bugs in the diff, but the new code paths introduce areas where future mistakes could matter: restoring a wallet from a QR-encoded full viewing key, signing transactions via animated QR codes, and skipping address rotation for a new wallet type.

Recommended action

Review the new UR/QR signing and restore flows for input validation, ensure the bc-ur-dart dependency is trustworthy and pinned securely, verify that disabling transparent address rotation for QR-signer wallets does not leak privacy or reuse addresses unexpectedly, and test that the `popped` guard fully prevents double-pops across all scanner entry points.

Security signals we found

01

New air-gap transaction signing flow (UR/QR PCZT encoding/decoding)

02

Wallet restoration from QR-encoded Zcash viewing key (ufvk) and account metadata

03

Transparent address rotation disabled for hardware/QR-signer wallets

04

Manual shielding now routed through UR QR page for non-hardware wallets in some paths

05

Dependency added on third-party bc-ur-dart git package

06

Scanner pop-state race condition fixed with `popped` guard

Risk score

Why this scored 27/100

Our methodology →
Potential impact 5/30
Exploitability 5/25
Stealth signal 3/15
Affected reach 5/15
Confidence 6/10
Evidence quality 3/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.