AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 22 Monero

i18n: fit the long Tamil strings on the new UI (#3878)

Public commit record

What the developer wrote

Authored by Seth For Privacy

96/100 · Strong
i18n: fit the long Tamil strings on the new UI (#3878)

* i18n: fit the long Tamil strings on the new UI

On-device QA of the merged i18n work on `dev` (Pixel 8 AVD, debug build)
found three places where Tamil copy is drawn outside its box:

- Welcome headline: it sits in a `Positioned` with only `top`, which
Flutter lays out with unbounded width, so the 13-glyph word was painted
past both screen edges with no overflow report. Bound the Positioned by
the visible width, let AutoSizeText shrink the word, and scale the
"to <logo> Cake Wallet" row beside it.
- Dashboard action row: captions were wider than their circles and pushed
the row 11 px past the edge. Captions now live inside their button and
auto-size.
- Receive buttons: the same caption problem overflowed by 56 px. Each
control takes an equal share of the row, the horizontal padding drops
from 32 to 16 and the caption shrinks to fit, so English stays on one
line (Copy / Set amount / Label / Addresses) while Tamil wraps inside it.

Verified on the emulator with the final APK: 0 `RenderFlex overflowed`
events for en, bn, hi, mr, ta and te on the dashboard and receive screens,
and the Tamil welcome screen renders fully.

* fix: keep action captions inside the row on narrow screens

Review follow-up (Bugbot on #3878):

- `CoinActionButton` captions were pinned to `effectiveSize + 12`, so even
short English captions made each button 12 dp wider than its circle and
four of them plus gaps exceeded a 360 dp row. The caption is now capped
with `ConstrainedBox`, and the row gives every action an equal `Expanded`
share, so a caption can never widen the row.
- Captions no longer break words: `wrapWords: false` makes a long single
word (Tamil "பரிமாற்றம்") shrink to fit one line instead of splitting
mid-glyph.

Also unblocks the `unit_tests` check, which is red on `dev` itself: the
settings page started reading `dashboardViewModel.settingsStore`, and
`test/new-ui/pages/settings_page_test.dart` never stubbed it, so the build
threw `type 'Null' is not a subtype of type 'SettingsStore'`. The mock now
exists and the amount display mode is stubbed; all 11 tests in that file
pass.

Verified on the Pixel 8 AVD at 360 dp and 320 dp (density 420): en and ta
dashboards and receive screens report 0 `RenderFlex overflowed`.

* fix: keep the welcome subtitle row inside the headline box

Bounding the headline `Positioned` also bounds the "to <logo> Cake Wallet"
row below it; with Tamil's "பெறுநர்" it overflowed by 3.2 px. Scaling that
row down keeps it inside the same box (verified at 360 dp and 411 dp).

* fix: never clip a long caption in the action buttons

`wrapWords: false` stopped mid-glyph breaks, but a single unbreakable word
that does not fit at `minFontSize` was still drawn clipped with no visible
report. Tamil "நகலெடுக்கப்பட்டது" (the Copy button's copied state) is the
case that hits it.

- Lower the floor to 6 sp, which fits it in the 76 dp caption box at
411/360 dp (single line) and allows a two-line fit in the narrower 320 dp
slot.
- Add `TextOverflow.ellipsis` as a last resort so nothing is ever clipped
silently.

The copied label only renders on Android < 13 (`CopyWrapper.shouldShowCopied`),
so it was verified by temporarily forcing that branch in a scratch build:
the caption renders complete at 411 dp and wraps to two lines at 320 dp,
with 0 `RenderFlex overflowed`.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
The short version

What changed, and why it matters

This commit fixes visual layout bugs in the Cake Wallet mobile app where long Tamil translations were being drawn off-screen or clipped. It also fixes a broken unit test by adding a missing mock object. There is no security vulnerability here; it is a routine user-interface polish and test-maintenance change.

Recommended action

No security action required. Treat as a normal UI/UX and test-fix merge.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 22/100

Our methodology →
Potential impact 2/30
Exploitability 0/25
Stealth signal 1/15
Affected reach 5/15
Confidence 9/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.