AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 20 Monero

i18n: add Bengali, Marathi, Tamil, Telugu and repair Hindi (#3859)

Public commit record

What the developer wrote

Authored by Seth For Privacy

100/100 · Strong
i18n: add Bengali, Marathi, Tamil, Telugu and repair Hindi (#3859)

* i18n: add ARB lint gate and review-sheet generator

- tool/i18n_lint.dart: key parity, placeholder order and drops, script
coverage, stray English, length and spacing per locale.
- tool/i18n_baseline.json rebuilt on dev so the gate starts green.
- tool/gen_review_sheet.dart: per-locale reviewer sheets by screen tier.
- are_translations_sane.yml runs the lint after the JSON check.

* i18n: add Bengali, Marathi, Tamil and Telugu; repair Hindi

- New locales at dev's full key set: 1,682 keys each. 517 keys that
did not exist on main were translated, 42 retranslated because the
English changed, and 1,123 carried over unchanged.
- Hindi repaired on dev's file, not replaced: terminology normalized
(86 strings), the four placeholder reorders fixed, 56 missing keys
translated.
- Wiring: language_service (bn -> bgd, others ind), translation
constants, CFBundleLocalizations, README list.
- Layout: select-button labels ellipsize; Picker gained an optional
imageSize used only by the language picker, so other icon sets keep
their natural size.

* i18n(hi): fix doubled शेष in balance strings

- The बैलेंस → शेष normalization collided with strings that already
used शेष: favorite_token_desc and gift_card_balance_note read
'शेष शेष'. Reworded to 'शेष बैलेंस कार्ड' and 'शेष राशि बची होगी'.

* i18n: make the gate safe for dev's workflow

- Missing keys are warnings, not errors: append_translation adds keys
to every file in langs, and pt_BR was not in that list, so a new key
would have failed the PR. pt_BR is now covered.
- Workflow keeps dev's permissions block, puzl-ubuntu runner and
PR_test_build job id; only the lint step is added, with setup-dart
pinned to the same SHA as the iOS workflow.
- checkString() is shared with gen_review_sheet.dart, so the sheet and
CI use identical thresholds; the sheet's call-site regex now matches
S.of(anyContext) and a dot on the next line.
- New highlight check: each *_highlight value must appear in its
paired _title string.
- Baseline pruned after the Hindi fixes (2,079 -> 2,015 entries).

* i18n: fix Tamil highlight, amount digits and stale wiring

- Tamil recovery highlight now matches the inflected form in its title,
so the education page highlights instead of silently missing.
- Amounts keep ASCII digits for locales with native numerals: only the
integer part was localised, so bn/mr/fa/my showed mixed scripts.
- Drop the unused SettingsPickerCell.imageSize (only Picker uses it).
- iOS CFBundleLocalizations no longer lists Guarani, which is disabled.

* i18n: add fixture tests for the lint

- i18n_lint accepts --arb-dir and --baseline so it can run against
fixtures instead of the repo tree.
- tool/i18n_lint_selftest.sh covers missing keys (warn, and fail under
--strict), placeholder reorder, dropped placeholder, and baseline
filtering; wired into the translations CI job.

* i18n: correct repeat kind and highlight pairing

- errorKinds listed ph-count, which nothing emits; dropped repeats are
reported as ph-repeat and stay warnings because the generator builds
parameter lists from a Set, so a repeat changes copy, not binding.
- Highlights are applied to a title OR a description depending on the
slide (order_highlight sits in order_description), so the check now
accepts either and reports only when the value is in neither.
- Fixture test for a highlight that matches nothing.

* i18n: pair highlights with the host the slide draws them in

- Accepting "title or description" still let a highlight pass when it
matched the title, while the slide renders it inside the description
(accounts_education_order_highlight is drawn against
accounts_education_order_description), so the text drew unhighlighted.
- English decides the pairing; the translation must highlight the same
host. Either host is accepted when English is ambiguous or the key has
no English counterpart.
- Fixture covers a highlight that matches the wrong host.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This commit adds new language translations (Bengali, Marathi, Tamil, Telugu), fixes Hindi translations, and introduces automated tools to check translation quality. It also makes a small formatting fix so cryptocurrency amounts display with regular ASCII digits instead of mixing different numeral scripts. There is no indication of a security vulnerability being fixed or introduced.

Recommended action

No security action required. Treat as a routine localization/quality-assurance commit. Reviewers may optionally verify that the new locale wiring does not accidentally enable an unsupported or disabled locale (e.g., Guarani remains removed from CFBundleLocalizations as intended).

Security signals we found

01

No changes to cryptographic, authentication, networking, or storage code

02

No permission changes or new entitlements

03

No changes to dependency versions or external URL endpoints

04

No vendor disclosure of security relevance in commit message or diff

05

Localization-only change with added CI quality checks

Risk score

Why this scored 20/100

Our methodology →
Potential impact 2/30
Exploitability 1/25
Stealth signal 1/15
Affected reach 3/15
Confidence 9/10
Evidence quality 4/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.