AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 19 Monero

a11y: name settings switches by their row title and expose selected state on Fiat API choices (#3808)

Public commit record

What the developer wrote

Authored by Seth For Privacy

96/100 · Strong
a11y: name settings switches by their row title and expose selected state on Fiat API choices (#3808)

* a11y: name settings switches by their row title

ListItemToggleWidget (Privacy, Connections, Display, Security and the
other new-list settings pages) and SettingsSwitcherCell (domain lookups,
silent payments, MWEB, background sync, home settings, 2FA, advanced
privacy) put the row text and the StandardSwitch in sibling semantics
nodes: the row tap target carried the title and the switch carried only
its toggled state, so TalkBack announced "Switch, off" with no name.

Wrap both shared rows in MergeSemantics. The title, subtitle, toggled
state and tap action now form one node, which Android reports as an
android.widget.Switch named by the row title ("Auto generate addresses,
switch, off"). The switch itself has no label, so nothing is read twice.
MergeSemantics is a semantics boundary, so the row is not absorbed into
an ancestor. ValueKeys and hit testing are unchanged.

* a11y: expose selected state on Picker and settings choice options

The Fiat API and Swap pickers on Connections (Picker) and the Fiat API /
Swap / seed type segmented choices on the wallet-creation privacy
settings page (SettingsChoicesCell) exposed each option as a plain
clickable group, so a screen reader could not tell which of "Enabled /
Tor only / Disabled" was active.

Give each option button role, selected state and mutually-exclusive
grouping. Picker renders the current item through buildSelectedItem and
every other item through buildItem, so the selected flag is constant in
each builder.

The SettingsChoicesCell line matches the one in draft #3693 (which also
wraps the row in TestId.merge). Landing it on dev first means #3693's
hunk resolves to its existing form when that stack is rebased, instead
of the two Semantics wrappers nesting.

* test: semantics contract for settings switches, choices and picker options

* a11y: keep row and switch actions apart when SettingsSwitcherCell has onTap

Merging the whole row into one semantics node leaves room for a single
tap action. For rows that pass onTap (Home settings token rows: tap
opens the token editor, the switch changes visibility) the merged node
kept the row's handler, so a screen reader could no longer toggle the
switch.

Merge only when onTap is null, where row tap and switch tap do the same
thing. When onTap is set, the row stays its own button and the switch
becomes its own container node labelled with the row title, so both
actions stay reachable and the switch is still named.

The new test drives both actions through the semantics tree; at the
previous head the switch action ran the row's onTap instead of toggling.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
The short version

What changed, and why it matters

This commit improves screen-reader accessibility in the Cake Wallet mobile app. It makes settings switches announce their name (e.g., 'Auto generate addresses, switch, off') and makes choice options like 'Enabled / Tor only / Disabled' tell the user which one is currently selected. There is no security vulnerability being fixed here; it is purely an accessibility (a11y) improvement.

Recommended action

No security action needed. Treat as a normal accessibility improvement. Reviewers may optionally verify the new tests pass and that TalkBack/VoiceOver announcements match the described behavior.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 19/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 5/15
Confidence 9/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.