What changed, and why it matters
This commit makes small GitHub workflow and documentation tweaks. It adds read-only permissions to four pull-request check workflows, deletes an already-commented-out lint workflow, and updates a Windows installer filename and release note in the verification guide. There is no direct product code change and no clear security vulnerability being fixed.
No immediate action required. The workflow permission changes are a minor hardening improvement. Reviewers may want to confirm the removed lint workflow is fully superseded and that no active CI job relied on it.
Security signals we found
Workflow least-privilege hardening: four PR workflows now declare read-only repository permissions
Removal of an inactive lint workflow that contained commented-out build steps and external download commands
Documentation-only update for Windows installer filename and release history
Evidence from the diff
The diff adds permissions: contents: read to four GitHub Actions workflows triggered by pull_request. It removes .github/workflows/lint.yml, whose job body was entirely commented out. It updates docs/VERIFY.md to reference Cake_Wallet_v6.5.4_Windows.exe and clarify that Windows builds were absent from v6.0.0 to v6.5.3. No application source code is modified.
Changed components
.github/workflows/are_translations_sane.yml.github/workflows/no_http_imports.yaml.github/workflows/no_print_in_dart.yaml.github/workflows/no_restricted_imports.yaml.github/workflows/lint.ymldocs/VERIFY.mdInspect captured patch +14 / −110
### .github/workflows/are_translations_sane.yml
@@ -2,6 +2,9 @@ name: Are translations sane
on: [pull_request]
+permissions:
+ contents: read
+
jobs:
PR_test_build:
runs-on: puzl-ubuntu-latest
### .github/workflows/lint.yml
@@ -1,108 +0,0 @@
-name: Lint
-
-on: [pull_request]
-
-defaults:
- run:
- shell: bash
-jobs:
-# lint:
-# runs-on: [Linux, amd64, android]
-# container:
-# image: ghcr.io/cake-tech/cake_wallet:debian13-flutter3.41.9-ndkr28-go1.24.1-ruststablenightly
-# env:
-# STORE_PASS: test@cake_wallet
-# KEY_PASS: test@cake_wallet
-# MONEROC_CACHE_DIR_ROOT: /opt/generic_cache
-# BRANCH_NAME: ${{ github.head_ref || github.ref_name }}
-# ANDROID_AVD_HOME: /root/.android/avd
-# volumes:
-# - /opt/cw_cache_android/root/.cache:/root/.cache
-# - /opt/cw_cache_android/root/.android/avd/:/root/.android/avd
-# - /opt/cw_cache_android/root/.ccache:/root/.ccache
-# - /opt/cw_cache_android/root/.pub-cache/:/root/.pub-cache
-# - /opt/cw_cache_android/root/.gradle/:/root/.gradle
-# - /opt/cw_cache_android/root/.android/:/root/.android
-# - /opt/cw_cache_android/root/go/pkg:/root/go/pkg
-# - /opt/cw_cache_android/opt/generic_cache:/opt/generic_cache
-# - /dev/kvm:/dev/kvm
-# - /var/run/docker.sock:/var/run/docker.sock
-# strategy:
-# matrix:
-# api-level: [ 29 ]
-#
-# steps:
-# - name: Fix github actions messing up $HOME...
-# run: "echo HOME=/root | sudo tee -a $GITHUB_ENV"
-# - uses: actions/checkout@v4
-# with:
-# ref: ${{ inputs.ref }}
-#
-# - name: configure git
-# run: |
-# git config --global --add safe.directory '*'
-# git config --global user.email "ci@cakewallet.com"
-# git config --global user.name "CakeWallet CI"
-#
-# - name: Fetch prebuilt Torch
-# run: |
-# set -x -e
-# pushd scripts
-# wget https://github.com/MrCyjaneK/torch_dart/releases/download/v1.0.17/torch_dart-v1.0.17.tar.gz -O torch_dart.tar.gz
-# rm -rf torch_dart
-# mkdir torch_dart
-# pushd torch_dart
-# tar -xzf ../torch_dart.tar.gz
-# popd
-# rm ./torch_dart.tar.gz
-# popd
-#
-# - name: Fetch prebuilt Reown
-# run: |
-# set -x -e
-# pushd scripts
-# # cleaning
-# rm -rf reown_flutter
-# rm -f reown_flutter.tar.gz
-#
-# wget https://github.com/cake-tech/reown_flutter/releases/download/v0.0.4/reown_flutter-v0.0.4.tar.gz -O reown_flutter.tar.gz
-# mkdir reown_flutter
-# pushd reown_flutter
-# tar -xzf ../reown_flutter.tar.gz
-# popd
-# rm ./reown_flutter.tar.gz
-# popd
-#
-# - name: Prepare Zcash
-# run: |
-# set -x -e
-# scripts/prepare_zcash.sh
-#
-# - name: Execute Build and Setup Commands
-# run: |
-# pushd scripts/android
-# source ./app_env.sh cakewallet
-# export GITHUB_HUH=yeah
-# ./app_config.sh
-# popd
-#
-# - name: Install Flutter dependencies
-# run: |
-# flutter pub get
-#
-# - name: Build generated code
-# run: |
-# flutter --version
-# flutter clean
-# rm -rf .dart_tool
-# rm pubspec.lock
-# flutter pub get
-# ./model_generator.sh async
-#
-# - name: Generate localization
-# run: |
-# dart run tool/generate_localization.dart
-#
-# - name: Lint
-# run: |
-# ABORT_ON_CHANGE=yeah scripts/lint.sh
### .github/workflows/no_http_imports.yaml
@@ -2,6 +2,9 @@ name: No http imports
on: [pull_request]
+permissions:
+ contents: read
+
jobs:
PR_test_build:
runs-on: puzl-ubuntu-latest
### .github/workflows/no_print_in_dart.yaml
@@ -2,6 +2,9 @@ name: No print statements in dart files
on: [pull_request]
+permissions:
+ contents: read
+
jobs:
PR_test_build:
runs-on: puzl-ubuntu-latest
### .github/workflows/no_restricted_imports.yaml
@@ -2,6 +2,9 @@ name: No restricted imports in lib directory
on: [pull_request]
+permissions:
+ contents: read
+
jobs:
check_restricted_imports:
runs-on: puzl-ubuntu-latest
### docs/VERIFY.md
@@ -197,14 +197,14 @@ flatpak install --user --bundle Cake_Wallet_Linux.flatpak
Windows installers are Authenticode-signed. In PowerShell:
```powershell
-Get-AuthenticodeSignature .\Cake_Wallet_Windows.exe | Format-List
+Get-AuthenticodeSignature .\Cake_Wallet_v6.5.4_Windows.exe | Format-List
```
The signature chains to `DigiCert Trusted G4 Code Signing RSA4096 SHA384 2021 CA1`, and the
publisher is `Cake Labs Inc` — the same name Windows shows in the UAC prompt as the verified
publisher. `Status` must be `Valid`.
-Note that recent 6.x releases do not include a Windows build.
+Releases v6.0.0 to v6.5.3 did not include a Windows build.
### iOS
Why this scored 18/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.