BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
171commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 20 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedwallet, test: remove -deprecatedrpc=bip125 from wallet_basic.pyby rkrux · 3ec550d1 · May 28, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · rkrux

wallet, test: remove -deprecatedrpc=bip125 from wallet_basic.py

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a minor test-only cleanup. It removes a deprecated command-line flag and an obsolete field name from a single automated test script. There is no change to Bitcoin Core's actual wallet or network code, and no security relevance.

AI review queuedwallet, test: remove -deprecatedrpc=bip125 from wallet_send.pyby rkrux · 2cbbcb56 · May 28, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · rkrux

wallet, test: remove -deprecatedrpc=bip125 from wallet_send.py

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes a test file. It removes the use of a deprecated RPC option and deletes test assertions that checked whether transactions were marked as replaceable. There is no change to the actual Bitcoin Core wallet or network code, and no security issue is evident.

AI review queuedwallet, test: remove -walletrbf startup option from wallet_backwards_compatibility.pyby rkrux · a52ea9bf · May 28, 2026 · 1 fileMessage 87 · StrongInformational 15Details
Commit message · rkrux

wallet, test: remove -walletrbf startup option from wallet_backwards_compatibility.py

This option can be removed from the previous releases as well because the
default for them is already 1.

87/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes a single test file. It removes the redundant '-walletrbf=1' startup flag from several test nodes because those older Bitcoin Core versions already default to that setting. There is no change to the actual Bitcoin Core wallet or network code, and no security issue is present.

AI review queueddoc: Remove good_first_issue.ymlby MarcoFalke · fab5733f · May 28, 2026 · 2 filesMessage 35 · OpaqueInformational 15Details
Commit message · MarcoFalke

doc: Remove good_first_issue.yml

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit simply removes a GitHub issue template and updates the contributor documentation to stop pointing to the 'good first issue' label. It is a documentation-only workflow change with no effect on Bitcoin Core's code, network behavior, or security.

AI review queuedwallet, test: remove -walletrbf startup option from wallet_backwards_compatibility.pyby rkrux · 42330922 · May 27, 2026 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · rkrux

wallet, test: remove -walletrbf startup option from wallet_backwards_compatibility.py

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a routine test-only cleanup. It removes an obsolete command-line option (-walletrbf) and its associated deprecation warning from a backwards-compatibility test script. There is no change to the Bitcoin Core wallet or network code that end users run, and no security issue is present.

AI review queuedwallet, test: remove -walletrbf startup option from wallet_listtransactions.pyby rkrux · 8cb6e405 · May 27, 2026 · 1 fileMessage 75 · AdequateInformational 15Details
Commit message · rkrux

wallet, test: remove -walletrbf startup option from wallet_listtransactions.py

The corresponding test case that tests for optin rbf variations can also
be removed.

75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only removes a test case from Bitcoin Core's automated test suite. It deletes the part of a test that exercised the deprecated '-walletrbf' startup option and related opt-in RBF transaction behavior. There is no change to the actual Bitcoin Core wallet, node, or network code, and no security vulnerability is present in the diff.

AI review queuedwallet, test: remove -deprecatedrpc=bip125 from wallet_listtransactions.pyby rkrux · 0ee94b2f · May 27, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · rkrux

wallet, test: remove -deprecatedrpc=bip125 from wallet_listtransactions.py

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes a single test file. It removes the use of a deprecated RPC option and deletes test assertions that checked a now-removed 'bip125-replaceable' field in wallet transaction output. There is no change to the actual Bitcoin Core wallet or node code that users run, so this cannot affect live wallets, funds, or network security.

AI review queuedwallet, test: -walletrbf startup option from wallet_bumpfee.pyby rkrux · 5e833e06 · May 27, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · rkrux

wallet, test: -walletrbf startup option from wallet_bumpfee.py

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes a single test file. It removes the use of the deprecated '-walletrbf' startup option and its associated deprecation warning from the wallet_bumpfee.py functional test. There is no change to production wallet code, no bug fix, and no security issue.

AI review queuedguix: Split manifest into build and codesign manifestsby Hennadii Stepanov · d846444d · May 26, 2026 · 4 filesMessage 50 · ThinInformational 15Details
Commit message · Hennadii Stepanov

guix: Split manifest into build and codesign manifests

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a build-system housekeeping change for Bitcoin Core's Guix reproducible-build tooling. It takes one large package list file (manifest.scm) and splits it into two smaller files: one used when compiling the software (manifest_build.scm) and one used when applying release signatures (manifest_codesign.scm). The scripts that invoke Guix are updated to point at the correct new file. There is no change to the Bitcoin Core node software, wallet logic, or network behavior, and nothing in the commit suggests a security vulnerability or fix.

AI review queuedtest: add IPC submitBlock functional testby woltx · 3962138c · May 26, 2026 · 2 filesMessage 100 · StrongInformational 15Details
Commit message · woltx

test: add IPC submitBlock functional test

Test the new Mining.submitBlock IPC method:
- Invalid block (bad version) returns failure with reason
- Valid block (with a real mempool tx) is accepted and propagates
- Duplicate block returns failure with "duplicate" reason
- Witness commitment without coinbase witness nonce is rejected
(bad-witness-nonce-size), confirming no auto-fix behavior
- submitBlock then submitSolution: duplicate is accepted (submitSolution
returns true for already-known blocks)
- submitSolution then submitBlock interaction (duplicate)

Build candidate blocks from BlockTemplate data in the existing coinbase and
submission test, then exercise checkBlock(), submitSolution(), and
submitBlock() against those candidates. submitBlock() uses an isolated IPC
node for cases that would otherwise affect the main submitSolution() and
checkBlock() assertions.

100/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This commit only adds new automated tests for the Bitcoin Core IPC mining interface. It does not change any production node code, consensus rules, or network behavior. The tests verify that a new submitBlock IPC method correctly accepts valid blocks and rejects invalid, duplicate, or malformed ones. There is no security vulnerability here.

AI review queuedwallet: refactor to read -walletrbf only once instead of twiceby rkrux · a3fe455a · May 26, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · rkrux

wallet: refactor to read -walletrbf only once instead of twice

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a tiny code cleanup in Bitcoin Core's wallet setup. It changes how the deprecated '-walletrbf' setting is read so the value is fetched once and reused, rather than checked for existence and then fetched separately. There is no security issue here.

AI review queuedtest: Allow --usecli in tests that already support itby MarcoFalke · fa246938 · May 26, 2026 · 5 filesMessage 72 · AdequateInformational 15Details
Commit message · MarcoFalke

test: Allow --usecli in tests that already support it

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's internal test scripts. It removes five lines that previously told the test framework these particular tests cannot be run with the command-line bitcoin-cli tool. There is no change to the actual Bitcoin node software, no security fix, and no vulnerability.

AI review queuedwallet: remove "RPC Only" from -walletrbf option help descriptionby rkrux · aba24a9b · May 22, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · rkrux

wallet: remove "RPC Only" from -walletrbf option help description

Effective post https://github.com/bitcoin-core/gui/pull/936.

Co-authored-by: Pol Espinasa <pol.espinasa@uab.cat>

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a one-word documentation update. It removes the phrase 'RPC only' from the help text of the -walletrbf command-line option because the feature is now also available through the graphical user interface. There is no code behavior change and no security impact.

AI review queuedrefactor: have mining files include what they useby Sjors Provoost · 8c58f635 · May 22, 2026 · 27 filesMessage 57 · ThinInformational 15Details
Commit message · Sjors Provoost

refactor: have mining files include what they use

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100

This commit is a pure code cleanup: it adjusts which header files are included in mining-related source files so each file explicitly includes only what it actually uses. There are no functional code changes, no bug fixes, and no security-relevant behavior changes.

AI review queuedmining: use interface for tests, bench and fuzzersby Sjors Provoost · 02016608 · May 22, 2026 · 20 filesMessage 83 · StrongInformational 15Details
Commit message · Sjors Provoost

mining: use interface for tests, bench and fuzzers

Have most tests, benchmarks and fuzzers go through the mining interface.
This is a refactor: it does not change what blocks are created, just how
the creation calls are made. This avoids most direct test, benchmark and
fuzzer use of node::BlockAssembler::Options, making it easier to drop in a
later commit.

Two exceptions which use BlockAssembler directly:
- one check in test/miner_tests.cpp needs m_package_feerates
- fuzz/tx_pool.cpp Finish() doesn't have access to a NodeContext

Move test_block_validity from BlockAssembler::Options to
BlockCreateOptions so bench/block_assemble.cpp can continue to set it.
Just like coinbase_output_script, this is not exposed to IPC clients.

Inline options variable in places where it's only needed once.

We also drop one unused PrepareBlock declaration and one unused
implementation.

TestChain100Setup::CreateBlock no longer needs a chainstate argument,
which in turn means it can be dropped from CreateAndProcessBlock. Using
the Mining interface here also requires marking the test
KernelNotifications chainstate as loaded after LoadVerifyActivateChainstate().

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidencesecond-pass: unusually broad change
AI analysis · Informational 15/100

This commit is a code cleanup (refactor) in Bitcoin Core's test, benchmark, and fuzzing code. It changes how test code asks the node to create blocks, switching most callers from the internal BlockAssembler class to a public Mining interface. The commit message explicitly says it does not change what blocks are created, only how the creation calls are made. There is no security fix or vulnerability here.

AI review queuedrefactor: Set TestNode.cli only after RPC is connectedby MarcoFalke · faf02674 · May 22, 2026 · 3 filesMessage 95 · StrongInformational 15Details
Commit message · MarcoFalke

refactor: Set TestNode.cli only after RPC is connected

The cli can only be called after the RPC is connected, so the cli field
should only be set after that. This is similar to the _rpc field.

This change has also other benefits:

* Manually overwriting the cli with a new rpchost is no longer needed,
so one cli-specific line can be removed from the rpc_bind.py test.
* The datadir and rpc_timeout fields are removed from the TestNodeCLI
struct. They were redundant with the -datadir and -rpcclienttimeout
command line options. Any command line option can be overwritten by
appending it with a new value, if needed.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a code cleanup in Bitcoin Core's internal testing tools. It changes when and how the test framework creates a command-line interface (CLI) helper for test nodes, and removes some redundant settings. There is no indication this fixes a security bug or affects live Bitcoin software.

AI review queuedrefactor: Use create_new_rpc_connection in wallet_multiwallet.pyby MarcoFalke · fa8f2511 · May 22, 2026 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · MarcoFalke

refactor: Use create_new_rpc_connection in wallet_multiwallet.py

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a minor code cleanup in a test file. It replaces a manual way of creating a connection to the Bitcoin node with a helper method that does the same thing. There is no security issue here.

AI review queuedtest: suppress ECONNABORTED in wait_for_rpc_connection on Windowsby Ryan Ofsky · 7209eb77 · May 21, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · Ryan Ofsky

test: suppress ECONNABORTED in wait_for_rpc_connection on Windows

Since bitcoin/bitcoin#33362, feature_bind_port_externalip.py runs in CI and
auto-detects whether 1.1.1.5 is assigned by starting nodes with -bind=1.1.1.5,
then converting a FailedToStartError containing "Unable to bind to" into a
SkipTest. On Windows CI the address is not configured, so bitcoind fails as
expected — but intermittently, while the process is shutting down, an RPC probe
raises ConnectionAbortedError (WSAECONNABORTED/WinError 10053) before
wait_for_rpc_connection() notices that the process has exited. That error was
not in the suppressed set, so it escaped and the test failed instead of being
skipped.

The intermittency is a race on TCP connection timing. If the probe connects
before the RPC port is listening, connect can fail with ECONNREFUSED. If the
TCP connection is established but is then closed abortively during shutdown,
the probe can see a connection-reset/aborted error instead. On POSIX systems
this commonly shows up as ECONNRESET ("connection reset by peer"). Winsock
also has WSAECONNABORTED for cases where an established connection is aborted
locally or otherwise terminated due to a timeout/protocol failure, in addition
to WSAECONNRESET for a reset by the remote side. This is why the
Windows-specific error may need to be suppressed separately.

Fix by treating ECONNABORTED identically to ECONNRESET, ETIMEDOUT, and
ECONNREFUSED: retry the probe rather than raising.

Fix was suggested by willcl-ark in
https://github.com/bitcoin/bitcoin/issues/35343#issuecomment-4507329622

Fixes #35343

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100

This is a test-only fix for a flaky automated test on Windows. It adds one more network error code (ECONNABORTED) to the list of temporary connection errors that the test framework should ignore while waiting for a Bitcoin node to start or shut down. It does not change Bitcoin Core's production code, network behavior, or security.

AI review queuedqa: use NORMAL_GBT_REQUEST_PARAMS consistentlyby Antoine Poinsot · ca5483a6 · May 21, 2026 · 5 filesMessage 68 · AdequateInformational 15Details
Commit message · Antoine Poinsot

qa: use NORMAL_GBT_REQUEST_PARAMS consistently

Some functional tests were still hardcoding parameters. Using the
constant allows to change the rules in a single place if necessary.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only changes Bitcoin Core's internal functional test code. It replaces hardcoded {'rules': ['segwit']} parameters with a shared constant NORMAL_GBT_REQUEST_PARAMS when calling getblocktemplate in tests. There is no change to production node code, no change to consensus rules, and no security fix or vulnerability introduced.

AI review queuedwallet: mark -walletrbf startup option as deprecatedby rkrux · 97f7cc02 · May 21, 2026 · 6 filesMessage 85 · StrongInformational 20Details
Commit message · rkrux

wallet: mark -walletrbf startup option as deprecated

All transactions are by default replaceable since v28, the wallet need not have
a configuration option to opt into RBF signalling because it seems redundant
now. Emit a warning if this option is used.

85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This commit simply marks an old wallet startup option called -walletrbf as deprecated. Since a recent release already makes all transactions replaceable by default, the option is now redundant. The change adds a warning when the option is used and updates tests to expect that warning. There is no security vulnerability here.

AI review queuedwallet: mark `bip125-replaceable` key as deprecated in transaction RPCsby rkrux · c4a7613e · May 21, 2026 · 5 filesMessage 73 · AdequateInformational 20Details
Commit message · rkrux

wallet: mark `bip125-replaceable` key as deprecated in transaction RPCs

Transactions are replaceable by default since v28 and the corresponding
tweaking argument has been removed since v29. The related key from the
mempool RPC has been marked deprecated as well since v29, this patch
does the same for the wallet transaction RPCs such as listtransactions,
listsinceblock, and gettransaction.

Users can pass the -deprecatedrpc=bip125 startup argument to retrieve
this key in the responses of above mentioned RPCs.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 20/100

This is a routine Bitcoin Core change that hides an old transaction status field called 'bip125-replaceable' from wallet RPC responses by default, marking it as deprecated. Users can still get it back by starting the node with -deprecatedrpc=bip125. It is not a security fix and does not introduce a vulnerability; it is a user-interface/API cleanup following earlier changes that made transactions replaceable by default.

AI review queuedrpc: Fix for duplicate external signers caseby optout · f05b1a35 · May 21, 2026 · 2 filesMessage 78 · AdequateLow 25Details
Commit message · optout

rpc: Fix for duplicate external signers case

In case of multiple external signers, with some duplicates,
de-duplicate them: keep one signer per fingerprint, and
keep all non-duplicates as well. Add a new test check.

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 25/100

This commit fixes a bug in how Bitcoin Core lists external hardware wallets (signers). Previously, if the list contained duplicate signers, the code would stop processing entirely after the first duplicate, potentially hiding valid non-duplicate signers from the user. The fix changes the behavior so duplicates are skipped while the rest of the list is still processed. This is a correctness and usability fix rather than a direct theft-of-funds vulnerability, but it could mislead a user about which hardware wallets are available.

AI review queuedrefactor: store wallet names to MigrationResultby Pol Espinasa · 97d08d62 · May 20, 2026 · 4 filesMessage 80 · StrongInformational 15Details
Commit message · Pol Espinasa

refactor: store wallet names to MigrationResult

Store wallet names into MigrationResult struct when migrating a wallet.
Also refactor the RPC and the wallet interface to rely on them instead of pointers to shared_ptr<CWallet> objects.

This allows in a future commit migrate wallet without loading them.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a straightforward internal code cleanup in Bitcoin Core's wallet migration feature. It changes how wallet names are passed around so that the code stores names directly in a result structure rather than fetching names from live wallet objects. There is no security-relevant change visible in the diff, and the commit message explicitly calls it a refactor.

AI review queuedtest: restore assertion that tx contains exactly 2500 sigopsby ismaelsadeeq · ae73b69b · May 20, 2026 · 1 fileMessage 87 · StrongInformational 15Details
Commit message · ismaelsadeeq

test: restore assertion that tx contains exactly 2500 sigops

Co-authored-by: Antoine Poinsot <darosior@protonmail.com>

87/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a tiny test-only change that adds a missing assertion in a unit test. It does not change any production code, network rules, or wallet behavior. There is no security issue here.

AI review queuedscripted-diff: logging: Drop LogAcceptCategoryby Anthony Towns · 611878b4 · May 15, 2026 · 7 filesMessage 78 · AdequateInformational 15Details
Commit message · Anthony Towns

scripted-diff: logging: Drop LogAcceptCategory

-BEGIN VERIFY SCRIPT-
sed -i 's/LogAcceptCategory(\(.*\), [a-zA-Z:]*::Level::Debug)/util::log::ShouldDebugLog(\1)/g' $(git grep -l LogAcceptCategory -- '*.cpp')
sed -i 's/LogAcceptCategory(\(.*\), [a-zA-Z:]*::Level::Trace)/util::log::ShouldTraceLog(\1)/g' $(git grep -l LogAcceptCategory -- '*.cpp')
sed -i '/Return true if log accepts specified category/,/^$/d' src/logging.h
-END VERIFY SCRIPT-

78/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathparser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a routine internal code cleanup in Bitcoin Core. It replaces an older logging helper function called LogAcceptCategory with newer, more specific helper functions (ShouldDebugLog and ShouldTraceLog). The behavior of the program is intended to remain exactly the same; only the names of the functions used to decide what to log have changed. There is no indication this fixes or introduces a security vulnerability.