tests: Add test for mempool-invalid wallet tx
What the developer wrote
Authored by Anthony Towns
tests: Add test for mempool-invalid wallet tx
Uses send rpc to create a tx with oversized OP_RETURN output, verifies
that it doesn't enter the mempool, and that getbalance rpc returns a
nonmempool value.
What changed, and why it matters
This commit only adds a new test case to Bitcoin Core's functional test suite. It checks that a wallet transaction containing an oversized data output (OP_RETURN) is rejected from the mempool and that the wallet correctly reports the funds as 'nonmempool'. There is no change to production wallet, mempool, or consensus code, so it does not introduce or fix a live security issue.
No action required. This is a test-only change. Reviewers may optionally confirm the new test passes in CI.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies test/functional/wallet_send.py. It lowers -datacarriersize to 16 bytes for test nodes, adds a nonmempool flag to the test helper, and adds a test that sends a transaction with a 43-byte OP_RETURN payload. Because the data exceeds the configured carrier size, the transaction is not accepted into the mempool. The test verifies getrawtransaction raises ‘No such mempool transaction’ and that getbalances reports a negative nonmempool value. This is purely test coverage; no node behavior is changed.
Changed components
test/functional/wallet_send.pyInspect captured patch +19 / −12
diff --git a/test/functional/wallet_send.py b/test/functional/wallet_send.py
index 1316aecb..b5119dc8 100755
--- a/test/functional/wallet_send.py
+++ b/test/functional/wallet_send.py
@@ -32,8 +32,8 @@ class WalletSendTest(BitcoinTestFramework):
self.noban_tx_relay = True
self.supports_cli = False
self.extra_args = [
- ["-walletrbf=1"],
- ["-walletrbf=1"]
+ ["-walletrbf=1", "-datacarriersize=16"],
+ ["-walletrbf=1", "-datacarriersize=16"]
]
getcontext().prec = 8 # Satoshi precision for Decimal
@@ -45,7 +45,7 @@ class WalletSendTest(BitcoinTestFramework):
conf_target=None, estimate_mode=None, fee_rate=None, add_to_wallet=None, psbt=None,
inputs=None, add_inputs=None, include_unsafe=None, change_address=None, change_position=None, change_type=None,
locktime=None, lock_unspents=None, replaceable=None, subtract_fee_from_outputs=None,
- expect_error=None, solving_data=None, minconf=None):
+ expect_error=None, solving_data=None, minconf=None, nonmempool=False):
assert_not_equal((amount is None), (data is None))
from_balance_before = from_wallet.getbalances()["mine"]["trusted"]
@@ -171,16 +171,20 @@ class WalletSendTest(BitcoinTestFramework):
tx = from_wallet.gettransaction(res["txid"])
assert tx
assert_equal(tx["bip125-replaceable"], "yes" if replaceable else "no")
- # Ensure transaction exists in the mempool:
- tx = from_wallet.getrawtransaction(res["txid"], True)
- assert tx
- if amount:
- if subtract_fee_from_outputs:
- assert_equal(from_balance_before - from_balance, amount)
- else:
- assert_greater_than(from_balance_before - from_balance, amount)
+ if nonmempool:
+ assert_raises_rpc_error(-5, "No such mempool transaction", from_wallet.getrawtransaction, res["txid"])
+ assert from_wallet.getbalances()["mine"]["nonmempool"] < 0
else:
- assert next((out for out in tx["vout"] if out["scriptPubKey"]["asm"] == "OP_RETURN 35"), None)
+ # Ensure transaction exists in the mempool:
+ tx = from_wallet.getrawtransaction(res["txid"], True)
+ assert tx
+ if amount:
+ if subtract_fee_from_outputs:
+ assert_equal(from_balance_before - from_balance, amount)
+ else:
+ assert_greater_than(from_balance_before - from_balance, amount)
+ else:
+ assert next((out for out in tx["vout"] if out["scriptPubKey"]["asm"] == "OP_RETURN 35"), None)
else:
assert_equal(from_balance_before, from_balance)
@@ -280,6 +284,9 @@ class WalletSendTest(BitcoinTestFramework):
res = w2.walletprocesspsbt(res["psbt"])
assert res["complete"]
+ self.log.info("Create mempool-invalid tx (due to large OP_RETURN)...")
+ self.test_send(from_wallet=w0, data=b"The quick brown fox jumps over the lazy dog".hex(), nonmempool=True)
+
self.log.info("Test setting explicit fee rate")
res1 = self.test_send(from_wallet=w0, to_wallet=w1, amount=1, arg_fee_rate="1", add_to_wallet=False)
res2 = self.test_send(from_wallet=w0, to_wallet=w1, amount=1, fee_rate="1", add_to_wallet=False)
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.