test: Remove confusing assert_debug_log in wallet_reindex.py
What the developer wrote
Authored by MarcoFalke
test: Remove confusing assert_debug_log in wallet_reindex.py
What changed, and why it matters
This commit only changes a single test file. It removes a debug-log assertion and slightly simplifies how a test node is restarted during a reindex test. There is no change to production Bitcoin Core code, no security fix, and no vulnerability.
No action required. This is a non-security test cleanup commit.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies test/functional/wallet_reindex.py. It removes a with node.assert_debug_log([‘initload thread exit’]): block around a restart_node call and adds a log message. The restart still occurs with -reindex=1 removed from extra_args (the framework likely supplies it elsewhere or the test was adjusted). This is purely a test-code readability/cleanup change.
Changed components
test/functional/wallet_reindex.pyInspect captured patch +2 / −4
diff --git a/test/functional/wallet_reindex.py b/test/functional/wallet_reindex.py
index 71ab69e0..a4180897 100755
--- a/test/functional/wallet_reindex.py
+++ b/test/functional/wallet_reindex.py
@@ -60,10 +60,8 @@ class WalletReindexTest(BitcoinTestFramework):
assert_equal(wallet_watch_only.gettransaction(tx_id)['confirmations'], 50)
assert_equal(wallet_watch_only.getbalances()['mine']['trusted'], 2)
- # Reindex and wait for it to finish
- with node.assert_debug_log(expected_msgs=["initload thread exit"]):
- self.restart_node(0, extra_args=['-reindex=1', f'-mocktime={self.node_time}'])
- node.syncwithvalidationinterfacequeue()
+ self.log.info("Reindex ...") # restart_node waits for it to finish
+ self.restart_node(0, extra_args=[ f'-mocktime={self.node_time}'])
# Verify the transaction is still 'confirmed' after reindex
wallet_watch_only = node.get_wallet_rpc('watch_only')
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.