Bitcoin Core

This is a one-line fix to a Bitcoin Core unit test file. The test was not exercising what its author intended because an empty signature does not trigger the expected script failure in a CHECKMULTISIG operation. The change replaces an empty second signature with a non-empty one so the test actually checks the intended execution-order behavior. It does not change any production code, consensus rules, or network behavior.

This commit removes a single outdated comment from a test data file. The comment referred to a file called script_invalid.json that no longer exists. There is no code change, no functional change, and no security relevance.

This is a straightforward code cleanup change that renames an internal label from DELETE to DELETE_FLAG. It fixes a build problem on Windows where a system header also uses the word DELETE, which could cause compilation errors depending on the order headers were included. There is no security vulnerability or runtime behavior change.

This is a small change to a CI (continuous integration) helper script. It makes build failures easier to diagnose by automatically re-running the build with verbose output if the first build fails. There is no security issue here.

This is a tiny internal cleanup in Bitcoin Core's continuous integration (CI) scripts. It makes two helper functions behave identically and lets callers override a default option. It does not touch wallet, networking, consensus, or any user-facing code, and the commit message explicitly says it changes no behavior.

This commit adds a comment and a reference link to a developer tooling file that maps C library symbols to their correct header files. It does not change any executable code, network behavior, or wallet logic. There is no security relevance.

This commit is a minor housekeeping change. It removes two unused '#include <iterator>' lines from source files and adds a temporary mapping for a third-party code-tidying tool (IWYU) to work around a known upstream bug. There is no change to Bitcoin's actual logic, networking, cryptography, or consensus behavior, and no security relevance.

This commit removes a small, outdated workaround from a developer-only tool configuration file. It has no effect on the Bitcoin Core software that users run, on network behavior, or on funds. It is purely a cleanup for the include-what-you-use (IWYU) static-analysis helper used during development.

This is a minor continuous integration (CI) script change. It removes a condition so that a notice about low ccache (compiler cache) hit rates is printed both in CI and in local test runs, and updates the ccache command from 'ccache -s' to 'ccache --show-stats'. There is no security relevance.

This commit fixes a minor bug in the `uptime` RPC command. Previously, the very first call to `uptime` would always report 0 seconds because the program's start time was accidentally recorded at the moment of that first call, not at actual startup. The fix moves the startup timestamp to a global variable that is set when the program begins. This is a correctness fix with no security impact.

This commit simply updates the version numbers and download hashes used to fetch Apple's macOS development toolkit (the SDK) when building Bitcoin Core for Mac computers. It does not change any Bitcoin protocol code, wallet logic, or network behavior. There is no indication in the commit that this fixes or introduces a security problem.

This is a build-system fix for compiling Bitcoin Core for macOS using newer Apple SDKs. It adds a compiler flag that turns off a Clang C++ feature called 'modules,' which was causing compile failures because the SDK uses that feature to decide whether to include some standard type definitions. There is no indication this is a security vulnerability or that it could be exploited by an attacker.

This is a performance optimization for Bitcoin Core's block validation. It reuses a single temporary cache instead of creating and destroying a new one for every block. There is no security issue visible in the change; it is purely about reducing memory allocation overhead.

This commit is a simple rename of a function parameter from 'will_reuse_cache' to 'reallocate_cache' across five files. The actual behavior of the code does not change at all; only the name and related comments are updated to be clearer. There is no security impact.

This commit adds a new helper class called ResetGuard to Bitcoin Core's coin cache. It is a safety tool that automatically resets a cache when a piece of code finishes, helping prevent accidental reuse of stale cache data. The change only touches internal code and tests; it does not fix a known bug or introduce a new feature users interact with. There is no indication this is a security patch.

This is a small internal cleanup in Bitcoin Core's coin-cache code. It replaces two direct assignments to an internal 'hashBlock' field with calls to an existing setter method named SetBestBlock. By itself, this change does not fix a known bug or add a security boundary; it is a code-quality refactor that makes future maintenance easier and slightly reduces the chance of someone later bypassing the setter if it ever needs to enforce invariants.

This commit adds a new Reset() method to an internal Bitcoin Core cache class. It simply clears in-memory data without saving anything to disk. There is no indication in the commit that this fixes a security bug or is being used to address an active vulnerability. It appears to be a routine code-cleanup or performance helper.

This is a routine code cleanup that adjusts which C++ header files are included in the ZeroMQ (ZMQ) notification module. It also tells the project's automated style checker to treat missing or unnecessary includes in these files as errors going forward. There is no change to program logic, no bug fix, and no security-relevant behavior.

This change only affects how Bitcoin Core's internal fuzz tests create temporary working folders. When running under the AFL++ fuzzer, it now reuses a folder named after the fuzzer's shared-memory ID and deletes any leftover contents first, instead of creating a new random folder every time. This prevents old test folders from piling up and filling the disk during long fuzzing runs. It is a test-infrastructure cleanup, not a fix for a vulnerability in Bitcoin's network or wallet code.

This is a minor code cleanup following a previous change. It adds a safety check confirming a lock is already held, fixes an outdated comment, and marks a function as not throwing exceptions. There is no security issue here.

This is a small internal cleanup of Bitcoin Core's test-only code. It renames a helper struct used in fuzz tests and adds a destructor that resets the mock clock after each test. There is no change to the live Bitcoin network code, no bug fix for user funds or consensus, and no security relevance.

This commit only improves error messages in Bitcoin Core's internal test framework. When a test setup step fails because the node returns a JSON-RPC error, the test runner now logs the actual error details and HTTP status code instead of a generic 'Unexpected exception' message. There is no change to production Bitcoin node code, no security fix, and no vulnerability.

This change fixes a bug in Bitcoin Core's built-in web server where an unexpected error inside an HTTP request handler could crash the entire program. The patch wraps each request in a safety net: if something throws an error, it is logged, the client connection is closed, and the program keeps running instead of crashing. The commit message also includes a test snippet showing the crash can be triggered intentionally.

This commit tightens the internal type-checking rules for a Bitcoin script feature called Miniscript. Specifically, it removes a property ('d', meaning 'dissatisfiable') from the logical 'and_v()' fragment because that property could never actually occur in valid Miniscripts. The commit message explicitly says this is not a bug fix because the old rule was unreachable in valid inputs, so there is no known way to exploit it.

This commit removes an unused macro named SCRIPT_ERR_LAST from a Bitcoin Core header file. The macro was simply another name for an existing internal counter and was not referenced anywhere in the code. There is no functional change, no bug fix, and no security relevance.