What the developer wrote
Authored by fanquake
leveldb: remove unused files
What changed, and why it matters
This commit removes three source files from the LevelDB build list in Bitcoin Core's CMake configuration. The files (c.cc, dumpfile.cc, histogram.cc) are reportedly unused. This is a routine build cleanup with no apparent security relevance.
No security action required. Treat as normal maintenance/cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies cmake/leveldb.cmake to exclude src/leveldb/db/c.cc, src/leveldb/db/dumpfile.cc, and src/leveldb/util/histogram.cc from the static leveldb target. These files appear to be auxiliary LevelDB components (C API bindings, a dump utility, and a statistics histogram) that are not needed for Bitcoin Core’s embedded LevelDB usage. The change is purely subtractive and build-scoped.
Changed components
cmake/leveldb.cmakeInspect captured patch +0 / −3
diff --git a/cmake/leveldb.cmake b/cmake/leveldb.cmake
index 572b2bed..e2119042 100644
--- a/cmake/leveldb.cmake
+++ b/cmake/leveldb.cmake
@@ -11,11 +11,9 @@ check_cxx_symbol_exists(F_FULLFSYNC "fcntl.h" HAVE_FULLFSYNC)
add_library(leveldb STATIC EXCLUDE_FROM_ALL
${PROJECT_SOURCE_DIR}/src/leveldb/db/builder.cc
- ${PROJECT_SOURCE_DIR}/src/leveldb/db/c.cc
${PROJECT_SOURCE_DIR}/src/leveldb/db/db_impl.cc
${PROJECT_SOURCE_DIR}/src/leveldb/db/db_iter.cc
${PROJECT_SOURCE_DIR}/src/leveldb/db/dbformat.cc
- ${PROJECT_SOURCE_DIR}/src/leveldb/db/dumpfile.cc
${PROJECT_SOURCE_DIR}/src/leveldb/db/filename.cc
${PROJECT_SOURCE_DIR}/src/leveldb/db/log_reader.cc
${PROJECT_SOURCE_DIR}/src/leveldb/db/log_writer.cc
@@ -45,7 +43,6 @@ add_library(leveldb STATIC EXCLUDE_FROM_ALL
$<$<BOOL:${WIN32}>:${PROJECT_SOURCE_DIR}/src/leveldb/util/env_windows.cc>
${PROJECT_SOURCE_DIR}/src/leveldb/util/filter_policy.cc
${PROJECT_SOURCE_DIR}/src/leveldb/util/hash.cc
- ${PROJECT_SOURCE_DIR}/src/leveldb/util/histogram.cc
${PROJECT_SOURCE_DIR}/src/leveldb/util/logging.cc
${PROJECT_SOURCE_DIR}/src/leveldb/util/options.cc
${PROJECT_SOURCE_DIR}/src/leveldb/util/status.cc
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.