BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

2894 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

254security candidates606second-pass queue2880AI analyses
210commits · 30 days
507commits · 60 days
1529commits · 180 days
2881commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

70/100 average clarity
931Strong · 80–100
1188Adequate · 60–79
687Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Antoine Poinsot22422170
Ava Chow15750157064
MarcoFalke41021406074
Lőrinc17721177081
fanquake22719226057
Hennadii Stepanov20914208063
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Hodlinator66566076
Analysis record

Published AI watches

Last scanned 44 minutes ago

Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35482: fuzz: exercise the transaction-handling path in process_message(s)

This commit only changes Bitcoin Core's internal fuzz testing code. It makes the fuzz tests exercise more of the transaction-handling code path by toggling Initial Block Download mode and resetting the mempool between test runs. There is n…

No production code modifiedNo consensus, validation, net_processing, or wallet logic changedOnly fuzz test harnesses and test utilities affected
f11dc617by merge-script+105−798 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35914: test, fuzz: Remove unused variables

This commit removes unused variables from Bitcoin Core's test and fuzzing code. It is a cleanup/refactoring change with no effect on the live network software or user funds. It does not fix or introduce any security vulnerability.

d36bf709by merge-script+1−138 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35896: refactor: Default uint256::operator==, add operator<=>

This commit is a routine code cleanup in Bitcoin Core. It switches the uint256 equality and comparison operators to use standard C++20 defaults, removes an old custom Compare() helper, and marks an internal assertion-failure function as ne…

ed2c59abby merge-script+99−245 files
No security note in commit
Moderate 62 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35872: rpc: avoid descriptor range counter overflow

This update fixes a counting bug in several Bitcoin Core RPC commands that scan descriptors. When a user requested a descriptor range ending at the maximum allowed value (2,147,483,647), the internal counter used a smaller integer type and…

Signed integer overflow in descriptor expansion loopCrash/undefined behavior on maximum-range descriptor scansAuthenticated RPC surface affected (scantxoutset, scanblocks, getdescriptoractivity, utxoupdatepsbt, descriptorprocesspsbt)
b388674aby Ava Chow+3−12 files
Vendor flagged security relevance
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35842: rpc: Properly make RPCResult::Type::ANY non-test-only

This is a small cleanup and documentation fix for Bitcoin Core's RPC help system. It removes a comment that incorrectly said a certain output type was 'for testing only' and makes the help text properly display those outputs. There is no d…

No memory safety, cryptography, consensus, or authorization changes observedChange is confined to RPC help/schema metadata generationComment-only/type-label change from 'for testing only' to general use
c36ffd87by merge-script+42−364 files
No security note in commit
Informational 15 AI analysisMessage 93 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35895: refactor: Enable clang-tidy rule to reject anon namespace in header

This is a code cleanup change that turns on a static-analysis rule to prevent a specific C++ coding pattern (anonymous namespaces in header files) and updates two headers to comply. It does not change how Bitcoin Core behaves at runtime an…

No security-relevant code changeNo memory safety, cryptography, consensus, or network changesTooling-only refactor (clang-tidy configuration)
c4fbd3c7by merge-script+9−123 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35630: test: Add importdescriptors rpc error test coverage

This commit only adds new test cases to Bitcoin Core's functional test suite. It does not change any production wallet, node, or RPC code. The tests verify that the importdescriptors RPC reports errors in the right order, rejects bad times…

465196d0by merge-script+77−11 file
No security note in commit
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35180: coins: group private cache helpers

This change is purely a code cleanup: it moves two internal helper functions of a Bitcoin Core cache class into the private section of the class and removes a duplicate 'private:' label. There is no change to what the code does, no bug fix…

c940fd75by merge-script+13−141 file
No security note in commit
Low 29 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#35582: rpc: reject null for optional parameters

This Bitcoin Core change tightens how three RPC commands (scantxoutset, scanblocks, deriveaddresses) handle the value null when it is passed for optional parameters. Previously, explicitly passing null could be treated differently from sim…

RPC parameter validation changeNull value handling changeAddition of explicit error checks for missing required contextual parameters
3db96eb5by merge-script+18−75 files
No security note in commit
Informational 15 AI analysisMessage 57 · Thin
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

refactor: Enable misc-definitions-in-headers

This commit is a code cleanup: it turns on a clang-tidy style check called 'misc-definitions-in-headers' and suppresses that check around a large inline implementation block in a benchmark header. There is no change to Bitcoin's runtime be…

fa93132dby MarcoFalke+3−02 files
No security note in commit
Informational 15 AI analysisMessage 85 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

refactor: Enable clang-tidy rule to reject anon namespace in header

This commit only changes a linting configuration file for the project's code style checker. It enables a rule that prevents anonymous namespaces from being used in header files, which is a code-quality and build-hygiene practice. There is …

No security-relevant signals in the diff or commit message.Change is purely a static-analysis/linting configuration update.
fa5ca877by MarcoFalke+2−11 file
No security note in commit
Informational 15 AI analysisMessage 62 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

refactor: Use C++20 std::identity over IntIdentity

This commit is a straightforward code cleanup: it replaces a small custom helper named IntIdentity with the standard C++20 std::identity from the <functional> header. The behavior of the ConvertBits function is unchanged; only the implemen…

fafe5042by MarcoFalke+4−111 file
No security note in commit
Informational 15 AI analysisMessage 87 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: test the result order of a multiple import request is correct

This commit only adds a new automated test to Bitcoin Core. It checks that when a user asks the wallet to import multiple descriptors at once, the list of results comes back in the same order as the original request, including any error me…

3ac8b806by Pol Espinasa+40−01 file
No security note in commit
Informational 15 AI analysisMessage 87 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: test invalid or missing timestamp throws importdescriptors

This commit only adds new automated tests for the Bitcoin Core wallet's importdescriptors RPC. It checks that the command correctly rejects requests with a missing or invalid timestamp. No production wallet code is changed, so this cannot …

No changes to consensus, networking, wallet logic, or cryptographyOnly functional test code is modifiedAdded assertions are for expected error handling paths
e4732bf0by Pol Espinasa+28−11 file
No security note in commit
Informational 15 AI analysisMessage 80 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

refactor: Remove unused #include in common/system

This is a minor code cleanup that removes one unused header file include and swaps another for a more specific one. It does not change any program behavior or fix any security issue.

fa7304f3by MarcoFalke+1−22 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

iwyu: Fix warnings in `src/consensus` and treat them as errors

This commit is a routine code cleanup: it adjusts which C++ header files are included in several consensus-related source files and turns on a stricter compiler hygiene check (Include What You Use, or IWYU) for the src/consensus directory.…

13b53f8bby Hennadii Stepanov+42−79 files
No security note in commit
Informational 15 AI analysisMessage 55 · Thin
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

fuzz: don't connman.ReceiveMsgFrom oversized msg

This is a small fix to a Bitcoin Core fuzz test (an automated internal testing harness), not to the live network code. The fuzzer was sometimes creating fake P2P messages larger than the real protocol allows and passing them into a test he…

Test-only fuzz harness hardeningOversized message guard added before ReceiveMsgFrom() in fuzz targetNo change to production P2P message acceptance logic
bb19f1daby Greg Sanders+5−01 file
No security note in commit
Informational 15 AI analysisMessage 97 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

ci: Temporarily remove riscv32 config from GHA matrix

This commit simply removes one failing test configuration (RISC-V 32-bit bare metal) from the project's GitHub Actions CI matrix because it was failing. It is a routine CI maintenance change with no security implications.

fa06ea42by MarcoFalke+0−61 file
No security note in commit
Low 47 AI analysisMessage 90 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

ci: verify cross-build SDK archives

This change adds checksum verification to the build system's downloads of Apple, FreeBSD, NetBSD, and OpenBSD software development kits (SDKs). Before this patch, those SDK archives were downloaded at build time and extracted without confi…

Adds cryptographic digest verification for downloaded SDK archivesRemoves unchecked extraction of remote SDK archives in CIHardens CI supply chain for macOS/BSD cross-builds
873550beby Lőrinc+25−126 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 80 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

ci: update NetBSD cross-build SDK

This is a routine maintenance update to Bitcoin Core's continuous integration (CI) system. It changes the version number of the NetBSD operating system used for cross-compilation testing from a release candidate (11.0_RC6) to the final rel…

2c87337eby Lőrinc+1−11 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritytest: add background validation test for getblockchaininfoby Pol Espinasa · af629821 · Mar 24, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · Pol Espinasa

test: add background validation test for getblockchaininfo

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds a new automated test that checks what information the getblockchaininfo RPC returns about a background validation process. It does not change any production code, network behavior, or wallet logic, so it cannot introduce a security vulnerability or fix one.

Lower-priorityrpc, log: add backgroundvalidation to getblockchaininfoby Pol Espinasa · a3d6f32a · Mar 24, 2026 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · Pol Espinasa

rpc, log: add backgroundvalidation to getblockchaininfo

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply adds a new optional information block called 'backgroundvalidation' to the getblockchaininfo RPC output. It exposes read-only status about an existing background chain-validation process, plus some minor capitalization fixes in help text. There is no security-relevant change.

AI review queuedrelease noteby Pol Espinasa · 25f69d97 · Mar 24, 2026 · 1 fileMessage 18 · OpaqueInformational 15Details
Commit message · Pol Espinasa

release note

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit is a documentation-only release note. It describes a new RPC feature that exposes background validation progress for the assumeutxo feature. There is no code change, no bug fix, and no security issue.

Lower-prioritylog: update progress calculations for background validationby Pol Espinasa · 5b2e4c4a · Mar 24, 2026 · 2 filesMessage 73 · AdequateInformational 19Details
Commit message · Pol Espinasa

log: update progress calculations for background validation

updates estimations to the block snapshot instead of the main chain tip as it will stop validation after reaching that height

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 19/100

This commit only changes how Bitcoin Core calculates and prints a progress percentage in log messages during a special background validation mode (used with the assume-utxo feature). It does not change consensus rules, network behavior, wallet handling, or any security-critical logic. The old code could show a misleading progress number; the new code makes the log estimate more accurate. There is no security vulnerability here.

Security candidaterpc, refactor: gettxoutsetinfo race condition fix follow-upsby rkrux · 3e5dc610 · Mar 24, 2026 · 2 filesMessage 78 · AdequateInformational 11Details
Commit message · rkrux

rpc, refactor: gettxoutsetinfo race condition fix follow-ups

This patch addresses my own review comments from the review of PR 34451.
If these are found helpful, it makes sense to do them now after the previous
PR was merged and backported.

Pasting the comments below that also explains the changes:

- Move the pindex declaration below now that it is not used earlier.
- stats was being generated partially in both these ComputeUTXOStats functions,
which reads oddly to me. Now that the pcursor is also moved and passed to this
function, which reads oddly as well, I believe we can refactor this function
to completely build the stats inside this function. A side benefit is that by
removing the stats and pcursor arguments, the function signature becomes quite
similar to its namesake, which in turn becomes a straightforward wrapper of
this function.

78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
signing boundary
AI analysis · Informational 11/100

This is a small internal cleanup change for a Bitcoin Core function that calculates statistics about the unspent coin set (used by the gettxoutsetinfo RPC). It moves where a variable is declared and refactors how the statistics object is built so the code is easier to read. There is no direct security fix in this commit itself; it is described as a follow-up to a prior pull request that addressed a race condition.

Lower-priorityrefactor: Fix redundant conversion to std::string and then to std::string_view [performance-string-view-conversions]by MarcoFalke · fa73ed46 · Mar 24, 2026 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · MarcoFalke

refactor: Fix redundant conversion to std::string and then to std::string_view [performance-string-view-conversions]

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This is a tiny code cleanup in Bitcoin Core's networking code. It removes an unnecessary conversion of a string-like variable to std::string before passing it to a function that accepts std::string_view. There is no security impact.

Lower-priorityci: add FreeBSD cross CI jobby fanquake · 65379bb8 · Mar 24, 2026 · 3 filesMessage 57 · ThinInformational 15Details
Commit message · fanquake

ci: add FreeBSD cross CI job

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit adds a new automated build test for Bitcoin Core that compiles the software for FreeBSD from a Linux machine. It does not change any Bitcoin code, wallet logic, networking, or security behavior. It only affects internal continuous integration (CI) scripts.

Lower-prioritydepends: build qrencode for Freebsdby fanquake · f44191f1 · Mar 24, 2026 · 1 fileMessage 45 · ThinInformational 16Details
Commit message · fanquake

depends: build qrencode for Freebsd

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 16/100

This commit adds FreeBSD to the list of operating systems for which Bitcoin Core's build system will compile the optional QR code generation library (qrencode). It is a one-line build configuration change with no apparent security relevance.

Lower-prioritydepends: FreeBSD cross with Clangby fanquake · 7f701873 · Mar 24, 2026 · 2 filesMessage 45 · ThinInformational 16Details
Commit message · fanquake

depends: FreeBSD cross with Clang

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 16/100

This commit updates Bitcoin Core's build system to support cross-compiling FreeBSD binaries using Clang and the LLVM toolchain. It changes compiler and linker settings in makefiles used only during the build process. There is no indication this fixes or introduces a security vulnerability.

Lower-prioritydepends: disable inotify in Freebsd Qt buildby fanquake · 6464f140 · Mar 24, 2026 · 1 fileMessage 45 · ThinInformational 11Details
Commit message · fanquake

depends: disable inotify in Freebsd Qt build

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 11/100

This commit changes how Bitcoin Core builds the Qt GUI library on FreeBSD. It disables Qt's inotify feature during the build process. Inotify is a Linux-style file-change notification mechanism that Qt tries to use on FreeBSD, but it can cause build or runtime problems because FreeBSD's support differs. The change is a build-system compatibility fix; there is no direct evidence in the commit that it fixes an exploitable security vulnerability.

Lower-priorityrefactor: Get rid of unnecessary newlines in logsby Fabian Jahr · 8444efbd · Mar 23, 2026 · 1 fileMessage 57 · ThinInformational 15Details
Commit message · Fabian Jahr

refactor: Get rid of unnecessary newlines in logs

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a simple cleanup: it removes extra line-break characters from the ends of log messages in the Tor control code. Modern logging functions already add their own line breaks, so the old manual ones were creating blank lines in log files. There is no security issue here.

Lower-priorityrefactor: Modernize member variable names in torcontrolby Fabian Jahr · 6bcb6035 · Mar 23, 2026 · 2 filesMessage 62 · AdequateInformational 15Details
Commit message · Fabian Jahr

refactor: Modernize member variable names in torcontrol

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a pure code cleanup: it renames variables in Bitcoin Core's Tor control module to follow the project's modern naming style (adding 'm_' prefixes to member variables and using snake_case for local names). No behavior, logic, or security properties of the code are changed.

Lower-priorityrefactor: Use constexpr in torcontrol where possibleby Fabian Jahr · a36591d1 · Mar 23, 2026 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · Fabian Jahr

refactor: Use constexpr in torcontrol where possible

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a straightforward code cleanup in Bitcoin Core's Tor control module. It changes several constant variable declarations from 'static const' to 'constexpr' for integer and float values. This is a non-functional style/refactoring change with no security relevance.

Lower-prioritysync: Use StdMutex for thread safety annotationsby Anthony Towns · 8d2f0685 · Mar 23, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Anthony Towns

sync: Use StdMutex for thread safety annotations

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This is a small internal cleanup in Bitcoin Core's lock-tracking code. It swaps the standard C++ mutex for a project-specific wrapper (StdMutex) and adds compile-time annotations that tell the compiler which data structures are protected by the mutex. There is no change to network behavior, consensus rules, or user-facing functionality, and no security bug is being fixed.

Lower-priorityscripted-diff: logging: Switch from StdLockGuard to STDLOCKby Anthony Towns · cbc231ed · Mar 23, 2026 · 2 filesMessage 83 · StrongInformational 15Details
Commit message · Anthony Towns

scripted-diff: logging: Switch from StdLockGuard to STDLOCK

-BEGIN VERIFY SCRIPT-
sed -i 's/StdLockGuard scoped_lock(\(.*\));/STDLOCK(\1);/' src/logging.h src/logging.cpp
-END VERIFY SCRIPT-

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit is a purely mechanical rename in Bitcoin Core's logging code. It replaces the old name 'StdLockGuard scoped_lock' with a shorter macro name 'STDLOCK' everywhere it appears. The actual locking behavior is unchanged, so there is no security impact.

Lower-prioritylogging: Add missing thread safety annotationsby Anthony Towns · f808786f · Mar 23, 2026 · 1 fileMessage 45 · ThinInformational 16Details
Commit message · Anthony Towns

logging: Add missing thread safety annotations

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 16/100

This commit adds compiler hints about which locks must not be held when calling two logging helper functions. It does not change any actual code behavior, memory layout, or runtime logic. The change helps automated tools detect potential future threading mistakes during development, but it does not fix an active bug by itself.

Lower-priorityutil/stdmutex.h: Add STDLOCK() and improve annotation checking for StdMutexby Anthony Towns · e196cf26 · Mar 23, 2026 · 1 fileMessage 73 · AdequateInformational 23Details
Commit message · Anthony Towns

util/stdmutex.h: Add STDLOCK() and improve annotation checking for StdMutex

StdLockGuard and clang's thread safety annotations did not ensure that
the lock it was taking was not already held. Add a STDLOCK() macro which
uses an annotated StdMutex::CheckNotHeld() function to correct that.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 23/100

This commit tightens a compile-time safety check in Bitcoin Core's custom mutex wrapper. It adds a macro called STDLOCK() that, when used, asks the compiler to verify the same lock is not being acquired twice in a row by the same thread. It does not change runtime behavior or fix an active exploit; it is a defensive hardening change to catch a specific programming mistake during compilation.

Security candidateMerge bitcoin-core/gui#815: Bugfix on TransactionsView - Disable if privacy mode is set during wallet selectionby Hennadii Stepanov · 999c4248 · Mar 22, 2026 · 2919 filesMessage 91 · StrongLow 25Details
Commit message · Hennadii Stepanov

Merge bitcoin-core/gui#815: Bugfix on TransactionsView - Disable if privacy mode is set during wallet selection

0dc337f73d013e342b880746292f1c3247b287cf gui: Fix TransactionsView on setCurrentWallet (pablomartin4btc)

Pull request description:

<details>
<summary>Currenlty on <code>master</code>, when the "mask values" checkbox is ticked if the user selects a different wallet, the history action is enable and if the user clicks on it can see all the transactions in the transaction view.</summary>

![Peek 2024-04-09 17-37](https://github.com/bitcoin-core/gui/assets/110166421/d8e2fdd1-aaa6-4506-acde-51fa45a74910)

</details>
<details>
<summary>This PR fixes it.</summary>

![Peek 2024-04-09 17-45](https://github.com/bitcoin-core/gui/assets/110166421/78c30dc5-42a6-4829-981d-6b9aaa03f014)

</details>

Note for maintainers: this needs to be backported to 25.x and 26.x.

ACKs for top commit:
hebasto:
ACK 0dc337f73d013e342b880746292f1c3247b287cf, tested on Fedora 43.

Tree-SHA512: 54581546917f87b4c1db0ff1eaa1962ee6eb078285dbb205b4c8d027c3e350f3dc46409b376948c10e668f9487b7a5a70bab0dff5faf510deab1a54452f7f0e5

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathseed or entropy pathsigning or wallet pathboot or update pathauthentication pathparser or protocol pathmerge-commit duplicate discount
AI analysis · Low 25/100

This commit fixes a small user-interface bug in Bitcoin Core's Qt wallet GUI. When the user turns on 'privacy mode' (the 'mask values' checkbox that hides balances), then switches to a different wallet, the 'History' button was incorrectly staying enabled. Clicking it would reveal the transaction list for the newly selected wallet, defeating the intended privacy setting. The fix makes the transaction view stay disabled when privacy mode is active during a wallet switch. It is a local, UI-only information-disclosure issue that requires the attacker to already have access to the unlocked GUI and the ability to switch wallets.

Lower-priorityci: Upgrade IWYU to 0.26 compatible with Clang 22by Hennadii Stepanov · 0b489886 · Mar 22, 2026 · 5 filesMessage 72 · AdequateInformational 15Details
Commit message · Hennadii Stepanov

ci: Upgrade IWYU to 0.26 compatible with Clang 22

Additionally, removes mapping workarounds for issues that have been
fixed upstream.

72/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit is a routine maintenance update for the project's automated code-quality tooling. It upgrades the Include-What-You-Use (IWYU) static-analysis tool from version 0.21 to 0.26 to match Clang 22, refreshes the tool's internal header-mapping patch, removes now-unnecessary workarounds, and adds or removes a few C++ standard-library #include lines in two source files so the code continues to pass the updated analyzer. There is no change to Bitcoin Core's runtime behavior, consensus logic, networking, wallet handling, or any user-facing feature.

AI review queuedwallet: fix amount computed as boolean in coin selectionby furszy · 0026b330 · Mar 22, 2026 · 1 fileMessage 73 · AdequateLow 46Details
Commit message · furszy

wallet: fix amount computed as boolean in coin selection

The comparison is evaluated before the assignment, so total_amount
ends up holding a boolean instead of the actual amount:
total_amount = (a - b < c)
which is not what we want here. This has been working by accident.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 46/100

A single missing semicolon in Bitcoin Core's wallet coin-selection code caused a comparison to run before an assignment. As a result, the variable that was supposed to hold the total available amount instead held just true or false. The code still mostly worked by accident, but the wrong value could mislead the wallet's decision about whether it has enough funds, especially when unconfirmed transactions with long chains are involved. This could lead to confusing error messages or, in edge cases, incorrect transaction creation.

Lower-prioritydoc: Note that generateblock does not collect transaction feesby HouseOfHufflepuff · 31365599 · Mar 22, 2026 · 1 fileMessage 93 · StrongInformational 15Details
Commit message · HouseOfHufflepuff

doc: Note that generateblock does not collect transaction fees

The generateblock RPC creates blocks where the coinbase only includes
the block subsidy, omitting transaction fees. Document this behavior
in the RPC help text to avoid confusion.

refs #31684

93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100

This commit only updates the help text for the generateblock command in Bitcoin Core. It adds a note explaining that the command does not collect transaction fees in the block reward. There is no code behavior change, no bug fix, and no security issue.

Lower-priorityci: Switch to VS-vendored vcpkg instanceby Hennadii Stepanov · 2d5cedfe · Mar 20, 2026 · 1 fileMessage 80 · StrongInformational 15Details
Commit message · Hennadii Stepanov

ci: Switch to VS-vendored vcpkg instance

The GHA Windows image contains two vcpkg installations: one vendored by
VS (`VCPKG_ROOT`) and an independent one (`VCPKG_INSTALLATION_ROOT`).
Our build documentation recommends using the VS-vendored instance to
minimize user effort. While this option previously failed to build in
the CI, forcing us to use the independent installation, it is now
working correctly.

This change removes the no-longer-needed workaround.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit is a routine cleanup of Bitcoin Core's GitHub Actions CI configuration for Windows builds. It switches the build from using a standalone vcpkg installation to the one that comes bundled with Visual Studio, matching the project's own documentation. The change only affects internal continuous-integration tooling and does not alter the Bitcoin Core software that users run.

Lower-prioritytest: move make_mining_ctx to ipc_util.pyby Enoch Azariah · 63684d69 · Mar 20, 2026 · 3 filesMessage 90 · StrongInformational 15Details
Commit message · Enoch Azariah

test: move make_mining_ctx to ipc_util.py

The async routines in both interface_ipc.py and interface_ipc_mining.py
contain redundant code to initialize the mining proxy object.

Move the make_mining_ctx helper into test_framework/ipc_util.py and
update both test files to use it. This removes the boilerplate and
prevents code duplication across the IPC test suite.

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit is a simple code cleanup in Bitcoin Core's test suite. It moves a small helper function that creates a mining test object from two individual test files into a shared utility file, so the same code isn't duplicated. There is no change to the actual Bitcoin node software, no change to how tests behave, and no security relevance.

Lower-prioritytest: scale IPC mining wait timeouts by timeout_factorby Enoch Azariah · ad75b147 · Mar 20, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · Enoch Azariah

test: scale IPC mining wait timeouts by timeout_factor

The IPC mining tests (interface_ipc_mining.py) currently use
hardcoded timeouts (e.g., 1000ms, 60000ms) for operations like
waitTipChanged and waiting for block templates. In heavily
loaded CI environments, such as those running sanitizers with
high parallelism, these hardcoded timeouts can be too short,
leading to spurious test failures and brittleness.

This commit multiplies these timeout variables by the test
suite's global `self.options.timeout_factor`. This ensures that
the IPC wait conditions scale appropriately when the test suite
is run with a higher timeout factor, making the tests robust
against slow execution environments.

Addresses CI brittleness observed in bitcoin-core/libmultiprocess#253.

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validation
AI analysis · Informational 15/100

This commit only adjusts timeout values in a single automated test file. It makes the test wait longer under slow CI conditions to avoid false failures. There is no change to the actual Bitcoin Core software that users run, and no security issue is present.

AI review queuedtest: verify IPC error handling for invalid coinbaseby Enoch Azariah · e7a918b6 · Mar 20, 2026 · 2 filesMessage 100 · StrongInformational 12Details
Commit message · Enoch Azariah

test: verify IPC error handling for invalid coinbase

Add a test case to interface_ipc_mining.py to verify that the IPC
server correctly handles and reports serialization errors rather than
crashing the node.

This covers the scenario where submitSolution is called with data
that cannot be deserialized, as discussed in #33341

Also introduces the assert_capnp_failed helper in ipc_util.py to
cleanly handle macOS-specific Cap'n Proto exception strings, and
refactors an existing block weight test to use it.

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 12/100

This commit only adds a new automated test and a small test helper. It checks that the Bitcoin Core IPC mining server returns a clean error when given invalid data, instead of crashing. There is no change to production code, so it does not introduce or fix a live security vulnerability by itself.