Bitcoin Core

This commit only adds documentation to the developer notes. It describes the project's rules for phasing out old features (RPC methods, startup options, REST endpoints, and ZMQ topics) over time. No code behavior changed, so there is no security issue or vulnerability here.

This is a minor test-framework bug fix. It moves one line of code earlier so that a test-only URL field is set before creating a command-line RPC connection. This allows a specific functional test to run with the --usecli option. It does not affect the Bitcoin Core software that users run, nor does it touch network code, wallets, consensus, or any production security mechanism.

This commit is a one-word documentation update. It removes the phrase 'RPC only' from the help text of the -walletrbf command-line option because the feature is now also available through the graphical user interface. There is no code behavior change and no security impact.

This commit only adds documentation. It announces that two Bitcoin Core settings related to transaction replacement (RBF/BIP125) are now deprecated and will be removed later. There is no code change, no bug fix, and no security issue in the commit itself.

This commit is a routine infrastructure change for Bitcoin Core's continuous integration (CI) system. It switches the CI cache provider from Cirrus to GitHub's own cache service because Cirrus is being phased out and GitHub now offers more cache storage. The changes only affect how build artifacts and dependencies are stored between automated test runs; they do not modify the Bitcoin Core software that users run, nor do they introduce any known security vulnerability.

This is a tiny code-cleanup change in Bitcoin Core's RPC helper code. It removes unnecessary 'std::move' calls on plain enum values, which do not benefit from moving. There is no security impact.

This is a tiny code-cleanup change in Bitcoin Core's internal transaction graph logic. It swaps three std::move calls for plain assignments because the variables are simple numbers or booleans, where moving and copying do the exact same thing. There is no security impact.

This is a small code cleanup change. It changes one internal function so it accepts a constant reference to an outpoint instead of taking ownership by moving it. Since COutPoint is a tiny, cheap-to-copy object, moving it was unnecessary and forced callers to write extra std::move() calls. The behavior of the program is unchanged; there is no security fix here.

This commit only adds a release note describing a prior code change. It does not modify any executable code, configuration, or behavior. The release note explains that two mining-related settings will now be rejected when invalid rather than silently adjusted. There is no security issue in this documentation-only commit itself.

This commit only changes which source files are checked by an automated CI linting tool called 'Include What You Use' (IWYU). It expands the list of files where missing or unnecessary #include statements are treated as errors. It does not change any Bitcoin Core runtime code, network behavior, wallet logic, or cryptographic operations, so it has no direct security impact on users.

This commit is a pure code cleanup: it adjusts which header files are included in mining-related source files so each file explicitly includes only what it actually uses. There are no functional code changes, no bug fixes, and no security-relevant behavior changes.

This commit is a straightforward internal code cleanup: it reads mining-related command-line options once when the program starts and stores them in a shared node structure, instead of re-reading and re-parsing them every time a block template is created or an RPC mining-info call is answered. There is no user-visible behavior change, no bug fix, and no security relevance in the diff itself.

This Bitcoin Core commit changes how mining options are validated. Previously, invalid values for things like block weight limits were silently adjusted (clamped) to valid values, which could cause a miner or an external mining client to unknowingly produce a block different from what they requested. Now the code explicitly rejects invalid options with an error. This is a defensive hardening change that prevents silent misbehavior, especially for external mining clients communicating over IPC.

This commit is a straightforward internal code cleanup in Bitcoin Core's mining module. It moves block-template option handling into helper functions and makes the same option type usable by both internal callers and external IPC callers. The commit message explicitly says it does not change behavior, and the diff shows only minor message-string changes (dropping the word 'Specified' from some startup error messages). There is no indication of a security fix or vulnerability.

This commit adds a new automated test for Bitcoin Core's mining interface. It checks that a feature called waitNext(), used by external mining programs, correctly follows the node's configured minimum transaction fee policy (-blockmintxfee) and does not quietly ignore that setting. The commit itself only adds a test; it does not change the actual mining code. The test appears to be a regression test for a bug where waitNext() may have fallen back to default fee policy instead of using the configured one.

This commit only adds a new automated test to Bitcoin Core. It checks that a configuration option called -blockmaxweight correctly limits the size of blocks produced through the IPC mining interface, both when a block template is first created and when it is refreshed. There is no change to production code, no bug fix, and no security patch.

This commit is a pure code reorganization: it moves mining-related data structures from one header file (node/types.h) into a new header file (node/mining_types.h) and updates the files that include them. No program behavior, logic, or security properties change.

This is a small, safe code cleanup change. It makes the mining-related interface accept a read-only (const) view of the node's internal state instead of a mutable one. It does not fix a security bug or change runtime behavior in any meaningful way.

This commit is a code cleanup (refactor) in Bitcoin Core's test, benchmark, and fuzzing code. It changes how test code asks the node to create blocks, switching most callers from the internal BlockAssembler class to a public Mining interface. The commit message explicitly says it does not change what blocks are created, only how the creation calls are made. There is no security fix or vulnerability here.

This commit refactors how Bitcoin Core's block builder (the miner) handles the maximum block weight setting. It replaces an older signed-size field with a new optional unsigned field and fixes a parsing quirk: a negative command-line value for -blockmaxweight is now treated as 0 before validation rejects it, instead of silently wrapping around to a huge positive number. The change is mostly a cleanup, but it removes a small overflow/underflow footgun in argument parsing.

This commit only moves a test helper function from one test file into a shared utility file. It does not change Bitcoin Core's actual code, network behavior, or security properties. It is a pure test-code refactoring with no security relevance.

This is a minor cleanup of a single Bitcoin Core test file. It reorders Python imports, adds a trailing comma, improves a code comment, and reuses an existing test wallet object instead of creating a new one. There is no change to production code and no security relevance.

This commit is a straightforward code cleanup: it moves the command-line argument parsing for block-mining settings out of the large init.cpp file into a new dedicated file. The validation checks remain the same, and the only functional change is that error messages for extremely large or negative weight values may now be phrased slightly differently. There is no security issue here.

This is a code cleanup in Bitcoin Core's internal testing tools. It changes when and how the test framework creates a command-line interface (CLI) helper for test nodes, and removes some redundant settings. There is no indication this fixes a security bug or affects live Bitcoin software.

This commit is a simple code cleanup in Bitcoin Core's internal test framework. It removes a small helper function called get_rpc_proxy and moves its logic directly into the one place that used it. There is no change to Bitcoin's network protocol, wallet handling, consensus rules, or production code. It only affects test infrastructure and does not introduce a security issue.