Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This change fixes a Bitcoin Core wallet bug where the `importprunedfunds` RPC command could only re-import transactions that sent money to the wallet, not transactions that spent money from it. After this fix, both incoming and outgoing tr…
Logic bug in wallet transaction import scopeIncorrect balance possible after removing and re-importing spending transactionFix routes import through existing involvement check (IsMine + IsFromMe)
This commit adds a new Bitcoin Core wallet startup option called -maxfeerate. It lets users set a maximum fee rate (fee per unit of transaction size) that the wallet will allow when creating or broadcasting transactions. Previously, the wa…
New wallet startup option -maxfeerate to cap transaction fee rateNew transaction error type MAX_FEE_RATE_EXCEEDEDBroadcastTransaction now checks both max absolute fee and max fee rate
This Bitcoin Core update fixes a wallet-signing quirk. When a user chose the SIGHASH_SINGLE signature mode, an input that had no matching output index would sign essentially nothing meaningful. That signature could then stay valid even if …
Funds-redirection footgun from SIGHASH_SINGLE signatures with no committed outputInconsistent guard between SignTransaction and SignPSBTInput pathsFix centralizes the guard in the low-level signature creator to cover future signing paths
This change updates Bitcoin Core's I2P (Invisible Internet Project) privacy network settings to use newer, stronger encryption for the published 'leaseset' that describes how other peers can contact a node. The old setting included ElGamal…
Cryptographic algorithm update (ElGamal to MLKEM-768)Use of I2P 'legacy' encryption type removedConfiguration-only change in network privacy layer
This change fixes a labeling bug in Bitcoin Core's first-run disk-space warning. The estimate was stored in GiB (binary gigabytes, 1024-based) but displayed as GB (decimal gigabytes, 1000-based), and for pruned nodes it showed the full-cha…
This is a wallet bug, not a theft or remote-code bug. When a Bitcoin Core user turns on the optional 'avoidpartialspends' or 'avoid_reuse' setting, an output group rejected during coin selection could be counted twice as 'discarded.' That …
Logic error causing double-counting of discarded UTXO groupsCan trigger false 'insufficient funds' failure in coin selectionAffects avoidpartialspends / avoid_reuse wallets only
This is a documentation-only fix in a tutorial file. It changes two shell examples from using '>>' (append to file) to '>' (overwrite file). If a user followed the old instructions and ran the same command twice, the file would contain two…
No security signal: change is limited to documentationNo code changes to Bitcoin Core binaries, RPC, wallet, or consensus logicNo cryptographic, network, or privilege-boundary implications
This is a large internal code reorganization (refactor) in Bitcoin Core. It creates a new BlockTemplateManager class that takes over block-template creation, block submission, and tip-waiting helpers that were previously spread across seve…
Large refactor touching mining, RPC, interfaces, and test shutdown pathsNew object lifetime dependency: BlockTemplateManager holds references to mempool, chainman, and notifications; explicit reset ordering added in Shutdown/InitAndLoadChainstate/test setupsRemoval of early-init node.mining interface; BlockTemplateManager is now created after chainstate load, with a comment that it must exist before setChainstateLoaded(true) unblocks IPC waiters
This commit adds the first implementation of BIP352 (Silent Payments) to Bitcoin Core. Silent Payments are a new type of privacy-preserving Bitcoin address that lets someone receive payments without publicly revealing a fixed address. The …
New cryptographic feature implementation (BIP352 Silent Payments)Extensive use of secp256k1 silentpayments moduleInput public key extraction from P2PKH, P2WPKH, P2SH-P2WPKH, and P2TR inputs
This update fixes a wallet database loading bug where a damaged or tampered Bitcoin wallet file could cause the program to read past the end of a stored extended public key (xpub). The patch makes the loader check the stored xpub length be…
Out-of-bounds read in wallet descriptor cache deserializationASan container-overflow triggered by malformed on-disk recordMissing length validation between record size prefix and fixed-size decoder
This commit adds a new wallet RPC called listrawtransactions to Bitcoin Core. It is a feature addition that lets users list every transaction their wallet knows about, including internal transfers and consolidations that the existing listt…
No security-relevant bug fix or vulnerability patch is present in the diff.New RPC exposes additional wallet transaction metadata, but only to callers already authorized for wallet RPCs.Code is a refactor of existing gettransaction logic into shared helpers; no new cryptographic, network, or consensus code.
This Bitcoin Core update fixes several wallet bugs where a failed database write could leave a wallet in an inconsistent state. For example, encrypting a wallet or changing its passphrase could appear to succeed in memory while the change …
Atomicity fix for encryption state and descriptor key persistenceFailure to persist master key during encryption previously reported success in memoryPassphrase change could activate new passphrase only in memory
This commit only changes Bitcoin Core's internal functional test code. It replaces hard-coded test keys and addresses with ones generated from a new test helper class, and unifies how tests tell nodes not to create a default wallet. There …
This commit only adds a new automated test to Bitcoin Core. It checks that when two partially-signed Bitcoin transactions (PSBTs) are combined, any custom 'unknown' data fields attached to them are preserved correctly. There is no change t…
This is a Bitcoin Core wallet maintenance patch. It speeds up a wallet function that checks whether a descriptor already exists by caching a hash of the descriptor's canonical text, instead of rebuilding that text every time. It also tidie…
No security-relevant signal in commit message or diffChange is described as performance improvement and code cleanupBackwards-compatibility test notes a known miniscript wallet loading incompatibility between v31.0/v31.1 and other versions, but this is a documented compatibility quirk, not a vulnerability
This is a documentation-only fix for Bitcoin Core's machine-readable RPC help data. It changes several default values from literal strings to 'hint' labels (because the real default depends on context) and corrects one boolean default from…
OpenRPC schema/default mismatch correctionRPC help metadata type correction (string 'false' to boolean false)No executable code path changes
This commit fixes documentation metadata for six Bitcoin Core RPC arguments. It changes how default values are described so that automatically generated API docs and schemas are accurate. The actual behavior of the software when running is…
No runtime code changesOnly RPC help/schema metadata modifiedVendor explicitly states runtime behavior is unchanged
This commit fixes a bug in Bitcoin Core's MuHash3072 cryptographic code where dividing a MuHash object by itself (x /= x) produced the wrong mathematical result. The fix is straightforward: the code now saves the divisor's numerator before…
Cryptographic correctness bug in MuHash3072 division operatorSelf-aliasing in operator/= produces incorrect 1/D result instead of empty setNo production code path identified that triggers self-division
This is a build-compatibility fix, not a security patch. It changes how some constant data is stored internally so that Apple's macOS linker (ld64) can build Bitcoin Core correctly. The change avoids a linker bug that caused build failures…
No security-relevant code logic changedChange is a linker bug workaround, not a vulnerability fixConstants remain read-only; no new attack surface introduced
This commit refactors Bitcoin Core's wallet descriptor import feature so the same logic can be used by both the RPC command and a new GUI-facing interface. It also tightens one input rule: negative timestamps are now rejected, and the mini…
Refactor of security-sensitive wallet import code into shared CWallet pathNew input validation: negative timestamps rejected for importdescriptorsCentralization of descriptor range bound checks in CheckDescriptorRangeBounds
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
AI review queuedwallet, test: remove -walletrbf startup option from wallet_listtransactions.pyby rkrux · 8cb6e405 · May 27, 2026 · 1 fileMessage 75 · AdequateInformational 15Details
Commit message · rkrux
wallet, test: remove -walletrbf startup option from wallet_listtransactions.py
The corresponding test case that tests for optin rbf variations can also be removed.
75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only removes a test case from Bitcoin Core's automated test suite. It deletes the part of a test that exercised the deprecated '-walletrbf' startup option and related opt-in RBF transaction behavior. There is no change to the actual Bitcoin Core wallet, node, or network code, and no security vulnerability is present in the diff.
AI review queuedwallet, test: -walletrbf startup option from wallet_bumpfee.pyby rkrux · 5e833e06 · May 27, 2026 · 1 fileMessage 60 · AdequateInformational 15Details
Commit message · rkrux
wallet, test: -walletrbf startup option from wallet_bumpfee.py
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only changes a single test file. It removes the use of the deprecated '-walletrbf' startup option and its associated deprecation warning from the wallet_bumpfee.py functional test. There is no change to production wallet code, no bug fix, and no security issue.
wallet, test: remove -walletrbf startup option from rpc_psbt.py
Also, include PSBT_GLOBAL_FALLBACK_LOCKTIME key/value while making the PSBT v2 blank for combinepsbt RPC.
75/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100
This commit only changes Bitcoin Core's own test code. It removes the obsolete -walletrbf startup option from two functional tests and adds a missing PSBT v2 field (fallback locktime) to a test helper that creates blank PSBTs. There is no change to production wallet or node code, so it does not affect real users' funds, transactions, or network security.
Lower-prioritytest: speed up feature_dbcrashby will · c17cc76a · May 27, 2026 · 1 fileMessage 57 · ThinInformational 15Details
Commit message · will
test: speed up feature_dbcrash
57/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100
This commit only changes a test script to make it run faster. It swaps one internal test helper for another equivalent one when sending transactions during a crash-recovery test. There is no change to the actual Bitcoin Core software that users run, and no security relevance.
Lower-prioritytest: Use operator<< for time_points instead of manual TickSinceEpochby MarcoFalke · fad4f417 · May 27, 2026 · 5 filesMessage 100 · StrongInformational 15Details
Commit message · MarcoFalke
test: Use operator<< for time_points instead of manual TickSinceEpoch
This partially reverts the changes from commit 020166080cf57e6eb869abc56d603eb1d6e5e45b to testnet4_miner_tests.cpp
Also, remove some confusing IWYU pragmas. Those were inconsistently added in 8c58f63578a44c8b4ebdda4637d1b198d8a67d08, but without any rationale why adding them is the correct approach. The correct approach should be done in a proper follow-up, with a clear rationale.
100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100
This is a minor cleanup commit in Bitcoin Core's test code only. It replaces a manual time-comparison helper with a direct comparison and removes some code-comment markers related to include-file management. There is no change to production code, no security fix, and no vulnerability.
Lower-priorityrefactor: Merge announce_cmpct_block() defs into oneby Hodlinator · 51dd90fb · May 26, 2026 · 1 fileMessage 62 · AdequateInformational 15Details
Commit message · Hodlinator
refactor: Merge announce_cmpct_block() defs into one
62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100
This commit is a simple code cleanup in a test file. It merges three nearly identical helper functions into one shared method used by Bitcoin Core's automated compact block tests. There is no change to the actual Bitcoin network software or its security behavior.
AI review queuedguix: Split manifest into build and codesign manifestsby Hennadii Stepanov · d846444d · May 26, 2026 · 4 filesMessage 50 · ThinInformational 15Details
Commit message · Hennadii Stepanov
guix: Split manifest into build and codesign manifests
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit is a build-system housekeeping change for Bitcoin Core's Guix reproducible-build tooling. It takes one large package list file (manifest.scm) and splits it into two smaller files: one used when compiling the software (manifest_build.scm) and one used when applying release signatures (manifest_codesign.scm). The scripts that invoke Guix are updated to point at the correct new file. There is no change to the Bitcoin Core node software, wallet logic, or network behavior, and nothing in the commit suggests a security vulnerability or fix.
Lower-priorityguix: Update `python-signapple` and wrap with OpenSSL pathsby Hennadii Stepanov · 0b9e10ad · May 26, 2026 · 1 fileMessage 50 · ThinInformational 20Details
Commit message · Hennadii Stepanov
guix: Update `python-signapple` and wrap with OpenSSL paths
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 20/100
This commit updates a build dependency called python-signapple, which is used to create and verify digital signatures on macOS Bitcoin binaries. It also adds environment variables so the tool can find OpenSSL libraries during the Guix reproducible build process. There is no direct evidence in the commit that this fixes an exploitable security flaw in Bitcoin Core itself; it appears to be a build tooling/maintenance change.
mining: add submitBlock IPC method to Mining interface
Add a submitBlock method to the Mining IPC interface, similar to the submitblock RPC. This accepts a fully assembled block, validates it, and if accepted as new, processes it into chainstate.
This is needed for Stratum v2 Job Declarator Server (JDS), where accepted solutions may correspond to jobs not tied to a Bitcoin Core BlockTemplate. JDS receives PushSolution fields and reconstructs full blocks; without an IPC submitBlock method, final submission requires the submitblock RPC.
The method returns detailed status (reason/debug strings) matching the checkBlock pattern, giving callers enough information to handle validation failures.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
defensive validation
AI analysis · Informational 23/100
This commit adds a new internal 'submitBlock' method to Bitcoin Core's Mining interface, used by external mining software (like Stratum v2 servers) to submit fully assembled blocks for validation. It is a feature addition that mirrors the existing submitblock RPC. There is no direct evidence in the commit of a security vulnerability, but it exposes block submission over the IPC interface, which carries the same general risks as any block-submission path: a compromised or buggy caller could submit invalid or duplicate blocks. The implementation explicitly rejects duplicates and requires a complete block, including coinbase witness data when needed.
Test the new Mining.submitBlock IPC method: - Invalid block (bad version) returns failure with reason - Valid block (with a real mempool tx) is accepted and propagates - Duplicate block returns failure with "duplicate" reason - Witness commitment without coinbase witness nonce is rejected (bad-witness-nonce-size), confirming no auto-fix behavior - submitBlock then submitSolution: duplicate is accepted (submitSolution returns true for already-known blocks) - submitSolution then submitBlock interaction (duplicate)
Build candidate blocks from BlockTemplate data in the existing coinbase and submission test, then exercise checkBlock(), submitSolution(), and submitBlock() against those candidates. submitBlock() uses an isolated IPC node for cases that would otherwise affect the main submitSolution() and checkBlock() assertions.
100/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit only adds new automated tests for the Bitcoin Core IPC mining interface. It does not change any production node code, consensus rules, or network behavior. The tests verify that a new submitBlock IPC method correctly accepts valid blocks and rejects invalid, duplicate, or malformed ones. There is no security vulnerability here.
Introduce a SubmitBlock() helper in node/miner.cpp that wraps ProcessNewBlock submission and captures validation state through the BlockChecked callback.
Route submitSolution through the helper before adding any new IPC method.
No behavior change.
70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Provides detailed explanatory context
AI analysis · Informational 15/100
This commit is a straightforward internal code reorganization (refactor) in Bitcoin Core. It moves the logic for submitting a newly mined block into a shared helper function called SubmitBlock(). The actual behavior of block submission does not change; the code just becomes cleaner and easier to reuse for future features like IPC (inter-process communication). There is no security bug being fixed and no new attack surface introduced.
AI review queuedwallet: refactor to read -walletrbf only once instead of twiceby rkrux · a3fe455a · May 26, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · rkrux
wallet: refactor to read -walletrbf only once instead of twice
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This is a tiny code cleanup in Bitcoin Core's wallet setup. It changes how the deprecated '-walletrbf' setting is read so the value is fetched once and reused, rather than checked for existence and then fetched separately. There is no security issue here.
AI review queuedtest: Allow --usecli in tests that already support itby MarcoFalke · fa246938 · May 26, 2026 · 5 filesMessage 72 · AdequateInformational 15Details
Commit message · MarcoFalke
test: Allow --usecli in tests that already support it
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only changes Bitcoin Core's internal test scripts. It removes five lines that previously told the test framework these particular tests cannot be run with the command-line bitcoin-cli tool. There is no change to the actual Bitcoin node software, no security fix, and no vulnerability.
Lower-prioritytest: Catch CalledProcessError to support --usecli in feature_dbcrash.pyby MarcoFalke · fa8d4d5c · May 26, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · MarcoFalke
test: Catch CalledProcessError to support --usecli in feature_dbcrash.py
72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100
This is a minor fix to a Bitcoin Core functional test script. It allows the dbcrash test to be run with the --usecli option by catching an additional error type that occurs when commands are sent through the bitcoin-cli tool instead of the direct RPC interface. It does not change the production Bitcoin node code and has no security impact on real users.
Lower-prioritytest: use echojson to allow rpc_named_arguments.py --usecliby MarcoFalke · faf0f848 · May 26, 2026 · 1 fileMessage 95 · StrongInformational 15Details
Commit message · MarcoFalke
test: use echojson to allow rpc_named_arguments.py --usecli
The echo and echojson RPCs are identical in the server. The only difference is that echojson is in the client conversion table.
95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100
This is a minor change to a single test file in Bitcoin Core. It swaps the test RPC from 'echo' to 'echojson' so the test can also run against the command-line bitcoin-cli tool. There is no change to production code, no wallet or network behavior change, and no security fix or vulnerability introduced.
Lower-prioritytest: Stop node before modifying config to support rpc_users.py --usecliby MarcoFalke · faf993ee · May 26, 2026 · 1 fileMessage 99 · StrongInformational 15Details
Commit message · MarcoFalke
test: Stop node before modifying config to support rpc_users.py --usecli
Otherwise, bitcoin-cli will read the wrong config from the "future".
99/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 15/100
This is a minor fix to a Bitcoin Core functional test script. It changes the test setup so that the test nodes are stopped before their configuration files are edited, then started again afterward. Previously, the test restarted the nodes after editing the config, which could cause the command-line tool bitcoin-cli to read settings that had not yet taken effect. There is no change to production Bitcoin Core code and no security vulnerability in the software itself.
Lower-prioritychainparams: add overloads for RegTest and SigNet with no optionsby Antoine Poinsot · 801e3bfe · May 25, 2026 · 3 filesMessage 85 · StrongInformational 15Details
Commit message · Antoine Poinsot
chainparams: add overloads for RegTest and SigNet with no options
For consistency with the overloads introduced in the previous commit, and because there is already a few places where they are useful.
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 15/100
This commit is a small internal code cleanup for Bitcoin Core. It adds shortcut versions of two functions used only for test networks (RegTest and SigNet) so callers don't have to pass an empty options object. There is no user-facing change and no security relevance.
Lower-prioritychainparams: make deployment configuration available on all test networksby Antoine Poinsot · 4995c00a · May 25, 2026 · 5 filesMessage 83 · StrongInformational 18Details
Commit message · Antoine Poinsot
chainparams: make deployment configuration available on all test networks
This allows unit tests to set `-testactivationheight` and `-vbparams` on all networks instead of exclusively on regtest. Those are kept test-network-only when used as startup parameters.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 18/100
This commit lets Bitcoin Core accept two testing-only command-line options on test networks (testnet, testnet4, signet) instead of only on regtest. It also adds an explicit guard so those options cannot be used on the real mainnet. The change is aimed at making unit tests more flexible, not at fixing a live security bug.
Security candidateutil: Require integers for SaturatingAdd() and AdditionOverflow()by Hodlinator · 0774eaaf · May 25, 2026 · 1 fileMessage 73 · AdequateLow 33Details
Commit message · Hodlinator
util: Require integers for SaturatingAdd() and AdditionOverflow()
Previously we could fall back to using an unspecialized implementation of std::numeric_limits<T> which would compile as long as the numeric operators existed, but would return 0 for min() & max().
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
memory safety
AI analysis · Low 33/100
This change tightens two low-level math helper functions so they only accept whole-number (integer) types. Previously, a non-integer type could slip through and silently produce wrong min/max values because the generic fallback for numeric limits returns 0. The patch prevents that misuse at compile time rather than relying on an internal check.
✓ Descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Moderate 62/100
This commit adds release notes describing a privacy bug that was fixed in Bitcoin Core pull request #35319. The bug could accidentally reveal a user's real IP address when sending a transaction privately using the sendrawtransaction RPC with privatebroadcast enabled. Normally, such transactions are forced through the Tor network to hide the sender's IP. But if a peer falsely advertised support for the newer P2P v2 protocol, Bitcoin Core would try v2, fail, then fall back to v2 over a direct IPv4/IPv6 connection—bypassing Tor and potentially exposing the originator's IP address. This commit only documents the fix; it does not contain the actual code change.
Lower-prioritynet: ensure no direct private broadcast connectionsby Vasil Dimov · d01b461f · May 25, 2026 · 2 filesMessage 85 · StrongLow 47Details
Commit message · Vasil Dimov
net: ensure no direct private broadcast connections
Private broadcast connections use either Tor or I2P, which require a proxy intrinsically or IPv4 or IPv6 which must use a proxy in the context of private broadcast to avoid leaking the originator's IP address.
Add a safety check to guard against future mistakes.
Co-authored-by: Andrew Toth <andrewstoth@gmail.com>
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Low 47/100
This change adds a safety check in Bitcoin Core's networking code to make sure a specific kind of private message-sending connection (called a 'private broadcast' connection) never connects directly over the internet. Instead, it must go through a proxy like Tor or I2P. Without this guard, a future code mistake could cause the sender's real IP address to be exposed. The patch is described by the authors as a preventive guard, not a fix for an active bug.
Lower-prioritynet: use the proxy if overriden when doing v2->v1 reconnectionsby Vasil Dimov · fd230f94 · May 25, 2026 · 2 filesMessage 73 · AdequateLow 35Details
Commit message · Vasil Dimov
net: use the proxy if overriden when doing v2->v1 reconnections
`OpenNetworkConnection()` supports overriding the proxy to use for connecting. However when v2 connection is attempted and it fails a v1 connection is tried without that proxy.
Store the override proxy in `CNode` and pass it to `CConnman::m_reconnections` to be used for v1 retries.
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 35/100
This commit fixes a bug in Bitcoin Core's networking code. When a user or operator had configured a specific proxy (a privacy-routing middleman) to be used for a particular outgoing connection, that proxy was correctly used on the first connection attempt. But if the modern v2 transport protocol handshake failed and Bitcoin Core automatically fell back to the older v1 protocol, the fallback connection ignored the specified proxy and used the global/default proxy instead. The fix stores the requested proxy override inside the peer object so the fallback reconnection remembers to use it.
Lower-priorityrpc: Correct type for tx_sigopsby Hodlinator · a815e3e2 · May 25, 2026 · 1 fileMessage 60 · AdequateInformational 18Details
Commit message · Hodlinator
rpc: Correct type for tx_sigops
Broken out from larger effort to make CAmount more type safe.
60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 18/100
This commit changes a single variable type in Bitcoin Core's mining RPC code. The variable that holds signature-operation counts for transactions is now declared as a plain integer type (int64_t) instead of the money-amount type (CAmount). The commit message frames this as a type-safety cleanup, not a security fix. There is no direct evidence in the commit or supplied references that this change fixes an exploitable vulnerability.
Security candidatetest: remove the lazy import of util in authproxyby rkrux · 7be0d6fa · May 25, 2026 · 1 fileMessage 82 · StrongInformational 15Details
Commit message · rkrux
test: remove the lazy import of util in authproxy
This lazy import prompted the removal of the circular dependency, so remove it now that we can.
82/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
authentication path
AI analysis · Informational 15/100
This is a minor code cleanup in Bitcoin Core's test framework. It removes a lazy (deferred) import and replaces it with a normal import at the top of the file. There is no security issue here—it's purely a refactoring change to simplify the code after an earlier dependency cleanup.
Security candidatetest: move out JSONRPCException from authproxy to utilby rkrux · 779f4446 · May 25, 2026 · 10 filesMessage 100 · StrongInformational 15Details
Commit message · rkrux
test: move out JSONRPCException from authproxy to util
So that util is not dependent on authproxy at all and going forward authproxy can use util methods.
Reviewing with --color-moved=dimmed-zebra option can be helpful.
100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
Why it was queued
signing or wallet pathauthentication path
AI analysis · Informational 15/100
This is a harmless internal code cleanup in Bitcoin Core's test suite. It moves a Python exception class named JSONRPCException from one test helper file (authproxy.py) to another (util.py) and updates the files that import it. There is no change to how Bitcoin nodes behave, no fix for a security bug, and no change that affects real users or live networks.