Bitcoin Core

This is a routine continuous integration (CI) build-script fix. It makes sure a build directory variable is passed into the container image build so that an Apple software development kit gets installed where the test runner expects it. There is no indication this affects Bitcoin Core software users, wallets, the network, or security.

This commit removes a CI (Continuous Integration) shell script feature that managed a local Docker build cache directory. It is a cleanup/revert of an earlier change and does not touch any Bitcoin Core node, wallet, consensus, or network code. There is no security-relevant change to user-facing software.

This commit changes the Bitcoin Core continuous integration (CI) script to use Docker's 'buildx' plugin instead of the older 'docker build' command with BuildKit enabled. It is a build-infrastructure tweak intended to make Docker image caching work correctly. There is no indication this change affects the Bitcoin software users run, handles money, keys, network messages, or introduces any security vulnerability.

This commit adds a new GitHub Actions helper that sets up Docker Buildx and configures Docker layer caching for Bitcoin Core's continuous integration (CI). It does not change any Bitcoin node code, wallet logic, or network behavior. There is no indication it fixes or introduces a security vulnerability.

This commit is a routine CI (Continuous Integration) configuration change for the Bitcoin Core repository. It adds a single environment variable that tells the project's GitHub Actions workflow to use faster Cirrus-provided runners and caching when running tests on the main bitcoin/bitcoin repository or pull requests against it. There is no code change affecting the Bitcoin software itself, wallets, transactions, networking, or cryptography.

This commit adds two new GitHub Actions helper files that manage caching for the project's continuous integration (CI) build system. It saves and reuses compiled code and dependency downloads to make automated builds faster. There is no indication this change introduces a security vulnerability or modifies any Bitcoin Core software code that users run.

This commit adds a new reusable GitHub Actions step that sets environment variables for Bitcoin Core's continuous integration (CI) system. It defines build/cache directories and computes cache hashes from source files. There is no user-facing or network-facing change, and nothing in the diff suggests a security vulnerability or fix.

This commit simply changes two function declarations in a header file from regular methods to virtual methods. Virtual methods can be overridden in subclasses, which is useful for testing with mock objects. There is no security issue here.

This is a tiny documentation-only change in a test helper file. It removes one outdated sentence from a docstring because a previous commit removed the assumption it described. No code behavior changed, and there is no security relevance.

This is a simple code cleanup change: a single default value for a database batch size setting is moved from one header file to another and renamed to follow project conventions. The actual numeric value (16 MiB) and how it is used remain unchanged. There is no security relevance.

This commit simply doubles a default internal setting that controls how much data Bitcoin Core groups together before writing to its UTXO database. It is a performance tuning change, not a security fix or vulnerability. There is no indication it introduces a security problem.

This change narrows the use of a global lock in the getblocktemplate RPC, which miners use to request work. The lock is now acquired later and held for a shorter time, rather than being held across the entire request setup. This is a performance and correctness cleanup. There is no direct evidence in the commit that it fixes an exploitable security bug, but reducing lock scope can prevent subtle race conditions or RPC stalls.

This is a routine Continuous Integration (CI) maintenance change for Bitcoin Core. It switches the CentOS test container back from using the ksh shell to the dash shell, because a Red Hat bug that previously required ksh has been fixed. The change only affects internal test scripts and installed CI packages; it does not touch Bitcoin Core's network code, wallet, consensus logic, or any user-facing software.

This commit undoes a recent code cleanup that changed how Bitcoin Core's memory pool tracks transactions for compact block reconstruction. The reversion restores the previous design where the mempool keeps pairs of transaction IDs and iterators, rather than storing direct shared references to transactions. There is no indication in the commit itself that this fixes a security bug; it appears to be a design or correctness revert, possibly due to bugs introduced by the original refactor.

This commit undoes a recent code cleanup in Bitcoin Core's compact block reconstruction feature. The original cleanup changed an internal list of spare transactions from storing pairs of 'transaction ID + transaction pointer' to storing only the transaction pointer. This revert restores the paired format and adds a comment explaining that keeping both values together improves CPU cache performance during block reconstruction. There is no direct evidence in the commit that this fixes an active security bug, but it is a defensive revert of a performance refactor in a consensus-adjacent code path.

This commit adds a new performance test (benchmark) for Bitcoin Core's compact block reconstruction feature. It does not change any production code that runs on the live Bitcoin network, so it cannot directly cause security problems or be exploited by attackers.

This commit simply updates the continuous integration (CI) test scripts to use LLVM/Clang version 21 instead of version 20. It does not change Bitcoin Core's actual source code, network behavior, or wallet logic. There is no security issue here.

This commit only changes a continuous integration (CI) test configuration file. It adds an environment variable that limits stack size during automated testing of a 32-bit Intel build. There is no change to the actual Bitcoin Core software that users run, and nothing in the commit suggests a security fix or vulnerability.

This commit fixes a bug in Bitcoin Core's own testing tools. The test framework had a limit meant to avoid passing overly long command-line arguments to the bitcoin-cli program, but it was checking the size of the largest single argument instead of the total size of all arguments. The fix lowers the threshold and checks the total length, and adds tests to make sure large arguments still work by routing them through standard input instead. This is a test-only change and does not affect the Bitcoin Core software that users run.

This commit updates the libmultiprocess subtree used by Bitcoin Core. The most notable change is a build-time guard that refuses to compile against specific old versions of the Cap'n Proto library because those versions contain a known memory-access vulnerability (CVE-2022-46149). The commit also adds CI testing for older Cap'n Proto versions and OpenBSD, fixes a C++20/Cap'n Proto 0.8 compatibility issue in the code generator, removes an obsolete linker flag, and adds a missing include. It is primarily a hardening and compatibility update, not a fix for a new vulnerability in Bitcoin Core itself.

This commit removes a now-impossible error path in Bitcoin Core's wallet code. Legacy (non-descriptor) wallets have already been removed from the codebase, so the check that rejected adding descriptors to a legacy wallet was unreachable 'dead code.' The change replaces that check with an internal assertion, which only affects debug builds and only crashes the program if an invariant that should never happen is violated. There is no security vulnerability here.

This commit simply deletes two unused C++ macros (ENTER_CRITICAL_SECTION and LEAVE_CRITICAL_SECTION) from a header file. These macros were non-RAII manual locking helpers that had been replaced by safer scoped lock wrappers. There is no runtime behavior change, no bug fix, and no security vulnerability being patched.

This commit is a small internal cleanup in Bitcoin Core's RPC mining code. It replaces manual lock/unlock macros with a safer, automatic 'reverse lock' helper that temporarily releases a lock and re-acquires it when done. The commit message explicitly says 'No functional change,' and the diff shows only a mechanical code-style swap with no behavior change visible.

This is a test-only cleanup change. It replaces old-style manual lock/unlock macros with safer automatic lock helpers in a single test file. There is no change to the actual Bitcoin Core software that users run, and no security bug is being fixed.

This commit removes two unused C++ template instantiations from Bitcoin Core's synchronization code. Template instantiations are pre-compiled versions of a generic function for specific data types. The removed ones supported older mutex types that are no longer used by the ENTER_CRITICAL_SECTION macro. This is a routine cleanup with no security impact.