What the developer wrote
Authored by MarcoFalke
test: Fixup fill_mempool docstring
The assumption was removed in commit
3eab8b724044dc321f70e5eed66b149713158a04.
What changed, and why it matters
This is a tiny documentation-only change in a test helper file. It removes one outdated sentence from a docstring because a previous commit removed the assumption it described. No code behavior changed, and there is no security relevance.
No action required. This is a non-functional test documentation cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
Commit fa3f682032a3292604f363a5ee4557937f3d8950 edits the docstring of fill_mempool() in test/functional/test_framework/mempool_util.py. The removed line stated the helper assumed -minrelaytxfee is 1 sat/vbyte; that assumption was removed in an earlier commit (3eab8b724044dc321f70e5eed66b149713158a04). The diff is +1/-2 lines and contains no executable code changes.
Changed components
test/functional/test_framework/mempool_util.py docstring onlyInspect captured patch +1 / −2
diff --git a/test/functional/test_framework/mempool_util.py b/test/functional/test_framework/mempool_util.py
index 9ffd934f..3c4609c0 100644
--- a/test/functional/test_framework/mempool_util.py
+++ b/test/functional/test_framework/mempool_util.py
@@ -57,8 +57,7 @@ def fill_mempool(test_framework, node, *, tx_sync_fun=None):
"""Fill mempool until eviction.
Allows for simpler testing of scenarios with floating mempoolminfee > minrelay
- Requires -maxmempool=5 and assumes -minrelaytxfee
- is 1 sat/vbyte.
+ Requires -maxmempool=5.
To avoid unintentional tx dependencies, the mempool filling txs are created with a
tagged ephemeral miniwallet instance.
"""
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.