ci: have base install run in right dir
What the developer wrote
Authored by will
ci: have base install run in right dir
This sets the build dir at build time so that Apple SDK gets installed
in the correct/expected location for the runtime to find it.
Co-authored-by: Max Edwards <youwontforgetthis@gmail.com>
What changed, and why it matters
This is a routine continuous integration (CI) build-script fix. It makes sure a build directory variable is passed into the container image build so that an Apple software development kit gets installed where the test runner expects it. There is no indication this affects Bitcoin Core software users, wallets, the network, or security.
No security action needed. Treat as a normal CI/maintenance fix.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit passes BASE_ROOT_DIR as a Docker build argument and environment variable in the CI container image build. This ensures the Apple SDK is installed under the correct path during image build time, matching the runtime expectation. The change is limited to ci/test/02_run_container.sh and ci/test_imagefile.
Changed components
ci/test/02_run_container.shci/test_imagefileInspect captured patch +4 / −0
diff --git a/ci/test/02_run_container.sh b/ci/test/02_run_container.sh
index eefac848..e91f8753 100755
--- a/ci/test/02_run_container.sh
+++ b/ci/test/02_run_container.sh
@@ -26,6 +26,7 @@ if [ -z "$DANGER_RUN_CI_ON_HOST" ]; then
--file "${BASE_READ_ONLY_DIR}/ci/test_imagefile" \
--build-arg "CI_IMAGE_NAME_TAG=${CI_IMAGE_NAME_TAG}" \
--build-arg "FILE_ENV=${FILE_ENV}" \
+ --build-arg "BASE_ROOT_DIR=${BASE_ROOT_DIR}" \
$MAYBE_CPUSET \
--platform="${CI_IMAGE_PLATFORM}" \
--label="${CI_IMAGE_LABEL}" \
diff --git a/ci/test_imagefile b/ci/test_imagefile
index f8b5eea1..224141b1 100644
--- a/ci/test_imagefile
+++ b/ci/test_imagefile
@@ -10,6 +10,9 @@ FROM ${CI_IMAGE_NAME_TAG}
ARG FILE_ENV
ENV FILE_ENV=${FILE_ENV}
+ARG BASE_ROOT_DIR
+ENV BASE_ROOT_DIR=${BASE_ROOT_DIR}
+
COPY ./ci/retry/retry /usr/bin/retry
COPY ./ci/test/00_setup_env.sh ./${FILE_ENV} ./ci/test/01_base_install.sh /ci_container_base/ci/test/
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.