BC
← All projectsBitcoin Core

Bitcoin Core

The Bitcoin network's reference node and wallet implementation.

BitcoinSupply chainNormal
Repository coverage

3483 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

402security candidates730second-pass queue3152AI analyses
171commits · 30 days
325commits · 60 days
1193commits · 180 days
2758commits · 365 days
Backfill bands
Aug 5 → Feb 61351 seen45 candidatesComplete
Feb 6 → Jun 61033 seen63 candidatesComplete
Jun 6 → Jul 6281 seen11 candidatesComplete
Jul 6 → Aug 5207 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

73/100 average clarity
1453Strong · 80–100
1227Adequate · 60–79
715Thin · 40–59
88Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
merge-script419112196589
Antoine Poinsot25422169
Ava Chow21874203071
MarcoFalke41923411074
fanquake24521230058
Lőrinc18121177081
Hennadii Stepanov25120221066
rkrux57957074
Sjors Provoost89889074
Sebastian Falbesoner33733073
David Gumberg55655072
Pieter Wuille95595066
Analysis record

Published AI watches

Last scanned 2 minutes ago

Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36704: doc: fix docs and enable `-Wdocumentation-pedantic`

This commit only changes documentation comments and enables a stricter compiler warning for documentation style. It does not alter any executable code, so it cannot introduce or fix a security vulnerability on its own.

0afaa731by Hennadii Stepanov+79−7716 files
No security note in commit
Low 41 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36040: Wallet: Don't backdate locktime rbf

This change fixes a privacy leak in Bitcoin Core's wallet. When users used the 'bumpfee' feature to replace a transaction with a higher fee, the replacement could sometimes end up with an older 'locktime' than the original transaction. Thi…

Privacy/fingerprinting issue in wallet transaction creationReplacement transaction locktime can be lower than original transaction locktimeAnti-fee-sniping random backdating can produce identifiable on-chain pattern
004cfb21by Ava Chow+171−86 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 86 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36342: wallet: reject recipient amounts above MAX_MONEY

This patch fixes a bug in Bitcoin Core's wallet transaction creation where extremely large output amounts could cause an integer overflow or even crash the node. Before the fix, a user could craft a transaction whose outputs added up to mo…

Integer overflow in recipient amount summationNode abort via failed assertion in coin selectionPossible creation of a transaction with wrapped/invalid total output value
8c360f08by Ava Chow+25−42 files
Vendor flagged security relevance
Low 49 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36637: torcontrol: send -torpassword hex-encoded to avoid escaping bugs

This change fixes how Bitcoin Core sends your Tor control password to the Tor daemon. Previously, the password was wrapped in quotes and only double-quote characters were escaped. If a password contained a backslash, Tor would misinterpret…

Improper escaping of protocol string (QuotedString)Potential Tor control command boundary confusionAuthentication bypass/failure risk for Tor control
6090f0afby Ava Chow+42−62 files
Vendor flagged security relevance
Low 30 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36387: wallet: rpc: Deprecate `encryptwallet` RPC for encrypting existing wallets.

This commit marks the existing 'recortar el video' feature as deprecated. It doesn't remove it, but it now shows a warning and requires a special flag to use. The change is meant to protect users from accidentally losing access to their bi…

Deprecation of risky wallet-encryption workflowKnown data-retention risk: unencrypted key material may remain on disk after late encryptionKnown backup/restore risk: post-encryption keys are not covered by pre-encryption backups
f98888efby Ava Chow+165−8819 files
Vendor flagged security relevance
Informational 21 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36087: util: Add and use AssertUnreachable

This is a code-cleanup change in Bitcoin Core. It replaces many uses of `assert(false)` and similar 'this should never happen' markers with a new macro called `AssertUnreachable()`. The goal is to make the code clearer for developers and a…

No security-relevant functional change: process still aborts on unreachable pathsRefactor only: replaces one abort mechanism with another equivalent oneAdds a new lint rule to enforce the preferred macro going forward
3ee664eaby Ryan Ofsky+274−26484 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36888: test: construct `coinselection_tests` output declaratively

This is a minor cleanup inside a single test file. It changes how a fake transaction output is built in a unit test so the empty script is written explicitly rather than created implicitly by resizing a list. The actual test behavior and t…

a690300eby merge-script+4−31 file
No security note in commit
Low 35 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36890: Update secp256k1 subtree to latest master

This is a routine subtree update for the secp256k1 cryptographic library inside Bitcoin Core. It pulls in several upstream fixes, most of which are build-system cleanups, test improvements, and API hardening. The most user-visible changes …

Silent Payments API no longer aborts on empty input/output arrays; returns 0 per documented behaviorSilent Payments label-tweak overflow now rejected with ARG_CHECK instead of being silently handledecmult_const gains a _ge variant that clears intermediate Jacobian coordinates to reduce secret leakage
c3d1b4c0by merge-script+902−49134 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36867: test: remove legacy wallet leftovers from wallet functional tests

This commit only cleans up Bitcoin Core's own functional test suite. It removes unused multisig test code, fixes outdated docstrings, and drops a no-longer-needed command-line flag in test scripts. None of these changes affect the actual B…

c138ff92by merge-script+40−923 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36914: test: simplify wallet_basic and rpc_getblockfilter tests

This commit only cleans up two internal test scripts for the Bitcoin Core project. It replaces a manual network disconnect/reconnect pattern with a simpler way to create an unconnected block header, and removes a hard-coded number in favor…

079437ccby merge-script+6−112 files
No security note in commit
Informational 15 AI analysisMessage 82 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

test: Drop hard-coded magic 3

This is a tiny code cleanup in a Bitcoin Core test file. It replaces the hard-coded number 3 with the actual number of test nodes, making the test slightly easier to maintain. It does not change any real Bitcoin Core software behavior and …

1eeeee49by MarcoFalke+3−31 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36864: rpc: deprecate iswatchonly field of getaddressinfo

This change hides an old, always-false field called 'iswatchonly' from the getaddressinfo API response unless the user explicitly asks for deprecated features. It is a routine cleanup, not a security fix, and does not change how wallets or…

66531447by merge-script+16−34 files
No security note in commit
Informational 15 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36868: test: remove unused nodes and restarts from wallet tests

This commit only cleans up Bitcoin Core's own automated test suite. It removes unused test nodes and an unnecessary double restart in a few wallet-related test scripts. There is no change to the actual Bitcoin node software that users run,…

0fb50460by merge-script+24−324 files
No security note in commit
Moderate 68 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36894: net_processing: set fDisconnect instead of calling DisconnectNode

This change fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one peer misbehaved. The problem is especially bad for users connecting through Tor, because all Tor traffic exits through a small set …

Denial of service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-to-peer network isolation of inbound connections
6832a273by merge-script+5−53 files
Vendor flagged security relevance
Moderate 62 AI analysisMessage 73 · Adequate
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

net_processing: set fDisconnect instead of calling DisconnectNode

This commit fixes a bug where Bitcoin Core would disconnect every peer sharing the same IP address when one of them misbehaved. Because Tor exit nodes share a single IP address among many users, a malicious user could deliberately misbehav…

Denial-of-service via shared IP disconnectTor exit-node IP collision exploited to disconnect honest peersPeer-disconnection logic changed from subnet match to single-node flag
d63068c5by Eugene Siegel+5−53 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 81 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36875: scripted-diff: Drop `IWYU pragma: keep` from build config includes

This change is purely a code-cleanup and linting improvement. It removes repetitive 'IWYU pragma: keep' comments from build-config header includes and instead marks the generated config header itself with a single 'always_keep' pragma. The…

1fbb5253by merge-script+67−7265 files
No security note in commit
Informational 19 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36451: refactor: Use NotNull for CreateNewBlock and pimpls

This is a code cleanup change that makes the type system express 'this pointer can never be null' for several internal objects and for block templates. It removes redundant null checks and adds helper functions to create such non-null poin…

No security-relevant bug is patchedChange is purely a type-system refactorRemoves dead null-check error paths rather than adding safety checks
8130b3b8by Ryan Ofsky+78−5230 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36848: test: drop flaky "server too slow" check from interface_http.py

This commit only changes a test file to make a timing check less strict. It removes an upper-bound timing assertion that was causing false test failures on slow CI machines. There is no change to Bitcoin Core's actual network or wallet cod…

e1a27bbbby merge-script+6−61 file
No security note in commit
Informational 20 AI analysisMessage 91 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36488: rpc: wallet: Schedule mixed-case confTarget option deprecation

This commit is a routine cleanup, not a security fix. It removes support for an old, confusingly-named option ('confTarget') in two Bitcoin wallet commands (bumpfee and psbtbumpfee), leaving only the clearer 'conf_target' name unless the u…

8b0b5775by merge-script+24−34 files
No security note in commit
Informational 15 AI analysisMessage 96 · Strong
BC Bitcoin CoreBitcoin Core BitcoinSupply chain

Merge bitcoin/bitcoin#36408: test: allow 3 bytes of fee overestimate in assert_fee_amount

This is a tiny change to a Bitcoin Core test helper that makes fee-checking tests slightly more tolerant. It is not a security fix and does not affect production wallet code or consensus rules. It simply reduces how often an extremely rare…

dd9d016bby merge-script+3−21 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityMerge bitcoin/bitcoin#36462: rpc: fix OpenRPC hex pattern to allow empty stringsby merge-script · 282a05b8 · Oct 8, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36462: rpc: fix OpenRPC hex pattern to allow empty strings

4d7e00d36bf0d287dc241c3aae3852f3d799ed08 rpc: Fix OpenRPC hex pattern to allow empty strings (ViniciusCestarii)

Pull request description:

The OpenRPC schema from `getopenrpcinfo` declares every `STR_HEX` value with the pattern `^[0-9a-fA-F]+$`. That pattern rejects the empty string, but the node both returns and accepts empty hex. For example:

- `scriptSig.hex` is `""` for native segwit input (`decoderawtransaction`, `getrawtransaction`, etc)
- `decodescript ""` succeeds

So a client that validates traffic against the schema rejects valid requests and responses.

This changes the pattern to `^([0-9a-fA-F]{2})*$` (zero or more hex-encoded bytes)

ACKs for top commit:
maflcko:
lgtm ACK 4d7e00d36bf0d287dc241c3aae3852f3d799ed08
sedited:
ACK 4d7e00d36bf0d287dc241c3aae3852f3d799ed08
willcl-ark:
ACK 4d7e00d36bf0d287dc241c3aae3852f3d799ed08

Tree-SHA512: 68a9798dbdc7f6369313934b72876ba90e3bdc3d5320dbbfe72ae6ba9a51b27ff723c09979b808088e7a6bc60a15353f5c1d0c9dfb879154239bfaeb3e4ad231

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationmerge-commit duplicate discount
Lower-priorityrpc: Fix OpenRPC hex pattern to allow empty stringsby ViniciusCestarii · 4d7e00d3 · Oct 7, 2026 · 2 filesMessage 50 · ThinTriage 0Details
Commit message · ViniciusCestarii

rpc: Fix OpenRPC hex pattern to allow empty strings

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Lower-priorityMerge bitcoin/bitcoin#36418: kernel: document that btck_WriteBytes may receive a null pointerby merge-script · db0bde16 · Oct 7, 2026 · 1 fileMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36418: kernel: document that btck_WriteBytes may receive a null pointer

b497a71c6630fe37f25620f9f08f1c52f9d4d558 kernel: document that btck_WriteBytes may receive a null pointer (Alexander Wiederin)

Pull request description:

The header does not say whether the bytes pointer can be null when size is zero. It can: `btck_witness_stack_get_item_at` passes `std::vector::data()` straight through, and that may be null for an empty element.

An alternative is to guarantee non-null rather than document that it isn't. In other words, route the vector-backed writer calls through a helper that substitutes a valid, never-read pointer when the buffer is empty.

ACKs for top commit:
stickies-v:
ACK b497a71c6630fe37f25620f9f08f1c52f9d4d558
sedited:
ACK b497a71c6630fe37f25620f9f08f1c52f9d4d558

Tree-SHA512: bdcdf8e3ad1e1822af36e5c2014fd7e1aa69169a00a102aad2f1219ebe5cfa9d8c1c6ea56178f3b9437bf42804b7bcc80a83734595e0e79dfc01073678e74806

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge bitcoin/bitcoin#36447: test: Misc fixes for pending validation events racesby merge-script · 9dfde64c · Oct 7, 2026 · 15 filesMessage 100 · StrongInformational 17Details
Commit message · merge-script

Merge bitcoin/bitcoin#36447: test: Misc fixes for pending validation events races

fa466dea808dedfc281cdff842cbefafae574d8a test: Avoid pending validation events from TestChain100Setup (MarcoFalke)
fa339713dbc58e36b0da0f2f1cce8a231939893f test: Drain all validation events before stopping indexes (MarcoFalke)
fa21ac647dc2e28f3b67ea0f057393a3b61e0aa6 test: [move-only] wallet rescan tests to separate TU (MarcoFalke)

Pull request description:

`TestChain100Setup` enqueues 100 validation events from blocks. Unit tests using that setup and their own validation events may run into non-determinism and even intermittent test failures.

Fix all issues by draining the pending validation events in the ctor.

This can be tested with a diff like:

```diff
diff --git a/src/validationinterface.cpp b/src/validationinterface.cpp
index 128f14a6d5..2ea3ec8d4c 100644
--- a/src/validationinterface.cpp
+++ b/src/validationinterface.cpp
@@ -14,2 +14,3 @@
#include <primitives/transaction.h>
+#include <random.h>
#include <util/check.h>
@@ -156,2 +157,4 @@ void ValidationSignals::SyncWithValidationInterfaceQueue()

+static FastRandomContext g_rnd{};
+
// Use a macro instead of a function for conditional logging to prevent
@@ -168,2 +171,3 @@ void ValidationSignals::SyncWithValidationInterfaceQueue()
LOG_EVENT("%s", local_log_msg); \
+ UninterruptibleSleep(1ms * g_rnd.randrange(105)); \
local_event(); \
```

and then running the test `scan_for_wallet_transactions_attach_chain` a few times.

Or master (or the first commit), it should fail with: `error: scan_for_wallet_transactions_attach_chain": check wallet->mapWallet.size() == static_cast<size_t>(NEW_BLOCKS + 1) has failed [7 != 6]`.

(Also included is a commit to move-only the many rescan tests to a separate file)

(Also included is a commit to fix unsafe index shutdowns in tests)

ACKs for top commit:
willcl-ark:
reACK fa466dea808dedfc281cdff842cbefafae574d8a
sedited:
ACK fa466dea808dedfc281cdff842cbefafae574d8a

Tree-SHA512: 3e3e57f373f150fecaef397e95ff0d6a120fea1fd7768e4de4f79708ed09e6b73311afb662a4d7967b5beddc53d28677e3707208e0da95752139d9adba76d559

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 17/100

This commit fixes timing problems in Bitcoin Core's own unit and benchmark tests. It does not change how the live Bitcoin node behaves. The changes make test setups wait for background 'validation' notifications to finish before tests run or shut down, which removes random test failures and unsafe shutdown races during testing. A large block of wallet rescan tests was also moved to a new file with no functional changes.

Lower-priorityMerge bitcoin/bitcoin#36029: cmake: Detect and log MinGW-w64 version when cross-compiling for Windowsby merge-script · 35e3c932 · Oct 7, 2026 · 2 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36029: cmake: Detect and log MinGW-w64 version when cross-compiling for Windows

09cdb3c48872b7a89a70abfaba86830655cc5007 cmake: Detect and log MinGW-w64 version when cross-compiling for Windows (Hennadii Stepanov)

Pull request description:

The behaviour of cross-compiled Windows binaries depends heavily on the toolchain components, including [MinGW-w64](https://www.mingw-w64.org/). When the toolchain is not provided by a distro package manager, determining the exact version being used can be difficult.

This PR detects and logs the MinGW-w64 version when cross-compiling for Windows, simplifying debugging when issues like [this](https://github.com/bitcoin/bitcoin/pull/34578#issuecomment-5344520378) arise.

ACKs for top commit:
willcl-ark:
ACK 09cdb3c48872b7a89a70abfaba86830655cc5007
ViniciusCestarii:
tACK 09cdb3c48872b7a89a70abfaba86830655cc5007
sedited:
ACK 09cdb3c48872b7a89a70abfaba86830655cc5007

Tree-SHA512: b6504e0db0f858c687cf9aaff742fb4ab70f8cedae7cf36230e3c435a5e1e4be1683ab5d60e237bc5cec1e8dd76c54398878404ab6908f61fa1be055d7a36108

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36392: test: Extract and use sigterm_node in init_fd_overflow_testby merge-script · ff623cfa · Oct 7, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36392: test: Extract and use sigterm_node in init_fd_overflow_test

fad49a733d611f6d49ab9cb80509b79af500b384 test: Extract and use sigterm_node in init_fd_overflow_test (MarcoFalke)

Pull request description:

Fixes https://github.com/bitcoin/bitcoin/issues/36388 (llvm-symbolizer broken pipe complaints) by replacing the unclean Bitcoin Core shutdown with a clean one in `init_fd_overflow_test`.

ACKs for top commit:
fametrano:
ACK fad49a733d611f6d49ab9cb80509b79af500b384
sedited:
ACK fad49a733d611f6d49ab9cb80509b79af500b384

Tree-SHA512: 8cabb77a92686c8bd68ab3d6febd0d4dcb11cd8b36b04471adb19665c996962866ff4144ca0ca2e96216eda2d4e1201e236664915bbe470c2892b6948196f613

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
memory safetymerge-commit duplicate discount
AI analysis · Informational 15/100

This is a test-only code cleanup. It changes how a Bitcoin Core test shuts down a node during one specific test scenario, replacing a force-kill with a cleaner signal-based shutdown. It does not affect the live Bitcoin Core software that users run, and it does not fix a security vulnerability.

Lower-priorityMerge bitcoin/bitcoin#34844: util: Add util::NotNull<SmartPtrType>by merge-script · 9523d2b4 · Oct 7, 2026 · 13 filesMessage 81 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#34844: util: Add util::NotNull<SmartPtrType>

fa42e2868414544503dcd9ae4bd74c911fedee80 refactor: Return util::NotNull<std::unique_ptr<ChangeSet>> from CTxMemPool::GetChangeSet() (MarcoFalke)
fa04fafb3aac3666599445f0944090e9d52b41a0 refactor: In CNode use util::NotNull<std::unique_ptr<Transport>> m_transport (MarcoFalke)
fae9ab0f0dc40b318d71d3756b55504b95b6c421 refactor: Use NotNull pointer to input fetching pool (MarcoFalke)
fa0184afa2f92a3056a905ef17448a744fafcbe2 refactor: Use util::NotNull<std::unique_ptr<LevelDBContext>> m_db_context (MarcoFalke)
fafa44e020ab7783515c3176f2205d47e6bc99c3 util: Add util::NotNull<SmartPtrType> (MarcoFalke)

Pull request description:

The C++ standard library lacks a type to denote a smart pointer is not null. For raw pointer there is `std::reference_wrapper`, or a plain reference.

Other third-party libraries provide such a type, such as `gsl::strict_not_null`.

Fix all issues by adding `util::NotNull<SmartPtrType>`, which documents (and checks) that the inner pointer is never null.

This type can be used when passing never-null smart pointers between functions. It removes the need to `Assert()` the pointer before dereference. For example, in a getter function:

```cpp
util::NotNull<std::unique_ptr<Stats>> GetStats()
{
return util::NotNull{std::make_unique<Stats>()};
}

int main()
{
auto stats{GetStats()};
stats->foo; // This can never lead to a nullptr deref
// Assert(stats)->foo; // This is redundant and won't compile
}
```

Fixes https://github.com/bitcoin/bitcoin/issues/24423

ACKs for top commit:
l0rinc:
quick diff review ACK fa42e2868414544503dcd9ae4bd74c911fedee80
sedited:
Re-ACK fa42e2868414544503dcd9ae4bd74c911fedee80
stickies-v:
re-ACK fa42e2868414544503dcd9ae4bd74c911fedee80

Tree-SHA512: d467d558715e60990b52536aa9520fda99fdb7e4404f24cbcc7d7d0ef50a88dd72f1a7d7944098513bfe7add4ce8efabe42b151504debcf171c9cb6ec944ce67

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36338: BIP-352: fix P2PKH pubkey extraction from malleated scriptSigby merge-script · 14a328f7 · Oct 7, 2026 · 2 filesMessage 100 · StrongModerate 62Details
Commit message · merge-script

Merge bitcoin/bitcoin#36338: BIP-352: fix P2PKH pubkey extraction from malleated scriptSig

cdfaa534d006f0effeb0ece3fb9aa5e53177a3fd BIP-352: fix P2PKH pubkey extraction from malleated scriptSig (Sebastian Falbesoner)
c35b99251450c9c8edd36b3e2a7594aa57a7f426 test: characterize buggy BIP-352 P2PKH extraction on malleated scriptSig (Sebastian Falbesoner)

Pull request description:

This PR fixes a Silent Payments pubkey extraction issue for P2PKH inputs: a third party can malleate the `scriptSig` such that it contains an OP_CHECKSIG that fails in real validation but succeeds with the dummy signature checker currently used (which accepts any non-empty signature). E.g. for a P2PKH spend with scriptSig

`<sig> <pubkey> <bogus_sig> OP_OVER OP_CHECKSIG OP_IF <wrong_pubkey> OP_ENDIF`

the `EvalScript` call would currently result in `wrong_pubkey` as the top stack item instead of `pubkey` and thus lead to an incorrect extraction (see the test added in the first commit). Fix this by parsing the scriptSig manually via a `.GetOp(...)` iteration, looking at all 33-byte data pushes to find the one where the Hash160 (SHA-256 + RIPEMD-160) matches the one in the output script.

Note that an alternative fix would be to keep using `EvalScript` but use an actual signature checker instead of the dummy one, but for that we need more transaction data in order to enable sighash calculation. Also involving a full script interpreter run including signature checks merely for extracting a public key seems overblown.

This issue was reported by [Project Loupe](https://github.com/project-loupe/) earlier this week (thanks!). From what I saw, none of the existing Silent Payments implementations are affected. I'm planning to add the test case to the BIP-352 test vectors in the BIPs repository as well, next to the existing ones that cover P2PKH malleation.

ACKs for top commit:
achow101:
ACK cdfaa534d006f0effeb0ece3fb9aa5e53177a3fd
fametrano:
tACK cdfaa534d006f0effeb0ece3fb9aa5e53177a3fd
Yudis-bit:
Tested ACK cdfaa534d006f0effeb0ece3fb9aa5e53177a3fd
sedited:
ACK cdfaa534d006f0effeb0ece3fb9aa5e53177a3fd

Tree-SHA512: 45a8027d854e8f63d696aca4a885d94308082e134261d6a0d1dfc470838cfdf89d000a71d1d28599766654caeada700855346f5708ad81dfea50d71c4cda8b16

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundaryfuzzing or regression evidencemerge-commit duplicate discount
AI analysis · Moderate 62/100

This update fixes a bug in how Bitcoin Core extracts public keys from certain old-style (P2PKH) transaction inputs when calculating Silent Payments. A troublemaker could tweak the input's script so that, during normal Bitcoin validation, the real public key is used, but the previous extraction method would pick a fake public key instead. That could cause a Silent Payments receiver to compute the wrong payment address and miss a payment. The fix manually scans the input for the public key whose fingerprint matches the output, instead of running the script with a dummy signature checker.

AI review queuedMerge bitcoin/bitcoin#36432: wallet: show real fee_reason strings in helpby merge-script · 5661a65c · Oct 7, 2026 · 4 filesMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36432: wallet: show real fee_reason strings in help

781d8dbd500d4f7b6577ed4b37d1d913c25052af wallet: show real fee_reason strings in help (Jehudi Castro-Sierra)

Pull request description:

The verbose help for sendtoaddress and sendmany paraphrased
fee_reason and left out "User Specified Fee". The strings the RPC
returns are the ones in StringForFeeReason.

Join that map for both help lines, the same way estimate_mode help
is built from FeeModeMap, so the list cannot drift again.

wallet_basic.py checks that an explicit fee_rate returns
"User Specified Fee" for sendtoaddress and sendmany.

ACKs for top commit:
maflcko:
lgtm ACK 781d8dbd500d4f7b6577ed4b37d1d913c25052af
ismaelsadeeq:
Code review ACK 781d8dbd500d4f7b6577ed4b37d1d913c25052af
sedited:
ACK 781d8dbd500d4f7b6577ed4b37d1d913c25052af

Tree-SHA512: 83a8cc240dffeab5b01cb54f146b38e63499f893163ae4c6ee184e23e658ea054c5a7e28cc12e02e15c084352808b3a4eefe4a96216accead9010163d529d0da

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This change only updates the help text shown by two wallet RPC commands (sendtoaddress and sendmany) so the list of possible fee reasons matches the actual strings returned by the software. It also adds a test to confirm that an explicit fee rate returns the string 'User Specified Fee'. There is no security issue here—just a documentation/help-text consistency fix.

Security candidateMerge bitcoin/bitcoin#36448: randomenv: use `KERN_POSIX1` over `KERN_OSREV`by merge-script · 672c2d21 · Oct 7, 2026 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36448: randomenv: use `KERN_POSIX1` over `KERN_OSREV`

d1f9a5b3e05082b99880c13a156f50e5239c1a26 randomenv: use KERN_POSIX1 over KERN_OSREV (fanquake)

Pull request description:

Given we are checking if `KERN_POSIX1` is defined, and `KERN_OSREV` is used above.

ACKs for top commit:
maflcko:
lgtm ACK d1f9a5b3e05082b99880c13a156f50e5239c1a26
sedited:
ACK d1f9a5b3e05082b99880c13a156f50e5239c1a26

Tree-SHA512: 0300693cc00239c724db11a2dd40ae7c3a7a0b8f85ace2eeb80560958b68ce6ab73e780203cc0e080bce0741487babe0ab032c1eeb523ba5ab867e3dc4f9deba

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
seed or entropy pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This is a one-line code cleanup in Bitcoin Core's random environment data gathering. The code was supposed to add a 'POSIX version' system value to the randomness pool when that value is available, but it accidentally added the 'OS revision' value twice instead. The fix makes the code do what the surrounding preprocessor guard already intended. It does not change security meaningfully: both values are harmless system identifiers used only as extra entropy input, and the OS revision was already being collected earlier in the same function.

Security candidateMerge bitcoin/bitcoin#36291: test: add script_tests cases covering interpreter mutantsby merge-script · 6b8a5524 · Oct 7, 2026 · 1 fileMessage 100 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36291: test: add script_tests cases covering interpreter mutants

efe0dfcf1e5c431c62dc9ac4fd2c2d97a62814fe test: cover DERSIG 9-byte signature lower bound (ViniciusCestarii)
bbc4bdf9092efb218202dceefbacda57d5513e1d test: cover DERSIG null S byte only when S is multi-byte (ViniciusCestarii)
fd2cf0450276e9f503570eda5639966ce81065e5 test: cover DERSIG null R byte only when R is multi-byte (ViniciusCestarii)
a1deba78c5f668eaab359b8e54ac93df02f4ce37 test: cover DERSIG total-length byte check (ViniciusCestarii)
3d04ed8ac77bf930d7b1d6dd11701417ff53a0d6 test: cover DERSIG 73-byte signature upper bound (ViniciusCestarii)
2c0f69a0478947de26d544c1b9b42a7d1eebd42f test: cover STRICTENC rejects bad 33-byte pubkey prefix (ViniciusCestarii)

Pull request description:

Kills some live mutants on `interpreter.cpp` found by https://bitcoincore.space. They are:

[interpreter.cpp#5168](https://bitcoincore.space/src/script/interpreter.cpp#5168): `IsCompressedOrUncompressedPubKey`: pubkey with neither compressed nor uncompressed prefix returns `true`

```diff
- } else if (vchPubKey[0] == 0x02 || vchPubKey[0] == 0x03) {
+ } else if (1==1) {
```

[interpreter.cpp#5191](https://bitcoincore.space/src/script/interpreter.cpp#5191): `IsValidSignatureEncoding`: 73-byte upper bound returns `true`

```diff
if (sig.size() < 9) return false;
- if (sig.size() > 73) return false;
```

[interpreter.cpp#5200](https://bitcoincore.space/src/script/interpreter.cpp#5200): `IsValidSignatureEncoding`: total-length byte check returns `true`

```diff
// Make sure the length covers the entire signature.
- if (sig[1] != sig.size() - 3) return false;
```

[interpreter.cpp#5232](https://bitcoincore.space/src/script/interpreter.cpp#5232): `IsValidSignatureEncoding`: null R byte check `lenR > 1` -> `lenR >=1`

```diff
// Null bytes at the start of R are not allowed, unless R would
// otherwise be interpreted as a negative number.
- if (lenR > 1 && (sig[4] == 0x00) && !(sig[5] & 0x80)) return false;
+ if (lenR >= 1 && (sig[4] == 0x00) && !(sig[5] & 0x80)) return false;
```

[interpreter.cpp#5259](https://bitcoincore.space/src/script/interpreter.cpp#5259): `IsValidSignatureEncoding`: null S byte check `lenS > 1` -> `lenS >= 1`

```diff
// Null bytes at the start of S are not allowed, unless S would otherwise be
// interpreted as a negative number.
- if (lenS > 1 && (sig[lenR + 6] == 0x00) && !(sig[lenR + 7] & 0x80)) return false;
+ if (lenS >= 1 && (sig[lenR + 6] == 0x00) && !(sig[lenR + 7] & 0x80)) return false;
```

[interpreter.cpp#5186](https://bitcoincore.space/src/script/interpreter.cpp#5186): `IsValidSignatureEncoding`: 9-byte lower bound returns `true`

```diff
// Minimum and maximum size constraints.
- if (sig.size() < 9) return false;
```

The first affects policy only, the next four affect consensus, and the last covers the lower bound and lets ASan catch UB: a 3-byte signature reaches the `sig[3]` read that the `sig.size() < 9` guard protects.

Recommend reviewing per commit.

ACKs for top commit:
fametrano:
ACK efe0dfcf1e5c431c62dc9ac4fd2c2d97a62814fe
brunoerg:
reACK efe0dfcf1e5c431c62dc9ac4fd2c2d97a62814fe
sedited:
ACK efe0dfcf1e5c431c62dc9ac4fd2c2d97a62814fe

Tree-SHA512: 6ce18dd013b65275fa5fd6d6c7752a8fcc0283648dc0a56411c37f3afa6da4125d7f849174f78475500800495d47131c1d91b42ee2967ad2c87cc967fb2a097a

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundaryconsensus or confidential-proof validationmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds new test cases to Bitcoin Core's script test data file. It does not change any production code, so it cannot introduce a security vulnerability on its own. The tests are designed to detect certain incorrect code changes ('mutants') in the script interpreter's signature and public-key validation logic, but the actual interpreter code remains unchanged.

Lower-priorityMerge bitcoin/bitcoin#36340: util: cap Sock::WaitMany timeout to fix -rpcclienttimeout=0 on macOSby merge-script · 14f89aee · Oct 7, 2026 · 2 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36340: util: cap Sock::WaitMany timeout to fix -rpcclienttimeout=0 on macOS

8dcf90a9b320c791f49f78de3b1094f54068e339 util: cap Sock::WaitMany timeout (Kanan)

Pull request description:

`bitcoin-cli -rpcclienttimeout=0` is documented as "no timeout", but on macOS it fails with "Could not connect to the server" since #34342 (it's in v32.0rc1/rc2).

bitcoin-cli turns 0 into `std::chrono::years(5)` and passes it to `Sock::Wait`. On platforms without `USE_POLL` (everything except Linux) `WaitMany` uses `select()`, and macOS returns EINVAL for timeouts above 10^8 seconds. Five years is about 1.58 * 10^8 s. The same happens with any explicit value above 10^8, e.g. `-rpcclienttimeout=110000000`. On Linux, `poll()` takes the timeout as an int, so the millisecond count gets narrowed. For five years this happens to wrap to a negative value, which means infinite, so it works there by accident.

This caps the timeout in `Sock::WaitMany` at INT_MAX milliseconds (about 24.8 days). That fits `poll()` and is below the 31 days POSIX requires `select()` to support. Doing it in `WaitMany` covers every caller, not only bitcoin-cli.

The new `sock_tests/wait_large_timeout` test waits with a 5 year timeout on a socket that already has data. It fails on master on macOS and passes with this change. I also checked by hand on macOS that `-rpcclienttimeout=0`, `157784760` and `2147483647` work against a running node, and `interface_bitcoin_cli.py` still passes.

This doesn't overlap with #36299, which changes how the timeout is counted but still passes the 5 year value down.

ACKs for top commit:
fjahr:
ACK 8dcf90a9b320c791f49f78de3b1094f54068e339
winterrdog:
tested ACK 8dcf90a9b320c791f49f78de3b1094f54068e339
ismaelsadeeq:
Tested ACK 8dcf90a9b320c791f49f78de3b1094f54068e339
pinheadmz:
ACK 8dcf90a9b320c791f49f78de3b1094f54068e339

Tree-SHA512: 997c9363c7645d260c0d774e63247b5d6a92e07d26b849976f3c1b7ce7064e2e175df5f9e39472d49ecc2ff99c239b170b492e48734d2c8f9362b2a9ed98ecea

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateTest: Cover malformed merkle trees and nBitsby benthecarman · 0c0e6ba0 · Oct 7, 2026 · 2 filesMessage 90 · StrongInformational 15Details
Commit message · benthecarman

Test: Cover malformed merkle trees and nBits

Add tests for malformed partial merkle trees, including the
transaction count limit at its 16666 boundary, and for GetBitsProof
returning zero for zero, negative and overflowing targets.

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
memory safety
AI analysis · Informational 15/100

This commit only adds new unit tests. It does not change any production code, so it cannot introduce a runtime vulnerability or fix one directly. The tests exercise existing validation behavior for malformed merkle-tree data and invalid proof-of-work target encodings, confirming that the current code rejects them.

Lower-priorityMerge bitcoin/bitcoin#36435: ci: isolate container test networksby merge-script · aef8a049 · Oct 6, 2026 · 3 filesMessage 100 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36435: ci: isolate container test networks

fa966fd76764a0e150f654d7c2760e58226edba5 ci: Use one subnet per container (MarcoFalke)
fae564e66ab46bf35edb27ae2c1f42ec4dcdba77 ci: Use one network per container and rm it after success (MarcoFalke)

Pull request description:

Fixes https://github.com/bitcoin/bitcoin/issues/35416, by:

* First, a general CI cleanup to use one network per CI container and remove it after success
* Then, to use one subnet per container and a unique IP in that subnet (to avoid collisions)

ACKs for top commit:
willcl-ark:
ACK fa966fd76764a0e150f654d7c2760e58226edba5
sedited:
utACK fa966fd76764a0e150f654d7c2760e58226edba5

Tree-SHA512: 9f25500df50d20a12518fce8b4082a3b1d567dd5f065d0548d28314d335c01357db130794c4ebf2a29049c10fae6c57f66c44404c02ff5488ec0e49b3ce7ff23

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge bitcoin/bitcoin#36308: test: Set tsan enable_adaptive_delay=1 by defaultby merge-script · 3cb91bc7 · Oct 6, 2026 · 8 filesMessage 91 · StrongTriage 0Details
Commit message · merge-script

Merge bitcoin/bitcoin#36308: test: Set tsan enable_adaptive_delay=1 by default

fa0d826eac336238642428a14db9d122aa6ecd4d test: Use sanitizer env in functional tests by default (MarcoFalke)
fafce3be39a267e5fa61943b51eb7f5726e9359b test: Set tsan enable_adaptive_delay=1 by default (MarcoFalke)
faf907fd1391884e3289451fc2b6750c078515e2 test: Add with_sanitizer_env.py (MarcoFalke)
fad2fc5a0f02f078ef8eed2a2228f3abcf104c9a doc: Remove section on how to install libasan etc (MarcoFalke)

Pull request description:

There are several small sanitizer option issues:

* Using the project's default settings outside of CI is only possible manually
* Modifying the project's default requires modifying three places (docs, ci, and the fuzz runner)

Fix both issues by adding a `with_sanitizer_env.py ...cmd...` command wrapper that sets the default values.

Also, enable https://clang.llvm.org/docs/ThreadSanitizer.html#adaptive-delay, which may help to find some kind of rare races more frequently.

ACKs for top commit:
Conradgabe:
tACK fa0d826eac336238642428a14db9d122aa6ecd4d
BrandonOdiwuor:
ACK fa0d826eac336238642428a14db9d122aa6ecd4d
sedited:
utACK fa0d826eac336238642428a14db9d122aa6ecd4d

Tree-SHA512: e52c574ad328fc7630eecec059fc2d9f20ee1d619018b6917239e031e3ffa2e2c9cce090586cadf2a79575a4f3234ba52cc8271ffa73c0a5c247f153f84a2bbd

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationfuzzing or regression evidencemerge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#36152: test: cover the feature-negotiation version boundary in p2p_leakby merge-script · acaf322f · Oct 6, 2026 · 2 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36152: test: cover the feature-negotiation version boundary in p2p_leak

2fabbc0bb38d0b87913d16777e25497ee6d017f0 test: check SENDTXRCNCL is sent at version 70016 (brunoerg)
36775471f81ab5ad8499bf0e1c8aab6545db9da6 test: cover the feature-negotiation version boundary in p2p_leak (brunoerg)

Pull request description:

p2p_leak already checks that a pre-wtxidrelay peer (nVersion 70015) is sent neither WTXIDRELAY nor SENDADDRV2, but nothing pins down the exact boundary: the feature negotiation messages are offered when the common version is >= WTXID_RELAY_VERSION (70016).

Add a peer advertising exactly 70016 and assert it receives both messages, so an off-by-one change of either `greatest_common_version >= WTXID_RELAY_VERSION` / `>= 70016` comparison to `>` is detected.

It kills https://bitcoincore.space/src/net_processing.cpp#3462 and https://bitcoincore.space/src/net_processing.cpp#3464

-----

edit: added a commit that adds a test case that checks `SENDTXRCNCL` is sent at version 70016. The existing 70015 case only shows SENDTXRCNCL is withheld below the wtxidrelay version. Add a peer at exactly 70016 so the lower bound of the `>= WTXID_RELAY_VERSION` check is covered too. It kills: https://bitcoincore.space/src/net_processing.cpp#3466.

ACKs for top commit:
Marisha-Sahay:
tACK 2fabbc0bb38d0b87913d16777e25497ee6d017f0
naiyoma:
tACK 2fabbc0bb38d0b87913d16777e25497ee6d017f0
sedited:
ACK 2fabbc0bb38d0b87913d16777e25497ee6d017f0

Tree-SHA512: 33d71176866b317063354880b4b465c9acb2737c7cba931a249faecc86fe30868caabf8cc69001f661163c2db58903ff3655c05a995a3233e9864ebdf2b3b551

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
access controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds new test cases to Bitcoin Core's functional test suite. It does not change any production networking code. The tests verify that peers advertising protocol version exactly 70016 receive expected feature-negotiation messages (WTXIDRELAY, SENDADDRV2, and SENDTXRCNCL), pinning down the lower boundary of an existing `>= 70016` check. There is no security vulnerability being fixed here.

Security candidateMerge bitcoin/bitcoin#36277: net: always complete all initial private broadcast connectionsby merge-script · f55788e8 · Oct 6, 2026 · 7 filesMessage 98 · StrongLow 39Details
Commit message · merge-script

Merge bitcoin/bitcoin#36277: net: always complete all initial private broadcast connections

00c1b52ee56b9a2f067befc56c171eef27efda41 net: remove PrivateBroadcast::DidNodeConfirmReception (Andrew Toth)
dc95a705d402d44b7092150878e33c75383a4d47 net: always complete all initial private broadcast connections (Andrew Toth)

Pull request description:

Make sure we send out all three connections when initiating a private broadcast.

Use `MarkResolved` instead of `Remove` to mark a tx as having been received back or mempool-conflicted. Prevent additional stale retry connections by tracking disconnects and explicitly granting new connections with `TryGrantRetry`.

Intended as an alternative to #34707, addressing the theoretical timing attack described in https://github.com/bitcoin/bitcoin/pull/34707#issuecomment-5603256702. Also fixes theoretical timing attacks described in https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2035693786. This is based on the idea described in https://github.com/bitcoin/bitcoin/pull/29415#discussion_r2037527330:

> always send 3 times regardless if the tx is received in our mempool or is otherwise invalid

ACKs for top commit:
vasild:
ACK 00c1b52ee56b9a2f067befc56c171eef27efda41
mzumsande:
Code Review ACK 00c1b52ee56b9a2f067befc56c171eef27efda41
sedited:
utACK 00c1b52ee56b9a2f067befc56c171eef27efda41

Tree-SHA512: 82c03898e9377f9702ee4e01a3a68cd2071fe6e137c531812761da145acb16780ca866b33c7ffbd2db5db100e203b27095ae9e9745c012e317434cd2f5368847

98/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languageconstant-time or timing behaviormerge-commit duplicate discount
AI analysis · Low 39/100

This Bitcoin Core patch fixes a privacy weakness in how new transactions are first announced to the network. Previously, if the node saw its own transaction come back from another peer quickly, it would cancel the remaining private broadcast connections. An attacker who can race the transaction back to the node could reduce how many independent peers receive it, making it easier to guess which peer originally created the transaction. The patch now always completes all three initial private broadcast sends, even after the transaction is seen again, and only stops further retries. It also tracks disconnects more carefully so failed sends are replaced rather than silently dropped.

Security candidateMerge bitcoin/bitcoin#34729: Reduce log noiseby Ava Chow · cf80493e · Oct 5, 2026 · 13 filesMessage 76 · AdequateInformational 22Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#34729: Reduce log noise

91f8b365e7e7887e59240651c2c76b1a64071233 validation: Upgrade log levels for possible block corruption warnings (Anthony Towns)
788242d6d009e57cdf9f132bea1a6aee1c23c6f5 txindex: Downgrade log messages and include index name (Anthony Towns)
93b9613b764a046148b426abf63d1a1f5058f019 kernel/coinstats: Downgrade ComputeUTXOStats log level (Anthony Towns)
3c4336631e3d05705521cc5c1001b73bc5a6cd1d script: Lower level of oversized redeemScript log, push errors to callers (Anthony Towns)
7902a8ee83fc1b81e29710b0b00b2316b42cacef netbase: Tidy up logging levels (Anthony Towns)
4f42b76ca76b54de5b4794e2402aaa5ea2925862 netbase: Reduce levels of socks5 error logging (Anthony Towns)
ec627b3f3b82929bf517fd5d00d0ea54f4fcc187 util/log: Add LogWarnThenDebug() helper (Anthony Towns)

Pull request description:

This set of changes reduces some of the exaggerated logging that was introduced in #29236 when "error()" logging was upgraded from `LogPrintf` (aka `LogInfo`) to `LogError`. It also introduces `LogWarnThenDebug()` which duplicates the behaviour of #34549 which issues a warning the first time the log line is hit, but downgrades that to categorized debug messages afterwards. This function is used for failures that are likely caused by system configuration problems (so likely degrade the node's functionality and warrant admin attention) but are triggered by remote activity and thus could occur frequently.

ACKs for top commit:
achow101:
ACK 91f8b365e7e7887e59240651c2c76b1a64071233
l0rinc:
lightweight re-ACK 91f8b365e7e7887e59240651c2c76b1a64071233
sedited:
Re-ACK 91f8b365e7e7887e59240651c2c76b1a64071233

Tree-SHA512: a90fc070f378322c336f7169aaf9545bca65c93078ea5b86a59585fb72d01196a7f3fd5d28a172d49c5d6c2abf61ba4b0d7dca4783965ae827631543cc3940d8

76/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
update trustsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 22/100

This commit is a logging cleanup. It reduces the severity of many routine or remote-triggered error messages so they don't flood node operators with false alarms, and adds a helper that issues a warning only the first time a problem occurs then switches to debug-level logs. It is not a security fix for a vulnerability.

Lower-priorityMerge bitcoin/bitcoin#36303: http: Log bytes received from client, use to replace receive-throttle regression testby Ava Chow · 2c992472 · Oct 5, 2026 · 3 filesMessage 91 · StrongTriage 0Details
Commit message · Ava Chow

Merge bitcoin/bitcoin#36303: http: Log bytes received from client, use to replace receive-throttle regression test

493850c4c4734acce0f75d1efcffb3868d4235fc test: assert HTTP receive throttle from server-side log (Matthew Zipkin)
767d86aaa780b81d0d3eede9ebb313cc100f4643 http: log received bytes per client read (Matthew Zipkin)

Pull request description:

Closes #36216

Improves and fixes the test introduced by #36123 to cover regressions in the server's receive throttle. The original test relied on client-side signals to assert server-side behavior which can easily be disrupted by a platform's TCP stack. Macos for example may suddenly re-open a TCP window size based on heuristics out of our control (`SB_AUTOSIZE`), despite the application not reading any data from the socket. Macos also may delay transmission of data between 5-60 seconds as the TCP window shrinks (`TCPTV_PERSMIN` / `TCPT_PERSIST` / "silly window syndrome" avoidance). All these behaviors were observed by running the current CI test on my fork hundreds of times, capturing TCP packets and processing them locally against the CI debug log.

The improved approach is similar to how we test the send-side throttle in #36174 using debug log messages. This way we test the thing we know we can control (bitcoind).

To introduce the regression patched by #36123 and fail the new test:

```diff
diff --git a/src/httpserver.cpp b/src/httpserver.cpp
--- a/src/httpserver.cpp
+++ b/src/httpserver.cpp
@@ -1040,13 +1040,7 @@ HTTPServer::IOReadiness HTTPServer::GenerateWaitSockets() const
// before the next is taken and they stay separate critical sections.
// Holding m_sock_mutex while acquiring m_send_mutex would invert that
// order and risk a lock-order-inversion deadlock.
- Sock::Event event{0};
- if (http_client->ReadyToSend()) {
- event = Sock::SendEvent;
- } else if (http_client->GetRequest() != nullptr || http_client->ReceiveBufferEmpty()) {
- // Mid-parse (need more bytes) or buffer empty.
- event = Sock::RecvEvent;
- }
+ Sock::Event event = (http_client->ReadyToSend() ? Sock::SendEvent : Sock::RecvEvent);

io_readiness.events_per_sock.emplace(sock, Sock::Events{event});
io_readiness.httpclients_per_sock.emplace(sock, http_client);
```

For usual bitcoind activity, httpo debug logs will only grow by one extra line per request. Huge requests like those generated by the test may produce a hundred or so lines of "Received data" messages. These are optional debug lines in a worst-case scenario, but reviewers can discuss rate-limiting that log activity if we're afraid it's too much.

ACKs for top commit:
davidgumberg:
crtACK https://github.com/bitcoin/bitcoin/commit/493850c4c4734acce0f75d1efcffb3868d4235fc
achow101:
ACK 493850c4c4734acce0f75d1efcffb3868d4235fc
winterrdog:
tACK 493850c4c4734acce0f75d1efcffb3868d4235fc
ismaelsadeeq:
Code review ACK 493850c4c4734acce0f75d1efcffb3868d4235fc

Tree-SHA512: 2c501b69c1b3cebb7c15e574edf8d24f50a4c49af48073123f0864ac38813d696bca3ccb5dd86cd98b47eac77c71bb8943a974a35e81b0df8f9690d2239f2922

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
Security candidateMerge bitcoin/bitcoin#35873: test: add a tx_valid vector for CVE-2024-38365by merge-script · 09e22fbb · Oct 5, 2026 · 1 fileMessage 100 · StrongInformational 20Details
Commit message · merge-script

Merge bitcoin/bitcoin#35873: test: add a tx_valid vector for CVE-2024-38365

6cd2fa5fb4b6d25b8400d2a7683ceb78610c0b4f test: add a tx_valid vector for CVE-2024-38365 (JP)

Pull request description:

Suggested by darosior in #35835.

`FindAndDelete` only matches whole pushes at opcode boundaries, so a push that carries the signature inside its data is left in the scriptCode. btcd (<0.24.2) removed any push containing the signature, computed a different sighash, and would have rejected a transaction Core accepts: the chain split in [CVE-2024-38365](https://delvingbitcoin.org/t/cve-2024-38365-public-disclosure-btcd-findanddelete-bug/1184).

The rule is already covered from the failure side, in `script_FindAndDelete` and in the `tx_invalid.json` vectors where the signature sits under a non-standard pushdata prefix. What was missing is the positive direction: a transaction Core must accept because nothing is deleted.

This adds one vector to `tx_valid.json`, with `OP_CHECKSIGVERIFY <0xaaaa||sig>` as the P2SH redeemScript and the minimal 8-byte DER signature (r = s = 1). The pubkey is recovered from that signature and the sighash Core computes, so it verifies only if the `<0xaaaa||sig>` push survives into the scriptCode. `CONST_SCRIPTCODE` doesn't fire — `FindAndDelete` finds nothing — and the vector runs with every flag.

To check it actually discriminates, I patched `EvalChecksigPreTapscript` to drop any push whose data contains the signature, the way btcd did. The vector fails with that patch and passes without it.

Tested with:

```
build/bin/test_bitcoin --run_test=transaction_tests
```

ACKs for top commit:
fametrano:
ACK 6cd2fa5fb4b6d25b8400d2a7683ceb78610c0b4f
sedited:
ACK 6cd2fa5fb4b6d25b8400d2a7683ceb78610c0b4f

Tree-SHA512: a08412e00ed43570c3cf556da1d243a40b9684ce17eb6d3017267c3e5e82f9cde232e077944b0ec9476df70e767caf0fcd33be5473dfd53ed2241f7b24a33b1d

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
explicit security languagesigning boundaryaccess controlmerge-commit duplicate discount
AI analysis · Informational 20/100

This commit only adds a new test case to Bitcoin Core's transaction validation test data. The test confirms that Bitcoin Core correctly handles a specific signature-checking quirk that caused a bug in another Bitcoin implementation (btcd). It does not change any production code, so it cannot by itself introduce a vulnerability or fix one in Bitcoin Core. It is a regression-style test for a known, already-disclosed issue (CVE-2024-38365).

Security candidateMerge bitcoin/bitcoin#35835: test: add CONST_SCRIPTCODE failure-path vectors to script_tests.jsonby merge-script · b47ec7c6 · Oct 5, 2026 · 1 fileMessage 96 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#35835: test: add CONST_SCRIPTCODE failure-path vectors to script_tests.json

829e44a1151fa432f293554f25832f19bde209ec test: add CONST_SCRIPTCODE failure-path vectors to script_tests.json (JP)

Pull request description:

Follow-up to #35664.

Going through which script error codes `script_tests.json` covers, I found that neither error gated behind `SCRIPT_VERIFY_CONST_SCRIPTCODE` is asserted anywhere. `SCRIPT_ERR_SIG_FINDANDDELETE` is not asserted by any test; `SCRIPT_ERR_OP_CODESEPARATOR` appears only as a mempool reject string in `invalid_txs.py`, never at the script level. `tx_invalid.json` does have a `CONST_SCRIPTCODE` section, but those vectors can only say a transaction is invalid, not which error made it fail; `script_tests.json` is the harness that pins error codes, and it has no vector using the flag.

This adds six vectors. Four fail with the flag set:

- `OP_CODESEPARATOR` in an executed pre-segwit script.
- `OP_CODESEPARATOR` in an unexecuted `IF` branch. The check in `EvalScript` runs ahead of the `fExec` guard, so the opcode is rejected even though it never executes — the rule with no error-level coverage before.
- A signature push that also appears in the scriptPubKey, against `CHECKSIG`.
- The same against `CHECKMULTISIG`, which calls `FindAndDelete` in a separate loop.

The other two are controls with the flag off, one per error. Both checks run before signature verification, so the vectors can use a dummy signature.

To confirm the expected errors are the ones that fire, I added the vectors expecting `OK` first and let the harness report the actual error for each.

Tested with:

```
build/bin/test_bitcoin --run_test=script_tests/script_json_test
```

ACKs for top commit:
fametrano:
ACK 829e44a1151fa432f293554f25832f19bde209ec
sedited:
ACK 829e44a1151fa432f293554f25832f19bde209ec

Tree-SHA512: b8d52028b5c7e0ec555b4df3749740337b6921b0357b5c9b156daf2a74203a5b95e3bcfa225ebd5a26e0b4cd90290732e4440c0d2b2bfe6f629f51cd319c4415

96/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarydefensive validationmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds new test cases to a Bitcoin Core test data file. It does not change any production code, consensus rules, or network behavior. The tests verify that two specific script error conditions are correctly detected when a particular validation flag is enabled. There is no security vulnerability being fixed here—this is purely additional test coverage.

Security candidateMerge bitcoin/bitcoin#36329: psbt: add new test vectorsby merge-script · 889e7c5a · Oct 5, 2026 · 2 filesMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36329: psbt: add new test vectors

6fa2f3974cbb69fb2086a8f89d300deec4486662 test: add BIP174 invalid value size vector (Sjors Provoost)
029bc15f2cb575ad4e19d99338cd133a4140e66f test: add BIP174 sighash combiner vector (Sjors Provoost)

Pull request description:

Add the two new test vectors from:

- https://github.com/bitcoin/bips/pull/2275
- https://github.com/bitcoin/bips/pull/1971

https://github.com/bitcoin/bips/pull/2275 additionally requires _existing_ `Combine` vectors to run in both orders, so we do that here too.

ACKs for top commit:
brunoerg:
reACK 6fa2f3974cbb69fb2086a8f89d300deec4486662
aaron-leeb:
reACK [6fa2f39](https://github.com/bitcoin/bitcoin/pull/36329/commits/6fa2f3974cbb69fb2086a8f89d300deec4486662)
sedited:
ACK 6fa2f3974cbb69fb2086a8f89d300deec4486662

Tree-SHA512: 5a07026cadbe0551728ac30e9b20212f94e322a2ab31a31a84c86320fc95d2ada82a12e7c2a50c7cd7c12ad202036fdc45b6ad4fc820a8d6f2cd71c87476a6f5

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundaryfuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds new test cases for PSBT (Partially Signed Bitcoin Transaction) handling. It does not change any production code, so it cannot introduce a security vulnerability or fix one directly. The new tests check that malformed PSBT data is rejected and that combining PSBTs works in both input orders.

Security candidateMerge bitcoin/bitcoin#36262: test: cover orphan reconsideration interruptibilityby merge-script · 0036d5f1 · Oct 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#36262: test: cover orphan reconsideration interruptibility

16bff77a5aaf7a9740b859f74b8898cee6de5588 test: cover orphan reconsideration interruptibility (ViniciusCestarii)

Pull request description:

Add test checking that ProcessOrphanTx reconsiders at most one orphan per ProcessMessages(). This test prevents regression of [CVE-2024-52914](https://bitcoincore.org/en/2024/07/03/disclose-orphan-dos/) which currently no existing test checks.

The test kills 2 mutants found with https://github.com/ViniciusCestarii/mutant-harness:

1. Remove `return true` after an orphan is accepted

```diff
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -3494,7 +3494,6 @@ bool PeerManagerImpl::ProcessOrphanTx(Peer& peer)
if (result.m_result_type == MempoolAcceptResult::ResultType::VALID) {
LogDebug(BCLog::TXPACKAGES, " accepted orphan tx %s (wtxid=%s)\n", orphanHash.ToString(), orphan_wtxid.ToString());
ProcessValidTx(peer.m_id, porphanTx, result.m_replaced_transactions);
- return true;
} else if (state.GetResult() != TxValidationResult::TX_MISSING_INPUTS) {
```

2. Remove `return true` after an orphan is rejected for a reason other than `TX_MISSING_INPUTS`

```diff
--- a/src/net_processing.cpp
+++ b/src/net_processing.cpp
@@ -3508,7 +3508,6 @@ bool PeerManagerImpl::ProcessOrphanTx(Peer& peer)
state.GetResult() != TxValidationResult::TX_RESULT_UNSET)) {
ProcessInvalidTx(peer.m_id, porphanTx, state, /*first_time_failure=*/false);
}
- return true;
}
}
```

ACKs for top commit:
instagibbs:
reACK https://github.com/bitcoin/bitcoin/pull/36262/commits/16bff77a5aaf7a9740b859f74b8898cee6de5588
fametrano:
tACK 16bff77a5aaf7a9740b859f74b8898cee6de5588

Tree-SHA512: 3d00bf7aa023c47d335b0f4c9d720c914611962272b895d91c8a542739f3b9c0d35c1dba5becdfd7167122c3f3f2be87b366d296732fa2765538467e6c0af6d7

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
explicit security languageaccess controlmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds a new automated test to Bitcoin Core. It does not change any production code. The test verifies that a previously fixed denial-of-service bug (CVE-2024-52914) stays fixed by checking that orphan transactions are reconsidered one at a time per network message. It is a regression test, not a security patch.

AI review queuedMerge bitcoin/bitcoin#34907: wallet, test: make wallet_fast_rescan robustby merge-script · 36e9e52f · Oct 5, 2026 · 1 fileMessage 91 · StrongInformational 15Details
Commit message · merge-script

Merge bitcoin/bitcoin#34907: wallet, test: make wallet_fast_rescan robust

f217da5c59f43b43abca96de66b95c24ae99eed7 wallet, test: wallet_fast_rescan follow-ups (rkrux)

Pull request description:

This patch addresses my own review comments from the review of #34667 and adds some more changes that I find helpful. It was observed in the review of the earlier PR that there is a tendency for the test code to cause the topups not being done that defeats the purpose of the test. Combine that with the earlier issue where the block filter was not being updated ever since this test was written, I think it's helpful that some robustness is added in the test.

Exact details are in the commit message.

ACKs for top commit:
Bicaru20:
lgtm ACK f217da5c59
polespinasa:
lgtm ACK f217da5c59f43b43abca96de66b95c24ae99eed7
sedited:
ACK f217da5c59f43b43abca96de66b95c24ae99eed7

Tree-SHA512: 781aeee4607a6750f370d4370b28da47f01428eb894ce59ac7de930396864a7c3708d1d1c05efb607fae8e5c2888a2503573140c37eed5c285c79d3e5155a3af

91/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a test-only change to a Bitcoin Core functional test file. It makes the wallet_fast_rescan test more robust by ensuring the test actually triggers wallet keypool top-ups and verifies block filter rescans find the expected transactions. There is no change to production wallet, node, or consensus code, and no security vulnerability is being fixed.

Security candidateMerge bitcoin/bitcoin#36151: makeseeds: fix off-by-one in field count checkby merge-script · 8c49a9ab · Oct 5, 2026 · 1 fileMessage 81 · StrongInformational 20Details
Commit message · merge-script

Merge bitcoin/bitcoin#36151: makeseeds: fix off-by-one in field count check

c786052865fd173fd8bc7396e1303f7840c5b0da makeseeds: fix off-by-one in field count check (aman21-droid)

Pull request description:

Fixes #36146.

`parseline()` checks that a line has at least 11 whitespace-separated fields:

```python
if len(sline) < 11:
# line too short to be valid, skip it.
return None
```

but it later reads `sline[11]` (the user agent), which needs 12. A line with exactly 11 fields got past the check and then raised `IndexError`, aborting the whole run instead of skipping that line. 11 is the highest index the function uses, so the check now requires 12 fields.

This isn't only theoretical: README.md builds seeds_main.txt by appending one crawler's output onto another's, so the file mixes two independently maintained formats, and a truncated download leaves a short last line too. Skipping the line is what the check was already trying to do.

ACKs for top commit:
maflcko:
lgtm ACK c786052865fd173fd8bc7396e1303f7840c5b0da
l0rinc:
ACK c786052865fd173fd8bc7396e1303f7840c5b0da

Tree-SHA512: 3c3aeb8876b7e0eccf8f03faafe0e0bb71d1b11924feaf22b2bb6bf1a36e25bedd622de257060de873c42f12fba8df42d96b2a831a2e8d395220fed70f4bba34

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
seed or entropy pathmerge-commit duplicate discount
AI analysis · Informational 20/100

This is a one-line fix in a Python helper script used to build the list of network seed nodes for Bitcoin Core. The script reads lines of data about internet nodes and was supposed to skip any line that didn't have enough fields. Due to an off-by-one error, a line with exactly 11 fields passed the 'too short' check but then crashed the program when it tried to read the 12th field. The fix simply changes the minimum required field count from 11 to 12. This only affects an offline developer/operations tool and cannot be used to attack the Bitcoin network or wallets directly.