rust-lightning

This change relaxes a fee-checking rule during Bitcoin Lightning channel transactions. When two parties jointly build a transaction, the code now accepts a remote party's fee contribution that is up to 5% lower than the agreed rate, matching how another major implementation (Eclair) behaves. This avoids false failures caused by real-world coin-selection quirks, but it also means the local node may accept slightly less fee than strictly required.

This commit fixes a fee-estimation bug in LDK's experimental splicing code. When the optional `grind_signatures` feature is enabled, signatures are guaranteed to be one byte smaller than the normal maximum. The splice funding-transaction fee estimator was not accounting for that smaller signature, so it could slightly overestimate fees. The patch subtracts one weight unit from the relevant estimates when the feature is on, and updates tests to match. It is a correctness/efficiency fix rather than a critical vulnerability.

This commit is a simple internal cleanup in the project's test code. It removes a helper macro named `get_revoke_commit_msgs!` and replaces every use with an already-existing function of the same name. There is no change to how the software behaves in production, no fix for a bug, and no security-relevant change.

This commit is a small internal cleanup in the project's test code. It replaces a few uses of a test helper macro with a direct call to an equivalent helper function. There is no change to the actual Lightning node logic that runs in production, and nothing in the commit suggests a security fix or vulnerability.

This commit is a straightforward internal cleanup in the project's test code. It removes a helper macro used only in tests and replaces its remaining uses with an equivalent regular function. There is no change to the actual Lightning protocol logic, network-facing behavior, or production code, so it does not create or fix a security issue.

This commit removes an unused branch of a Rust macro used only in test helper code. It is a code cleanup change with no apparent effect on production Lightning node behavior or security.

This commit is a test-only refactoring change. It replaces uses of a test helper macro (`commitment_signed_dance!`) with direct calls to an equivalent test helper function (`do_commitment_signed_dance`) in many test files. There is no change to production code, no change to behavior, and no security fix or vulnerability introduced.

This commit is a test-only refactoring change. It replaces uses of a macro called `commitment_signed_dance!` with direct calls to a helper function `do_commitment_signed_dance` in many test files. There is no change to production code, no security fix, and no vulnerability introduced.

This commit is a cleanup of the project's continuous integration fuzz-testing script. It replaces a custom, per-target method of limiting how long each fuzz test runs with a built-in honggfuzz command-line option (`--run_time 30`). There is no change to the actual Lightning protocol code, cryptography, networking, or any code that end users run. It only affects how long automated fuzzing jobs run in CI.

This commit fixes an internal inconsistency in how LDK estimates Bitcoin transaction fees. Some parts of the code assumed signatures could be 73 weight units (WU) long, while others used 72 WU. Since 73 WU signatures are non-standard and LDK never produces them, the 73 WU assumption caused fee estimates to be slightly too high. The patch standardizes on 72 WU and replaces magic numbers with named constants. The practical effect is slightly lower, more accurate fee estimates for Lightning channel funding and splicing transactions. It is not a direct vulnerability fix, but incorrect fee estimation could in edge cases cause transactions to be over-funded or, more importantly, could contribute to fee-related negotiation failures.

This commit is a routine code cleanup in the Lightning Dev Kit Rust library. It takes advantage of a newer Rust language feature (available since Rust 1.75) to remove unnecessary 'Box' heap allocations around futures returned from certain trait methods. There is no indication this change fixes a security bug or introduces a vulnerability; it is a refactoring to simplify the code and reduce allocations.

This commit is a routine code cleanup that swaps one Rust standard-library mechanism for pinning futures (`Box::pin`) with a newer, allocation-free equivalent (`pin!`). It removes heap allocations in a few internal loops and sync wrappers, but does not change program logic, trust boundaries, or behavior. There is no security relevance.

This commit is purely a housekeeping change: it moves the `lightning-transaction-sync` crate from a separate mini-workspace back into the main project workspace because it now uses the same minimum Rust version as everything else. The only files changed are CI workflow definitions and test scripts. There is no change to application code, no bug fix, and no security patch.

This commit is a routine code cleanup in the Lightning Dev Kit's BOLT 11 invoice serialization code. It replaces heap-allocated boxed iterators with Rust's newer 'impl Trait' return type feature, eliminating unnecessary memory allocations. There is no security-relevant change here.

This commit is a routine code cleanup in the Lightning Dev Kit's block synchronization module. It takes advantage of a newer Rust language feature (returning 'impl Trait' from trait methods, now that the project's minimum supported Rust version is 1.75) to remove unnecessary heap-allocated boxed futures. There is no security-relevant change here; it is purely a refactoring to simplify the code and remove an old workaround.

This commit is a routine Rust code cleanup: it removes the requirement that KVStore trait methods return their futures inside a Box (a heap allocation). It takes advantage of a newer Rust compiler feature (returning 'impl Trait' from trait methods) to make the code simpler and slightly more efficient. There is no indication this fixes a security bug or introduces a vulnerability.

This commit is a minor code cleanup that removes a Rust compiler warning. It changes how a macro handles the `mut` keyword so that one version of the code no longer triggers an 'unused_mut' warning when compiled with a specific configuration flag. There is no functional change and no security impact.

This is a one-line change that adds a Rust compiler feature gate to silence a warning. It does not change program behavior or fix any security issue.

This commit adds a new automated CI workflow that checks whether changes in the rust-lightning project break the public API used by a related project called LDK Node. It does not change any application code, cryptographic logic, network handling, or user-facing behavior. It is purely a testing/infrastructure addition.

This change fixes a Lightning channel splicing behavior where one side would unnecessarily force-close the channel if the counterparty tried to abort a splice before both sides had exchanged their first commitment signatures. Previously, any tx_abort during the signature-waiting phase triggered a force close. The patch makes the protocol more forgiving: aborting is allowed until the counterparty has actually sent its initial commitment_signed, because before that point no dangerous on-chain transaction has been committed to. Once commitment_signed is received, aborting remains unsafe and still triggers a force close. The change also cleans up internal state when aborting early and adds tests for the new behavior.

This commit only changes internal test helper code in the Lightning Dev Kit repository. It extends a test macro and a test reconnection helper so that automated tests can optionally capture and forward a `tx_abort` message during channel re-establishment scenarios. No production code is modified, and there is no indication this fixes or introduces a security issue.

This commit only adds a documentation comment to a Rust trait method. It does not change any code behavior, logic, or security properties. The added text explains that the method returns a script pubkey usable as a change destination and references another function.

This commit only copies documentation comments from asynchronous Rust traits and structs to their synchronous counterparts. It fixes broken documentation links and adds notes reminding developers to keep both versions in sync. No code behavior changes.

This commit only copies documentation comments from the asynchronous version of a key-value storage trait to its synchronous wrapper. It fixes broken documentation links for language bindings but does not change any code behavior, logic, or security properties.

This commit is a documentation-only change. It copies the user-facing documentation from the asynchronous OutputSweeper struct to its synchronous wrapper OutputSweeperSync, and fixes a broken doc link. No code behavior changes, no security fix or vulnerability introduced.