Drop `SplicePrototype` feature
What the developer wrote
Authored by Matt Corallo
Drop `SplicePrototype` feature
Now that `SplicePrototype` and `SpliceProduction` share the same
feature bit, there's not really any reason to have the
`SplicePrototype` feature at all. Instead, we drop it, leaving only
a `Splice` feature.
What changed, and why it matters
This commit is a routine cleanup of internal feature-flag names in a Lightning network library. It removes a duplicate 'SplicePrototype' label and keeps a single 'Splice' label for the same protocol feature bit. There is no security bug being fixed here.
No security action needed. Review as normal code cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The patch drops the redundant SplicePrototype feature flag from lightning-types/src/features.rs. SplicePrototype and SpliceProduction previously shared the same feature bit (63), so the code consolidates on a single Splice feature with the existing helper methods (set_splicing_optional, supports_splicing, etc.). This is a naming/organizational refactor with no functional change to protocol behavior.
Changed components
lightning-types/src/features.rsInspect captured patch +8 / −19
diff --git a/lightning-types/src/features.rs b/lightning-types/src/features.rs
index 8bb317f..22493ef 100644
--- a/lightning-types/src/features.rs
+++ b/lightning-types/src/features.rs
@@ -166,7 +166,7 @@ mod sealed {
// Byte 6
ZeroConf,
// Byte 7
- Trampoline | SimpleClose | SpliceProduction | SplicePrototype,
+ Trampoline | SimpleClose | Splice,
// Byte 8 - 16
,,,,,,,,,
// Byte 17
@@ -195,7 +195,7 @@ mod sealed {
// Byte 6
ZeroConf | Keysend,
// Byte 7
- Trampoline | SimpleClose | SpliceProduction | SplicePrototype,
+ Trampoline | SimpleClose | Splice,
// Byte 8 - 16
,,,,,,,,,
// Byte 17
@@ -687,14 +687,14 @@ mod sealed {
);
define_feature!(
63,
- SpliceProduction,
+ Splice,
[InitContext, NodeContext],
"Feature flags for channel splicing.",
- set_splicing_production_optional,
- set_splicing_production_required,
- clear_splicing_production,
- supports_splicing_production,
- requires_splicing_production
+ set_splicing_optional,
+ set_splicing_required,
+ clear_splicing,
+ supports_splicing,
+ requires_splicing
);
// By default, allocate enough bytes to cover up to Splice. Update this as new features are
// added which we expect to appear commonly across contexts.
@@ -721,17 +721,6 @@ mod sealed {
supports_htlc_hold,
requires_htlc_hold
);
- define_feature!(
- 63, // Actually the SpliceProduction feature
- SplicePrototype,
- [InitContext, NodeContext],
- "Feature flags for channel splicing.",
- set_splicing_optional,
- set_splicing_required,
- clear_splicing,
- supports_splicing,
- requires_splicing
- );
define_feature!(
259,
DnsResolver,
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.