AI-generated analysisPublished automatically and not human-verified. Validated context appears in community notes below.
← Watch feed
Informational 15 Bitcoin

Correct FeeEstimator docs on the 253 sat/kW lower bound

Public commit record

What the developer wrote

Authored by auto-pr-bot

81/100 · Strong
Correct FeeEstimator docs on the 253 sat/kW lower bound

@matt asked in #5649:

> @auto-pr-bot please fix `FeeEstimator`'s documentation - while lightning
> protocol things always use a feerate of at least 253, not everything does,
> nor should everything now that feerates can be below 1.0 sat/vB.
> `OutputSweeper`, notably, accepts a lower feerate.

The trait's docs claimed LDK always bounds the value returned by
`get_est_sat_per_1000_weight` below by 253 sats/KW, but that bound is only
applied where lightning protocol feerates are required, via the
`LowerBoundedFeeEstimator` wrapper. Callers outside channel management use
the estimate as-is; most notably `OutputSweeper` passes the value returned
for `ConfirmationTarget::OutputSpendingFee` straight to the output spender,
so implementations must not rely on LDK enforcing a minimum.

Documentation-only change; no behavioural difference.

Fixes #5649

Requested-by: @matt
Link: https://git.rust-bitcoin.org/lightningdevkit/rust-lightning/issues/5649
Authored-By: matt/GLM-5.3-Flash-GGUF:Q4_K_XL <goose@users.noreply.local>
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
The short version

What changed, and why it matters

This is a documentation-only edit. It corrects a misleading comment in the code that wrongly claimed all fee estimates returned to LDK are forced to be at least 253 satoshis per 1000 weight units. The new comment clarifies that this minimum only applies to Lightning protocol fee rates, not to all uses of the fee estimate. No code behavior changes.

Recommended action

No action required. This is a documentation correction with no runtime effect.

Security signals we found

No strong security signals were identified.

Risk score

Why this scored 15/100

Our methodology →
Potential impact 0/30
Exploitability 0/25
Stealth signal 0/15
Affected reach 0/15
Confidence 10/10
Evidence quality 5/5
Human-validated context

Community notes

Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.

No validated notes yet.

The AI analysis stands alone for now. Submit a note if you can add evidence or important context.