Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
53/100 average clarity
22Strong · 80–100
158Adequate · 60–79
690Thin · 40–59
66Opaque · 0–39
14security candidates with opaque commit messaging
This commit only adds a new automated test tool (a fuzzer) for the Monero wallet. It does not change any production wallet, node, or consensus code. It cannot by itself introduce a vulnerability that affects real users, nor does it fix one…
This is a cleanup and refactoring patch for Monero's new FCMP++ (full-chain membership proof) database and transaction handling code. It renames a method, fixes typos and comments, tightens a constant name, adds a safety check that outputs…
Added runtime invariant check that locked outputs do not unlock below the default unlock blockRefactored transparent-amount commitment collection to reduce indirection and potential misuseClarified unlock-time semantics and coinbase detection in migration code
This commit is a cleanup and hardening patch following an earlier pull request. It adds a safety check to make sure outputs are not incorrectly treated as spendable before they should be, fixes several typos and variable-name issues, rewri…
Added invariant check that outputs unlock no earlier than the default unlock block before adding locked outputs to the databaseRefactored transparent-amount commitment collection to remove std::reference_wrapper indirection, reducing complexityCorrected constant-name typos in spendable-age calculations
This is a one-line fix in Monero's wallet software that adjusts how far ahead the wallet tries to 'skip' scanning after a blockchain reorganization (reorg). A reorg happens when the network briefly disagrees on the chain of blocks and then…
Incorrect scan resume height after blockchain reorgPotential missed transaction detectionBalance accuracy issue in wallet
This commit is a code cleanup that replaces the non-standard WIN32 preprocessor macro with the compiler-defined _WIN32 macro across 18 files. It does not change program logic or behavior; it only makes Windows-specific code detection more …
No functional code changes observedPreprocessor macro standardization onlyWindows-specific code paths remain identical in behavior
This commit only adds a new automated security test (a fuzzer) for Monero's wallet cache file parser. It does not change any production wallet code, fix a bug, or introduce a vulnerability. It is a testing-only addition intended to help fi…
Adds a fuzz target for wallet cache deserializationNo changes to production code pathsNo patch of a reported vulnerability
This Monero update adds a cache that remembers which transactions in the memory pool have already failed expensive input verification, so the node does not waste CPU re-checking the same bad transaction repeatedly. It is a performance and …
Adds caching of invalid input verification IDs to avoid repeated expensive ring signature verificationReduces CPU consumption for transactions that re-enter or remain in the mempool with unchanged invalid inputsCould mitigate a minor denial-of-service vector where a node repeatedly re-verifies a bad transaction
This patch changes how Monero's daemon calculates the total coinbase transaction sum (emission plus fees) for a range of blocks. Previously, the code called a general 'get_transactions' helper that could trigger a deadlock because it might…
Deadlock avoidance in consensus-related coinbase emission calculationChange from general transaction retrieval to direct, pruned database readAddition of functional test covering coinbase sum correctness
This change is a performance optimization for the Monero wallet's balance-reporting RPC. When a user asks for balances across many subaddresses, the code now pre-counts unspent outputs in one pass instead of re-scanning the entire transact…
This update adds a safety check in the Monero wallet's fast refresh process. Previously, if a malicious or buggy remote server told the wallet to start syncing from a block height beyond the wallet's known blockchain data, the wallet could…
Added bounds check on untrusted server-supplied start_height against local hash chain sizeDefensive hardening at wallet/daemon trust boundaryUnit test demonstrates rejection of out-of-bounds refresh request
This commit tightens filename validation in the Monero wallet's remote-control interface (RPC server). It now rejects wallet names that are just '.' or '..', contain a hidden null character, or contain path separators like '/' (and on Wind…
Path-traversal defense: blocks directory separators and parent-directory references in wallet filenamesNull-byte injection defense: rejects embedded NUL characters that could truncate or confuse downstream path handlingRPC input validation hardening in wallet_rpc_server
This Monero wallet update fixes a file-handling bug in the 'save wallet as' function. Previously, the code compared only the main wallet cache path and used a simple path check that could be fooled by symlinks or filenames ending in '.keys…
Path overlap / self-overwrite protection for wallet cache and keys filesSymlink and hardlink alias detection using boost::filesystem::equivalentRejection of ambiguous paths where .keys file and cache file could collide
This commit adds an optional, faster way to set up N-of-N Monero multisig wallets. Normally, all signers must complete a final verification round to prove they are active and have finished setup. The new 'fast non-interactive setup' skips …
New feature adds a non-default, opt-in fast setup path that intentionally weakens a liveness/verification guaranteeForce-update flag (force_update_use_with_caution) is used internally to bypass the normal post-KEX roundUser-facing and API documentation clearly warn that funds may become inaccessible if other signers do not complete setup
This change refactors how Monero's wallet fetches transaction data when creating or verifying 'spend proofs'—cryptographic receipts that prove you spent funds. Previously, spend-proof code fetched transactions directly from the network dae…
Refactoring of spend-proof transaction lookup to a single helperAddition of explicit RPC timeout parameter to transaction fetch helperImproved daemon RPC error/status reporting in get_tx_for_proof
This commit refactors how the Monero wallet fetches a transaction when verifying a payment proof (the check_tx_key feature). It replaces a direct daemon RPC call with a helper function called get_tx_for_proof, which is described in the com…
Replaces direct /gettransactions RPC with centralized helper for proof verificationCommit title explicitly frames change as 'verify v1 txid in check_tx_key'Removes local tx_hash == txid equality check in favor of helper-internal verification
This change stops a Monero wallet from creating 'InProofs' (receipt proofs) for transactions that the wallet itself sent. InProofs are meant to prove to someone else that you received money. If a wallet could generate an InProof for a tran…
Prevents generation of misleading InProofs for outgoing/self-sent transactionsAdds explicit runtime guard in wallet proof generation pathFunctional tests updated to assert refusal behavior
This patch fixes a bug in the Monero wallet where, if a pending transaction failed, the wallet could incorrectly mark coins as unspent even though they had already been spent by a separate confirmed transaction. This could let the wallet t…
Incorrect state reset on failure pathPotential double-spend attempt caused by stale UTXO selectionWallet balance/availability inconsistency after failed pending tx
This commit only adds a new automated fuzz-testing harness for Monero wallet features. It does not change any production wallet code, fix a bug, or alter network behavior. It is a test-only addition intended to help find bugs in the future…
Adds fuzz targets for payment URI parsing and transaction proof verificationNo changes to production wallet, consensus, or network codeNo bug fix or behavior change in existing source files
This Monero update fixes a bug in how nodes ask each other for blockchain history. Previously, a node could get stuck or drop a peer when it already knew about some blocks from another connection, because it would not ask for the next batc…
P2P protocol synchronization logic changePotential denial-of-service via peer dropping or sync stallNo authentication or cryptographic boundary crossed
This commit fixes a bug in how the Monero wallet saves itself to disk. Previously, the wallet could accidentally overwrite or corrupt its own files when the user chose a path that overlapped with existing wallet files, such as saving to a …
File overwrite / corruption prevention in wallet save path handlingSymlink and hardlink alias detection via filesystem equivalent() checksRejection of overlapping source/destination wallet files
Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.
Security candidatecryptonote_protocol: remove dead codeby Thomas · c2dc8a5b · Jul 20, 2026 · 4 filesMessage 58 · ThinInformational 15Details
Commit message · Thomas
cryptonote_protocol: remove dead code
block_queue: - print(): added with two debug call sites in the sync-speedup rewrite (5be43fcdb, 2017-07-02); 08abb670e (2017-08-12) removed one call and Pruning (b750fb27b, 2018-04-29) removed the last; dead since. - get_num_filled_spans_prefix(): added in 5be43fcdb (2017-07-02) without any caller; dead on arrival. - get_last_known_hash(): added in 5be43fcdb with one caller in the protocol handler; 08abb670e (2017-08-12) removed that caller while reworking reorg handling; dead since. - has_spans(): added in 7b7476075 (2017-08-16, kick idle synchronizing peers) without any caller; dead on arrival. - get_download_rate(): added by Pruning (b750fb27b, 2018-04-29) without any caller; dead on arrival. - has_unpruned_height(): declaration added by Pruning (b750fb27b); a definition never existed, so it was never callable.
cryptonote_protocol_handler: - get_synchronizing_connections_count(): from the original 2014 import (296ae46ed, 2014-03-03); its only reference was already commented out in the import, and 8efa1313f (2014-03-20) deleted that comment. Never had a live caller in the repo's history. - PASSIVE_PEER_KICK_TIME: added in 1ff638e92 (2017-10-19) with one use in the idle-peer kick threshold; Pruning (b750fb27b) removed the use, orphaning the macro. - LOCALHOST_INT: added in ae2a50659 (2015-02-20) for numeric localhost comparisons, second use added in c511abf00; 072102cfd (2017-05-27, abstracted network addresses) removed both uses.
cryptography-sensitive pathparser or protocol path
AI analysis · Informational 15/100
This commit simply deletes unused code from Monero's network synchronization module. It removes functions, macros, and declarations that were never called or had no definition. There is no change to active behavior, no bug fix, and no security-relevant change.
Security candidateringct: remove dead codeby Thomas · bf461566 · Jul 20, 2026 · 6 filesMessage 61 · AdequateInformational 15Details
Commit message · Thomas
ringct: remove dead code
- h2b, b2h (rctTypes) and sumKeys (rctOps): from the original RingCT import (9b1afe5f2, 2016-05-13); never referenced by any caller since the import. - cn_fast_hash128, hash_to_scalar128 (rctOps): from the same import. hash_to_scalar128 (and cn_fast_hash128 through it) was last used by the original MLSAG gen/ver hashing, which dbb5f2d6a (2016-07-09) replaced with keyV-based hash_to_scalar; dead since then. - bos_coster_heap_conv (multiexp): added in 9ff6e6a0a (2018-01-09) alongside bos_coster_heap_conv_robust; multiexp() only ever dispatched the robust variant, so the non-robust one was never called. The robust variant is kept, as tests/performance_tests still uses it (production dispatch moved to Straus/Pippenger in 939bc22/263431c).
61/100 · AdequateMessage clarity
✓ Subject identifies a change✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
privacy or spend-authorization protocol
AI analysis · Informational 15/100
This commit simply deletes unused functions and one unused inline helper from Monero's RingCT code. The removed code was never called by any part of the program, so the change cannot introduce or fix a security vulnerability on its own. It is a routine cleanup that reduces clutter and maintenance burden.
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit changes a single log message from 'Device inited...' to 'Device initiated...' in the Monero wallet code. It is purely a wording/spelling fix with no functional or security effect.
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This is a small cleanup change in Monero's command-line wallet. It moves a call that retrieves a transaction's secret key so it only runs when the user actually asked to export keys. Previously, the key was retrieved for every exported transfer even if keys were not being exported. There is no direct security vulnerability here, but retrieving secret key material unnecessarily is a minor defensive-coding concern.
AI review queuedtests: make libwallet_api_tests work under ctest, add testsby selsta · 85f8bbbc · Jul 17, 2026 · 19 filesMessage 60 · AdequateInformational 18Details
Commit message · selsta
tests: make libwallet_api_tests work under ctest, add tests
60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100
This commit is a test-infrastructure change for the Monero wallet API. It makes existing integration tests runnable under the automated CTest framework by spinning up a temporary local blockchain instead of relying on external testnet nodes. It also adds a few new test cases and exposes two small helper methods in the wallet API so tests can configure daemon-version mismatch tolerance and a custom ring database path. There is no obvious security vulnerability in the changes, and the commit does not describe itself as a security fix.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
proof-of-work or emission validationseed or entropy path
AI analysis · Informational 3/100
This commit updates the bundled RandomX library (used for Monero's mining proof-of-work) from one version to version 1.2.3. The actual code changes are not visible because the diff was not provided, and no security references were supplied. On its own, the commit message only says 'update to v1.2.3' and does not claim to fix any security issue.
general: replace auto_scope_leave_caller with scope_guard
And replace unused inclusions of misc_language.h
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet pathparser or protocol path
AI analysis · Informational 19/100
This is a large internal cleanup commit in the Monero codebase. It replaces an older scope-guard helper (auto_scope_leave_caller) with a newer, simpler scope_guard type, trims unused #include lines, and replaces a few value-initialization macros with direct C++ syntax. There is no direct evidence in the commit message or diff that this fixes a security vulnerability; it appears to be a refactoring and code-quality improvement. The changes touch many files but do not alter program logic in a way that is obviously exploitable.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit removes a custom hash comparison helper that was used to sort transaction hashes in the memory pool data structure. The code now relies on Boost's default comparison for the hash type. There is no visible security change: the removed comparator behaved the same as the standard less-than comparison for the hash data, and no behavior or interface changes are apparent.
crypto: derive key image generator & separate {un}biased hash to ec https://github.com/monero-project/research-lab/issues/142
Co-authored-by: Jeffro <jeffro256@tutanota.com> Co-authored-by: Luke Parker <lukeparker5132@gmail.com>
81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
privacy or spend-authorization protocolcryptography-sensitive path
AI analysis · Low 34/100
This commit adds new cryptographic routines to Monero and renames an existing one. It introduces a new way to derive 'key image generators' (used to prove a coin hasn't been spent twice) and a new 'unbiased' method for hashing data to an elliptic-curve point. The old method is now explicitly labeled 'biased' but remains in use for existing ring signatures. The changes are presented as a research-driven cryptographic improvement, not as a fix for an active bug or vulnerability.
/get_blocks.bin is HTTP binary RPC serialized with portable storage, not a P2P Levin message. The previously added pool limiter used LEVIN_DEFAULT_MAX_PACKET_SIZE as a response budget, but that constant does not apply to the RPC path.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
cryptography-sensitive path
AI analysis · Low 49/100
This Monero code change fixes how the /get_blocks.bin RPC endpoint limits the size of transaction-pool data it returns. Previously, the code reused a P2P Levin packet-size constant that does not apply to HTTP RPC responses, and it tried to budget pool data against the size of the block data already sent. The patch removes that size-budget plumbing and instead caps the number of added pool transactions at a fixed maximum (20,000). This is a correctness fix for response-size limiting, but it also removes a cumulative byte-size cap that could, in edge cases, allow very large individual transactions to make responses bigger than intended.
wallet2: guard gamma picker against zero-output windows
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 41/100
This commit adds a safety check in Monero's wallet code to prevent a crash or undefined behavior when the wallet tries to select decoy transaction outputs but finds none in the expected time window. It also fixes a related unit test that was not correctly simulating a blockchain with only one output. The change is defensive and improves robustness, but the commit message does not describe it as a security fix.
Addresses several issues with miner block template:
1. Fixes key image conflict issue due to lazy transaction prefix - This line checks whether the next tx candiates has conflicting key images with the rest of the block template: https://github.com/monero-project/monero/blob/0f84863feda75574788e15c9691abecf57bc3f8f/src/cryptonote_core/tx_pool.cpp#L1744 - The function takes in a transaction prefix and parses the key images from it - However, the transaction may or may not actually ever be deserialized, depending on the state of `m_input_cache`: https://github.com/monero-project/monero/blob/0f84863feda75574788e15c9691abecf57bc3f8f/src/cryptonote_core/tx_pool.cpp#L1455-L1466 2. Deduplicates code between `tx_memory_pool::fill_block_template()` and `tx_memory_pool::get_block_template_backlog()`, and thus converging the backlog lists between the 2 functions 3. Saves time creating block templates by skipping transaction blob readings and deserializations for some txs 4. Stops template candidate search after block is reasonably full and we are iterating through txs which lower coinbase reward or exceed size limit by a "smallish" amount. Prevents us from unnecessarily reading thousands of useless tx metadatas under load. May help https://github.com/seraphis-migration/monero/issues/293 5. Fixes block templates when coinbase transactions are > 600 bytes 6. Fills closer to block weight limit for small coinbase transactions 7. Fixes "Invalidating block template cache" spam while popping blocks / during reorgs 8. More accurate "expected block reward" field in RPC
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
privacy or spend-authorization protocolproof-of-work or emission validationcryptography-sensitive path
AI analysis · Moderate 59/100
This Monero commit fixes a bug in how mining software picks transactions for the next block. The old code could accidentally include two transactions that spend the same 'key image' (like the same coin being spent twice), which would create an invalid block. It also cleans up and speeds up the transaction selection logic. The commit message explicitly calls this a 'key image conflict issue' and says it is fixed.
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100
This is a tiny cosmetic fix in Monero's command-line wallet. It removes a stray colon and space from a prompt asking the user whether to enable background mining. The change does not affect security, user funds, cryptography, network behavior, or how user input is interpreted.
AI review queuedwallet_api: set m_password in the recovery creation pathsby plowsof · a4f8ef48 · Jul 11, 2026 · 2 filesMessage 65 · AdequateLow 44Details
Commit message · plowsof
wallet_api: set m_password in the recovery creation paths
libwallet_api_tests: cover password retention on wallet recovery
65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 44/100
This commit fixes a bug in Monero's wallet programming interface (wallet_api). When a wallet was restored from a recovery seed or from private keys, the internal copy of the wallet password was not being saved. As a result, operations that later needed the password—such as saving the wallet to disk—could fail or behave incorrectly. The patch simply records the password in those three recovery code paths and adds tests to confirm that a recovered wallet can be saved and reopened with the same password.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Low 46/100
This commit changes how Monero reads 64-bit chunks from cryptographic hashes during difficulty checks. Previously the code cast a byte array directly to a uint64_t pointer, which can violate strict aliasing rules and cause unaligned or misread memory on some platforms. The new code copies the bytes with memcpy first, then converts endianness. This is a correctness and portability fix; it likely prevents subtle consensus bugs where different nodes might interpret a hash's numeric value differently, but the commit itself does not describe any active security incident or exploit.
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Informational 15/100
This commit only changes two error log messages in Monero's blockchain code. It removes the phrase 'dropping connection' from messages that are printed when a peer sends an invalid chain request. The actual behavior—returning false and not dropping the connection—was already in place; the logs were simply inaccurate. There is no security fix here.
Successful parses left optional outputs unchanged when the URI omitted them, which could expose stale values or an uninitialized amount
Initialize them after validating the address so outputs only describe the current URI
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 48/100
This change fixes a bug in how Monero wallet software reads payment web links (URIs). Before the fix, if a payment link did not specify an amount, description, or other optional fields, the wallet could accidentally keep leftover values from a previous parse. That could mislead the user into sending the wrong amount or seeing wrong payment details. The patch now clears those fields right after confirming the address is valid, and adds a test to prove it.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 36/100
This commit fixes the 'donate' command in Monero's command-line wallet. Previously, the command accepted an optional extra argument (an obsolete payment ID) and its argument-count check allowed up to 5 items. The code then tried to read the last item as an amount after optionally popping the payment ID, which could lead to reading from an empty argument list or misinterpreting arguments. The patch removes the obsolete payment ID handling and tightens the argument limit to 4, preventing the out-of-bounds or misdirected read. There is no evidence in the commit that this was exploitable for code execution or theft; it appears to be a defensive correctness fix.
AI review queuedutils/openrc: require net dependencyby jpk68 · 6c5ac121 · Jul 9, 2026 · 1 fileMessage 45 · ThinInformational 19Details
Commit message · jpk68
utils/openrc: require net dependency
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 19/100
This commit changes the Monero daemon's OpenRC service script so that it now requires ('needs') a working network and uses DNS, rather than merely starting after the network service. This is a service-dependency hardening fix: it helps ensure the Monero daemon does not start without network connectivity, which could prevent misbehavior or partial startup failures. It is not a code vulnerability fix and does not directly allow an attacker to exploit the daemon.
AI review queuedwallet: rpc; req. ssl cert params w/ proxy when daemon not onion/i2pby nahuhh · 2f2409df · Jul 8, 2026 · 1 fileMessage 50 · ThinModerate 63Details
Commit message · nahuhh
wallet: rpc; req. ssl cert params w/ proxy when daemon not onion/i2p
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Moderate 63/100
This change tightens security for Monero wallet users who connect to a daemon through a proxy (such as Tor or I2P). Previously, when a proxy was used, the wallet did not require users to supply a way to verify the daemon's SSL certificate. That could let a malicious exit node or proxy operator impersonate the daemon and steal wallet data or funds. The patch now requires strong verification (a known certificate, fingerprint, or an onion/i2p address) whenever a proxy or SSL is used.
AI review queuedwallet: rpc; dont allow startup with missing ssl paramsby nahuhh · 4036e145 · Jul 8, 2026 · 1 fileMessage 50 · ThinLow 45Details
Commit message · nahuhh
wallet: rpc; dont allow startup with missing ssl params
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 45/100
This change makes the Monero wallet RPC server refuse to start if its SSL/TLS-related settings are incomplete or invalid. Previously, the server may have started anyway when only a wallet directory was supplied, potentially leaving the RPC interface in an unintended security state. The fix validates the configuration early by running a dummy wallet creation check before proceeding.
✓ Descriptive subject! No meaningful explanatory body! Opaque security-relevant change
Why it was queued
cryptography-sensitive path
AI analysis · Low 29/100
This commit adds new cryptographic code to Monero that converts points on the Ed25519 curve into Weierstraß (short Weierstrass) form. It introduces helper functions, new curve constants, and unit tests, but does not appear to fix any known vulnerability. The change is a feature addition for the FCMP++ (Full Chain Membership Proofs) work. There is no direct evidence in the commit or supplied references that this patch addresses a security bug, but any new elliptic-curve conversion code carries implementation-risk that could affect correctness or side-channel resistance if used incorrectly.
AI review queuedescape control characters in json string serialiserby alhudz · b305c44f · Jul 8, 2026 · 2 filesMessage 50 · ThinModerate 65Details
Commit message · alhudz
escape control characters in json string serialiser
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Moderate 65/100
This commit fixes the way Monero's internal JSON serializer handles special low-value characters (control characters). Previously, characters such as vertical tab and other invisible control characters were either escaped in non-standard ways or left unescaped, which could produce JSON that violates the official JSON standard (RFC 8259). Invalid JSON can confuse other programs that read Monero's output, and in the worst case could be abused to alter how data is parsed or to inject unexpected content. The patch now correctly escapes all control characters and adds tests to prove it.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Moderate 67/100
This commit adds a new cryptographic safety check for Monero's upcoming FCMP++ (Full Chain Membership Proof) system. It makes sure that certain elliptic-curve points used in transactions are free of small 'torsion' components—mathematical artifacts that can be exploited in some zero-knowledge proof attacks. The patch introduces helper functions to clear torsion and a new validation routine, plus tests. It does not by itself fix a known exploitable bug in live code; it is a defensive hardening measure for a feature that is still being integrated.
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
privacy or spend-authorization protocolsigning or wallet path
AI analysis · Low 44/100
This commit fixes a bug in Monero's wallet software where exporting 'key images' (cryptographic proofs that help verify account balances without exposing private keys) could use an outdated cached value instead of the freshly generated correct one. The change ensures the wallet always exports the newly generated key image, and adds a test to confirm this behavior. If the wrong key image were exported, a wallet relying on it could fail to prove ownership of funds correctly, potentially causing accounting errors or denial of service in balance verification.