XMR
← All projectsMonero Project

Monero

Reference Monero node, command-line wallet, consensus, networking, and cryptographic protocol implementation.

Cryptographic librariesMoneroNode implementationsPrivacy protocolsNormal
Repository coverage

936 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

278security candidates305second-pass queue583AI analyses
116commits · 30 days
247commits · 60 days
685commits · 180 days
899commits · 365 days
Backfill bands
Sep 27 → Mar 3192 seen34 candidatesComplete
Mar 31 → Jul 29369 seen101 candidatesComplete
Jul 29 → Aug 28128 seen36 candidatesComplete
Aug 28 → Sep 2788 seen21 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

53/100 average clarity
22Strong · 80–100
158Adequate · 60–79
690Thin · 40–59
66Opaque · 0–39
14security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
jeffro256664153257
koe424258
tobtoht35281200155
Cole Munz424177
Masamune222164
SNeedlewoods906152
selsta17751100051
j-berman443035058
jpk68931655046
Samy451129048
Thomas271015057
SChernykh1188062
Analysis record

Published AI watches

Last scanned 43 minutes ago

Informational 15 AI analysisMessage 68 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11439

This commit only adds a new automated test tool (a fuzzer) for the Monero wallet. It does not change any production wallet, node, or consensus code. It cannot by itself introduce a vulnerability that affects real users, nor does it fix one…

f8632a38by tobtoht+355−02 files
No security note in commit
Informational 24 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11741

This is a cleanup and refactoring patch for Monero's new FCMP++ (full-chain membership proof) database and transaction handling code. It renames a method, fixes typos and comments, tightens a constant name, adds a safety check that outputs…

Added runtime invariant check that locked outputs do not unlock below the default unlock blockRefactored transparent-amount commitment collection to reduce indirection and potential misuseClarified unlock-time semantics and coinbase detection in migration code
f9e6b2c1by tobtoht+77−598 files
No security note in commit
Low 25 AI analysisMessage 53 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

db: cleanup following PR #11425

This commit is a cleanup and hardening patch following an earlier pull request. It adds a safety check to make sure outputs are not incorrectly treated as spendable before they should be, fixes several typos and variable-name issues, rewri…

Added invariant check that outputs unlock no earlier than the default unlock block before adding locked outputs to the databaseRefactored transparent-amount commitment collection to remove std::reference_wrapper indirection, reducing complexityCorrected constant-name typos in spendable-age calculations
e108199dby koe+77−598 files
No security note in commit
Low 30 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11732

This is a one-line fix in Monero's wallet software that adjusts how far ahead the wallet tries to 'skip' scanning after a blockchain reorganization (reorg). A reorg happens when the network briefly disagrees on the chain of blocks and then…

Incorrect scan resume height after blockchain reorgPotential missed transaction detectionBalance accuracy issue in wallet
4ab1a673by tobtoht+1−01 file
No security note in commit
Informational 19 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11739

This commit is a code cleanup that replaces the non-standard WIN32 preprocessor macro with the compiler-defined _WIN32 macro across 18 files. It does not change program logic or behavior; it only makes Windows-specific code detection more …

No functional code changes observedPreprocessor macro standardization onlyWindows-specific code paths remain identical in behavior
90ab1660by tobtoht+52−5218 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11438

This commit only adds a new automated security test (a fuzzer) for Monero's wallet cache file parser. It does not change any production wallet code, fix a bug, or introduce a vulnerability. It is a testing-only addition intended to help fi…

Adds a fuzz target for wallet cache deserializationNo changes to production code pathsNo patch of a reported vulnerability
7b6d76b1by tobtoht+144−02 files
No security note in commit
Low 26 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11737

This Monero update adds a cache that remembers which transactions in the memory pool have already failed expensive input verification, so the node does not waste CPU re-checking the same bad transaction repeatedly. It is a performance and …

Adds caching of invalid input verification IDs to avoid repeated expensive ring signature verificationReduces CPU consumption for transactions that re-enter or remain in the mempool with unchanged invalid inputsCould mitigate a minor denial-of-service vector where a node repeatedly re-verifies a bad transaction
dfa1a30dby tobtoht+56−104 files
No security note in commit
Moderate 51 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11710

This patch changes how Monero's daemon calculates the total coinbase transaction sum (emission plus fees) for a range of blocks. Previously, the code called a general 'get_transactions' helper that could trigger a deadlock because it might…

Deadlock avoidance in consensus-related coinbase emission calculationChange from general transaction retrieval to direct, pruned database readAddition of functional test covering coinbase sum correctness
e64f2bc1by tobtoht+8−42 files
No security note in commit
Informational 19 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11714

This change is a performance optimization for the Monero wallet's balance-reporting RPC. When a user asks for balances across many subaddresses, the code now pre-counts unspent outputs in one pass instead of re-scanning the entire transact…

da768cd9by tobtoht+18−12 files
No security note in commit
Moderate 59 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11720

This update adds a safety check in the Monero wallet's fast refresh process. Previously, if a malicious or buggy remote server told the wallet to start syncing from a block height beyond the wallet's known blockchain data, the wallet could…

Added bounds check on untrusted server-supplied start_height against local hash chain sizeDefensive hardening at wallet/daemon trust boundaryUnit test demonstrates rejection of out-of-bounds refresh request
c4a1491bby tobtoht+34−02 files
No security note in commit
Moderate 61 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11724

This commit tightens filename validation in the Monero wallet's remote-control interface (RPC server). It now rejects wallet names that are just '.' or '..', contain a hidden null character, or contain path separators like '/' (and on Wind…

Path-traversal defense: blocks directory separators and parent-directory references in wallet filenamesNull-byte injection defense: rejects embedded NUL characters that could truncate or confuse downstream path handlingRPC input validation hardening in wallet_rpc_server
084af8f6by tobtoht+3−61 file
No security note in commit
Moderate 67 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11726

This Monero wallet update fixes a file-handling bug in the 'save wallet as' function. Previously, the code compared only the main wallet cache path and used a simple path check that could be fooled by symlinks or filenames ending in '.keys…

Path overlap / self-overwrite protection for wallet cache and keys filesSymlink and hardlink alias detection using boost::filesystem::equivalentRejection of ambiguous paths where .keys file and cache file could collide
b5402182by tobtoht+266−62 files
No security note in commit
Low 27 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11697

This commit adds an optional, faster way to set up N-of-N Monero multisig wallets. Normally, all signers must complete a final verification round to prove they are active and have finished setup. The new 'fast non-interactive setup' skips …

New feature adds a non-default, opt-in fast setup path that intentionally weakens a liveness/verification guaranteeForce-update flag (force_update_use_with_caution) is used internally to bypass the normal post-KEX roundUser-facing and API documentation clearly warn that funds may become inaccessible if other signers do not complete setup
df52dd3eby tobtoht+301−1512 files
No security note in commit
Moderate 57 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11696

This change refactors how Monero's wallet fetches transaction data when creating or verifying 'spend proofs'—cryptographic receipts that prove you spent funds. Previously, spend-proof code fetched transactions directly from the network dae…

Refactoring of spend-proof transaction lookup to a single helperAddition of explicit RPC timeout parameter to transaction fetch helperImproved daemon RPC error/status reporting in get_tx_for_proof
49ee3f43by tobtoht+9−422 files
No security note in commit
Low 37 AI analysisMessage 68 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11693

This commit refactors how the Monero wallet fetches a transaction when verifying a payment proof (the check_tx_key feature). It replaces a direct daemon RPC call with a helper function called get_tx_for_proof, which is described in the com…

Replaces direct /gettransactions RPC with centralized helper for proof verificationCommit title explicitly frames change as 'verify v1 txid in check_tx_key'Removes local tx_hash == txid equality check in favor of helper-internal verification
a2ef2c6aby tobtoht+5−241 file
No security note in commit
Low 44 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11655

This change stops a Monero wallet from creating 'InProofs' (receipt proofs) for transactions that the wallet itself sent. InProofs are meant to prove to someone else that you received money. If a wallet could generate an InProof for a tran…

Prevents generation of misleading InProofs for outgoing/self-sent transactionsAdds explicit runtime guard in wallet proof generation pathFunctional tests updated to assert refusal behavior
61055c9dby tobtoht+47−392 files
No security note in commit
Moderate 57 AI analysisMessage 58 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11603

This patch fixes a bug in the Monero wallet where, if a pending transaction failed, the wallet could incorrectly mark coins as unspent even though they had already been spent by a separate confirmed transaction. This could let the wallet t…

Incorrect state reset on failure pathPotential double-spend attempt caused by stale UTXO selectionWallet balance/availability inconsistency after failed pending tx
7b3f6271by tobtoht+2−01 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11492

This commit only adds a new automated fuzz-testing harness for Monero wallet features. It does not change any production wallet code, fix a bug, or alter network behavior. It is a test-only addition intended to help find bugs in the future…

Adds fuzz targets for payment URI parsing and transaction proof verificationNo changes to production wallet, consensus, or network codeNo bug fix or behavior change in existing source files
4014125fby tobtoht+364−02 files
No security note in commit
Low 27 AI analysisMessage 66 · Adequate
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

Merge pull request #11653

This Monero update fixes a bug in how nodes ask each other for blockchain history. Previously, a node could get stuck or drop a peer when it already knew about some blocks from another connection, because it would not ask for the next batc…

P2P protocol synchronization logic changePotential denial-of-service via peer dropping or sync stallNo authentication or cryptographic boundary crossed
8b99fe43by tobtoht+55−02 files
No security note in commit
Moderate 65 AI analysisMessage 45 · Thin
XMR Monero ProjectMonero Cryptographic librariesMoneroNode implementationsPrivacy protocols

wallet2: handle .keys saves and overlapping paths

This commit fixes a bug in how the Monero wallet saves itself to disk. Previously, the wallet could accidentally overwrite or corrupt its own files when the user chose a path that overlapped with existing wallet files, such as saving to a …

File overwrite / corruption prevention in wallet save path handlingSymlink and hardlink alias detection via filesystem equivalent() checksRejection of overlapping source/destination wallet files
4cc0e506by Samy+266−62 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityMerge pull request #11701by tobtoht · ebaf5fb1 · Nov 19, 2026 · 1 fileMessage 70 · AdequateTriage 0Details
Commit message · tobtoht

Merge pull request #11701

23e3ef5 unit_tests: run ban.file_banlist offline to avoid p2p port conflict (jpk68)

ACKs: selsta, SNeedlewoods

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge pull request #11678by tobtoht · 2bf1cacf · Nov 19, 2026 · 2 filesMessage 58 · ThinTriage 0Details
Commit message · tobtoht

Merge pull request #11678

65b8703 p2p: schedule timed sync independently across network zones (selsta)

ACKs: jpk68, vtnerd

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge pull request #11439by tobtoht · f8632a38 · Nov 19, 2026 · 2 filesMessage 68 · AdequateInformational 15Details
Commit message · tobtoht

Merge pull request #11439

ddf3858 OSS-Fuzz: Add fuzzer targets wallet scan (Arthur SC Chan)

ACKs: selsta, jpk68

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new automated test tool (a fuzzer) for the Monero wallet. It does not change any production wallet, node, or consensus code. It cannot by itself introduce a vulnerability that affects real users, nor does it fix one. It is purely test infrastructure.

Security candidateMerge pull request #11741by tobtoht · f9e6b2c1 · Nov 19, 2026 · 8 filesMessage 58 · ThinInformational 24Details
Commit message · tobtoht

Merge pull request #11741

e108199 db: cleanup following PR #11425 (koe)

ACKs: j-berman*, selsta, jpk68, thomasbuilds

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 24/100

This is a cleanup and refactoring patch for Monero's new FCMP++ (full-chain membership proof) database and transaction handling code. It renames a method, fixes typos and comments, tightens a constant name, adds a safety check that outputs are not spendable too early, and simplifies how transparent (non-hidden) coin amounts are collected. There is no direct evidence in the commit that this fixes an active exploit; it reads as hardening and code-quality improvements following a larger earlier change.

Security candidatedb: cleanup following PR #11425by koe · e108199d · Nov 18, 2026 · 8 filesMessage 53 · ThinLow 25Details
Commit message · koe

db: cleanup following PR #11425

53/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
cryptography-sensitive path
AI analysis · Low 25/100

This commit is a cleanup and hardening patch following an earlier pull request. It adds a safety check to make sure outputs are not incorrectly treated as spendable before they should be, fixes several typos and variable-name issues, rewrites a helper function to avoid an unnecessary indirection, and improves comments. There is no direct evidence in the commit that an exploitable vulnerability exists; rather, the changes reduce the chance of future bugs in how Monero tracks spendable outputs for its new FCMP++ membership proofs.

Lower-priorityMerge pull request #11738by tobtoht · 05fa7646 · Nov 18, 2026 · 1 fileMessage 58 · ThinTriage 0Details
Commit message · tobtoht

Merge pull request #11738

8e9f05f FCMP++: rm unused leftover artifacts from db migration (Justin Berman)

ACKs: jpk68, thomasbuilds

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge pull request #11732by tobtoht · 4ab1a673 · Nov 18, 2026 · 1 fileMessage 58 · ThinLow 30Details
Commit message · tobtoht

Merge pull request #11732

55e25d2 wallet2: lower scan skip height on reorg (selsta)

ACKs: jpk68, jeffro256

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 30/100

This is a one-line fix in Monero's wallet software that adjusts how far ahead the wallet tries to 'skip' scanning after a blockchain reorganization (reorg). A reorg happens when the network briefly disagrees on the chain of blocks and then switches to a different version. The change lowers the skip height so the wallet does not skip past blocks it actually needs to re-scan, which could otherwise cause the wallet to miss transactions or show an incorrect balance.

Security candidateMerge pull request #11739by tobtoht · 90ab1660 · Nov 18, 2026 · 18 filesMessage 58 · ThinInformational 19Details
Commit message · tobtoht

Merge pull request #11739

fc1e7c5 src: use compiler-defined win32 macro (jpk68)

ACKs: selsta, tobtoht

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 19/100

This commit is a code cleanup that replaces the non-standard WIN32 preprocessor macro with the compiler-defined _WIN32 macro across 18 files. It does not change program logic or behavior; it only makes Windows-specific code detection more reliable and portable. There is no direct security vulnerability being fixed here, though using the compiler-defined macro reduces the risk of build misconfiguration on Windows.

Lower-priorityMerge pull request #11453by tobtoht · f89bd0ba · Nov 18, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · tobtoht

Merge pull request #11453

16f6d3b OSS-Fuzz: Add new fuzzer targets fcmp-pp (Arthur SC Chan)

ACKs: jpk68, selsta

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencemerge-commit duplicate discount
AI review queuedMerge pull request #11438by tobtoht · 7b6d76b1 · Nov 18, 2026 · 2 filesMessage 68 · AdequateInformational 15Details
Commit message · tobtoht

Merge pull request #11438

cbec7a4 OSS-Fuzz: Add new fuzzer targets wallet cache (Arthur SC Chan)

ACKs: PyXMR2025, jpk68, selsta

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
fuzzing or regression evidencesigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new automated security test (a fuzzer) for Monero's wallet cache file parser. It does not change any production wallet code, fix a bug, or introduce a vulnerability. It is a testing-only addition intended to help find bugs in the future.

Lower-priorityMerge pull request #11717by tobtoht · 7bb7a611 · Nov 18, 2026 · 2 filesMessage 68 · AdequateTriage 0Details
Commit message · tobtoht

Merge pull request #11717

5be6f44 FCMP++: test improvements by @thomasbuilds (Justin Berman)

ACKs: jpk68, thomasbuilds, selsta, redsh4de

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge pull request #11737by tobtoht · dfa1a30d · Nov 18, 2026 · 4 filesMessage 58 · ThinLow 26Details
Commit message · tobtoht

Merge pull request #11737

ea52a51 tx_pool: cache invalid input verID's for txs in the pool (Justin Berman)

ACKs: selsta, thomasbuilds, jeffro256

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Low 26/100

This Monero update adds a cache that remembers which transactions in the memory pool have already failed expensive input verification, so the node does not waste CPU re-checking the same bad transaction repeatedly. It is a performance and denial-of-service hardening change, not a fix for a currently exploitable vulnerability. The commit message and code comments describe it as a caching improvement, not a security patch.

Lower-priorityMerge pull request #11734by tobtoht · fade3206 · Nov 18, 2026 · 1 fileMessage 66 · AdequateTriage 0Details
Commit message · tobtoht

Merge pull request #11734

03f1ee6 FCMP++: stronger db check when overwriting last layer elem in tree (Justin Berman)

ACKs: selsta, jpk68, UkoeHB, thomasbuilds

66/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Lower-priorityMerge pull request #11704by tobtoht · ad81f267 · Nov 16, 2026 · 1 fileMessage 58 · ThinTriage 0Details
Commit message · tobtoht

Merge pull request #11704

b0aa339 Keys: 3rd update for expired 'rbrunner7' key, valid 2 years (rbrunner7)

ACKs: selsta, thomasbuilds

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
Security candidateMerge pull request #11710by tobtoht · e64f2bc1 · Nov 16, 2026 · 2 filesMessage 58 · ThinModerate 51Details
Commit message · tobtoht

Merge pull request #11710

ea04c71 cryptonote_core: avoid coinbase sum deadlock (Samy)

ACKs: jpk68, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Moderate 51/100

This patch changes how Monero's daemon calculates the total coinbase transaction sum (emission plus fees) for a range of blocks. Previously, the code called a general 'get_transactions' helper that could trigger a deadlock because it might re-enter the same database locks held by the caller. The fix fetches only the raw, pruned transaction blobs directly from the database and parses just the transaction base, avoiding the broader locking path. A functional test was added to verify the coinbase sum matches the block reward and reported fee.

AI review queuedMerge pull request #11714by tobtoht · da768cd9 · Nov 16, 2026 · 2 filesMessage 58 · ThinInformational 19Details
Commit message · tobtoht

Merge pull request #11714

c87aaa5 wallet rpc: batch unspent counts in get_balance (Samy)

ACKs: jpk68, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This change is a performance optimization for the Monero wallet's balance-reporting RPC. When a user asks for balances across many subaddresses, the code now pre-counts unspent outputs in one pass instead of re-scanning the entire transaction list once per subaddress. The functional test was updated to check that a multi-subaddress balance query returns the same results as before. There is no security vulnerability here.

AI review queuedMerge pull request #11720by tobtoht · c4a1491b · Nov 16, 2026 · 2 filesMessage 58 · ThinModerate 59Details
Commit message · tobtoht

Merge pull request #11720

0a424db wallet2: check upper bound in fast_refresh (Jan Kahmen)

ACKs: jpk68, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 59/100

This update adds a safety check in the Monero wallet's fast refresh process. Previously, if a malicious or buggy remote server told the wallet to start syncing from a block height beyond the wallet's known blockchain data, the wallet could proceed with inconsistent state. Now the wallet detects this condition, logs an error, and stops. The change prevents potential wallet corruption or confusion caused by untrusted server responses.

Lower-priorityMerge pull request #11721by tobtoht · 391873da · Nov 16, 2026 · 1 fileMessage 68 · AdequateTriage 0Details
Commit message · tobtoht

Merge pull request #11721

a67f02e tests: avoid shutdown race in I2P SAM reconnect test (selsta)

ACKs: jpk68, thomasbuilds

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
merge-commit duplicate discount
AI review queuedMerge pull request #11724by tobtoht · 084af8f6 · Nov 16, 2026 · 1 fileMessage 58 · ThinModerate 61Details
Commit message · tobtoht

Merge pull request #11724

0cacd83 wallet_rpc_server: harden wallet filename validation (selsta)

ACKs: jpk68, thomasbuilds

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
defensive validationsigning or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 61/100

This commit tightens filename validation in the Monero wallet's remote-control interface (RPC server). It now rejects wallet names that are just '.' or '..', contain a hidden null character, or contain path separators like '/' (and on Windows also '\' and ':'). This prevents callers from tricking the server into opening or creating wallet files outside the intended directory, which could lead to files being written in unexpected places or existing wallets being accessed.

AI review queuedMerge pull request #11726by tobtoht · b5402182 · Nov 16, 2026 · 2 filesMessage 58 · ThinModerate 67Details
Commit message · tobtoht

Merge pull request #11726

4cc0e50 wallet2: handle .keys saves and overlapping paths (Samy)

ACKs: jpk68*, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 67/100

This Monero wallet update fixes a file-handling bug in the 'save wallet as' function. Previously, the code compared only the main wallet cache path and used a simple path check that could be fooled by symlinks or filenames ending in '.keys'. The patch now checks both the cache file and the encrypted keys file, detects when the destination overlaps the current wallet via symlinks or tricky paths, and rejects unsafe saves. If exploited, an attacker or malfunctioning script could have overwritten or corrupted wallet files; the patch prevents that.

Lower-priorityMerge pull request #11746by tobtoht · 3ae9ded9 · Nov 16, 2026 · 1 fileMessage 58 · ThinTriage 0Details
Commit message · tobtoht

Merge pull request #11746

43b7aa0 fcmp_pp: link Windows synchronization after Rust (Samy)

ACKs: selsta, jpk68

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
documentation-only discountmerge-commit duplicate discount
AI review queuedMerge pull request #11697by tobtoht · df52dd3e · Nov 16, 2026 · 12 filesMessage 58 · ThinLow 27Details
Commit message · tobtoht

Merge pull request #11697

46cfa05 wallet: add n-of-n multisig fast non-interactive setup (jpk68)

ACKs: UkoeHB, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 27/100

This commit adds an optional, faster way to set up N-of-N Monero multisig wallets. Normally, all signers must complete a final verification round to prove they are active and have finished setup. The new 'fast non-interactive setup' skips that final round for convenience, but the code and user-facing warnings clearly note the trade-off: you cannot be sure the other signers are alive or finished, so funds sent to the shared address could become permanently inaccessible if any signer failed. The change is explicitly opt-in, gated by warnings, and restricted to N-of-N (e.g., 2-of-2, 3-of-3) setups. It is not a bug fix or a secret backdoor; it is a documented feature with a known risk.

AI review queuedMerge pull request #11696by tobtoht · 49ee3f43 · Nov 16, 2026 · 2 filesMessage 58 · ThinModerate 57Details
Commit message · tobtoht

Merge pull request #11696

3b24f26 wallet2: bind v1 spend proofs to the requested transaction (Samy)

ACKs: jpk68, selsta

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 57/100

This change refactors how Monero's wallet fetches transaction data when creating or verifying 'spend proofs'—cryptographic receipts that prove you spent funds. Previously, spend-proof code fetched transactions directly from the network daemon in two separate places. Now it uses a single helper function, and importantly, that helper now passes through a configurable network timeout and reports daemon errors more precisely. The commit title says the goal is to bind v1 spend proofs to the requested transaction, suggesting the previous code may have used the wrong transaction under some edge cases. However, the diff itself does not show a clear bug being fixed; it mostly consolidates duplicated code and tightens error handling.

AI review queuedMerge pull request #11693by tobtoht · a2ef2c6a · Nov 16, 2026 · 1 fileMessage 68 · AdequateLow 37Details
Commit message · tobtoht

Merge pull request #11693

203add0 wallet: verify v1 txid in check_tx_key (Samy)

ACKs: jpk68, selsta

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 37/100

This commit refactors how the Monero wallet fetches a transaction when verifying a payment proof (the check_tx_key feature). It replaces a direct daemon RPC call with a helper function called get_tx_for_proof, which is described in the commit title as adding verification for older v1 transaction IDs. The change appears intended to prevent a wallet from being tricked by a fake or mismatched transaction when checking a proof, but the diff itself only shows the refactoring, not the new helper's implementation.

AI review queuedMerge pull request #11655by tobtoht · 61055c9d · Nov 16, 2026 · 2 filesMessage 58 · ThinLow 44Details
Commit message · tobtoht

Merge pull request #11655

bf8d372 wallet2: refuse InProofs for transactions the wallet sent (Thomas)

ACKs: selsta, jpk68

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 44/100

This change stops a Monero wallet from creating 'InProofs' (receipt proofs) for transactions that the wallet itself sent. InProofs are meant to prove to someone else that you received money. If a wallet could generate an InProof for a transaction it sent, a user might trick someone into believing they had received funds when they had actually sent them to themselves (including change outputs). The patch adds a guard that refuses to create such proofs and updates tests to verify the refusal.