LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

301 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

75security candidates126second-pass queue60AI analyses
59commits · 30 days
82commits · 60 days
231commits · 180 days
301commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

51/100 average clarity
13Strong · 80–100
76Adequate · 60–79
157Thin · 40–59
55Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala1674838155
Ilya Artemov952621145
github-actions[bot]1711046
Mathias BROUSSET1400040
José Luis Landabaso Díaz400067
iartemov-ledger100043
Cerberus Merlin100062
Charles-Edouard de la Vergne100045
Michael Evans100073
Analysis record

Published AI watches

Last scanned 23 minutes ago

Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Propagate crypto_tr_lift_x errors in cpoint

This commit fixes a small but meaningful bug in the Ledger Bitcoin app's code that handles advanced multi-signature (MuSig) operations. A function called crypto_tr_lift_x can fail when given an invalid x-coordinate that does not correspond…

Unchecked return value from cryptographic point-lifting functionPotential use of invalid/uninitialized curve point in MuSig signing flowMissing error propagation in compressed public-key parsing
18647877by Salvatore Ingala+7−12 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Type consistency in psbt_parse_rawtx, and some other hardenings

This commit hardens a Bitcoin transaction parser in Ledger's app. It changes some numeric fields to safer types, adds bounds checks on transaction counts and sizes, rejects extra trailing bytes after a transaction, checks a previously-igno…

Integer type narrowing and sentinel change from -1 to SIZE_MAXBounds checks before uint64_t to unsigned int castsReturn value of parser_consolidate_buffers now checked
1af86279by Salvatore Ingala+66−173 files
No security note in commit
Informational 21 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Display total amount of external inputs when reliable

This commit changes what information the Ledger Bitcoin app shows on its screen when signing a transaction that includes 'external inputs'—coins the user did not provide and whose amounts the device cannot independently verify. Previously …

UI/UX hardening: additional contextual data shown for transactions with unverified external inputsNo change to cryptographic checks, sighash validation, or input verificationExternal inputs warning is preserved; new data is displayed only when the input set is closed (no ANYONECANPAY)
26f631c5by Salvatore Ingala+126−174 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Trustworthy sign_psbt amount/fee display for non-default sighash: snapshots

This commit only updates test screenshot snapshots for the Ledger Bitcoin app. It does not change any application source code, so it cannot directly fix or introduce a security vulnerability in the shipped app. The snapshots reflect new ex…

No source-code changes in the commitOnly test snapshot images (PNG) are modified or addedCommit title references trustworthy amount/fee display for non-default sighash, suggesting a prior functional change exists elsewhere
086967aeby github-actions[bot]+0−0840 files
No security note in commit
Informational 12 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Trustworthy sign_psbt amount/fee display for non-default sighash: integration tests

This commit only adds and updates automated integration tests for the Ledger Bitcoin app. It does not change the app's actual signing code. The tests verify that the device now shows clearer, more trustworthy on-screen amount and fee infor…

No C/device firmware code changesTest-only commit adjusting UI navigation expectationsNew tests assert that negative fees are rejected for default sighash but allowed/relabeled for ANYONECANPAY sighash
bb6a6aadby Ilya Artemov+175−325 files
No security note in commit
Informational 12 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Trustworthy sign_psbt amount/fee display for non-default sighash: unit-tests

This commit only adds new automated unit tests for functions that decide how transaction amounts and fees are displayed on a Ledger device when signing a Bitcoin transaction with non-standard signature hash (sighash) modes. It does not cha…

Commit title references trustworthy amount/fee display for non-default sighash, a historically sensitive area in hardware-wallet signing UITests cover sighash commitment semantics (SIGHASH_NONE, SIGHASH_SINGLE, SIGHASH_ANYONECANPAY combinations) that directly affect what outputs a signature commits toNo functional code changes in this commit; only unit-test additions
d44e34ddby Ilya Artemov+102−01 file
No security note in commit
Moderate 59 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Trustworthy sign_psbt amount/fee display for non-default sighash: implementation

This commit changes how the Ledger Bitcoin app shows transaction amounts and fees on the device screen when a user signs a transaction that does not use the normal 'sign everything' rule (a so-called non-default sighash). Previously the ap…

UI trust reduction for non-default sighash prevents misleading fee/amount displaySighash classification helpers centralize ANYONECANPAY/NONE/SINGLE semanticsMixed-sighash detection disables coherent amount display
d4525576by Ilya Artemov+451−6612 files
No security note in commit
Informational 11 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Remove initial search for sentinel

This commit is a small code cleanup in the Ledger Bitcoin app. It removes an initial loop that counted commands and instead checks for the end marker directly while processing. The author says the old loop was unnecessary and caused a harm…

Commit message explicitly frames the change as removing a redundant scan and a static-analysis false positive, not as a security fix.No change to parsing, cryptography, authorization, or transaction semantics.Functional behavior for valid command lists is equivalent before and after the patch.
0ae87d9cby Salvatore Ingala+99−1051 file
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix slight mismatch in definition of crypto_hash160

This commit only fixes a documentation/declaration inconsistency in a C header file. The function parameter name in the comment is changed from `in_len` to `inlen` to match the actual declaration, and the output pointer is annotated with a…

54587441by Salvatore Ingala+3−31 file
No security note in commit
Informational 19 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add support for generating PSBTs for MuSig2 in txmaker

This commit adds test-only helper code for creating Bitcoin transaction fixtures that support newer wallet types (MuSig2 multi-signature and several legacy/wrapped SegWit descriptor forms). It is not a change to the Ledger app firmware its…

No security-relevant signal: change is in test utilities onlyAdds cryptographic helper for MuSig2 key aggregation in test fixturesAdds P2SH/P2SH-P2WPKH/P2SH-P2WSH script generation in test fixtures
13d84acaby Salvatore Ingala+211−112 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Various improvements, refactorings and simplifications from PR review

This commit is purely a build-system and test-harness cleanup. It refactors CMakeLists.txt, updates comments, simplifies the speculos test bridge, and removes a workaround in a test file. Nothing here changes the actual Ledger Bitcoin app …

1e4853f1by Salvatore Ingala+388−4274 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add unit tests for crypto_ripemd160, crypto_hash160, crypto_get_checksum

This commit only adds new unit tests and renames some existing test functions. It does not change any production code behavior, so it cannot introduce a security vulnerability or fix one on its own.

af900978by Salvatore Ingala+136−172 files
No security note in commit
Informational 12 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add unit tests for crypto_ecdsa_sign_sha256_hash_with_key

This commit only adds unit tests and a test-only bridge implementation for cryptographic signing functions. It does not change the actual device application code that users rely on, so it cannot introduce a security vulnerability in the sh…

96a9203dby Salvatore Ingala+107−112 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Delete mock_include, rely on the speculos_bridge for all tests

This commit is a test-only refactoring: it removes a set of local mock SDK headers and a software SHA-256 implementation used by unit tests, and instead makes those tests run against the real Ledger SDK headers through the existing Speculo…

No production code changesTest infrastructure refactoring onlyRemoval of local cryptographic mock in favor of real SDK/speculos bridge
6f7b4472by Salvatore Ingala+79−352528 files
No security note in commit
Informational 15 AI analysisMessage 75 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Link unit tests with speculos implementations of crypto syscalls

This commit is purely about improving the project's automated test setup. It links unit tests to a software simulator (Speculos) so cryptographic code can be tested on a regular computer without a physical Ledger device. It adds tests for …

53a997c6by Salvatore Ingala+747−296 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Get rid of SKIP_FOR_CMOCKA; compile tests with the speculos bridge

This commit is purely a testing infrastructure cleanup. It removes a workaround called SKIP_FOR_CMOCKA that previously hid parts of the code from unit tests, and instead compiles those parts using a more realistic emulator bridge (speculos…

c098c659by Salvatore Ingala+37−8210 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add unit tests for crypto_get_compressed_pubkey_at_path

This commit only adds unit tests and test-support code. It does not change the actual Bitcoin app that runs on Ledger devices, so it cannot introduce a security vulnerability in shipped firmware. The changes make the test harness able to s…

86fa0b30by Salvatore Ingala+429−1164 files
No security note in commit
Informational 15 AI analysisMessage 75 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add minimal utility functions to work with serialized xpub in unit tests

This commit only adds helper functions for unit tests to convert Bitcoin extended public keys (xpubs) between base58 string form and raw binary form. It does not change the actual Ledger app code that runs on the device, nor does it fix or…

31a302d2by Salvatore Ingala+151−1124 files
No security note in commit
Informational 15 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Unit tests for the crypto_tr_* taproot helpers

This commit only adds unit tests and test infrastructure for Bitcoin Taproot cryptographic helpers. It does not change the actual app code that runs on the hardware wallet, so it cannot introduce a security vulnerability in shipped firmwar…

cc9ea60dby Salvatore Ingala+310−162 files
No security note in commit
Informational 15 AI analysisMessage 70 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Move some duplicated mocking code to headers

This commit is a routine cleanup of the project's unit-test code. It removes duplicate mock implementations of a small helper function called `pic()` from 14 test files and places a single shared version in a mock header. The change only a…

3ac25325by Salvatore Ingala+4−9415 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedapp-bitcoin-new rename to app-bitcoinby Ilya Artemov · 3975774b · Jul 7, 2026 · 17 filesMessage 45 · ThinTriage 12Details
Commit message · Ilya Artemov

app-bitcoin-new rename to app-bitcoin

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queueddocs: Add user documentationby Salvatore Ingala · f32a3610 · Jun 24, 2026 · 4 filesMessage 87 · StrongTriage 0Details
Commit message · Salvatore Ingala

docs: Add user documentation

Existing documentation is rather detailed on the wire protocol, but
lacks a higher level technical overview of the features and
operating principles of the app.

This commit adds two new high-level guides for technical readers
that are not interested in the details of the wire protocol:

- features.md: high-level overview of the app's features
- integration.md: integration concepts and security model

Also, wallet.md was trimmed to avoid repeating what is in BIP-388.

87/100 · StrongMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Names security-relevant behavior explicitly
Why it was queued
signing or wallet pathdocumentation-only discountsecond-pass: security-sensitive path
AI review queuedSIGHASH gating: status screen on disabled rejectionby Ilya Artemov · 0e35a24d · Jun 23, 2026 · 4 filesMessage 50 · ThinTriage 12Details
Commit message · Ilya Artemov

SIGHASH gating: status screen on disabled rejection

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedSIGHASH gating: update Ragger snapshotsby github-actions[bot] · 84e9bc7c · Jun 23, 2026 · 177 filesMessage 45 · ThinTriage 0Details
Commit message · github-actions[bot]

SIGHASH gating: update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI review queuedSIGHASH gating: tests_mainnetby Ilya Artemov · b67c7982 · Jun 23, 2026 · 1 fileMessage 35 · OpaqueTriage 0Details
Commit message · Ilya Artemov

SIGHASH gating: tests_mainnet

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedSIGHASH gating: functional testsby Ilya Artemov · cb60be9a · Jun 23, 2026 · 3 filesMessage 45 · ThinTriage 12Details
Commit message · Ilya Artemov

SIGHASH gating: functional tests

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedSIGHASH gating: implementationby Ilya Artemov · 296bed60 · Jun 23, 2026 · 6 filesMessage 35 · OpaqueTriage 12Details
Commit message · Ilya Artemov

SIGHASH gating: implementation

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI review queuedRemove bad include directive with CFLAGSby Charles-Edouard de la Vergne · 704b361a · Jun 16, 2026 · 2 filesMessage 45 · ThinTriage 12Details
Commit message · Charles-Edouard de la Vergne

Remove bad include directive with CFLAGS

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedUnit tests for get_extended_pubkeyby Salvatore Ingala · 88fa41c7 · Jun 16, 2026 · 4 filesMessage 68 · AdequateTriage 17Details
Commit message · Salvatore Ingala

Unit tests for get_extended_pubkey

Refactored the handler_get_extended_pubkey to move the actual
logic (after APDU parsing) into a separate function
get_extended_pubkey_response, which get be tested directly based
on the test vectors.

Rafactored some common TOML utilities into toml_helpers.h.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI review queuedAdd unit tests for register_walletby Salvatore Ingala · 0a99cb8e · Jun 16, 2026 · 2 filesMessage 55 · ThinTriage 12Details
Commit message · Salvatore Ingala

Add unit tests for register_wallet

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedNit from PR reviewby Salvatore Ingala · 795a0445 · Jun 16, 2026 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Salvatore Ingala

Nit from PR review

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI review queuedExtract test assets into TOML filesby Salvatore Ingala · 04cdef8b · Jun 16, 2026 · 8 filesMessage 55 · ThinTriage 12Details
Commit message · Salvatore Ingala

Extract test assets into TOML files

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedUnit tests for sign_messageby Salvatore Ingala · b4727094 · Jun 16, 2026 · 2 filesMessage 45 · ThinTriage 12Details
Commit message · Salvatore Ingala

Unit tests for sign_message

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedUpdate sign_message test vectorsby Salvatore Ingala · 867f69c8 · Jun 16, 2026 · 2 filesMessage 45 · ThinTriage 17Details
Commit message · Salvatore Ingala

Update sign_message test vectors

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI review queuedValidate key classification in register_wallet unit testsby Salvatore Ingala · 5cefe555 · Jun 16, 2026 · 3 filesMessage 83 · StrongTriage 20Details
Commit message · Salvatore Ingala

Validate key classification in register_wallet unit tests

By recording what the UI mock receives, we verify that the
handler correctly classifies the key expressions as internal,
external or unspendable.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI review queuedenable stack protectorby Mathias BROUSSET · 257e9766 · Jun 12, 2026 · 2 filesMessage 28 · OpaqueTriage 0Details
Commit message · Mathias BROUSSET

enable stack protector

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedApply clang-21 fixesby Salvatore Ingala · 87fa76f3 · Jun 8, 2026 · 17 filesMessage 28 · OpaqueTriage 12Details
Commit message · Salvatore Ingala

Apply clang-21 fixes

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI review queuedFix and simplify HAVE_SEMIHOSTED_PRINTFby Salvatore Ingala · cdc959d1 · Jun 3, 2026 · 2 filesMessage 35 · OpaqueTriage 0Details
Commit message · Salvatore Ingala

Fix and simplify HAVE_SEMIHOSTED_PRINTF

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedAdd missing includeby Salvatore Ingala · 725fd66a · Jun 3, 2026 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Salvatore Ingala

Add missing include

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI review queuedDelete stale _zero_outputs_mutator; reduced code duplicationby Salvatore Ingala · db4d4c7b · Jun 1, 2026 · 3 filesMessage 50 · ThinTriage 12Details
Commit message · Salvatore Ingala

Delete stale _zero_outputs_mutator; reduced code duplication

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedAdd address generation unit-testsby Salvatore Ingala · e1415280 · May 29, 2026 · 4 filesMessage 55 · ThinTriage 12Details
Commit message · Salvatore Ingala

Add address generation unit-tests

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI review queuedImprove docs of get_merkle_preimage.h; remove stale TODOby Salvatore Ingala · 957eb8cd · May 19, 2026 · 2 filesMessage 30 · OpaqueTriage 0Details
Commit message · Salvatore Ingala

Improve docs of get_merkle_preimage.h; remove stale TODO

30/100 · OpaqueMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body! Contains work-in-progress language
Why it was queued
second-pass: opaque commit message
AI review queuedfix pypi deployby Mathias BROUSSET · 01133ef8 · May 18, 2026 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Mathias BROUSSET

fix pypi deploy

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI review queuedremove pypi tokenby Mathias BROUSSET · 42bdeb0f · May 18, 2026 · 1 fileMessage 28 · OpaqueTriage 0Details
Commit message · Mathias BROUSSET

remove pypi token

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI review queuedMove taptree hash computation in the inner loop of produce_musig2_pubnoncesby Salvatore Ingala · b0d900fd · May 11, 2026 · 1 fileMessage 50 · ThinTriage 12Details
Commit message · Salvatore Ingala

Move taptree hash computation in the inner loop of produce_musig2_pubnonces

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path