LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

447 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

148security candidates154second-pass queue402AI analyses
19commits · 30 days
63commits · 60 days
249commits · 180 days
414commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
50Strong · 80–100
152Adequate · 60–79
186Thin · 40–59
59Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala2981122561062
Ilya Artemov962696145
Ruben Waterman666083
Aymeric Robert434063
github-actions[bot]17117046
Mathias BROUSSET17015039
José Luis Landabaso Díaz404067
iartemov-ledger201051
Cerberus Merlin101062
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 19 minutes ago

Informational 20 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

tests: pin all Python test dependencies to exact versions

This commit pins the exact versions of Python testing tools used by the project's automated tests. Previously, the test setup allowed any newly released version of those tools to be installed automatically, which could introduce unexpected…

Supply-chain risk reduction for test/CI dependenciesPrevents unreviewed automatic upgrades of speculos and raggerNo change to firmware or published package code
def417a3by Salvatore Ingala+329−142 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Bump version to 2.6.0

This commit is a routine version bump from 2.5.1 to 2.6.0 in the Ledger Bitcoin app. It only updates the version number in the Makefile and the release date in the CHANGELOG. There are no code changes, no bug fixes, and no security-related…

2b424b54by Salvatore Ingala+4−42 files
No security note in commit
Moderate 66 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #581 from LedgerHQ/client-fixes

This commit tightens how the Ledger Bitcoin app and its companion client libraries read PSBT (Partially Signed Bitcoin Transaction) data. It adds checks that reject malformed or suspicious PSBTs: truncated fields, unexpected extra bytes af…

Hardened PSBT deserialization against truncation and trailing dataAdded duplicate-key detection in PSBT mapsRejected PSBTv2-only fields inside PSBTv0 to prevent locktime/field override attacks
f8f790a3by Salvatore Ingala+544−17018 files
No security note in commit
Low 47 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

python client: reject PSBTv2-only fields in a PSBTv0

This commit tightens input validation in the Python helper library that prepares Bitcoin transaction data for Ledger hardware wallets. It now rejects PSBT files that claim to be the older version 0 format but contain fields that only belon…

Input-validation hardening: stricter parsing of PSBT version 0 to reject v2-only key typesConsistency fix across clients: aligns Python client with HS and Rust client behaviorLocktime normalization during v0-to-v2 conversion to prevent per-input locktime from overriding transaction locktime
84165be7by Salvatore Ingala+92−02 files
No security note in commit
Informational 24 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

tests: update authproxy.py to the latest version from Bitcoin Core

This commit updates a test helper file used to talk to a Bitcoin node during automated testing. The old helper could accidentally send the same command twice if the network connection hiccuped, which could cause a test-only action like sen…

Removed transparent retry of non-idempotent RPC requests after connection resetsTest helper could execute state-changing RPCs twice before the fixNew connection-per-call configuration mitigates idle-timeout disconnects without retry risk
c7ca508eby Salvatore Ingala+91−522 files
Vendor flagged security relevance
Low 40 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject duplicate keys and trailing data when parsing a PSBT in the JS client

This commit fixes the JavaScript PSBT (Partially Signed Bitcoin Transaction) parser in Ledger's Bitcoin app so it now rejects malformed PSBTs that contain duplicate keys or extra trailing bytes. Previously, such malformed data could be acc…

BIP-174 non-compliance: duplicate keys and trailing data were previously acceptedState reuse bug: deserializing multiple PSBTs in the same instance could merge mapsInput validation gap in client-side PSBT parsing
4942a4aeby Salvatore Ingala+40−02 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

ragger: fail if a request succeeds without showing the expected screens

This commit fixes the automated test harness, not the Ledger Bitcoin app itself. Previously, the test framework could silently pass even when the device completed a request without showing the expected on-screen review. The change makes te…

Test-hardening only: no firmware or runtime application code changedFixes false-negative test results where a request could succeed without expected UI reviewCorrects scope of navigation settings to avoid leaking across nested or subsequent calls
202d352aby Salvatore Ingala+76−957 files
No security note in commit
Low 37 AI analysisMessage 88 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

unit tests: Fix length overflow in unit-test PSBT parser

This commit fixes an arithmetic overflow bug in a test-only PSBT (Bitcoin transaction format) parser used in unit tests. The bug could let a crafted test input make the parser think a data length is huge, potentially confusing the mock dis…

Integer overflow/wrap-around in length calculationOut-of-bounds length derived from arithmetic on attacker-influenced offsetsUnit-test-only code path, not device firmware
6a2a9262by Salvatore Ingala+6−21 file
No security note in commit
Low 48 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

rust client: reject PSBTv2-only fields when converting a PSBTv0

This commit fixes a bug in the Ledger Bitcoin app's Rust client where a PSBT v0 (an older transaction format) could silently carry fields that only have meaning in PSBT v2. When converting v0 to v2, those fields could override values taken…

Input validation added for cross-format PSBT conversionPrevents v2-only fields from overriding unsigned-transaction-derived valuesBIP-370 compliance enforcement for PSBTv0
602055d6by Salvatore Ingala+66−91 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject PSBTv2-only fields when converting a PSBTv0 in the JS client

This commit fixes a bug in the Ledger Bitcoin app's JavaScript client library. When converting an older-style Bitcoin transaction file (PSBT version 0) into the newer PSBT version 2 format, the library previously ignored fields that are on…

Input validation fix: rejects malformed PSBTv0 containing v2-only fieldsPrevents silent override of transaction locktime during PSBTv0-to-v2 conversionAdds missing BIP-370 key type constants for required time/height locktime
a1f6dc84by Salvatore Ingala+66−22 files
No security note in commit
High 72 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject duplicate keys and truncated maps when parsing PSBT maps in sign_psbt

This commit fixes a bug in how the Ledger Bitcoin app client parses PSBT (Partially Signed Bitcoin Transaction) maps. Previously, if the same key appeared twice in a map, the parser silently kept the last value. A malicious or malformed PS…

Silent overwrite of duplicate PSBT map keys could create commitment mismatch between client and deviceTruncated PSBT maps were silently accepted due to exception swallowing in deserialization loopsTrailing data after PSBT maps was ignored, allowing reserialization to silently normalize malformed inputs
75df80f9by Salvatore Ingala+107−104 files
Vendor flagged security relevance
High 72 AI analysisMessage 53 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #579 from LedgerHQ/misc-fixes

This commit fixes several bugs in Ledger's Bitcoin app. The most serious ones are: (1) a set of miniscript policy analyzer mistakes that could let the app accept Bitcoin wallet policies whose scripts are too large or too expensive to execu…

Miniscript cost/property analysis errors that could allow oversized/undercosted wallet policiesHost-driven infinite-loop / denial-of-service via zero-length GET_MORE_ELEMENTS responsesUI state inconsistency causing a security warning to be prematurely dismissed
ec389348by Salvatore Ingala+413−3113 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #576 from LedgerHQ/musig2_improvements

This commit improves the Ledger Bitcoin app's MuSig2 multi-signature feature. It lets wallet software pre-generate public nonces before a transaction is known, adds an optional MUSIG2_SESSION_ID field so multiple signing sessions can be in…

New PSBT proprietary field parsing with length validation (1-32 bytes, empty rejected)Session ID now commits to wallet policy plus optional MUSIG2_SESSION_IDSession storage limit raised from 8 to 32 with LRU eviction
26d22adcby Salvatore Ingala+710−7216 files
No security note in commit
Informational 18 AI analysisMessage 85 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Use signed scratch arrays in the thresh ops and stack size computations

This commit is a small code cleanup in Ledger's Bitcoin app. It changes two local arrays from unsigned (uint16_t) to signed (int16_t) in functions that count operations and stack sizes for Bitcoin miniscript 'thresh' policies. The commit m…

Signed/unsigned type mismatch in sentinel handlingPotential latent integer interpretation bug in miniscript threshold policy analysisCode clarity improvement around invalid (dis)satisfaction markers
4ff6f2f0by Salvatore Ingala+4−41 file
No security note in commit
Low 48 AI analysisMessage 91 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Align miniscript type and ops computations with bitcoin-core

This commit fixes the Ledger Bitcoin app's internal checker for Miniscript wallet policies. The checker was incorrectly rejecting some valid Bitcoin spending policies as unsafe, and in a few places it was computing safety properties using …

Logic change in Miniscript policy analysisAlignment with upstream Bitcoin Core reference implementationRelaxation of overly strict non-malleability and timelock-mixing checks
4694d317by Salvatore Ingala+26−132 files
No security note in commit
Moderate 68 AI analysisMessage 86 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix ops computation for andor fragments

This commit fixes a bug in how the Ledger Bitcoin app counts the number of Bitcoin script operations (ops) needed to spend certain wallet policies that use a 'miniscript andor' fragment. Because the count was wrong, the app could allow use…

Incorrect miniscript ops accounting for andor fragmentPolicy sanity check bypass leading to unspendable registered walletsReference alignment with Bitcoin Core implementation
86159d1eby Salvatore Ingala+40−13 files
Vendor flagged security relevance
High 74 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix ops computation for l: and u: fragments

This commit fixes a bug in how the Ledger Bitcoin app counts Bitcoin script operations ('ops') for two specific Miniscript fragments, 'l:' and 'u:'. Because the count was too low, the app could accept wallet policies that look valid but ar…

Undercounting of script operation budget leading to acceptance of unspendable policiesIncorrect handling of Miniscript wrapper dissatisfaction semanticsPolicy sanity check bypass via operation-count accounting flaw
b6ac1de8by Salvatore Ingala+39−33 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

doc: document the MUSIG2_SESSION_ID PSBT field

This commit only updates documentation and the changelog. It explains a new optional PSBT field called MUSIG2_SESSION_ID that lets software wallets manage multiple MuSig2 signing sessions for the same wallet policy on a Ledger device. Ther…

8d8ed9afby Salvatore Ingala+28−62 files
No security note in commit
Informational 15 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

musig_sessions: store up to 32 sessions

This commit is a simple capacity increase, not a security fix. It raises the number of simultaneous MuSig2 signing sessions the Ledger Bitcoin app can keep in memory from 8 to 32, because users with multiple MuSig accounts or wallets that …

a6798172by Salvatore Ingala+12−54 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

sign_psbt: fail before the UI if the MuSig2 session is missing

This commit improves the user experience and error handling for Ledger's Bitcoin app when using MuSig2 multi-signatures. Previously, if a required MuSig2 session was missing during the second round of signing, the device would only report …

UX-hardening: fail-fast before user approval instead of afterNew specific error code EC_SIGN_PSBT_MUSIG2_SESSION_NOT_FOUND for missing MuSig2 sessionsRefactored session storage lookup to support non-destructive existence check
2d04b144by Salvatore Ingala+118−187 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityAdd to playground presets for sighash flags, and for external inputsby Salvatore Ingala · 8bf62f9a · Jul 20, 2026 · 4 filesMessage 50 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add to playground presets for sighash flags, and for external inputs

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds new developer-testing presets and a declarative helper for the project's internal 'playground' dev tool. It does not change the Ledger Bitcoin app firmware, wallet logic, or any code that end users rely on. There is no security fix or vulnerability introduced here.

Lower-priorityUpdate txmaker to allow creating transactions with external inputsby Salvatore Ingala · 7da434b6 · Jul 20, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Salvatore Ingala

Update txmaker to allow creating transactions with external inputs

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes a test helper script (txmaker.py) used to build fake Bitcoin transactions for automated tests. It adds the ability to mark some inputs as 'external' (not owned by the wallet being tested) so the test suite can exercise transaction signing with mixed wallet and non-wallet inputs. There is no change to the actual Ledger app firmware or its security logic.

Security candidatedoc: document the BIP-322 flow of SIGN_PSBTby Ruben Waterman · 23c29ba9 · Jul 18, 2026 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · Ruben Waterman

doc: document the BIP-322 flow of SIGN_PSBT

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing boundarydocumentation-only discount
AI analysis · Informational 15/100

This commit only adds documentation and a changelog entry describing a previously implemented BIP-322 message-signing feature. No code changes are present, so it cannot introduce or fix a security vulnerability on its own.

Security candidatetests: functional tests for BIP-322 message signing and proof of fundsby Ruben Waterman · f0c76851 · Jul 18, 2026 · 269 filesMessage 88 · StrongInformational 15Details
Commit message · Ruben Waterman

tests: functional tests for BIP-322 message signing and proof of funds

Adds test_utils/bip0322.py (to_spend/to_sign PSBT builders, sighash
recomputation, signature verification and smp encoding helpers),
musig() support in test_utils/wallet_policy.py's plain descriptor
derivation, and a ragger suite covering:
- P2WPKH, P2TR, legacy P2PKH, registered 2-of-2 multisig, and musig()
(taproot keypath and scriptpath) signings, each verifying the
returned signature against an independently recomputed sighash;
- the address being proven on a change address, the empty message,
and an explicit SIGHASH_ALL on a taproot input;
- proof of funds (P2WPKH and P2TR), verifying every input's signature
and the on-screen total; the unverified inputs warning is shown for
a real input missing the non-witness utxo, but never for the
to_spend input; proof-of-funds inputs may also have a final
sequence, explicit or implied by an omitted PSBT_IN_SEQUENCE;
- long and short non-printable messages (hash display);
- the review rejected by the user;
- rejections: message/to_spend mismatch, first input not spending
output 0 of to_spend, non-zero amounts, OP_RETURN with a data push,
extra outputs, invalid tx version, timelocks (non-zero locktime,
non-zero or omitted sequence on the first input, relative timelock
on a proof-of-funds input), external proof-of-funds inputs, and
non-ALL sighashes (refused by the generic sighash gating by
default, and by the BIP-322 validation when the non-standard
sighash setting is enabled).

The message is set with the client's PSBT.generic_signed_message.

Golden snapshots for all five devices.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Salvatore Ingala <6681844+bigspider@users.noreply.github.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

88/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Names security-relevant behavior explicitly
Why it was queued
signing boundarydefensive validationcryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100

This commit only adds automated tests and test helper code for a new Bitcoin message-signing feature (BIP-322). It does not change the actual Ledger app firmware that users run, so it cannot by itself introduce a security vulnerability in shipped software. The tests exercise both valid and invalid signing requests, including many cases designed to make the device reject malformed or suspicious inputs.

Lower-priorityAligning the streaming review to the normal one - using "To" for "Adddress"by Ilya Artemov · 0d4a7599 · Jul 17, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Aligning the streaming review to the normal one - using "To" for "Adddress"

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit changes a single label shown on Ledger hardware wallet screens during Bitcoin transaction review. The label 'Address' is renamed to 'To' in the streaming transaction review flow so it matches the regular (non-streaming) review flow. There is no code behavior change, no security fix, and no vulnerability.

AI review queued[auto-update] Update Ragger snapshotsby github-actions[bot] · 643885b6 · Jul 17, 2026 · 103 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates test screenshot images (called 'Ragger snapshots') used to check what the Ledger device screen looks like during automated testing. No application code, firmware, or user-facing behavior was changed. It is not a security fix and does not affect users' devices or funds.

AI review queued[auto-update] Update Ragger snapshotsby github-actions[bot] · fb23ccb2 · Jul 17, 2026 · 39 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100

This commit only updates automated test screenshots (Ragger snapshots) for the Ledger Bitcoin app. No application code, firmware, or user-facing behavior was changed. It is not a security fix and does not introduce a vulnerability.

AI review queuedUsing also_delete_snapshots parameterby Ilya Artemov · b7e86265 · Jul 17, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Ilya Artemov

Using also_delete_snapshots parameter

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only changes a GitHub Actions CI workflow file. It adds a new optional checkbox that lets maintainers choose to delete outdated test snapshot files when automatically regenerating snapshots during a manual test run. There is no change to the Bitcoin app code, device firmware, cryptography, or anything users install.

Security candidateTrustworthy sign_psbt amount/fee display for non-default sighash: snapshotsby github-actions[bot] · 086967ae · Jul 17, 2026 · 840 filesMessage 50 · ThinInformational 15Details
Commit message · github-actions[bot]

Trustworthy sign_psbt amount/fee display for non-default sighash: snapshots

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots for the Ledger Bitcoin app. It does not change any application source code, so it cannot directly fix or introduce a security vulnerability in the shipped app. The snapshots reflect new expected screen output after a prior code change that altered how amounts and fees are displayed when signing transactions with non-default Bitcoin sighash types.

Security candidateTrustworthy sign_psbt amount/fee display for non-default sighash: integration testsby Ilya Artemov · bb6a6aad · Jul 17, 2026 · 5 filesMessage 60 · AdequateInformational 12Details
Commit message · Ilya Artemov

Trustworthy sign_psbt amount/fee display for non-default sighash: integration tests

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 12/100

This commit only adds and updates automated integration tests for the Ledger Bitcoin app. It does not change the app's actual signing code. The tests verify that the device now shows clearer, more trustworthy on-screen amount and fee information when a transaction uses unusual Bitcoin signature modes (non-default 'sighash' types). Because no production firmware code is modified, there is no direct security vulnerability or fix introduced by this commit itself.

Security candidateTrustworthy sign_psbt amount/fee display for non-default sighash: unit-testsby Ilya Artemov · d44e34dd · Jul 17, 2026 · 1 fileMessage 60 · AdequateInformational 12Details
Commit message · Ilya Artemov

Trustworthy sign_psbt amount/fee display for non-default sighash: unit-tests

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Informational 12/100

This commit only adds new automated unit tests for functions that decide how transaction amounts and fees are displayed on a Ledger device when signing a Bitcoin transaction with non-standard signature hash (sighash) modes. It does not change the actual signing or display logic, so by itself it cannot introduce or fix a security bug. The tests appear to be a companion to a separate code change that made the amount/fee display trustworthy for non-default sighash types.

Security candidateTrustworthy sign_psbt amount/fee display for non-default sighash: implementationby Ilya Artemov · d4525576 · Jul 17, 2026 · 12 filesMessage 50 · ThinModerate 59Details
Commit message · Ilya Artemov

Trustworthy sign_psbt amount/fee display for non-default sighash: implementation

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Moderate 59/100

This commit changes how the Ledger Bitcoin app shows transaction amounts and fees on the device screen when a user signs a transaction that does not use the normal 'sign everything' rule (a so-called non-default sighash). Previously the app might have displayed a fee or total that could actually change later, because some sighash types let other people add inputs or change outputs after the signature. Now the app detects those cases and either shows only the net amount the user is spending/receiving, or shows a warning that amounts cannot be verified. It also adds a 'Signing rule' line so the user knows the transaction is not fully committed.

AI review queuedAdding codecov configuration fileby Ilya Artemov · cd53dd96 · Jul 17, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Ilya Artemov

Adding codecov configuration file

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit adds a configuration file for Codecov, a service that tracks how much of the project's code is covered by automated tests. It only tells Codecov which folders to ignore and how to label different kinds of test coverage. It does not change any application code, security logic, or build process.

Lower-priorityCoverage for functional testsby Ilya Artemov · 6f96beff · Jul 17, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

Coverage for functional tests

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only adds a new GitHub Actions CI job that runs automated test coverage reports for the Bitcoin app. It does not change any application code, wallet logic, or security behavior. There is no user-facing or security-relevant change.

Lower-priorityRefactor creation of static pairs structby Salvatore Ingala · 2245761b · Jul 17, 2026 · 1 fileMessage 68 · AdequateLow 26Details
Commit message · Salvatore Ingala

Refactor creation of static pairs struct

Writing the struct directly is fragile, and risks incomplete
initializations or non-zeroed fields 'leaking' into future calls.

We rather write a simple helper that creates the full struct with
a literal, guaranteeing that everything that is not explicitly set
is zeroed.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 26/100

This commit is a defensive code cleanup in the user-interface layer of Ledger's Bitcoin app. It replaces repeated manual setup of a display data structure with a single helper function that always zeroes out any fields the caller does not explicitly set. The change reduces the risk that leftover data from a previous screen could accidentally leak into a later one, but it does not by itself fix a known, exploitable bug.

AI review queuedAdd testcase for registering a policy with too high confusion scoreby Salvatore Ingala · 20963719 · Jul 17, 2026 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · Salvatore Ingala

Add testcase for registering a policy with too high confusion score

The test verifies that register_wallet still succeeds, but showing
the raw descriptor template (fallback to usual behavior) rather
than the cleartext version.

Also, slightly refactored the shared code across unit tests.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds a new unit test and refactors shared test helper code. It does not change the actual Ledger Bitcoin app firmware behavior. The new test verifies that when a wallet policy is too confusing to display safely, the app falls back to showing the raw technical descriptor instead of a user-friendly version. This is a defensive test for an existing safety mechanism, not a fix for a vulnerability.

Lower-prioritycleartext: add BIP388 cleartext engine, codegen and CI checkby Salvatore Ingala · eab93592 · Jul 17, 2026 · 14 filesMessage 95 · StrongInformational 12Details
Commit message · Salvatore Ingala

cleartext: add BIP388 cleartext engine, codegen and CI check

Implements the confusion score and the cleartext representation for a
large subset of commonly used wallet policies. This is the standalone
engine layer: it compiles into the app but is not yet wired into any
handler.

The classifier tables and AST matchers are generated from the TOML specs
in specs/bip388/ by gen.py:
- specs/bip388/cleartext.toml -> cleartext_specs.{h,c}, cleartext_match.c
- specs/bip388/test_vectors.toml -> unit-tests/cleartext_vectors.inc.c
The hand-written runtime (cleartext.c, cleartext_match.h) provides the
scorer/encoder and the primitives the generated classifier calls into.

are_key_placeholders_identical() is exposed from policy.h for use by the
encoder.

A CI job (cleartext-gen-check.yml) runs `gen.py --check` to ensure the
committed generated files stay in sync with the TOML specs.

Mostly ported by Claude from the Rust reference implementation, with
several iterations of review and refinement.

95/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Mentions testing or verification
AI analysis · Informational 12/100

This commit adds a new feature to the Ledger Bitcoin app that translates complex wallet policies into plain English for user review, plus a 'confusion score' to warn when a policy's description could match multiple different wallet setups. It is a large, self-contained addition of generated code, a code generator, specs, tests, and a CI check. The feature is not yet connected to any user-facing handler, so it cannot by itself change app behavior or expose secrets. Nothing in the commit message or diff describes this as a security fix or reports a vulnerability.

AI review queuedUpdate test snapshotsby Salvatore Ingala · a606e745 · Jul 17, 2026 · 229 filesMessage 38 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Update test snapshots

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates test snapshot images (screenshots used for automated visual testing) for the Ledger Bitcoin app. No application source code, firmware logic, or user-facing behavior was changed. It is a routine test-maintenance update and has no security relevance on its own.

Lower-priorityUpdate CHANGELOG for cleartext featureby Salvatore Ingala · c4974b73 · Jul 17, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Update CHANGELOG for cleartext feature

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only updates the changelog text. It documents a user-experience improvement that shows wallet policies in plain English on the Ledger device screen. There is no code change and no security fix or vulnerability present in the diff.

AI review queuedAdd testcases with snapshots for multisig k-of-n and several taproot leavesby Salvatore Ingala · fd75dadd · Jul 17, 2026 · 108 filesMessage 50 · ThinInformational 15Details
Commit message · Salvatore Ingala

Add testcases with snapshots for multisig k-of-n and several taproot leaves

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new test cases and screen snapshots for the Ledger Bitcoin app. It exercises two wallet-registration scenarios: a 2-of-3 multisig wallet and a Taproot wallet with multiple spending paths. There are no changes to the app's actual code, so this cannot introduce a security vulnerability or fix one in the shipped firmware.

AI review queuedShow cleartext representation of wallet policy, when possibleby Salvatore Ingala · f883a913 · Jul 17, 2026 · 7 filesMessage 83 · StrongInformational 22Details
Commit message · Salvatore Ingala

Show cleartext representation of wallet policy, when possible

Wires the cleartext engine into the register-wallet flow: the handler
computes the confusion score and, when below the threshold, renders the
cleartext spending-path lines shown before the raw descriptor template.

For multisig wallet policies specifically, this also simplifies the UX by
omitting the raw descriptor template altogether. This is safe for such
simple policies, with very little ambiguity. In the long term, we might be
able to extend this to more complex wallet policies, but that needs to be
done intentionally, and possibly be an opt-in feature that is explicitly
requested by software wallets that adapt their own UX accordingly.

Unit tests of register_wallet had to be adapted slightly to take into
account that the descriptor is not always shown.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 22/100

This commit changes how Ledger devices display Bitcoin wallet policies during setup. Instead of always showing the raw technical descriptor, it tries to show a human-readable summary ("cleartext") of the spending rules. For simple multisig wallets, it hides the raw descriptor entirely because the plain-English summary is considered unambiguous. This is a UX improvement, not a fix for a known vulnerability, but it touches security-critical user confirmation code.

Lower-prioritycleartext: add unit tests for the cleartext engineby Salvatore Ingala · 178e2a43 · Jul 17, 2026 · 2 filesMessage 60 · AdequateInformational 12Details
Commit message · Salvatore Ingala

cleartext: add unit tests for the cleartext engine

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only adds new unit tests for an existing 'cleartext' feature in the Ledger Bitcoin app. It does not change any production code, fix a bug, or alter app behavior. The tests check how wallet descriptors are rendered into human-readable text and how a 'confusion score' is calculated. There is no security patch here.

Lower-priorityapp-bitcoin-new rename to app-bitcoin - let's now use the docker image - already deployed after the push on developby Ilya Artemov · be18c501 · Jul 7, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

app-bitcoin-new rename to app-bitcoin - let's now use the docker image - already deployed after the push on develop

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply updates a GitHub Actions workflow to use a renamed Docker container image. The old image name contained 'app-bitcoin-new' and the new name contains 'app-bitcoin'. This is a routine repository rename follow-up with no visible security relevance.

Lower-priorityLet's use so far existing app-bitcoin-new docker imageby Ilya Artemov · 18599aea · Jul 7, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Let's use so far existing app-bitcoin-new docker image

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply updates the GitHub Actions CI workflow to use the correct Docker image name for the newer 'app-bitcoin-new' project instead of the old 'app-bitcoin' image. It is a build/test infrastructure change with no effect on the app users install on their Ledger devices.

Lower-priorityapp-bitcoin-new rename to app-bitcoinby Ilya Artemov · 5f68df41 · Jul 7, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

app-bitcoin-new rename to app-bitcoin

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit is a simple repository rename from 'app-bitcoin-new' to 'app-bitcoin'. It changes only one line in a GitHub Actions workflow file, updating the Docker container image path used for automated testing. There is no code change, no security fix, and no vulnerability introduced.