LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

301 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

75security candidates126second-pass queue279AI analyses
51commits · 30 days
82commits · 60 days
231commits · 180 days
301commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

51/100 average clarity
13Strong · 80–100
76Adequate · 60–79
157Thin · 40–59
55Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala16748161455
Ilya Artemov952682145
github-actions[bot]17115046
Mathias BROUSSET14014040
José Luis Landabaso Díaz404067
Cerberus Merlin101062
iartemov-ledger100043
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 36 minutes ago

Moderate 59 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #542 from LedgerHQ/musig-fixes

This commit fixes missing error handling in the Ledger Bitcoin app's MuSig2 multi-signature code. Several cryptographic functions could fail silently or return incorrect results because their error codes were ignored. The patch now checks …

Missing error propagation in cryptographic point operationsUnchecked return value of crypto_tr_lift_x could lead to use of an unspecified pointUnchecked point_add return value in key aggregation, nonce aggregation, and tweaking
0fec192fby Salvatore Ingala+21−63 files
No security note in commit
Moderate 59 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix missing return value checks for point_add calls

This commit fixes three places in the Ledger Bitcoin app's MuSig2 code where the result of an elliptic-curve point-addition operation was not checked for failure. If point_add fails (for example, because it produced the special 'point at i…

Unchecked cryptographic operation return value (point_add)Potential use of invalid/infinite elliptic-curve point in MuSig2 aggregationMuSig2 nonce aggregation failure path now returns correct cosigner index
b1132395by Salvatore Ingala+14−52 files
No security note in commit
Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Propagate crypto_tr_lift_x errors in cpoint

This commit fixes a small but meaningful bug in the Ledger Bitcoin app's code that handles advanced multi-signature (MuSig) operations. A function called crypto_tr_lift_x can fail when given an invalid x-coordinate that does not correspond…

Unchecked return value from cryptographic point-lifting functionPotential use of invalid/uninitialized curve point in MuSig signing flowMissing error propagation in compressed public-key parsing
18647877by Salvatore Ingala+7−12 files
No security note in commit
High 72 AI analysisMessage 58 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #539 from LedgerHQ/fix-stack-exhaustion

This update fixes a stack-exhaustion weakness in Ledger's Bitcoin app. A malicious or unusually crafted wallet policy (the text string that describes how coins can be spent) could make the app recurse so deeply that it runs out of call sta…

Stack exhaustion / unbounded recursion in policy parsing and validationMissing depth accounting for miniscript wrapper chainsLarge automatic arrays inside recursive functions (compute_thresh_ops / compute_thresh_stacksize)
1621b7faby Salvatore Ingala+371−1427 files
Vendor flagged security relevance
Low 41 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reduce the stack frame of key_orderings_count

This commit rewrites a function in the Ledger Bitcoin app to use less memory. The old code stored a large table of key-derivation pairs for every possible class of key expression, which grew quadratically with the maximum number of key exp…

Large stack allocation removed (quadratic memory reduced to linear)Integer types narrowed based on stated boundsNo explicit security claim in commit message or diff comments
2e39aa2aby Salvatore Ingala+29−361 file
No security note in commit
Low 27 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Move the wallet confirmation stage out of the handler's frame

This commit refactors the Ledger Bitcoin app's wallet registration code so that the user-confirmation step runs in a separate function that the compiler is told not to inline. The stated goal is to reduce peak stack memory use by freeing l…

Stack memory layout hardening via noinline separation of validation and UI phasesReduction of peak stack footprint for deeply recursive policy validationRefactor only: no change to validation rules, cryptographic checks, or UI logic
ff2a7c7aby Salvatore Ingala+107−861 file
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Limit the amount of nesting for `thresh` fragments to 4

This commit fixes a stack-overflow risk in Ledger's Bitcoin app when parsing wallet policies that deeply nest 'thresh' miniscript fragments. It limits nesting to four levels and prevents two helper functions from being inlined so their lar…

Stack-frame bloat from inlined functions with large local arraysRecursive policy-tree walker with unbounded nested thresh inputPotential stack exhaustion / overflow on crafted miniscript policy
d4e23574by Salvatore Ingala+68−73 files
No security note in commit
Low 36 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add functional tests for the policy depth limits

This commit adds automated tests to the Ledger Bitcoin app to check that very deep or heavily nested wallet policies are rejected safely. The tests confirm that an over-deep policy returns an error instead of freezing or crashing the devic…

Tests for policy recursion/depth limitsReference to app constants MAX_PARSE_SCRIPT_RECURSION_DEPTH and MAX_THRESH_NESTINGAssertion that over-deep policy does not crash the app
a81554f8by Salvatore Ingala+51−01 file
No security note in commit
Low 43 AI analysisMessage 70 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Lowers MAX_N_IN_THRESH to 24

This commit reduces a hard-coded limit in Ledger's Bitcoin app on how many branches a 'thresh' miniscript operator can have, from 128 down to 24. The change is framed as a memory-usage improvement, not a security fix. It also adds a test t…

Stack-memory pressure reduction in recursive miniscript analysisHard-coded threshold lowered to prevent large dynamic-programming tablesNew unit test checks rejection of oversized thresh fragments
97ad772aby Salvatore Ingala+38−33 files
No security note in commit
High 72 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Count miniscript wrappers in the parser's recursion depth limit

This commit fixes a bug in the Ledger Bitcoin app's wallet-policy parser. Miniscript 'wrappers' (short letters like 'n' that modify a policy) were not counted toward the parser's recursion-depth safety limit. A crafted wallet descriptor wi…

Stack-exhaustion / denial-of-service via crafted descriptor templateMissing recursion-depth accounting for parser-level wrapper expansionPatch adds explicit depth budget check and regression test
ed7cd029by Salvatore Ingala+75−63 files
Vendor flagged security relevance
Low 31 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Delete MAX_POLICY_DEPTH; rather, align with MAX_PARSE_SCRIPT_RECURSION_DEPTH from the parsing stage

This commit changes how deeply nested Bitcoin wallet policies can be when processed by a Ledger hardware wallet app. It removes a separate, smaller limit (10 levels) and instead uses the same deeper limit already applied during an earlier …

Depth-limit constant unified across parsing and processing stagesRemoval of a stricter local limit that could create inconsistent policy acceptanceNo new input validation or memory safety bug introduced by the diff itself
bb5386b0by Salvatore Ingala+3−41 file
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix wrong comment in policy_node_thresh_t

This commit only changes a code comment to accurately describe how child scripts are stored. It does not alter any actual program logic, data structures, or behavior, so it has no security impact.

fbbdca3fby Salvatore Ingala+1−11 file
No security note in commit
Low 42 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Disable musig in key expressions of musig_a/sortedmulti_a

This commit temporarily blocks a specific advanced Bitcoin wallet feature (MuSig inside multi_a/sortedmulti_a) because the code that reads those wallet descriptions doesn't handle it correctly yet. It's a defensive change to prevent malfor…

Parser hardening for unsupported nested MuSig expressionsAddition of negative unit tests for malformed/unsupported policiesCommentary in code explicitly notes incompatibility and temporary disablement
558854ebby Salvatore Ingala+24−132 files
No security note in commit
Moderate 62 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Additional integrity checks for Merkle proofs

This commit adds extra safety checks when the Ledger Bitcoin app verifies Merkle proofs, which are cryptographic evidence used to confirm that a piece of data belongs to a larger set. The changes ensure that the proof length matches the ex…

Merkle proof length validation against leaf depthEnforcement of Merkle leaf prefix byte 0x00Prevention of streaming invalid preimage data before callback invocation
c44c9b8bby Salvatore Ingala+32−44 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 55 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Add unit tests for get_merkle_preimage

This commit only adds new unit tests for existing code. It does not change any production behavior, fix a bug, or introduce new functionality. The tests verify that certain security checks (proof length and domain separator checks) already…

Test-only commit with no production code changesTests verify existing Merkle proof length validation rejects internal-node-as-leaf and overlong proofsTests verify existing leaf preimage domain-separator check rejects internal-node preimages and non-zero prefixes
05445baeby Salvatore Ingala+334−03 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Type consistency in psbt_parse_rawtx, and some other hardenings

This commit hardens a Bitcoin transaction parser in Ledger's app. It changes some numeric fields to safer types, adds bounds checks on transaction counts and sizes, rejects extra trailing bytes after a transaction, checks a previously-igno…

Integer type narrowing and sentinel change from -1 to SIZE_MAXBounds checks before uint64_t to unsigned int castsReturn value of parser_consolidate_buffers now checked
1af86279by Salvatore Ingala+66−173 files
No security note in commit
Informational 15 AI analysisMessage 50 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Sign consistency for parser steps; removed stale comment

This commit only changes the declared type of three array-length constants from signed int to unsigned size_t, and removes two stale comments about a 10,000-byte limit. There is no change to program logic, memory allocation, bounds checkin…

373f4a56by Salvatore Ingala+7−72 files
No security note in commit
Moderate 59 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Harden prevout tx parsing checks

This commit tightens how the Ledger Bitcoin app parses previous transaction data when signing Bitcoin transactions. It adds size limits and completion checks that prevent malformed or oversized previous transaction outputs from being proce…

Adds explicit bounds checks on prevout scriptPubKey lengthsSwitches signed integer length arithmetic to size_t to avoid negative-length edge casesAdds completion check for streamed raw previous transaction parsing
0df0add4by Salvatore Ingala+44−64 files
No security note in commit
Informational 18 AI analysisMessage 45 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix taptree hash computation in test_utils

This commit fixes a copy-paste bug in test helper code used during automated testing of Ledger's Bitcoin app. The bug caused the right-hand branch of a Taproot script tree to be ignored and the left-hand branch to be hashed twice when comp…

Incorrect cryptographic hash construction in Taproot taptree root computationCopy-paste error causing left subtree to be hashed twice and right subtree omittedTest-only code path, not production firmware
7cba440aby Salvatore Ingala+6−52 files
No security note in commit
Informational 15 AI analysisMessage 60 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Do not truncate preset names

This commit removes manual shortening of preset names in a developer-only playground GUI and lets the UI toolkit handle truncation automatically. It is a cosmetic/usability fix with no apparent security relevance.

9f57d1a4by Salvatore Ingala+9−41 file
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritycleartext: add unit tests for the cleartext engineby Salvatore Ingala · 178e2a43 · Jul 17, 2026 · 2 filesMessage 60 · AdequateInformational 12Details
Commit message · Salvatore Ingala

cleartext: add unit tests for the cleartext engine

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only adds new unit tests for an existing 'cleartext' feature in the Ledger Bitcoin app. It does not change any production code, fix a bug, or alter app behavior. The tests check how wallet descriptors are rendered into human-readable text and how a 'confusion score' is calculated. There is no security patch here.

Lower-priorityapp-bitcoin-new rename to app-bitcoin - let's now use the docker image - already deployed after the push on developby Ilya Artemov · be18c501 · Jul 7, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

app-bitcoin-new rename to app-bitcoin - let's now use the docker image - already deployed after the push on develop

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply updates a GitHub Actions workflow to use a renamed Docker container image. The old image name contained 'app-bitcoin-new' and the new name contains 'app-bitcoin'. This is a routine repository rename follow-up with no visible security relevance.

Lower-priorityLet's use so far existing app-bitcoin-new docker imageby Ilya Artemov · 18599aea · Jul 7, 2026 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Let's use so far existing app-bitcoin-new docker image

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit simply updates the GitHub Actions CI workflow to use the correct Docker image name for the newer 'app-bitcoin-new' project instead of the old 'app-bitcoin' image. It is a build/test infrastructure change with no effect on the app users install on their Ledger devices.

Lower-priorityapp-bitcoin-new rename to app-bitcoinby Ilya Artemov · 5f68df41 · Jul 7, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

app-bitcoin-new rename to app-bitcoin

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit is a simple repository rename from 'app-bitcoin-new' to 'app-bitcoin'. It changes only one line in a GitHub Actions workflow file, updating the Docker container image path used for automated testing. There is no code change, no security fix, and no vulnerability introduced.

Lower-priorityA note added to README.mdby Ilya Artemov · be0f6e90 · Jul 7, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

A note added to README.md

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only adds a short note to the README.md file explaining that the repository was renamed. There are no code changes, no security fixes, and no functional changes to the Ledger Bitcoin app.

AI review queuedapp-bitcoin-new rename to app-bitcoinby Ilya Artemov · 3975774b · Jul 7, 2026 · 17 filesMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

app-bitcoin-new rename to app-bitcoin

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a simple project rename from 'app-bitcoin-new' to 'app-bitcoin'. It only updates URLs, repository references, and documentation strings across 17 files. There are no code logic changes, no security fixes, and no behavior changes.

Lower-priorityAllow exporting BIP-87 xpubs without explicit user approvalby Salvatore Ingala · 08f5d1aa · Jul 7, 2026 · 1 fileMessage 73 · AdequateModerate 53Details
Commit message · Salvatore Ingala

Allow exporting BIP-87 xpubs without explicit user approval

BIP-87 is a scheme for derivation paths that is similar to BIP-48,
and intended for multisig accounts.
Since we support silent xpub export for BIP-48, it makes more sense
to also support it for BIP-87 for consistency.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Moderate 53/100

This commit expands an existing feature that lets a connected computer request extended public keys (xpubs) from a Ledger device without requiring the user to press 'Approve' on the device screen. It now allows this silent export for BIP-87 multisig derivation paths, matching the existing behavior for BIP-48. The change is presented by the developer as a consistency improvement, not as a security fix. It does not add new code paths; it only adds one more derivation-path standard to an existing allow-list.

Lower-priorityUpdate docs and CHANGELOG for BIP-87 supportby Salvatore Ingala · f7920f56 · Jul 7, 2026 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Update docs and CHANGELOG for BIP-87 support

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only updates documentation and a changelog. It adds BIP-87 to the list of standard Bitcoin derivation paths whose extended public keys (xpubs) can be exported without requiring the user to confirm on the device screen. There is no code change in the commit itself, so it does not introduce or fix a security vulnerability directly.

Lower-priorityUpdate tests for BIP-87 supportby Salvatore Ingala · 518fc20d · Jul 7, 2026 · 2 filesMessage 55 · ThinInformational 15Details
Commit message · Salvatore Ingala

Update tests for BIP-87 support

55/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds new test cases for BIP-87 extended public key derivation. It does not change any application code, cryptographic logic, or security behavior. There is no indication of a security fix or vulnerability.

AI review queueddocs: Add user documentationby Salvatore Ingala · f32a3610 · Jun 24, 2026 · 4 filesMessage 87 · StrongInformational 15Details
Commit message · Salvatore Ingala

docs: Add user documentation

Existing documentation is rather detailed on the wire protocol, but
lacks a higher level technical overview of the features and
operating principles of the app.

This commit adds two new high-level guides for technical readers
that are not interested in the details of the wire protocol:

- features.md: high-level overview of the app's features
- integration.md: integration concepts and security model

Also, wallet.md was trimmed to avoid repeating what is in BIP-388.

87/100 · StrongMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Names security-relevant behavior explicitly
Why it was queued
signing or wallet pathdocumentation-only discountsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds and reorganizes user and developer documentation. No program code, build scripts, tests, or cryptographic logic were changed. It is not a security patch and does not introduce or fix any vulnerability.

Lower-priority[auto-update] Update Ragger snapshotsby github-actions[bot] · df859c3b · Jun 23, 2026 · 5 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only updates five test snapshot images used by the Ragger automated testing framework. These are expected screen captures for a test named 'test_sighash_none_rejected_by_default' across different Ledger device models. There are no code changes, no application behavior changes, and no security fix or vulnerability present.

Lower-prioritySIGHASH gating: status screen on disabled rejection - testsby Ilya Artemov · ef9d1ecc · Jun 23, 2026 · 1 fileMessage 60 · AdequateInformational 12Details
Commit message · Ilya Artemov

SIGHASH gating: status screen on disabled rejection - tests

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only adds a new automated test that checks the on-device error screen shown when a user tries to sign a Bitcoin transaction with a non-standard SIGHASH type while the non-standard SIGHASH setting is disabled. It does not change the app's actual signing behavior or security logic; it only verifies that the existing rejection screen appears correctly.

AI review queuedSIGHASH gating: status screen on disabled rejectionby Ilya Artemov · 0e35a24d · Jun 23, 2026 · 4 filesMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

SIGHASH gating: status screen on disabled rejection

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a user-experience improvement, not a security fix. When a Bitcoin transaction uses a non-standard sighash and the user has not enabled the 'Allow non-standard sighash' setting, the app already rejected the transaction. Now it also shows an on-screen message explaining why it was rejected, so the user is not left confused.

AI review queuedSIGHASH gating: update Ragger snapshotsby github-actions[bot] · 84e9bc7c · Jun 23, 2026 · 177 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

SIGHASH gating: update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots for the Ledger Bitcoin app. It does not change any application code, so it cannot directly fix or introduce a security vulnerability. The snapshots show what the device screen looks like during tests of a new 'SIGHASH gating' feature, but the actual security behavior is implemented elsewhere.

AI review queuedSIGHASH gating: tests_mainnetby Ilya Artemov · b67c7982 · Jun 23, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Ilya Artemov

SIGHASH gating: tests_mainnet

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates a test script that navigates the Ledger device's on-screen dashboard. It adds extra button presses to account for a new 'App settings' menu item that appears before 'App info'. There is no change to the actual Bitcoin app code, cryptographic logic, or transaction signing behavior, so this commit does not introduce or fix a security issue by itself.

AI review queuedSIGHASH gating: functional testsby Ilya Artemov · cb60be9a · Jun 23, 2026 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

SIGHASH gating: functional tests

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds automated functional tests for a new device setting that controls whether non-standard Bitcoin signature hash (sighash) types are allowed. It does not change the app code that runs on the Ledger device, so it cannot introduce a security vulnerability by itself. The tests verify that dangerous sighash types are blocked by default and require the user to explicitly enable a setting to allow them.

Lower-prioritySIGHASH gating: unit testsby Ilya Artemov · d89aa8b5 · Jun 23, 2026 · 2 filesMessage 45 · ThinInformational 12Details
Commit message · Ilya Artemov

SIGHASH gating: unit tests

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only adds new automated unit tests for an existing function called classify_sighash. It does not change any production wallet code, fix a bug, or alter behavior. The tests verify that different Bitcoin signature-hash types are correctly categorized as safe, non-safe, or unsupported for legacy, SegWit v0, and Taproot transactions. By itself, this is a testing/infrastructure change with no direct security impact.

AI review queuedSIGHASH gating: implementationby Ilya Artemov · 296bed60 · Jun 23, 2026 · 6 filesMessage 35 · OpaqueLow 48Details
Commit message · Ilya Artemov

SIGHASH gating: implementation

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Low 48/100

This commit adds a user-controlled setting to the Ledger Bitcoin app that blocks non-standard Bitcoin transaction signing modes by default. Previously, these modes were allowed with only a warning. Now the app rejects them unless the user explicitly turns on 'Allow non-standard sighash' in settings and confirms a warning. This is a security-hardening change, not a vulnerability fix in the traditional sense, but it reduces the risk of users accidentally signing transactions that protect fewer funds than they expect.

Lower-priorityfix: TARGET_* constants propagationby Ilya Artemov · 56299efa · Jun 17, 2026 · 3 filesMessage 47 · ThinLow 35Details
Commit message · Ilya Artemov

fix: TARGET_* constants propagation

47/100 · ThinMessage clarity
✓ Descriptive subject✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 35/100

This commit fixes a build-configuration problem in Ledger's Bitcoin app. Two source files now explicitly include the SDK header that defines TARGET_* constants (such as TARGET_NANOX, TARGET_STAX, TARGET_FLEX), and the build adds the correct include path for unit tests. Without these constants, the code could silently fall back to default values, potentially changing behavior on different Ledger devices. The change also adds compile-time #error checks so the problem cannot happen silently again.

AI review queuedRemove bad include directive with CFLAGSby Charles-Edouard de la Vergne · 704b361a · Jun 16, 2026 · 2 filesMessage 45 · ThinInformational 17Details
Commit message · Charles-Edouard de la Vergne

Remove bad include directive with CFLAGS

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 17/100

This commit removes a leftover debugging include from the build and adds a missing standard header to one source file. It is a cleanup/fix for build hygiene, not a security patch for an exploitable vulnerability. There is no evidence in the commit or supplied references that this fixes a security issue.

AI review queuedValidate key classification in register_wallet unit testsby Salvatore Ingala · 5cefe555 · Jun 16, 2026 · 3 filesMessage 83 · StrongInformational 12Details
Commit message · Salvatore Ingala

Validate key classification in register_wallet unit tests

By recording what the UI mock receives, we verify that the
handler correctly classifies the key expressions as internal,
external or unspendable.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit only adds and improves unit tests for the Ledger Bitcoin app. It records what the user-interface confirmation function receives during wallet registration tests, then checks that the app correctly labels each key as internal (ours), external (someone else's), or unspendable. It also adds a new test case for a fingerprint-collision scenario. There is no change to the actual app code that runs on the device, so this is a testing/quality improvement rather than a security fix.

AI review queuedUnit tests for get_extended_pubkeyby Salvatore Ingala · 88fa41c7 · Jun 16, 2026 · 4 filesMessage 68 · AdequateInformational 15Details
Commit message · Salvatore Ingala

Unit tests for get_extended_pubkey

Refactored the handler_get_extended_pubkey to move the actual
logic (after APDU parsing) into a separate function
get_extended_pubkey_response, which get be tested directly based
on the test vectors.

Rafactored some common TOML utilities into toml_helpers.h.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds and reorganizes unit tests for the get_extended_pubkey feature. It does not change the actual app code that runs on the Ledger device, so it cannot introduce a security vulnerability or fix one in shipped software.

AI review queuedNit from PR reviewby Salvatore Ingala · 795a0445 · Jun 16, 2026 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Nit from PR review

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only removes periods at the end of sentences in a test documentation file (test_vectors/README.md). It is a cosmetic formatting change with no effect on code, security, or functionality.

AI review queuedUnit tests for sign_messageby Salvatore Ingala · b4727094 · Jun 16, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Unit tests for sign_message

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds new unit tests for the existing sign_message feature in Ledger's Bitcoin app. It does not change the actual signing code that runs on the device, so it cannot introduce a security vulnerability or fix one by itself. The tests exercise the handler with known test vectors and mock UI approval, and include one extra test for an over-long message length.

AI review queuedUpdate sign_message test vectorsby Salvatore Ingala · 867f69c8 · Jun 16, 2026 · 2 filesMessage 45 · ThinInformational 15Details
Commit message · Salvatore Ingala

Update sign_message test vectors

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
fuzzing or regression evidencesigning or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates test data and documentation for the Bitcoin app's message-signing feature. It documents how the device displays messages (full text versus a hash) and adds matching test expectations. There is no code change and no security fix or vulnerability present in the diff.