LD
← All projectsLedger

Ledger Bitcoin app

Open-source Bitcoin application running on Ledger devices; the device OS is outside this repository.

BitcoinHardware walletsNormal
Repository coverage

447 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

148security candidates154second-pass queue402AI analyses
19commits · 30 days
63commits · 60 days
249commits · 180 days
414commits · 365 days
Backfill bands
Aug 5 → Feb 670 seen8 candidatesComplete
Feb 6 → Jun 6149 seen21 candidatesComplete
Jun 6 → Jul 623 seen0 candidatesComplete
Jul 6 → Aug 555 seen5 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

57/100 average clarity
50Strong · 80–100
152Adequate · 60–79
186Thin · 40–59
59Opaque · 0–39
6security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
Salvatore Ingala2981122561062
Ilya Artemov962696145
Ruben Waterman666083
Aymeric Robert434063
github-actions[bot]17117046
Mathias BROUSSET17015039
José Luis Landabaso Díaz404067
iartemov-ledger201051
Cerberus Merlin101062
Michael Evans101073
Charles-Edouard de la Vergne101045
Analysis record

Published AI watches

Last scanned 38 minutes ago

Informational 20 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

tests: pin all Python test dependencies to exact versions

This commit pins the exact versions of Python testing tools used by the project's automated tests. Previously, the test setup allowed any newly released version of those tools to be installed automatically, which could introduce unexpected…

Supply-chain risk reduction for test/CI dependenciesPrevents unreviewed automatic upgrades of speculos and raggerNo change to firmware or published package code
def417a3by Salvatore Ingala+329−142 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Bump version to 2.6.0

This commit is a routine version bump from 2.5.1 to 2.6.0 in the Ledger Bitcoin app. It only updates the version number in the Makefile and the release date in the CHANGELOG. There are no code changes, no bug fixes, and no security-related…

2b424b54by Salvatore Ingala+4−42 files
No security note in commit
Moderate 66 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #581 from LedgerHQ/client-fixes

This commit tightens how the Ledger Bitcoin app and its companion client libraries read PSBT (Partially Signed Bitcoin Transaction) data. It adds checks that reject malformed or suspicious PSBTs: truncated fields, unexpected extra bytes af…

Hardened PSBT deserialization against truncation and trailing dataAdded duplicate-key detection in PSBT mapsRejected PSBTv2-only fields inside PSBTv0 to prevent locktime/field override attacks
f8f790a3by Salvatore Ingala+544−17018 files
No security note in commit
Low 47 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

python client: reject PSBTv2-only fields in a PSBTv0

This commit tightens input validation in the Python helper library that prepares Bitcoin transaction data for Ledger hardware wallets. It now rejects PSBT files that claim to be the older version 0 format but contain fields that only belon…

Input-validation hardening: stricter parsing of PSBT version 0 to reject v2-only key typesConsistency fix across clients: aligns Python client with HS and Rust client behaviorLocktime normalization during v0-to-v2 conversion to prevent per-input locktime from overriding transaction locktime
84165be7by Salvatore Ingala+92−02 files
No security note in commit
Informational 24 AI analysisMessage 83 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

tests: update authproxy.py to the latest version from Bitcoin Core

This commit updates a test helper file used to talk to a Bitcoin node during automated testing. The old helper could accidentally send the same command twice if the network connection hiccuped, which could cause a test-only action like sen…

Removed transparent retry of non-idempotent RPC requests after connection resetsTest helper could execute state-changing RPCs twice before the fixNew connection-per-call configuration mitigates idle-timeout disconnects without retry risk
c7ca508eby Salvatore Ingala+91−522 files
Vendor flagged security relevance
Low 40 AI analysisMessage 65 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject duplicate keys and trailing data when parsing a PSBT in the JS client

This commit fixes the JavaScript PSBT (Partially Signed Bitcoin Transaction) parser in Ledger's Bitcoin app so it now rejects malformed PSBTs that contain duplicate keys or extra trailing bytes. Previously, such malformed data could be acc…

BIP-174 non-compliance: duplicate keys and trailing data were previously acceptedState reuse bug: deserializing multiple PSBTs in the same instance could merge mapsInput validation gap in client-side PSBT parsing
4942a4aeby Salvatore Ingala+40−02 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

ragger: fail if a request succeeds without showing the expected screens

This commit fixes the automated test harness, not the Ledger Bitcoin app itself. Previously, the test framework could silently pass even when the device completed a request without showing the expected on-screen review. The change makes te…

Test-hardening only: no firmware or runtime application code changedFixes false-negative test results where a request could succeed without expected UI reviewCorrects scope of navigation settings to avoid leaking across nested or subsequent calls
202d352aby Salvatore Ingala+76−957 files
No security note in commit
Low 37 AI analysisMessage 88 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

unit tests: Fix length overflow in unit-test PSBT parser

This commit fixes an arithmetic overflow bug in a test-only PSBT (Bitcoin transaction format) parser used in unit tests. The bug could let a crafted test input make the parser think a data length is huge, potentially confusing the mock dis…

Integer overflow/wrap-around in length calculationOut-of-bounds length derived from arithmetic on attacker-influenced offsetsUnit-test-only code path, not device firmware
6a2a9262by Salvatore Ingala+6−21 file
No security note in commit
Low 48 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

rust client: reject PSBTv2-only fields when converting a PSBTv0

This commit fixes a bug in the Ledger Bitcoin app's Rust client where a PSBT v0 (an older transaction format) could silently carry fields that only have meaning in PSBT v2. When converting v0 to v2, those fields could override values taken…

Input validation added for cross-format PSBT conversionPrevents v2-only fields from overriding unsigned-transaction-derived valuesBIP-370 compliance enforcement for PSBTv0
602055d6by Salvatore Ingala+66−91 file
No security note in commit
Moderate 51 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject PSBTv2-only fields when converting a PSBTv0 in the JS client

This commit fixes a bug in the Ledger Bitcoin app's JavaScript client library. When converting an older-style Bitcoin transaction file (PSBT version 0) into the newer PSBT version 2 format, the library previously ignored fields that are on…

Input validation fix: rejects malformed PSBTv0 containing v2-only fieldsPrevents silent override of transaction locktime during PSBTv0-to-v2 conversionAdds missing BIP-370 key type constants for required time/height locktime
a1f6dc84by Salvatore Ingala+66−22 files
No security note in commit
High 72 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Reject duplicate keys and truncated maps when parsing PSBT maps in sign_psbt

This commit fixes a bug in how the Ledger Bitcoin app client parses PSBT (Partially Signed Bitcoin Transaction) maps. Previously, if the same key appeared twice in a map, the parser silently kept the last value. A malicious or malformed PS…

Silent overwrite of duplicate PSBT map keys could create commitment mismatch between client and deviceTruncated PSBT maps were silently accepted due to exception swallowing in deserialization loopsTrailing data after PSBT maps was ignored, allowing reserialization to silently normalize malformed inputs
75df80f9by Salvatore Ingala+107−104 files
Vendor flagged security relevance
High 72 AI analysisMessage 53 · Thin
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #579 from LedgerHQ/misc-fixes

This commit fixes several bugs in Ledger's Bitcoin app. The most serious ones are: (1) a set of miniscript policy analyzer mistakes that could let the app accept Bitcoin wallet policies whose scripts are too large or too expensive to execu…

Miniscript cost/property analysis errors that could allow oversized/undercosted wallet policiesHost-driven infinite-loop / denial-of-service via zero-length GET_MORE_ELEMENTS responsesUI state inconsistency causing a security warning to be prematurely dismissed
ec389348by Salvatore Ingala+413−3113 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Merge pull request #576 from LedgerHQ/musig2_improvements

This commit improves the Ledger Bitcoin app's MuSig2 multi-signature feature. It lets wallet software pre-generate public nonces before a transaction is known, adds an optional MUSIG2_SESSION_ID field so multiple signing sessions can be in…

New PSBT proprietary field parsing with length validation (1-32 bytes, empty rejected)Session ID now commits to wallet policy plus optional MUSIG2_SESSION_IDSession storage limit raised from 8 to 32 with LRU eviction
26d22adcby Salvatore Ingala+710−7216 files
No security note in commit
Informational 18 AI analysisMessage 85 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Use signed scratch arrays in the thresh ops and stack size computations

This commit is a small code cleanup in Ledger's Bitcoin app. It changes two local arrays from unsigned (uint16_t) to signed (int16_t) in functions that count operations and stack sizes for Bitcoin miniscript 'thresh' policies. The commit m…

Signed/unsigned type mismatch in sentinel handlingPotential latent integer interpretation bug in miniscript threshold policy analysisCode clarity improvement around invalid (dis)satisfaction markers
4ff6f2f0by Salvatore Ingala+4−41 file
No security note in commit
Low 48 AI analysisMessage 91 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Align miniscript type and ops computations with bitcoin-core

This commit fixes the Ledger Bitcoin app's internal checker for Miniscript wallet policies. The checker was incorrectly rejecting some valid Bitcoin spending policies as unsafe, and in a few places it was computing safety properties using …

Logic change in Miniscript policy analysisAlignment with upstream Bitcoin Core reference implementationRelaxation of overly strict non-malleability and timelock-mixing checks
4694d317by Salvatore Ingala+26−132 files
No security note in commit
Moderate 68 AI analysisMessage 86 · Strong
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix ops computation for andor fragments

This commit fixes a bug in how the Ledger Bitcoin app counts the number of Bitcoin script operations (ops) needed to spend certain wallet policies that use a 'miniscript andor' fragment. Because the count was wrong, the app could allow use…

Incorrect miniscript ops accounting for andor fragmentPolicy sanity check bypass leading to unspendable registered walletsReference alignment with Bitcoin Core implementation
86159d1eby Salvatore Ingala+40−13 files
Vendor flagged security relevance
High 74 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

Fix ops computation for l: and u: fragments

This commit fixes a bug in how the Ledger Bitcoin app counts Bitcoin script operations ('ops') for two specific Miniscript fragments, 'l:' and 'u:'. Because the count was too low, the app could accept wallet policies that look valid but ar…

Undercounting of script operation budget leading to acceptance of unspendable policiesIncorrect handling of Miniscript wrapper dissatisfaction semanticsPolicy sanity check bypass via operation-count accounting flaw
b6ac1de8by Salvatore Ingala+39−33 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 68 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

doc: document the MUSIG2_SESSION_ID PSBT field

This commit only updates documentation and the changelog. It explains a new optional PSBT field called MUSIG2_SESSION_ID that lets software wallets manage multiple MuSig2 signing sessions for the same wallet policy on a Ledger device. Ther…

8d8ed9afby Salvatore Ingala+28−62 files
No security note in commit
Informational 15 AI analysisMessage 78 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

musig_sessions: store up to 32 sessions

This commit is a simple capacity increase, not a security fix. It raises the number of simultaneous MuSig2 signing sessions the Ledger Bitcoin app can keep in memory from 8 to 32, because users with multiple MuSig accounts or wallets that …

a6798172by Salvatore Ingala+12−54 files
No security note in commit
Low 26 AI analysisMessage 73 · Adequate
LD LedgerLedger Bitcoin app BitcoinHardware wallets

sign_psbt: fail before the UI if the MuSig2 session is missing

This commit improves the user experience and error handling for Ledger's Bitcoin app when using MuSig2 multi-signatures. Previously, if a required MuSig2 session was missing during the second round of signing, the device would only report …

UX-hardening: fail-fast before user approval instead of afterNew specific error code EC_SIGN_PSBT_MUSIG2_SESSION_NOT_FOUND for missing MuSig2 sessionsRefactored session storage lookup to support non-destructive existence check
2d04b144by Salvatore Ingala+118−187 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidateAllowing for message signature the line feed (LF) character handled by NBGL (2 new tests)by Ilya Artemov · e928b752 · Nov 17, 2025 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · Ilya Artemov

Allowing for message signature the line feed (LF) character handled by NBGL (2 new tests)

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit only changes automated test code for the Bitcoin app's message-signing feature. It adds a new test for messages containing a line feed (LF) character and updates an existing test to use a carriage return (CR) instead of a line feed. There is no change to the actual app code that runs on the Ledger device, so this commit does not introduce or fix a security vulnerability by itself.

Security candidateAllowing for message signature the line feed (LF) character handled by NBGLby Ilya Artemov · f4e1a90b · Nov 17, 2025 · 1 fileMessage 55 · ThinInformational 20Details
Commit message · Ilya Artemov

Allowing for message signature the line feed (LF) character handled by NBGL

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 20/100

This commit changes how the Ledger Bitcoin app decides whether a message being signed is 'printable' on the device screen. It now allows the Line Feed (newline) character to pass through, because the newer NBGL screen library can display multi-line text. Previously, any character outside the normal visible ASCII range would make the message be shown as a hex dump instead of readable text. The change is a small UI/UX improvement for message signing and does not appear to alter the actual cryptographic signature.

Lower-priorityRemoving the special handling and the warning for the suspicious derivation paths (test framework)by Ilya Artemov · 89bba825 · Nov 14, 2025 · 2 filesMessage 60 · AdequateInformational 12Details
Commit message · Ilya Artemov

Removing the special handling and the warning for the suspicious derivation paths (test framework)

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only changes test helper code, not the actual Ledger Bitcoin app that users run. It removes a special test-only shortcut for handling 'suspicious derivation path' warnings and replaces it with more explicit test button presses. There is no direct evidence in the commit that a real security vulnerability was fixed.

AI review queuedRemoving the special handling and the warning for the suspicious derivation paths (snapshots)by Ilya Artemov · 635044fe · Nov 14, 2025 · 79 filesMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Removing the special handling and the warning for the suspicious derivation paths (snapshots)

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: unusually broad change
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots (expected device screen images used in automated testing). It does not change any application code, firmware logic, or user-facing behavior. The title refers to a prior change that removed warnings for unusual Bitcoin key derivation paths; this commit merely refreshes the test images to match that earlier change.

Lower-priorityRemoving the special handling and the warning for the suspicious derivation pathsby Ilya Artemov · 2b665f87 · Nov 14, 2025 · 4 filesMessage 50 · ThinLow 37Details
Commit message · Ilya Artemov

Removing the special handling and the warning for the suspicious derivation paths

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 37/100

This commit removes a warning screen that previously appeared when a Bitcoin public key was requested for an unusual or non-standard derivation path. Without the warning, users may be less likely to notice if malicious software asks their Ledger device to reveal keys for a suspicious path. The change itself is a deliberate feature removal, not a hidden bug, but it weakens a user-facing safety check.

Security candidateUsing classical NBGL API for message signing - snapshotsby Ilya Artemov · 0fb99583 · Nov 14, 2025 · 157 filesMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Using classical NBGL API for message signing - snapshots

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit only updates test screenshot images (snapshots) for the Ledger Bitcoin app's message-signing user-interface tests. It does not change any application source code, cryptographic logic, or device behavior. The snapshots reflect a switch to the 'classical NBGL API' for message signing, but this is a test-asset update, not a security-relevant code change.

Security candidateUsing classical NBGL API for message signing - test adaptationby Ilya Artemov · d30eb8f9 · Nov 14, 2025 · 2 filesMessage 60 · AdequateInformational 15Details
Commit message · Ilya Artemov

Using classical NBGL API for message signing - test adaptation

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing boundary
AI analysis · Informational 15/100

This commit only updates automated test scripts for Ledger's Bitcoin app. It changes how on-screen button presses are simulated during message-signing tests on newer touch-screen devices, switching from one generic test helper to more specific tap coordinates. There is no change to the actual wallet application code that users run, so this cannot directly affect user funds or security.

Security candidateUsing classical NBGL API for message signingby Ilya Artemov · ad031119 · Nov 13, 2025 · 4 filesMessage 45 · ThinLow 27Details
Commit message · Ilya Artemov

Using classical NBGL API for message signing

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 27/100

This commit refactors how the Ledger Bitcoin app displays messages before signing. It replaces a streaming, paginated message-review flow with a single-page review using the standard NBGL API. The change increases the maximum message that can be shown from about 128 bytes to roughly 640 bytes, and removes the intermediate 'loading' start page. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a user-interface simplification. However, any change to the confirmation screen logic can affect whether users correctly see what they are signing, so it warrants careful review.

AI review queuedSnapshots update for transaction send: unstreaming, warning unification, status diversificationby Ilya Artemov · b25b44c7 · Nov 7, 2025 · 1991 filesMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Snapshots update for transaction send: unstreaming, warning unification, status diversification

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates test screenshot snapshots (PNG images) for the Ledger Bitcoin app. It does not change any application source code, so it cannot directly affect the security of the app or user funds. The images are used by automated tests to verify that the device's on-screen prompts look as expected when signing transactions.

AI review queuedTest framework update for transaction send: unstreaming, warning unification, status diversificationby Ilya Artemov · 73fe541f · Nov 7, 2025 · 4 filesMessage 60 · AdequateInformational 15Details
Commit message · Ilya Artemov

Test framework update for transaction send: unstreaming, warning unification, status diversification

60/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates the automated test framework for the Ledger Bitcoin app. It changes how tests simulate button presses on the device screen, renames some test helper functions, and adds new test cases for transactions with many outputs and for navigating back and forth during signing. There is no change to the actual app code that runs on the Ledger device, so this commit does not introduce or fix a security vulnerability in the product itself.

Security candidateSource code: transaction signature status diversificationby Ilya Artemov · ae9304ab · Nov 7, 2025 · 3 filesMessage 55 · ThinInformational 15Details
Commit message · Ilya Artemov

Source code: transaction signature status diversification

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 15/100

This commit is a minor user-interface wording change. It replaces the generic spinner text 'Signing' with the more descriptive phrase 'Signing transaction' shown while the device is computing a Bitcoin transaction signature. There is no change to cryptographic logic, transaction validation, or security behavior.

AI review queuedSource code: unstreaming for transaction send + warning message unificationby Ilya Artemov · 5201e56c · Nov 7, 2025 · 8 filesMessage 50 · ThinLow 33Details
Commit message · Ilya Artemov

Source code: unstreaming for transaction send + warning message unification

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 33/100

This commit refactors how the Ledger Bitcoin app displays transaction details on newer devices (Stax/Flex/Apex). It replaces a streaming, one-output-at-a-time review flow with a non-streaming 'simplified' flow for transactions with up to 16 external outputs, unifies warning messages, and moves warning screens to appear before the main transaction review. The changes are primarily a user-interface restructuring rather than a clear security fix, but they do widen the simplified-review path from 0/1 external outputs to up to 16 and change the order/timing of user warnings.

Lower-priorityMoving the ticker to the end for the swap caseby Ilya Artemov · 20beef19 · Oct 28, 2025 · 1 fileMessage 45 · ThinInformational 17Details
Commit message · Ilya Artemov

Moving the ticker to the end for the swap case

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 17/100

This commit changes how a cryptocurrency amount is formatted on screen during a swap operation. Previously the coin ticker (like 'BTC') appeared before the amount; now it appears after. The change also replaces hard-coded number 8 with a named constant and uses a safer array initialization. There is no direct evidence this fixes a security vulnerability.

Lower-priorityFeezing speculos container version to the one before breaking changesby Ilya Artemov · 2c7956fe · Oct 7, 2025 · 1 fileMessage 50 · ThinInformational 15Details
Commit message · Ilya Artemov

Feezing speculos container version to the one before breaking changes

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only changes the version of a testing container used in the project's automated CI workflow. It freezes the Speculos emulator image from 'latest' to a specific older version (0.25.5) because the test suite still uses an old Nano S Bitcoin binary that newer Speculos versions no longer support. There is no change to the actual Bitcoin app code, no user-facing change, and no security fix or vulnerability introduced.

AI review queued[auto-update] Update Ragger snapshotsby github-actions[bot] · 07bfe6b4 · Oct 7, 2025 · 286 filesMessage 45 · ThinInformational 15Details
Commit message · github-actions[bot]

[auto-update] Update Ragger snapshots

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates test screenshot images (called 'Ragger snapshots') for the Ledger Bitcoin app. No actual application code, transaction logic, or security behavior was changed. It is a routine test-maintenance update and does not affect users' funds or security.

AI review queuedAdding automatic snapshots updateby Ilya Artemov · 77e22e3d · Oct 7, 2025 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Ilya Artemov

Adding automatic snapshots update

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
documentation-only discountsecond-pass: opaque commit message
AI analysis · Informational 15/100

This commit only changes a GitHub Actions CI workflow file. It adds a manual option for developers to automatically update test snapshot images when running tests, rather than failing the build. There is no change to the actual Bitcoin app code, no user-facing behavior change, and no security relevance.

Security candidateHarden crypto_derive_symmetric_keyby Salvatore Ingala · c63f73cb · Sep 29, 2025 · 3 filesMessage 53 · ThinLow 45Details
Commit message · Salvatore Ingala

Harden crypto_derive_symmetric_key

The function would cause a buffer overflow passed a buffer longer
than 32 bytes. This is not an issue today as it was only ever used
for a fixed short string (WALLET_SLIP0021_LABEL).

The workaround to copy into a local buffer is still needed, so we
defensively forbid longer strings.

53/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly! Too few words to establish purpose
Why it was queued
memory safetydefensive validationcryptography-sensitive pathsigning or wallet path
AI analysis · Low 45/100

This commit fixes a defensive coding issue in the Ledger Bitcoin app. A function that derives a secret key from a text label could overflow an internal 32-byte buffer if given a label longer than 32 bytes. In practice, the app only ever passed one fixed short label, so the overflow was not reachable from normal use. The patch now rejects oversized labels and also handles the rare failure case when generating a wallet security code (HMAC).

AI review queuedDelete obsolete commentby Salvatore Ingala · be4a94d4 · Sep 29, 2025 · 1 fileMessage 28 · OpaqueInformational 15Details
Commit message · Salvatore Ingala

Delete obsolete comment

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only removes an old developer comment (a 'TODO' note) about a possible future feature. No actual code behavior changes, so it has no security effect on its own.

AI review queuedApp version bump: snapshotsby Ilya Artemov · 347ee89c · Sep 10, 2025 · 3 filesMessage 35 · OpaqueInformational 15Details
Commit message · Ilya Artemov

App version bump: snapshots

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only updates three test snapshot images for Ledger device screens. These are reference pictures used in automated testing to check that the app's user interface displays correctly. No application code, firmware logic, or security-sensitive files were changed.

AI review queuedAPEX_P snapshotsby Ilya Artemov · 95669f9f · Sep 10, 2025 · 390 filesMessage 18 · OpaqueInformational 15Details
Commit message · Ilya Artemov

APEX_P snapshots

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: unusually broad changesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds 390 PNG image files used for automated testing of the Ledger Bitcoin app on a new device variant called 'apex_p'. These are screenshot snapshots that the test suite compares against expected device screens. No application code, no firmware logic, and no user-facing behavior were changed. There is no security risk visible in this commit.

AI review queuedApp version bumpby Ilya Artemov · 2cb54d79 · Sep 10, 2025 · 2 filesMessage 28 · OpaqueInformational 15Details
Commit message · Ilya Artemov

App version bump

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only bumps the app's version number from 2.4.1 to 2.4.2 and updates the changelog to note 'Apex P porting'. There are no code changes, no security fixes, and no functional modifications visible in the diff.

Lower-priorityPorting to APEX_P first stepby Ilya Artemov · 3a990114 · Sep 10, 2025 · 9 filesMessage 45 · ThinInformational 15Details
Commit message · Ilya Artemov

Porting to APEX_P first step

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit adds initial support for a new Ledger hardware device model called 'Apex P'. It is a routine platform-porting change: build scripts, icons, documentation, and one conditional UI icon definition are updated to include the new device. There is no indication of a security fix or vulnerability.