What changed, and why it matters
This commit only changes a GitHub Actions CI workflow file. It adds a manual option for developers to automatically update test snapshot images when running tests, rather than failing the build. There is no change to the actual Bitcoin app code, no user-facing behavior change, and no security relevance.
No security action needed. This is a routine CI maintenance change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff modifies .github/workflows/build_and_functional_tests.yml to add a workflow_dispatch input named ‘golden_run’ with choices ‘Raise an error (default)’ and ‘Open a PR’. When ‘Open a PR’ is selected, the regenerate_snapshots flag is passed to the reusable test workflow. This is purely a CI/test-maintenance convenience feature.
Changed components
.github/workflows/build_and_functional_tests.ymlInspect captured patch +12 / −1
diff --git a/.github/workflows/build_and_functional_tests.yml b/.github/workflows/build_and_functional_tests.yml
index bd84fe8..ff035e6 100644
--- a/.github/workflows/build_and_functional_tests.yml
+++ b/.github/workflows/build_and_functional_tests.yml
@@ -5,11 +5,21 @@ name: Build and run functional tests using ragger through reusable workflow
# resulting binaries.
# It then calls another reusable workflow to run the Ragger tests on the compiled application binary.
#
-# While this workflow is optional, having functional testing on your application is mandatory and this workflow and
+# The build part of this workflow is mandatory, this ensures that the app will be deployable in the Ledger App Store.
+# While the test part of this workflow is optional, having functional testing on your application is mandatory and this workflow and
# tooling environment is meant to be easy to use and adapt after forking your application
on:
workflow_dispatch:
+ inputs:
+ golden_run:
+ type: choice
+ required: true
+ default: 'Raise an error (default)'
+ description: CI behavior if the test snapshots are different than expected.
+ options:
+ - 'Raise an error (default)'
+ - 'Open a PR'
push:
branches:
- master
@@ -34,3 +44,4 @@ jobs:
container_image: "ghcr.io/ledgerhq/app-bitcoin-new/speculos-bitcoin-musig2:latest"
# when merging a PR, we run the tests with the --enable_slow_tests parameter
test_options: ${{ github.event_name == 'push' && '--enable_slow_tests' || '' }}
+ regenerate_snapshots: ${{ github.event_name == 'workflow_dispatch' && inputs.golden_run == 'Open a PR' }}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.