KS
← All projectsKeystone

Keystone 3 firmware

Open-source device firmware for Keystone 3 hardware wallets.

BitcoinHardware walletsNormal
Repository coverage

562 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

125security candidates296second-pass queue559AI analyses
5commits · 30 days
9commits · 60 days
185commits · 180 days
402commits · 365 days
Backfill bands
Aug 5 → Feb 6260 seen14 candidatesComplete
Feb 6 → Jun 6117 seen7 candidatesComplete
Jun 6 → Jul 639 seen4 candidatesComplete
Jul 6 → Aug 5115 seen4 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

43/100 average clarity
39Strong · 80–100
75Adequate · 60–79
213Thin · 40–59
235Opaque · 0–39
39security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
soralit11634116248
Adam Tucker931193263
aaron30430248
Soralit11711154
ww351268717652176026
github-actions[bot]656074
willwang15215025
John Boyd626088
Aaron Chen222068
Qkin-Keystone26126036
qkin12112050
Greg Pfeil616074
Analysis record

Published AI watches

Last scanned 56 minutes ago

Moderate 56 AI analysisMessage 81 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Stop the wallet-prep countdown when its label goes (#2324)

This commit fixes a firmware crash and a timer-doubling bug in a cryptocurrency hardware wallet. If a user scanned a transaction too quickly after unlocking, a countdown timer could keep running after its on-screen label was destroyed, cau…

Use-after-free/dangling reference in UI timer callbackOrphaned timer leak causing accelerated countdown behaviorFirmware crash triggered by user timing (quick unlock → scan)
7da0b941by Greg Pfeil+0−00 files
No security note in commit
Informational 15 AI analysisMessage 100 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

fix(zcash): Fix regression in 3.2.2, improve performance by 15-18%, reduce firmware size by 4.4% (#2330)

This commit updates a Zcash cryptography dependency and changes compiler hints to fix a firmware performance regression and reduce firmware size. There is no security-relevant change visible in the diff.

36859d27by Jack Grigg+4−22 files
No security note in commit
Low 28 AI analysisMessage 81 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Send the whole `g_checkResult` to the UI task (#2323)

A firmware fix for a data-passing bug between internal tasks. The code was accidentally sending only the memory address size of a result structure, not the full result. Right now this only affects the rarely-used error_message field, but i…

Incorrect size passed in inter-task message (sizeof pointer instead of sizeof structure)Structure member truncation could leak partial or stale data to UI taskCrash observed by developer when accessing the omitted error_message field
6f0fb82bby Greg Pfeil+0−00 files
No security note in commit
Low 45 AI analysisMessage 61 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

release 3.2.2 (#2327)

This is a routine firmware release (version 3.2.2) for the Keystone 3 hardware wallet. The main user-visible change is adding support for the Zcash NU7 network upgrade. The code changes mostly update Zcash-related Rust libraries to newer v…

Zcash dependency major-version upgrades and API migration for NU7 compatibilityLock-screen countdown timer now initialized to NULL and explicitly stopped on label deletion, reducing dangling-timer riskTransaction-check-fail signal fixed to pass correct struct size instead of pointer size
08150faeby github-actions[bot]+1032−90129 files
No security note in commit
Informational 19 AI analysisMessage 65 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore(release): 3.2.0 (#2315)

This commit is a routine version-bump release (3.2.0) for the Keystone 3 firmware. The visible changes are almost entirely code formatting/indentation, removal of unused imports and dead code, adding 'deprecated' annotations to legacy Bitc…

No security-relevant signals detected in the diff.No mention of CVE, security fix, vulnerability, audit, or bug bounty in commit message or changelog.Changes are cosmetic, dead-code removal, feature gating, and version bump.
3690bf1fby Soralit+674−51576 files
No security note in commit
Moderate 61 AI analysisMessage 80 · Strong
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: release 3.1.4 (#2311)

This is a large routine firmware release (version 3.1.4) for the Keystone 3 hardware wallet. The visible changes add support for signing Bitcoin Cash, Dash and Dogecoin PSBTs, improve Solana and Tron transaction parsing, add Zcash shielded…

FreeRTOS MPU peripheral region narrowed to PSRAM-only and unprivileged peripheral access now disallowed by compile-time errorNew PSBT signing paths for BCH/DASH/DOGE with custom validation and sighash rulesSolana parser changes and addition of an overflow test fixture (squads-overflow.hex)
d2987b99by github-actions[bot]+18413−6376240 files
No security note in commit
Informational 23 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.1.2 (#2306)

This is a routine firmware release merge (version 3.1.2). The only functional code change visible in the diff adds one more allowed cryptocurrency derivation path prefix, 'm/44'/9000'', for Avalanche (AVAX) X/P-chain addresses when the dev…

Additive change to a path-prefix allowlistNo input validation, parsing, or memory-safety changes visibleNo vendor statement of security relevance in commit or references
f95101fbby github-actions[bot]+23−25 files
No security note in commit
Informational 15 AI analysisMessage 48 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci (#2302)

This commit only updates a Git submodule pointer (a reference to another repository) in a release-related file. There are no code changes visible in the diff, no description of any security issue, and no references provided. It appears to …

6ef9ddd3by Soralit+1−11 file
No security note in commit
Low 42 AI analysisMessage 58 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2293 from KeystoneHQ/merge/v3.1.0

This is a large firmware release merge (v3.1.0) for the Keystone 3 hardware wallet. The visible changes are mostly a major FreeRTOS kernel upgrade (from v10.x to v11.3.0), build-system improvements, and user-facing feature tweaks such as b…

FreeRTOS kernel major version upgrade (10.x -> 11.3.0) with MPU hardeningSwitch from ARM_CM4F non-MPU port to ARM_CM4_MPU portNew MPU configuration flags: configTOTAL_MPU_REGIONS=8, configENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1, configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0
0c0ae467by stone+59616−26981300 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 48 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci (#2292)

This commit only updates a Git submodule pointer in a release-tracking file. The actual code change is a one-line pointer update from one commit hash to another in a file named 'keystone3-firmware-release'. There is no visible security-rel…

90d1c789by Soralit+1−11 file
No security note in commit
Informational 15 AI analysisMessage 40 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

chore: update ci

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. No source code, build scripts, CI configuration, or security-related files are changed in the visible diff. There is no evidence…

a7f6db29by Soralit+1−11 file
No security note in commit
Moderate 58 AI analysisMessage 28 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

release 3.1.0

This is a large firmware release commit (version 3.1.0) for the Keystone 3 hardware wallet. The most significant change visible in the diff is a major upgrade of the FreeRTOS real-time operating system kernel from version 10.x to 11.3.0, c…

FreeRTOS major version upgrade (10.x → 11.3.0) with MPU port enabledNew MPU sandbox task/runtime/validator files addedconfigENFORCE_SYSTEM_CALLS_FROM_KERNEL_ONLY=1 and configALLOW_UNPRIVILEGED_CRITICAL_SECTIONS=0 set
2b007a29by Soralit+59615−26980300 files
Vendor flagged security relevance
Informational 15 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.8 (#2291)

This commit is a routine version-bump merge for release v3.0.8. It only updates changelogs, a Git submodule pointer, and a build version number. There is no code change visible in the diff and nothing that suggests a security fix or vulner…

b5e8f9fcby github-actions[bot]+18−24 files
No security note in commit
Low 47 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.6 (#2290)

This firmware update adds support for Solana's new V1 transaction format and changes how oversized or malformed transaction details are displayed. The code introduces a dedicated parser for V1 messages with strict size and structure checks…

New parser enforces hard limits on V1 message fields and rejects malformed 0x81-prefix payloads instead of falling back to message signingCompute-budget instructions in V1 are explicitly ignored to prevent fee-display spoofingUI pagination change for large transaction details reduces truncation risk
87b78ae1by github-actions[bot]+564−2812 files
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

pin to new release config (#2285)

This commit only updates a Git submodule pointer (keystone3-firmware-release) from one commit hash to another. There is no code change visible in the diff, no description of what the new release config contains, and no security-related inf…

bc01c889by Aaron Chen+1−11 file
No security note in commit
Informational 15 AI analysisMessage 68 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

update the release repo (#2282)

This commit simply updates a Git submodule pointer for the project's release repository. There is no visible code change, no description of any security issue, and no indication this is anything other than a routine release-tracking update.

3ac7e802by Aaron Chen+1−11 file
No security note in commit
Moderate 59 AI analysisMessage 76 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge release v3.0.4 (#2279)

This is a routine firmware release merge (v3.0.4) for the Keystone 3 hardware wallet. The bulk of the changes are UI tweaks, new feature support (Solana CLI, Lace Wallet), and hardening fixes found during an internal 'regular AI review'. T…

NUL-byte rejection in EIP-712 typed data parsingC-string conversion hardening against NUL bytesNull-pointer and UTF-8 validation added to UR parsing entry points
6ab436a2by github-actions[bot]+4960−548845 files
No security note in commit
Informational 13 AI analysisMessage 59 · Thin
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Build fix (#2273)

This commit is a routine build-system and code-formatting fix. It resets cached CMake build options so each build starts from known defaults, makes cbindgen header-generation failures visible instead of silently ignored, runs Rust formatti…

8568a657by stone wang+8−145 files
No security note in commit
Low 44 AI analysisMessage 36 · Opaque
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

limit file count (#2272)

This commit adds a hard cap on how many files the device will list from its SD card when loading multi-signature Bitcoin wallet data. It also tightens up null-pointer and length checks while scanning directories. The likely goal is to prev…

Unbounded directory listing now bounded by FATFS_MAX_FILE_NUMBERNull-pointer guards added for fileName, number, and path parametersLength checks added before copying filenames into caller buffers
de6879c3by stone wang+31−146 files
No security note in commit
Low 46 AI analysisMessage 73 · Adequate
KS KeystoneKeystone 3 firmware BitcoinHardware wallets

Merge pull request #2268 from KeystoneHQ/regular-review-fix

This commit tightens which old-style Bitcoin-like transactions the Keystone hardware wallet will accept. It now rejects raw protobuf Bitcoin (BTC) and Dogecoin (DOGE) legacy UTXO transactions, allowing only Bitcoin Cash (BCH), Dash (DASH),…

Deprecation of raw-protobuf Bitcoin transaction handlingRejection of unsupported legacy UTXO variants at multiple entry pointsShift from coin_code string matching to protobuf variant matching for legacy path eligibility
1c70d3d4by Soralit+134−166 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Security candidatefix(zcash): skip finalized dummy spends during signingby Adam Tucker · 9792998a · Jul 13, 2026 · 3 filesMessage 62 · AdequateLow 43Details
Commit message · Adam Tucker

fix(zcash): skip finalized dummy spends during signing

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 43/100

This commit fixes a bug in the Keystone hardware wallet's Zcash signing code. When signing a batch of Zcash transactions that include 'dummy' placeholder spends (zero-value decoy actions used for privacy), the signer could get stuck or fail because it tried to re-sign a dummy spend whose signature had already been finalized and then stripped for transport. The fix tells the signer to skip these finalized zero-value dummy spends, allowing the real spend to be signed normally. The changelog frames it as a fix for batch signing with finalized zero-value dummy spends.

Lower-priorityUse typed batch firmware version encodingby Adam Tucker · e4c1713c · Jul 13, 2026 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · Adam Tucker

Use typed batch firmware version encoding

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit updates the firmware's Zcash batch signing result to use a new typed encoding for the firmware version field. It is a routine dependency bump and code adjustment to match a changed SDK API. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a correctness or compatibility change.

Lower-priorityClarify firmware version wire encodingby Adam Tucker · c531d791 · Jul 13, 2026 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · Adam Tucker

Clarify firmware version wire encoding

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only changes a code comment to make it clearer where a particular 3-byte version format is used. No actual code behavior was changed, so it cannot introduce or fix a security issue on its own.

AI review queuedClarify firmware version sourceby Adam Tucker · e9b2548c · Jul 13, 2026 · 2 filesMessage 35 · OpaqueInformational 15Details
Commit message · Adam Tucker

Clarify firmware version source

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only updates comments and documentation to make clear which firmware version number is sent over the wire for Zcash signing. It does not change any code behavior, so it is not a security fix and does not introduce a vulnerability.

AI review queuedReport firmware version in Zcash batch resultsby Adam Tucker · 38219fde · Jul 13, 2026 · 6 filesMessage 45 · ThinInformational 18Details
Commit message · Adam Tucker

Report firmware version in Zcash batch results

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
parser or protocol pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit adds the firmware version number to Zcash batch signing responses. It is a feature/documentation change, not a security fix or vulnerability. The version was already included in single-transaction responses; now it is also included in batch responses so wallets can identify which firmware version produced the signatures.

AI review queuedPreserve master software versionby Adam Tucker · 177a1177 · Jul 13, 2026 · 1 fileMessage 35 · OpaqueInformational 15Details
Commit message · Adam Tucker

Preserve master software version

35/100 · OpaqueMessage clarity
✓ Descriptive subject! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit only changes the firmware version numbers in a header file (from 12.4.9 beta 2 to 12.5.0 beta 1). It does not modify any executable code, fix any bug, or change any security behavior. There is no security relevance visible in the diff.

AI review queuedperf(zcash): speed up batch processing and show a loading hintby Adam Tucker · be657651 · Jul 13, 2026 · 12 filesMessage 62 · AdequateInformational 19Details
Commit message · Adam Tucker

perf(zcash): speed up batch processing and show a loading hint

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 19/100

This commit is a performance and user-experience improvement for Zcash batch transactions on the Keystone 3 hardware wallet. It speeds up processing of multiple Zcash PCZTs by caching decoded viewing keys and spend-authorization keys across the batch, instead of re-deriving them for every transaction. It also adds a loading hint telling users that batch processing may take a few minutes. There is no direct evidence in the commit of a security vulnerability being fixed; the changes appear to be a refactor with added tests and UI feedback.

Lower-priorityfix(zcash): bound batch count before parsingby Adam Tucker · c3c717c9 · Jul 12, 2026 · 3 filesMessage 57 · ThinModerate 61Details
Commit message · Adam Tucker

fix(zcash): bound batch count before parsing

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Moderate 61/100

This commit adds a safety check for Zcash batch transactions on Keystone hardware wallets. Before fully parsing a batch of PCZT (Zcash transaction) data, the firmware now reads the declared number of items and rejects it if it exceeds 50. This prevents the parser from trying to allocate memory for an absurdly large number of items based solely on attacker-controlled input, which could cause memory exhaustion or a crash.

AI review queuedfeat(zcash): use bounded PCZT batches and compact responsesby Adam Tucker · 2a86bb62 · Jul 12, 2026 · 13 filesMessage 62 · AdequateLow 37Details
Commit message · Adam Tucker

feat(zcash): use bounded PCZT batches and compact responses

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathparser or protocol pathsecond-pass: security-sensitive path
AI analysis · Low 37/100

This commit refactors how Keystone's Zcash batch signing feature handles large batches. It replaces an older message envelope with a new format that uses the upstream Zcash PCZT batch signer, adds a 512 KiB total size cap, raises the maximum PCZT count from 35 to 50, and returns only compact signatures instead of full signed PCZT data. It also updates several Zcash Rust dependencies from a fork to upstream releases and tightens some digest helpers to handle missing optional fields safely. The changes are framed as a feature improvement and hardening, not as a fix for a known active vulnerability.

Lower-prioritydocs(zcash): clarify FFI memory ownershipby Adam Tucker · 94e77e73 · Jul 11, 2026 · 1 fileMessage 57 · ThinInformational 12Details
Commit message · Adam Tucker

docs(zcash): clarify FFI memory ownership

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 12/100

This commit only changes a code comment in a Zcash-related Rust file. It does not modify any actual program logic, function behavior, or memory-management code. The new comment explains more clearly that certain memory must be freed through a specific C-style free function rather than Rust's normal cleanup, and warns that leaving the function early after partial conversion would leak memory. There is no code change to fix or introduce a leak.

Lower-priorityfix(zcash): make migration review order independentby Adam Tucker · 44d6d428 · Jul 11, 2026 · 3 filesMessage 62 · AdequateLow 42Details
Commit message · Adam Tucker

fix(zcash): make migration review order independent

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 42/100

This commit rewrites how a Zcash wallet's firmware summarizes batches of migration transactions on its screen. Previously, the code assumed the first message in a batch was an ordinary transaction and all later messages were migration-style transfers, then folded only those later messages into a compact summary. The new code inspects every message individually and decides by its actual contents whether it can be compacted. This makes the review order-independent and avoids mis-classifying a batch when the first message is actually a migration or when there are multiple ordinary transactions. The change is a defensive refactor rather than a clear-cut vulnerability patch, but the old design could have led to misleading on-device transaction summaries if a batch were presented in an unexpected order.

AI review queuedfeat(zcash): aggregate migration reviewby Adam Tucker · 7770a70a · Jul 11, 2026 · 8 filesMessage 57 · ThinLow 33Details
Commit message · Adam Tucker

feat(zcash): aggregate migration review

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 33/100

This commit adds a new compact review screen for batches of Zcash 'migration' transactions (moving funds from the Orchard pool to the newer Ironwood pool). It also fixes a small user-experience issue: the device will no longer auto-lock while a long batch of transactions is loading or being signed. The change is a feature addition with defensive checks, not a fix for an active security bug.

AI review queuedfix(zcash): scrub cached spend authorizing keysby Adam Tucker · e05af65a · Jul 11, 2026 · 3 filesMessage 57 · ThinModerate 60Details
Commit message · Adam Tucker

fix(zcash): scrub cached spend authorizing keys

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 60/100

This commit fixes a security hygiene issue in the Keystone hardware wallet's Zcash signing code. Previously, secret 'spend authorizing keys' were cached in ordinary memory and could remain there after use. The patch adds explicit memory scrubbing (zeroization) when keys are replaced or no longer needed, reducing the chance that an attacker with physical or debug access could recover leftover secret key material.

Lower-priorityfix(zcash): validate shielded outputs, memos, and ownershipby Adam Tucker · 7459ef9d · Jul 11, 2026 · 4 filesMessage 62 · AdequateModerate 66Details
Commit message · Adam Tucker

fix(zcash): validate shielded outputs, memos, and ownership

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
Why it was queued
defensive validation
AI analysis · Moderate 66/100

This commit fixes validation of Zcash shielded transaction data on a Keystone hardware wallet. Previously, the device could accept transactions where it could not verify where shielded funds were going, could not read certain encrypted outputs, or could be shown invalid memos. The patch makes the wallet reject such cases, helping prevent theft or misleading transaction review.

Lower-priorityrefactor(zcash): check and parse batch PCZTs in a single passby Adam Tucker · c55a8572 · Jul 11, 2026 · 3 filesMessage 62 · AdequateLow 29Details
Commit message · Adam Tucker

refactor(zcash): check and parse batch PCZTs in a single pass

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Low 29/100

This commit refactors how Keystone's Zcash firmware checks and parses batches of partially-created shielded transactions (PCZTs). It merges what used to be separate validation and display steps into a single pass, adds a new public function for batch PCZTs, and adds tests for Ironwood spends and Orchard-to-Ironwood migrations. The change is described by the vendor as a refactor, not a security fix, and no independent security references are supplied.

Lower-priorityrefactor(zcash): remove orphaned sign_message_orchard helperby Adam Tucker · eb08e34e · Jul 11, 2026 · 1 fileMessage 62 · AdequateInformational 12Details
Commit message · Adam Tucker

refactor(zcash): remove orphaned sign_message_orchard helper

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 12/100

This commit removes an unused helper function called sign_message_orchard from the Zcash code in a cryptocurrency hardware wallet firmware. The function was not being called anywhere in the codebase (orphaned/dead code), so removing it is a routine cleanup. There is no direct evidence in the commit that this was a security fix or that the removed code was exploitable.

Lower-priorityci(zcash): run rust_c Zcash tests for relevant changesby Adam Tucker · 25c20357 · Jul 11, 2026 · 1 fileMessage 72 · AdequateInformational 15Details
Commit message · Adam Tucker

ci(zcash): run rust_c Zcash tests for relevant changes

72/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
Why it was queued
documentation-only discount
AI analysis · Informational 15/100

This commit only adds a new GitHub Actions CI workflow that runs automated tests for Zcash-related Rust code when relevant files change. It does not modify any firmware code, cryptographic logic, or user-facing behavior. There is no security issue here.

Lower-priorityperf(zcash): hoist the shielded sighash out of the per-action loopby Adam Tucker · 1596d47d · Jul 11, 2026 · 1 fileMessage 62 · AdequateInformational 18Details
Commit message · Adam Tucker

perf(zcash): hoist the shielded sighash out of the per-action loop

62/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 18/100

This commit is a small performance and code-clarity improvement for Zcash shielded transaction signing in a Keystone hardware wallet firmware component. It moves a repeated transaction-hash calculation out of a per-action loop so it is computed once per transaction instead of once per action, and replaces hard-coded byte-slice numbers with named constants. There is no direct evidence this fixes a security vulnerability, but it reduces the chance of accidental slicing mistakes when handling encrypted note data.

AI review queuedRemove obsolete NU6.3 cfgby Adam Tucker · a99e518e · Jul 10, 2026 · 9 filesMessage 45 · ThinLow 28Details
Commit message · Adam Tucker

Remove obsolete NU6.3 cfg

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 28/100

This commit removes a compile-time feature flag called NU6.3 from the Zcash code in the Keystone hardware wallet firmware. Previously, Ironwood (a newer Zcash shielded pool) and v6 transaction support were only compiled when the 'zcash_unstable="nu6.3"' flag was set. The change makes that code always compile and run, effectively enabling Ironwood/v6 support by default. There is no direct evidence in the commit that this fixes a security vulnerability; it appears to be a cleanup that promotes experimental code to stable. However, enabling new consensus code paths always carries some risk that previously-unreachable bugs or parsing differences could now affect real transactions.

AI review queuedFormat Zcash PCZT codeby Adam Tucker · a759792c · Jul 10, 2026 · 3 filesMessage 28 · OpaqueInformational 15Details
Commit message · Adam Tucker

Format Zcash PCZT code

28/100 · OpaqueMessage clarity
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: opaque commit messagesecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only reformats existing Zcash PCZT code—adjusting line breaks, indentation, and whitespace. No logic, behavior, or security checks were changed.

Lower-prioritydocs(zcash): tighten orchard patch commentby Adam Tucker · 1d76df4d · Jul 9, 2026 · 1 fileMessage 57 · ThinInformational 15Details
Commit message · Adam Tucker

docs(zcash): tighten orchard patch comment

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only rewrites a comment in a dependency configuration file. No code, dependency versions, or build settings were changed. It has no security relevance on its own.

Lower-priorityrefactor(zcash): remove checked PCZT digest stampby Adam Tucker · cf6b75c8 · Jul 9, 2026 · 2 filesMessage 57 · ThinModerate 57Details
Commit message · Adam Tucker

refactor(zcash): remove checked PCZT digest stamp

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Moderate 57/100

This commit removes a security check that verified a Zcash transaction buffer had not been tampered with between the 'check/review' screen and the 'sign' step on a Keystone hardware wallet. Before the change, the device stored a fingerprint (SHA-256 digest) of the reviewed transaction and re-checked it before signing. After the change, it only checks that the buffer pointer is not null. This weakens the defense-in-depth boundary between the C code and the Rust code that handles signing, but the commit does not by itself create a known exploitable bug.

Lower-prioritytest(zcash): clarify Sapling fixture omissionby Adam Tucker · c2fbb6d4 · Jul 9, 2026 · 1 fileMessage 67 · AdequateInformational 15Details
Commit message · Adam Tucker

test(zcash): clarify Sapling fixture omission

67/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This is a one-line comment change in a Zcash test file. It rewords an explanatory note about why a test sample lacks a Sapling bundle. No code behavior changes, no security fix or vulnerability is introduced.

Lower-prioritytest(zcash): clarify PCZT wire prefix fixtureby Adam Tucker · 004c6143 · Jul 9, 2026 · 1 fileMessage 67 · AdequateInformational 15Details
Commit message · Adam Tucker

test(zcash): clarify PCZT wire prefix fixture

67/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Mentions testing or verification! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only renames a test-only helper struct and updates comments in unit tests for Zcash PCZT (partially-created transaction) handling. It makes no changes to production code, cryptography, transaction parsing, or wallet behavior. There is no security issue here.

Lower-priorityrefactor(zcash): collapse checked PCZT helpersby Adam Tucker · 8127079d · Jul 9, 2026 · 1 fileMessage 57 · ThinInformational 12Details
Commit message · Adam Tucker

refactor(zcash): collapse checked PCZT helpers

57/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope! No meaningful explanatory body
AI analysis · Informational 12/100

This commit is a straightforward code cleanup in the Zcash PCZT (Partially Created Zcash Transaction) handling code. It merges two nearly identical internal helper functions into one shared helper that takes a policy argument, and removes a separate 'already parsed' helper that was only used internally. There is no change to user-visible behavior, no new security checks removed, and no bug fix or vulnerability patch evident from the diff.