Clarify firmware version wire encoding
What the developer wrote
Authored by Adam Tucker
Clarify firmware version wire encoding
What changed, and why it matters
This commit only changes a code comment to make it clearer where a particular 3-byte version format is used. No actual code behavior was changed, so it cannot introduce or fix a security issue on its own.
No security action needed. Treat as a normal documentation cleanup.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The diff updates a doc comment in rust/apps/zcash/src/version.rs. The old comment said the encoding was used in global.proprietary values; the new comment says it is the raw 3-byte wire encoding used by Zcash signing responses. The encode() implementation remains [self.0, self.1, self.2] and is unchanged. This is a documentation-only clarification.
Changed components
rust/apps/zcash/src/version.rsInspect captured patch +1 / −1
diff --git a/rust/apps/zcash/src/version.rs b/rust/apps/zcash/src/version.rs
index 2926760..82fcbf7 100644
--- a/rust/apps/zcash/src/version.rs
+++ b/rust/apps/zcash/src/version.rs
@@ -29,7 +29,7 @@ include!(concat!(env!("OUT_DIR"), "/version_generated.rs"));
pub struct Version(pub u8, pub u8, pub u8);
impl Version {
- /// Raw 3-byte encoding used in `global.proprietary` values.
+ /// Raw 3-byte wire encoding used by Zcash signing responses.
pub fn encode(&self) -> [u8; 3] {
[self.0, self.1, self.2]
}
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.