test(zcash): clarify Sapling fixture omission
What the developer wrote
Authored by Adam Tucker
test(zcash): clarify Sapling fixture omission
What changed, and why it matters
This is a one-line comment change in a Zcash test file. It rewords an explanatory note about why a test sample lacks a Sapling bundle. No code behavior changes, no security fix or vulnerability is introduced.
No action needed; this is a non-functional documentation/comment-only change.
Security signals we found
No strong security signals were identified.
Evidence from the diff
The commit modifies only a comment in rust/apps/zcash/src/lib.rs within a test module. It clarifies that the orchard-change PCZT sample has an empty Sapling bundle that v2 omits on the wire, and removes the phrase ‘and negative value sum’ from the comment. The actual test code that synthesizes a Sapling bundle remains identical.
Changed components
rust/apps/zcash/src/lib.rs test moduleInspect captured patch +2 / −2
diff --git a/rust/apps/zcash/src/lib.rs b/rust/apps/zcash/src/lib.rs
index 9501db7..a3df090 100644
--- a/rust/apps/zcash/src/lib.rs
+++ b/rust/apps/zcash/src/lib.rs
@@ -1293,8 +1293,8 @@ mod tests {
let mut sample = pczt::test_support::sample_orchard_change_pczt();
let (mut prefix, rest) =
postcard::take_from_bytes::<PcztWirePrefix>(&sample.bytes[8..]).unwrap();
- // The orchard-change sample carries no Sapling bundle (v2 omits it); synthesize one
- // with a single output and negative value sum so the batch check rejects it.
+ // The orchard-change sample has an empty Sapling bundle, which v2 omits on the wire;
+ // synthesize one with a single output so the batch check rejects it.
let mut sapling = prefix.sapling.take().unwrap_or(SaplingBundleMirror {
spends: Vec::new(),
outputs: Vec::new(),
Why this scored 15/100
Community notes
Notes can correct, qualify, or add evidence to the AI analysis. Every note shown here has been validated by a human moderator.
The AI analysis stands alone for now. Submit a note if you can add evidence or important context.