Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.
Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.
This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…
Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…
Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…
Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…
Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…
Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…
This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…
This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.
This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…
Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…
Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…
This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…
UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…
No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…
Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …
Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…
Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…
Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…
Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…
No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…
Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
contrib: build appimage: fetch ca-certificates from pinned sources
Fetch ca-certificates from the pinned sources similar to the other packages. This needs to be done because the default sources of debian 11 stopped working. Because the pinned sources are https they need to be patched to http before using them to get ca-certificate, as https requires ca-certificates. This is safe as packages are signed by debian (the previous way of installing ca-certificates also used http).
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 19/100
This commit changes how the Electrum AppImage build container first obtains trusted web certificates. Because the build's pinned Debian package sources use HTTPS, the container needs certificates before it can talk to them. The old method stopped working on Debian 11, so the patch temporarily switches the package source to plain HTTP just long enough to install the certificate bundle, then switches back. The packages are still verified by Debian's own signatures, so this is a build-fix rather than a security vulnerability, though it does introduce a brief HTTP download step inside the isolated build environment.
Merge pull request #10871 from accumulator/hww_deprecation_bb01_archos
hww: add a deprecation message popup at get_xpub time for bitbox01 and safe-t
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 19/100
This commit adds user-facing warning popups that appear when Electrum interacts with two older hardware wallets: the Digital Bitbox (BitBox01) and the Archos Safe-T mini. The message tells users these devices are being deprecated, are no longer supported by their manufacturers, and that users should move their coins to a modern device. It is a notification-only change, not a security fix or vulnerability.
qt: fix onchain invoice dialog exc for script outputs
Fixes exception when double clicking on saved invoice (`show_onchain_invoice()`) for an invoice containing a script output (invoice.address is None).
``` 17.57 | E | gui.qt.exception_window.Exception_Hook | exception caught by crash reporter Traceback (most recent call last): File "/var/home/user/code/code_vm/electrum/electrum/gui/qt/my_treeview.py", line 341, in mouseDoubleClickEvent self.on_double_click(idx) ~~~~~~~~~~~~~~~~~~~~^^^^^ File "/var/home/user/code/code_vm/electrum/electrum/gui/qt/invoice_list.py", line 88, in on_double_click self.show_invoice(key) ~~~~~~~~~~~~~~~~~^^^^^ File "/var/home/user/code/code_vm/electrum/electrum/gui/qt/invoice_list.py", line 150, in show_invoice self.main_window.show_onchain_invoice(invoice) ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^ File "/var/home/user/code/code_vm/electrum/electrum/gui/qt/main_window.py", line 1672, in show_onchain_invoice outputs_str = '\n'.join(map(lambda x: x.address + ' : ' + self.format_amount(x.value)+ self.base_unit(), invoice.outputs)) File "/var/home/user/code/code_vm/electrum/electrum/gui/qt/main_window.py", line 1672, in <lambda> outputs_str = '\n'.join(map(lambda x: x.address + ' : ' + self.format_amount(x.value)+ self.base_unit(), invoice.outputs)) ~~~~~~~~~~^~~~~~~ TypeError: unsupported operand type(s) for +: 'NoneType' and 'str' ```
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 21/100
This commit fixes a simple user-interface crash in Electrum's desktop (Qt) wallet. When a user double-clicked a saved invoice that pays to a raw Bitcoin script (rather than a normal address), the invoice details dialog threw an error and failed to open. It is a UI-only bug, not a way to steal funds or bypass security.
AI review queuedadb: add missing cache invalidation sites for transitions to/from unverifiedby Sander van Grieken · b5a54166 · Sep 8, 2026 · 2 filesMessage 50 · ThinModerate 57Details
Commit message · Sander van Grieken
adb: add missing cache invalidation sites for transitions to/from unverified
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 57/100
This commit fixes missing cache invalidation in Electrum's wallet history code. When a transaction's status changed—such as when a confirmed transaction returned to the mempool after a blockchain reorganization—the wallet's internal caches were not always cleared. This could leave the wallet showing stale or inconsistent information, such as an outdated balance, an outdated transaction height, or a now-invalid 'short ID' used to identify coins. The fix adds explicit cache clearing at several state-transition points and includes tests demonstrating the problem.
AI review queuedwallet: keep height and txpos in sync in wallet.add_input_info()by Sander van Grieken · 4d66088b · Sep 8, 2026 · 5 filesMessage 85 · StrongLow 35Details
Commit message · Sander van Grieken
wallet: keep height and txpos in sync in wallet.add_input_info()
a change in funding tx status (e.g. from verified to back in mempool due to reorg) can change both height and txpos, but txpos was not kept in sync here. match what adb.get_transaction() does.
also guard TxInput.short_id on both height and txpos
85/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 35/100
This commit fixes a bookkeeping bug in the Electrum Bitcoin wallet. When a transaction's status changes due to a blockchain reorganization (for example, a confirmed transaction temporarily returns to the unconfirmed mempool), the wallet was updating a coin's 'block height' but forgetting to update its 'position within the block' (txpos). The two values were getting out of sync, which could make the wallet display or identify coins incorrectly. The fix keeps both values together and adds a safety check so the short display ID is only used when both height and position are valid.
Merge pull request #10929 from spesmilo/fix_trampoline_forwarding
Fix trampoline forwarding
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 69/100
This commit fixes how Electrum handles Lightning trampoline forwarding and zero-conf channels. Previously, a forwarding node could be tricked into forwarding a partial/incomplete payment set, or could open risky zero-conf channels while also acting as a payment forwarder. The patch makes forwarding wait until the full expected amount arrives, blocks zero-conf channels for forwarding wallets, and tightens feature signaling so wallets don't advertise zero-conf support to untrusted peers when they shouldn't.
✓ Subject identifies a change! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 36/100
This is a one-line bug fix in Electrum's Lightning Network payment handling. The code was comparing a whole status object to a resolution value, which would always be false. The fix compares just the resolution status correctly. This likely changes when a specific payment timeout error is returned versus a generic payment-details error. It appears to be a correctness fix for Lightning multi-part payment handling, with possible security implications around error handling but no clear exploit shown.
Merge pull request #10933 from SomberNight/202609_crandom_prep
prep crandom.py: trivial refactor to centralise our RNG code
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
entropy or randomnesscryptography-sensitive pathseed or entropy pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 20/100
This commit is a cleanup change: it creates a single helper module for random-number generation and replaces scattered calls to os.urandom, secrets.token_bytes, and an old randrange helper with the new helpers. The new helpers still use the same Python standard-library secure random sources (os.urandom and secrets.randbelow), so the change does not introduce a security weakness. It is preparation work for a future improvement, not a fix for an active vulnerability.
Add missing information to lightning channel backup so users of non-deterministic lightning wallets trying to recover anchor channels are able to sweep the to_remote output of a remote ctx.
Also shows a warning to affected users, urging them to export a new backup.
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 53/100
This commit fixes a bug in Electrum's Lightning channel backups for 'anchor' channels. Previously, the backup did not store enough secret key information, so users with non-deterministic Lightning wallets who restored from a backup could not recover funds if the remote party force-closed the channel. The fix adds a new backup version (v3) that includes the needed private key and warns users with older backups to export fresh ones. It is a recovery/bug-fix patch, not an exploitable vulnerability in live software.
AI review queueddisable zeroconf as client if forwarding is enabled.by ThomasV · 84ddffc4 · Sep 4, 2026 · 3 filesMessage 50 · ThinModerate 59Details
Commit message · ThomasV
disable zeroconf as client if forwarding is enabled.
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Moderate 59/100
This commit changes how Electrum's Lightning wallet advertises and accepts 'zeroconf' channels when payment forwarding is enabled. Zeroconf channels are opened instantly without waiting for on-chain confirmations, which is useful for receiving payments quickly but risky if the wallet also forwards payments for others. The patch prevents forwarding wallets from acting as zeroconf clients and from accepting zeroconf channels, likely to stop a situation where a forwarding node could be tricked into losing money on an unconfirmed channel.
Merge pull request #10888 from spesmilo/lnchannel_funding_height_downgrade
lnchannel: do not remove funded channel once funding tx is confirmed
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
update trustmerge-commit duplicate discount
AI analysis · Moderate 60/100
This patch fixes a bug in Electrum's Lightning channel handling where a malicious or misbehaving server could trick the wallet into deleting a funded channel by claiming the funding transaction was no longer confirmed. The fix makes the wallet remember that a funding transaction was once mined and refuse to downgrade that status to 'unconfirmed,' preventing accidental loss of access to funds stored in the channel.
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 12/100
This is a minor code cleanup in Electrum's Lightning Network peer handling. It simplifies how an inner trampoline onion packet is processed, replacing an if-statement with a conditional expression. There is no visible security change: the same operations happen in the same order and with the same conditions as before.
Merge pull request #10903 from SomberNight/202608_fix_type_hints_optional
type hints: (trivial) add missing "Optional" qualifiers
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathsigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100
This commit only updates Python type hints to explicitly mark parameters and variables that can be None. It does not change any program logic, runtime behavior, or security checks. It is a code-quality and documentation improvement with no security impact.
Merge pull request #10922 from accumulator/fix_use_change_config_sweeps
wallet: make sure there is a change address in case of sweeps
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 64/100
This commit fixes a bug in the Electrum Bitcoin wallet where, if the user had disabled change addresses, funds from 'sweep' transactions (such as recovering Lightning channel funds or claiming submarine swaps) could accidentally be sent back to an address controlled by someone else instead of to the user's own wallet. The fix forces the creation of a wallet-owned change address whenever a sweep is involved, even when change addresses are normally disabled.
Merge pull request #10919 from f321x/qml_dont_delete_paid_invoices
qml: prevent deleting paid invoices
58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 37/100
This change fixes a bug in Electrum's mobile/QML wallet interface where paid Lightning invoices were being deleted from the wallet's records. The fix moves the 'don't delete paid invoices' protection into the core wallet code so it applies consistently, and it also prevents deletion of invoices that are still 'in flight' (payment pending). Keeping paid invoice records is important because they are needed to show transaction history and to prove a payment was made. Deleting them could cause confusion, accounting problems, or loss of payment evidence.
wallet: don't delete payment infos when deleting paid/inflight invoice/req
Don't try to delete a `PaymentInfo` when deleting the attached `Invoice`/`Request` if they were already paid (or the payment is still inflight).
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 33/100
This commit fixes a bug in the Electrum Bitcoin wallet where deleting a paid or in-flight Lightning invoice/request could incorrectly erase important payment records. The change now preserves those records when a payment has already completed or is still pending, preventing loss of payment history and avoiding a minor privacy leak if an in-flight payment later fails.
This change tightens up Electrum's crash reporter so it cannot be flooded with an unbounded number of exceptions. Before the patch, every unhandled exception was placed in an internal queue with no size limit, which could slowly consume memory if something kept crashing. The patch caps that queue at 100 entries and logs exceptions immediately instead of silently holding them. It is a hardening fix rather than a fix for an active attack.
Merge pull request #10920 from SomberNight/202609_ln_chan_backup_db_upgrade
lnutil: refactor channel backup classes to dataclass
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 26/100
This commit refactors how Electrum stores Lightning channel backups on disk. It converts backup records from a flexible JSON-style format into a stricter binary format, and adds a one-time database upgrade routine. The change is primarily a code-quality and data-format cleanup, not a fix for an active security flaw. However, any database migration that touches sensitive key material carries a small risk of corruption or mis-handling of secrets if the conversion has bugs.
AI review queuedtests: db upgrade: add test for convert_version_72by SomberNight · 83115d66 · Sep 1, 2026 · 2 filesMessage 83 · StrongInformational 15Details
Commit message · SomberNight
tests: db upgrade: add test for convert_version_72
It's a quite complicated conversion, that even pulls in BCDataStream as dependency. (though BCDataStream is kind of bitcoin-consensus-critical, so unlikely to change.) This test should hopefully catch and prevent future regressions.
83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 15/100
This commit only adds a new automated test. It does not change any production wallet code, fix a bug, or alter how user funds are handled. The test verifies that Electrum can correctly upgrade an old test wallet database containing Lightning channel backups from database version 71 to version 72. It is a quality-assurance change, not a security patch.
AI review queuedMerge pull request #10911 from SomberNight/202608_transaction_var_intby ThomasV · 66f73cb5 · Aug 29, 2026 · 4 filesMessage 73 · AdequateInformational 22Details
Commit message · ThomasV
Merge pull request #10911 from SomberNight/202608_transaction_var_int
transaction: de-dupe write_compact_size and var_int
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 22/100
This commit is a small code cleanup in Electrum's Bitcoin transaction handling. It merges two duplicate functions for writing variable-length integer sizes and adds explicit error checks for invalid values (negative numbers or numbers too large). The change makes the code more consistent and slightly safer, but it does not appear to fix any active security vulnerability or change behavior in normal use.
Security candidatetransaction: fix return value of already_has_some_signatures()by SomberNight · 9522628b · Aug 28, 2026 · 1 fileMessage 50 · ThinInformational 18Details
Commit message · SomberNight
transaction: fix return value of already_has_some_signatures()
harmless in current usage.
50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing boundarysigning or wallet path
AI analysis · Informational 18/100
A one-line fix changes a function so it always returns a true/false value instead of returning the raw list of signatures. The commit message says this is harmless in how Electrum currently uses it. It is a code-correctness bug, not an obvious security vulnerability.
AI review queuedtype hints: (trivial) small fixes all overby SomberNight · 9db29b63 · Aug 28, 2026 · 10 filesMessage 45 · ThinInformational 15Details
Commit message · SomberNight
type hints: (trivial) small fixes all over
45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100
This commit only adjusts Python type hints and one test counter variable. It does not change any runtime behavior, so it cannot introduce or fix a security vulnerability on its own.
AI review queuedlnwatcher: catch exc during ctx output sweepingby f321x · a3dd27f9 · Aug 28, 2026 · 1 fileMessage 68 · AdequateLow 31Details
Commit message · f321x
lnwatcher: catch exc during ctx output sweeping
Catch exceptions occuring during the sweep of a single ctx output and keep going sweeping the other outputs so we sweep at least those that do not crash and don't leave them on the table.
68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Low 31/100
This commit is a defensive hardening fix for Electrum's Lightning channel watcher. It wraps each individual sweep operation in a try/except block so that if one output fails or crashes, the remaining outputs are still swept. Previously, an unhandled exception during one sweep could stop the entire process, potentially leaving funds unclaimed. The commit does not itself introduce a vulnerability; it reduces the risk of losing funds due to a crash or edge-case bug during channel closure recovery.
type hints: (trivial) add missing "Optional" qualifiers
In many cases with our type hinting, we do not explicitly specify that variables are allowed to be None when they have a default value of None. This PR now adds the missing explicit "Optional" markers.
-----
Consider: ``` class Foo(NamedTuple): field: str = None ``` This type-hinting is technically incorrect, we should type hint it as either one of these options: - `field: Optional[str] = None` - `field: str | None = None`
PyCharm has had soft-warnings about these lines for quite a while, however when doing type-inference, it used to internally "fix" the type by allowing None. Recently however it seems it is not doing the internal inference-fixing anymore, but assume that `path` has type `str` (as we specified) and then make "incorrect" inferences:
``` class Foo(NamedTuple): field: str = None
def func(foo: Foo): assert foo.field is None print("function body") # <<< PyCharm now says this code is unreachable ``` I have whole function bodies grayed out and marked as dead code due to this.
Example: https://github.com/spesmilo/electrum/blob/c82a0d12ef1e03a96d6180839f215c05efe9efe3/electrum/lnpeer.py#L2320, where htlc_set.parent_set_key is type-hinted as str, so the assert "must" always fail
93/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Informational 15/100
This commit only fixes type hints in the source code. It changes annotations such as `name: str = None` to `name: str | None = None` so that developer tools correctly understand that these variables may be empty. No actual program behavior, logic, or security checks are changed.
AI review queuedMerge pull request #10894 from f321x/fix_qml_use_after_freeby accumulator · a3f8b5cd · Aug 26, 2026 · 7 filesMessage 73 · AdequateLow 33Details
Commit message · accumulator
Merge pull request #10894 from f321x/fix_qml_use_after_free
qt/qml: handle RuntimeError when accessing deleted QObject
73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 33/100
This commit fixes a class of crash bugs in Electrum's Qt/QML graphical user interface. When a user closes a dialog or window while a background task is still running, the background task can try to talk to a Qt object that has already been destroyed, causing a RuntimeError and possibly crashing the app. The patch adds a helper that safely ignores these 'already destroyed' errors instead of letting them propagate. It does not appear to be a security vulnerability that an attacker can exploit to steal funds or run malicious code; it is a stability/robustness fix.