EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsActive incident
Repository coverage

1361 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

108security candidates322second-pass queue1084AI analyses
90commits · 30 days
200commits · 60 days
570commits · 180 days
1124commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
252Strong · 80–100
675Adequate · 60–79
388Thin · 40–59
46Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
SomberNight42533373163
ThomasV16511104163
ghost4376626170
f321x44128400070
Sander van Grieken12412112057
Felix54720070
user323062
ekzyis222053
accumulator28111072
Roman Zeyde515053
Sasha Zykov515075
Aaron Fiore414068
Analysis record

Published AI watches

Last scanned 55 minutes ago

Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11172 from accumulator/qml_crash_reporter_threading

This is a small bug-fix patch for Electrum's QML (mobile-style) graphical interface. The crash reporter was not correctly handling exceptions that come from Python's threading system, which could cause the crash reporter itself to misbehav…

Fixes incorrect exception argument handling in crash reporterPrevents potential secondary failure in error-reporting pathNo security boundary crossed; no input from untrusted source is processed
45ad42f7by Felix+4−11 file
No security note in commit
Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: crash reporter: handle threading.excepthook arguments

This commit fixes a bug in Electrum's mobile-style QML crash reporter. When an uncaught exception occurred inside a background thread, the crash reporter itself would break because it expected three pieces of information but received one b…

Crash reporter failure could hide or obscure real runtime errors in background threadsNo input validation, privilege boundary, or cryptographic issue presentFix improves diagnostic fidelity but does not close an attack vector
2e7fe460by Sander van Grieken+4−11 file
No security note in commit
Low 40 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11154 from spesmilo/make_unsigned_tx_with_base_tx

This commit changes how Electrum creates unsigned Bitcoin transactions when an existing 'base transaction' is provided. Previously, the wallet wrongly demanded spendable coins even when the caller supplied a base transaction that already c…

Relaxation of input-source preconditionAddition of consensus-level invariant assertion (at least one input)Addition of empty-input guard before PartialTransaction construction
ff273162by ThomasV+4−11 file
No security note in commit
Low 29 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

wallet: make_unsigned_tx: follow-up prev

This commit fixes a crash in Electrum's transaction builder. If a user had only one on-chain coin (UTXO) that was just enough to meet a reserve requirement, clicking 'Max' in the send tab would hit an internal assertion and fail instead of…

Denial-of-service-like crash path triggered by user action in normal wallet stateAssertion failure reachable through GUI send flowFix converts assertion crash into handled NotEnoughFunds exception
462f631dby SomberNight+2−01 file
No security note in commit
Low 28 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11097 from SomberNight/202610_bump_deps

This is a routine maintenance commit that updates many of Electrum's software building blocks (dependencies) and raises the minimum required Python version from 3.10 to 3.11. It also refreshes the Linux distribution snapshots used to build…

Dependency version bumps for security-sensitive libraries (cryptography, cffi, libffi, sqlite)Removal of an embedded PGP public key and switch to hash verification for Windows Python installer downloadsBase image refresh from EOL/near-EOL Debian bullseye to bookworm for AppImage builds
84345fdcby ghost43+934−103048 files
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11139 from accumulator/consolidate_platform_checks

This commit is a straightforward internal cleanup: it moves repeated checks like 'are we running on Windows?', 'are we on Android?', and 'are we inside an AppImage?' into a single new helper module called platform.py. The actual behavior o…

22e24580by ghost43+87−7619 files
No security note in commit
Informational 15 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

consolidate platform checks into platform.py

This commit is a straightforward internal cleanup: it moves repeated operating-system checks (Windows, macOS, Linux, Android, AppImage) into a single new helper module called platform.py and updates the rest of the code to use those helper…

9715f882by Sander van Grieken+87−7619 files
No security note in commit
Informational 15 AI analysisMessage 38 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

version: bump to 4.8.4

This commit only changes the software version number from 4.8.3 to 4.8.4 in a single file. It contains no security-related changes, no bug fixes, and no functional code modifications.

0c661eb8by f321x+1−11 file
No security note in commit
Low 29 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

make_unsigned_transaction: do not require coins if there is a base_tx

This commit relaxes a wallet check when creating a new Bitcoin transaction. Previously, Electrum refused to create a transaction if the user had no spendable coins and no explicit inputs. The change allows creation to continue if a 'base t…

Relaxation of input/coin availability guardAddition of post-construction input count assertionPotential workflow: Replace-By-Fee (RBF) or transaction bumping using base_tx inputs
876360deby ThomasV+2−11 file
No security note in commit
Informational 17 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11111 from accumulator/qml_bip39recovery_task_refactor

This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an older thread-based background scan for BIP39 seed accounts with a newer asyncio-based task approach, and makes the recovery dialog destroy itself wh…

Refactor of async task lifecycle and cancellation handlingDialog lifecycle cleanup with onClosed: destroy()Use of ignore_if_destroyed to avoid callbacks on destroyed QML objects
896a68d7by Felix+44−332 files
No security note in commit
Informational 12 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: refactor BIP39 account scan to asyncio tasks.

This commit is a code cleanup in Electrum's mobile-style QML wallet wizard. It replaces an extra background thread with a simpler asyncio-based callback for scanning BIP39 seed accounts. There is no indication this fixes a security bug; it…

00ed883aby Sander van Grieken+44−332 files
No security note in commit
Moderate 59 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: paytoedit: complete contacts to their key, not 'name <key>'

This commit fixes a bug in Electrum's Qt 'Send' tab where selecting a contact from the autocomplete dropdown could briefly leave the wrong recipient active. Previously, the payment field was set to a display name like 'Alice <alice@example…

UI state desynchronization between displayed recipient and active PaymentIdentifierStale PaymentIdentifier usable for ~1 second after recipient text changesPay/Save/Max buttons enabled while recipient is being edited
dd1b50fbby f321x+47−132 files
No security note in commit
Informational 18 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11092 from f321x/qml_address_history_labels

This commit fixes a UI bug in Electrum's QML (mobile-style) interface where transaction and address labels could become stale or fail to update after editing. It replaces a fragile manual callback system with a proper event listener so the…

No security-relevant signals in diff: no privilege escalation, injection, cryptographic, or authentication changes.Fixes a UI consistency bug (stale labels) that could mislead users but does not enable direct exploitation.Adds event-listener lifecycle management (register/unregister on destroy) to prevent dangling callbacks and potential use-after-free patterns.
9242c505by Felix+334−8412 files
No security note in commit
Low 34 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qml: avoid potential Ok signal by tapping while dialog is closing,

This commit fixes a bug in Electrum's mobile-style QML password dialog. If a user tapped the OK/confirm button while the dialog was already closing, the app could emit an extra 'password entered' signal. That extra signal triggered a crash…

Crash in authentication-related code path (AuthMixin)Duplicate signal emission during UI state transitionUser-interaction race condition (tap while dialog closing)
00f981edby Sander van Grieken+8−01 file
No security note in commit
Informational 21 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11091 from f321x/fix_num_parents_perf_simple

This commit is a performance fix for a wallet function that traces where a transaction's funds came from. It replaces a slow, repeatedly-recursive approach with a more efficient loop and removes an old cache. The change also fixes how the …

Performance fix for wallet history traversalAddress-reuse uncle detection logic changedCache removed in favor of iterative computation
4ec70746by ThomasV+82−463 files
No security note in commit
Informational 24 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11047 from fametrano/old-seed-odd-length

This commit fixes a bug where Electrum wallets created with unusual, hand-crafted 'old-style' seed phrases could not be opened or used. These seeds decode to an odd number of hex characters, which the program previously rejected. The chang…

Input validation relaxed for legacy data (odd-length hex strings)New user-facing error path prevents seed display when mnemonic encoding is impossibleGUI exception handling narrowed: UserFacingException shown as str, other Exception as repr
fc31115eby ghost43+93−157 files
No security note in commit
Informational 19 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11096 from f321x/followup_11094

This commit is a small follow-up cleanup. It translates several user-facing error messages into different languages and makes the Qt GUI handle one specific file-read/write error (StorageReadWriteError) more gracefully, showing a warning d…

Exception-handling path changed in GUIUser-facing error messages internationalizedNo changes to encryption, wallet parsing semantics, or permissions
54c355feby Felix+9−75 files
No security note in commit
Informational 23 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #11094 from devdavidejesus/fix-10760-storage-not-utf8

This commit improves Electrum's error handling when a user tries to open a file that is not a valid Electrum wallet. Previously, if the file contained bytes that were not valid UTF-8 text, the program would crash with a confusing technical…

Error-handling hardeningUser-facing exception message improvedNo cryptographic or parsing logic changed
2a20256fby Felix+10−12 files
No security note in commit
Informational 20 AI analysisMessage 65 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: show StorageReadWriteError to user instead of crash reporting it

This is a small user-interface fix in Electrum's Qt desktop app. Previously, if the wallet file was on a read-only folder or an unplugged drive, the app treated the resulting StorageReadWriteError as an unexpected crash and sent a crash re…

No memory safety, cryptographic, or authorization changesException handling change only; no new attack surface introducedCrash-reporting no longer triggered for expected I/O failure scenarios
5a971b11by f321x+2−11 file
No security note in commit
Low 26 AI analysisMessage 45 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

keystore: follow-up prev: small clean-up

This commit is a small follow-up cleanup in Electrum's keystore code. It renames an internal helper function, makes the code accept certain unusual 'old' seed phrases that some users created by hand, improves an error message shown to user…

Refactoring of seed validation helperUser-facing error handling improvement in seed displayGrandfathering of non-standard old seed phrases
ead42d09by SomberNight+35−154 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

AI review queuedqt: wizard: dedup seed validation rulesby f321x · 89d0de06 · Sep 24, 2026 · 1 fileMessage 68 · AdequateInformational 12Details
Commit message · f321x

qt: wizard: dedup seed validation rules

`WCHaveSeed.is_seed()` carried the same rules as
`KeystoreWizard.validate_seed()`, so instead use this method
to have the rules in a single place and prevent them from
drifting apart.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
defensive validationsigning or wallet pathsecond-pass: near security thresholdsecond-pass: security-sensitive path
AI analysis · Informational 12/100

This commit is a small code cleanup in Electrum's wallet setup wizard. It removes a duplicate copy of the rules used to check whether a recovery seed is valid and instead reuses an existing method. There is no indication this fixes a security bug; it is a maintenance change to keep the two copies of the rules from diverging in the future.

Security candidatetests: wizard: cover standard -> 2fa redirectionby f321x · 70b4d27c · Sep 24, 2026 · 1 fileMessage 70 · AdequateInformational 15Details
Commit message · f321x

tests: wizard: cover standard -> 2fa redirection

Add tests to cover the newly added standard restore to 2fa
redirection.

70/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Mentions testing or verification
Why it was queued
access control
AI analysis · Informational 15/100

This commit only adds and reorganizes automated test code for Electrum's wallet creation wizard. It does not change any production wallet logic, cryptography, or network handling. The tests verify that when a user tries to restore a 'standard' wallet but enters a seed phrase that actually belongs to a two-factor authentication (2FA) wallet, the wizard correctly redirects them to the 2FA setup flow. There is no security-relevant code change here.

Security candidateMerge pull request #10988 from f321x/update_security_review_ci_modelby Felix · 638fbba8 · Sep 23, 2026 · 1 fileMessage 78 · AdequateInformational 15Details
Commit message · Felix

Merge pull request #10988 from f321x/update_security_review_ci_model

ci: bump security review model to opus 5.5, detect downgrades

78/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
Why it was queued
update trustmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit updates Electrum's internal CI (continuous integration) script that runs an automated security review using Anthropic's Claude Code tool. It changes the AI model version used for reviews from 'claude-opus-5' to 'claude-opus-5-5', switches the output format to a streaming JSON format, and adds detection and warning logic for cases where Claude Code silently falls back to a different (presumably weaker) model. There is no change to Electrum wallet code, cryptography, networking, or user-facing behavior.

Security candidateci: security review: warn if the model got downgradedby f321x · ace2ca7a · Sep 23, 2026 · 1 fileMessage 90 · StrongInformational 12Details
Commit message · f321x

ci: security review: warn if the model got downgraded

Use stream-json output to detect when Claude Code falls back to another
model (e.g. after a cyber safeguards refusal), and show a warning in the
CI log, as a GitHub Actions annotation, and in the PR comment.

90/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Names security-relevant behavior explicitly
Why it was queued
update trust
AI analysis · Informational 12/100

This commit updates Electrum's own CI security-review script. It adds detection and warnings when the automated code reviewer (Claude Code) silently falls back to a different AI model, for example after a content-policy refusal. It does not change Electrum wallet code, network behavior, cryptography, or anything end users install. It is purely an internal CI/quality-assurance improvement.

AI review queuedMerge pull request #10987 from spesmilo/fix_10986by ghost43 · bef80421 · Sep 22, 2026 · 2 filesMessage 68 · AdequateLow 44Details
Commit message · ghost43

Merge pull request #10987 from spesmilo/fix_10986

transaction: treat native segwit input with non-empty witness as complete

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 44/100

This commit fixes a bug where Electrum failed to recognize certain already-signed Bitcoin transactions as complete. Specifically, for native SegWit inputs, Bitcoin Core can produce a finalized PSBT with a valid witness but an empty scriptSig. Electrum's 'is this transaction complete?' check previously required a non-empty scriptSig for such inputs, so it wrongly treated these valid, signed transactions as incomplete. The fix adds a rule: if a native SegWit input has a non-empty witness, treat it as complete. This could have led users to try re-signing or re-broadcasting, or to confusion about whether a transaction was ready.

AI review queuedtransaction: treat native segwit input with non-empty witness as completeby ThomasV · e9bb42e6 · Sep 22, 2026 · 2 filesMessage 81 · StrongLow 35Details
Commit message · ThomasV

transaction: treat native segwit input with non-empty witness as complete

Bitcoin Core, Sparrow omit the final scriptSig is empty, for native
segwit inputs, and only write the witness. PartialTxInput.is_complete()
should not require both fields to be present. fixes #10986

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 35/100

This commit fixes a bug where Electrum incorrectly treated finalized Bitcoin transactions as incomplete. Some wallet software (like Bitcoin Core and Sparrow) creates native SegWit transactions that omit an empty placeholder field Electrum expected. As a result, Electrum could wrongly refuse to broadcast or mishandle valid, already-signed transactions. The fix makes Electrum recognize these transactions as complete when the witness data is present.

Security candidatelightning: give LocalConfig and RemoteConfig the same fields.by ThomasV · 41ba9ce5 · Sep 21, 2026 · 7 filesMessage 73 · AdequateLow 27Details
Commit message · ThomasV

lightning: give LocalConfig and RemoteConfig the same fields.

Based on ab0cab8a1 in the 'peerbackups' branch. Both parties now
have current_commitment_signature, current_htlc_signatures current
and next per-commitment points. For REMOTE, our signatures are saved
in sign_next_commitment.

Note that this creates a few extra disk writes per channel commitment.
The missing fiedls are added in the same WalletDB upgrade as previous commit.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 27/100

This commit refactors how Electrum stores Lightning channel configuration data so that both sides of a channel (local and remote) use the same set of fields. It adds per-commitment points and signature fields to the shared base class, updates channel setup and state-transition code to populate them, and includes a database upgrade for existing wallets. The change appears to be a structural cleanup and preparation for future peer-backup functionality rather than a direct fix for an active security bug. There is no explicit vendor statement that this is a security patch, and no independent researcher is credited.

AI review queuedMerge pull request #10981 from spesmilo/do_not_sign_txin_with_witnessby ThomasV · 9da4c342 · Sep 20, 2026 · 1 fileMessage 73 · AdequateModerate 68Details
Commit message · ThomasV

Merge pull request #10981 from spesmilo/do_not_sign_txin_with_witness

transaction: do not sign txin if if already has a witness

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 68/100

This change prevents Electrum from re-signing Bitcoin transaction inputs that already contain a witness (the data proving the input was authorized). The patch fixes a bug where Electrum could incorrectly sign a non-SegWit input as if it were SegWit when a PSBT already included a witness for that input. This could lead to producing invalid or unintended signatures during transaction signing, especially when handling partially-signed transactions from external signers.

AI review queuedlightning: derive local channel keys instead of storing them (see #4909)by ThomasV · 461238aa · Sep 19, 2026 · 9 filesMessage 81 · StrongLow 31Details
Commit message · ThomasV

lightning: derive local channel keys instead of storing them (see #4909)

Keep only pubkeys in LocalConfig. Privkeys and per_commitment_secret_seed
are removed; they are re-derived from channel_seed on startup, and checked
against the pubkeys. Secrets (channel_seed, multisig privkey) and
funding_locked_received are moved to channel storage.

WalletDB conversion 73->74.

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 31/100

This commit refactors how Electrum stores Lightning channel keys. Instead of keeping private keys inside the channel configuration object that gets saved to disk, it now keeps only public keys there and re-derives the private keys from a channel seed when the wallet starts up. The goal is to reduce the amount of secret material sitting in persisted channel data. It also adds a wallet database upgrade that strips old private keys from existing wallets and moves the remaining secrets into the channel storage. This is a defensive hardening change, not a fix for an active exploit.

Security candidateMerge pull request #10974 from SomberNight/202609_nostr_psbt_xpubby ThomasV · 46408a78 · Sep 18, 2026 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · ThomasV

Merge pull request #10974 from SomberNight/202609_nostr_psbt_xpub

plugins: psbt_nostr: document design choice for using xpub as nsec

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet pathmerge-commit duplicate discount
AI analysis · Informational 15/100

This commit only adds a long code comment explaining a design choice in Electrum's PSBT-over-Nostr plugin. It does not change any program behavior. The comment documents that the plugin derives each cosigner's Nostr secret key from their Bitcoin extended public key (xpub), which means every cosigner can also compute every other cosigner's secret key. The developers explicitly call this an accepted tradeoff because the only shared cryptographic material among cosigners is the xpubs, and the Nostr keys are only used to exchange proposed transaction drafts (PSBTs). No vulnerability is introduced or fixed by this change.

AI review queuedMerge pull request #10980 from spesmilo/add_input_from_network_do_not_ignore_exceptionsby ghost43 · bb9d3280 · Sep 18, 2026 · 1 fileMessage 73 · AdequateLow 42Details
Commit message · ghost43

Merge pull request #10980 from spesmilo/add_input_from_network_do_not_ignore_exceptions

add_info_from_network: do not swallow exceptions

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 42/100

This is a one-line bugfix in Electrum's transaction handling. Previously, the code accidentally swallowed (hid) almost all exceptions when fetching extra transaction data from the network, only re-raising errors that were both network-related and not set to be ignored. After the fix, any unexpected error is re-raised so it can be handled or reported properly. The change improves reliability and error visibility, but the diff alone does not show an active security vulnerability being exploited.

AI review queuedMerge pull request #10970 from f321x/fix_bolt11_bugs_2by ghost43 · 4b92c0f2 · Sep 18, 2026 · 9 filesMessage 58 · ThinModerate 60Details
Commit message · ghost43

Merge pull request #10970 from f321x/fix_bolt11_bugs_2

bolt11: bugfixes and cleanup

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 60/100

This commit fixes several bugs in Electrum's handling of BOLT11 Lightning invoices. The most user-visible fixes are: stricter validation of invoice amounts (rejecting zero, negative, sub-millisatoshi, and leading-zero amounts), correct padding of the timestamp field so small dates don't get corrupted, preserving the 'n' (public key) tag when decoding so re-encoding doesn't silently drop it, and removing support for the non-standard 't' routing tag that could previously hide malformed data. There is also a fix to how description fields are truncated so they don't produce invalid UTF-8. These are correctness and robustness fixes rather than a single critical vulnerability, but they could have allowed malformed or ambiguous invoices to be accepted or re-encoded incorrectly.

Security candidateadd_info_from_network: do not swallow exceptionsby ThomasV · 3f67b21b · Sep 18, 2026 · 1 fileMessage 80 · StrongModerate 61Details
Commit message · ThomasV

add_info_from_network: do not swallow exceptions

An attacker can provide a witness_utxo whose value disagrees with
the real previous transaction. That would raise PSBTInputConsistencyFailure,
which is swallowed because it is not a NetworkException.

This would lead us to sign a tx with the wrong input amount.
(no fund loss: the tx is invalid under BIP143)

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
explicit security languagesigning boundarysigning or wallet path
AI analysis · Moderate 61/100

Electrum's transaction builder had a bug where it would ignore certain consistency errors when fetching extra transaction data from the network. A malicious or misbehaving server could supply a wrong input amount, and Electrum would silently continue and sign the transaction with that wrong amount. The resulting transaction would be invalid and not accepted by the Bitcoin network, so no funds could be lost, but it could cause confusion, failed payments, or be used to probe wallet behavior.

AI review queuedbolt11: remove tag arg from get_routing_infoby f321x · e78fba28 · Sep 18, 2026 · 7 filesMessage 60 · AdequateInformational 15Details
Commit message · f321x

bolt11: remove tag arg from get_routing_info

Through the removal of t-type routing info tags
this argument isn't neccessary anymore.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a small code cleanup change. A function that reads routing hints from Lightning invoices no longer takes a tag argument because only one type of routing hint ('r') is now supported. All callers are updated accordingly. There is no security issue visible in the change.

Security candidateqt: explicitly opt-in to RichText where usedby SomberNight · c83992f7 · Sep 14, 2026 · 13 filesMessage 45 · ThinLow 37Details
Commit message · SomberNight

qt: explicitly opt-in to RichText where used

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
seed or entropy pathsigning or wallet pathboot or update path
AI analysis · Low 37/100

This commit makes the Electrum desktop wallet explicitly tell its Qt GUI widgets to interpret certain text as rich HTML-like text, rather than leaving it on the automatic/default setting. In recent Qt versions, the default behavior changed so that labels with link tags or HTML may no longer render as clickable rich text unless the application opts in. The patch is defensive: it ensures user-facing labels (help text, warnings, update notices, transaction details, seed warnings, etc.) continue to display formatted text and clickable links correctly. There is no direct evidence in the diff of an exploitable vulnerability being fixed; it reads more like a compatibility/adjustment change after a Qt behavior change. One label was also converted from HTML line breaks to plain-text line breaks, which slightly reduces HTML parsing exposure.

Security candidateqml: explicitly opt-in to RichText where usedby SomberNight · 841529b4 · Sep 14, 2026 · 6 filesMessage 45 · ThinInformational 11Details
Commit message · SomberNight

qml: explicitly opt-in to RichText where used

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
seed or entropy pathsigning or wallet path
AI analysis · Informational 11/100

This commit adds explicit 'RichText' formatting markers to several user-interface text labels in Electrum's QML (mobile-style) GUI. Previously these labels may have implicitly rendered HTML-like tags. The change is a cleanup/adaptation to newer Qt behavior and does not, on its own, introduce a security vulnerability. It is not a fix for a known exploit, but it touches code that handles rich text rendering, which can be security-relevant if untrusted strings are later inserted.

AI review queuedMerge pull request #10940 from accumulator/fix_10937by Felix · a57ef6e7 · Sep 14, 2026 · 10 filesMessage 73 · AdequateModerate 62Details
Commit message · Felix

Merge pull request #10940 from accumulator/fix_10937

Add BOLT11DecodeException and InvalidBitcoinURI wraps for missing uncaught exceptions.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Moderate 62/100

This commit tightens how Electrum parses Bitcoin payment requests (BOLT11 lightning invoices and BIP21 URIs). It turns previously uncaught internal errors into proper validation failures, rejects malformed invoice fields that used to be silently skipped, and adds a wallet database upgrade that deletes stored invoices which no longer pass the stricter checks so old wallets can still open. The main user-visible risk is that a malicious or malformed invoice/URI could previously crash the parser or be accepted when it should have been rejected.

AI review queuedbolt11: followup #10940by f321x · 3026fbdb · Sep 14, 2026 · 2 filesMessage 36 · OpaqueLow 40Details
Commit message · f321x

bolt11: followup #10940

Address review comments of #10940

36/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Low 40/100

This commit tightens how Electrum parses BOLT11 Lightning invoices. It now rejects duplicate 'n' (node pubkey) tags instead of silently keeping only the first one, and it rejects invoice timestamps that are negative or too far in the future. These are defensive correctness fixes that reduce the chance a malformed or malicious invoice could confuse the wallet, but they are follow-up cleanups rather than a fix for a known active attack.

AI review queuedMerge pull request #10737 from sashazykov/hw-close-wallet-thread-leakby Felix · 5b77ca46 · Sep 11, 2026 · 2 filesMessage 73 · AdequateLow 32Details
Commit message · Felix

Merge pull request #10737 from sashazykov/hw-close-wallet-thread-leak

hw_wallet: fix crash on exit if device unpairing fails

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: broader security terminologysecond-pass: security-sensitive path
AI analysis · Low 32/100

This commit fixes a shutdown bug in Electrum's hardware wallet support. Previously, if disconnecting from a hardware wallet failed, the cleanup thread could keep running, which could crash the application when closing. The fix stops the thread before attempting disconnect, and makes the disconnect step tolerate errors instead of crashing.

Security candidateMerge pull request #10958 from SomberNight/202609_depsby ghost43 · 8bd8c3fb · Sep 11, 2026 · 12 filesMessage 58 · ThinInformational 23Details
Commit message · ghost43

Merge pull request #10958 from SomberNight/202609_deps

build: update some dependencies

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathmerge-commit duplicate discount
AI analysis · Informational 23/100

This commit is a routine dependency update for the Electrum Bitcoin wallet. It bumps versions of Python, OpenSSL, secp256k1, and various Python packages used in builds and runtime. The commit itself does not fix any known security bug in Electrum's own code, nor does the project describe it as a security update. Dependency updates can indirectly improve security by including upstream bug fixes, but without specific vulnerability information we cannot say this patch is itself a security fix.

AI review queuedMerge pull request #10965 from SomberNight/202609_header_checkpointsby ghost43 · 9e0b7e64 · Sep 11, 2026 · 4 filesMessage 58 · ThinInformational 21Details
Commit message · ghost43

Merge pull request #10965 from SomberNight/202609_header_checkpoints

update block header checkpoints

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Informational 21/100

This commit only adds new Bitcoin block header checkpoints to Electrum's built-in chain data files. Checkpoints are hardcoded reference points that help the wallet verify it is following the real blockchain and not a fake one. Updating them is a routine maintenance change; it does not fix a software bug and does not introduce new code behavior. It slightly strengthens protection against certain long-range attacks by extending the known-good chain history.

AI review queuedupdate block header checkpointsby SomberNight · e11c579b · Sep 11, 2026 · 4 filesMessage 58 · ThinInformational 15Details
Commit message · SomberNight

update block header checkpoints

```
>>> network.export_checkpoints(f"/home/user/wspace/electrum/electrum/chains/{electrum.constants.net.NET_NAME}/checkpoints.json")
```
(with the last 1-3 retarget periods manually removed, depending on how much we trust a chain not to do deep reorgs)

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit simply refreshes Electrum's built-in list of Bitcoin blockchain checkpoints. Checkpoints are known-good block hashes that help the wallet verify it is following the real chain. The update adds newer checkpoints for mainnet, signet, testnet, and testnet4. There is no code change and no security vulnerability introduced or fixed here.

AI review queuedMerge pull request #10945 from accumulator/stale_utxo_data_fixesby Felix · e20b24c0 · Sep 10, 2026 · 9 filesMessage 58 · ThinLow 46Details
Commit message · Felix

Merge pull request #10945 from accumulator/stale_utxo_data_fixes

Stale utxo data fixes

58/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Links an issue, advisory, or supporting reference! No meaningful explanatory body
Why it was queued
signing or wallet pathmerge-commit duplicate discountsecond-pass: security-sensitive path
AI analysis · Low 46/100

This commit fixes cases where Electrum's wallet cache could hold onto outdated information about coins and transactions after blockchain reorganizations or mempool changes. For example, if a transaction was previously thought to be mined but later returned to the mempool, the wallet might still treat it as confirmed and display an incorrect 'short ID' for it. The patch adds cache invalidation calls and makes the code consistently check whether a transaction is actually mined before showing a compact short ID. It is a correctness/bug-fix change rather than a direct remote-exploitable vulnerability, but stale cached state could mislead users or downstream logic about confirmation status.

AI review queuedtransaction: add set_mined_info setter to TxInputby f321x · 61f71acb · Sep 10, 2026 · 3 filesMessage 60 · AdequateInformational 15Details
Commit message · f321x

transaction: add set_mined_info setter to TxInput

...to deduplicate setting the block_height and block_txpos
attributes on a txin from a TxMinedInfo.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a simple code cleanup: it replaces two repeated lines that set a transaction input's block height and position with a single helper method called set_mined_info. There is no change in behavior, no bug fix, and no security relevance visible in the diff.

AI review queuedqt/util: consolidate short_id check patternby f321x · 2af9e26a · Sep 10, 2026 · 3 filesMessage 60 · AdequateInformational 15Details
Commit message · f321x

qt/util: consolidate short_id check pattern

Consolidate a bit the assembly of short_id from tx_height and tx_pos
across the qt and util code.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This is a small internal code cleanup in the Electrum Bitcoin wallet. It moves the logic that builds a compact transaction identifier (like '123x4') into one shared helper method, and removes a duplicate helper class. There is no user-facing behavior change and no security fix.