EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsNormal
Repository coverage

1153 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

92security candidates261second-pass queue1007AI analyses
127commits · 30 days
262commits · 60 days
545commits · 180 days
1002commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
220Strong · 80–100
549Adequate · 60–79
340Thin · 40–59
44Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
ThomasV137891162
SomberNight39330362063
f321x40325387070
Sander van Grieken10910101057
ghost4342517069
Felix25410072
user323062
ekzyis222053
accumulator613071
Roman Zeyde515053
Sasha Zykov515075
Aaron Fiore414068
Analysis record

Published AI watches

Last scanned 28 minutes ago

Low 29 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10992 from f321x/dedup_is_seed_wizard

This commit simplifies the seed-validation logic in Electrum's Qt wallet wizard by replacing a local copy of the rules with a call to an existing shared validation method. The change appears to be a code-cleanup refactor that removes dupli…

Refactor of seed-validation logic in wallet creation wizardRemoval of duplicated seed-type checks in favor of centralized validationAdded assertion constraining seed type to 'electrum'
554daca6by ghost43+2−81 file
No security note in commit
Low 29 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10982 from spesmilo/wizard_2fa_seed_redirect

This commit changes Electrum's wallet creation wizard so that if a user tries to restore a normal 'standard' wallet but pastes a seed phrase that actually belongs to a two-factor authentication (2FA) wallet, the wizard automatically redire…

UX-level safety fix preventing wallet-type/seed mismatchState mutation: wizard_data['wallet_type'] changed from 'standard' to '2fa' based on seed typeNo cryptographic, network, or privilege changes
310c9dd0by Felix+102−133 files
No security note in commit
Informational 12 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: wizard: dedup seed validation rules

This commit is a small code cleanup in Electrum's wallet setup wizard. It removes a duplicate copy of the rules used to check whether a recovery seed is valid and instead reuses an existing method. There is no indication this fixes a secur…

89d0de06by f321x+2−81 file
No security note in commit
Informational 15 AI analysisMessage 70 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

tests: wizard: cover standard -> 2fa redirection

This commit only adds and reorganizes automated test code for Electrum's wallet creation wizard. It does not change any production wallet logic, cryptography, or network handling. The tests verify that when a user tries to restore a 'stand…

70b4d27cby f321x+68−91 file
No security note in commit
Informational 15 AI analysisMessage 78 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10988 from f321x/update_security_review_ci_model

This commit updates Electrum's internal CI (continuous integration) script that runs an automated security review using Anthropic's Claude Code tool. It changes the AI model version used for reviews from 'claude-opus-5' to 'claude-opus-5-5…

CI hardening: detects and reports AI model downgrades during automated security reviewNo changes to application code, cryptography, network protocol, or build artifactsNo privilege escalation, injection, or data-exfiltration vectors introduced by the diff
638fbba8by Felix+75−111 file
No security note in commit
Informational 12 AI analysisMessage 90 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

ci: security review: warn if the model got downgraded

This commit updates Electrum's own CI security-review script. It adds detection and warnings when the automated code reviewer (Claude Code) silently falls back to a different AI model, for example after a content-policy refusal. It does no…

CI-only changeNo modification of wallet, crypto, networking, or build artifactsAdds detection for AI model fallback/downgrade in automated security review
ace2ca7aby f321x+74−101 file
No security note in commit
Low 44 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10987 from spesmilo/fix_10986

This commit fixes a bug where Electrum failed to recognize certain already-signed Bitcoin transactions as complete. Specifically, for native SegWit inputs, Bitcoin Core can produce a finalized PSBT with a valid witness but an empty scriptS…

Logic error in transaction completeness detectionNative SegWit witness handling edge casePSBT interoperability issue with Bitcoin Core
bef80421by ghost43+11−02 files
No security note in commit
Low 35 AI analysisMessage 81 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

transaction: treat native segwit input with non-empty witness as complete

This commit fixes a bug where Electrum incorrectly treated finalized Bitcoin transactions as incomplete. Some wallet software (like Bitcoin Core and Sparrow) creates native SegWit transactions that omit an empty placeholder field Electrum …

Logic error in transaction completeness detectionPotential denial of service / user funds stuck due to refusal to broadcast valid finalized transactionInteroperability failure with Bitcoin Core and Sparrow PSBT output
e9bb42e6by ThomasV+11−02 files
No security note in commit
Moderate 68 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10981 from spesmilo/do_not_sign_txin_with_witness

This change prevents Electrum from re-signing Bitcoin transaction inputs that already contain a witness (the data proving the input was authorized). The patch fixes a bug where Electrum could incorrectly sign a non-SegWit input as if it we…

Incorrect signature algorithm selection for non-SegWit inputs when witness data is presentPSBT handling edge case where pre-existing witness data influences signing pathPotential invalid signature production during transaction signing
9da4c342by ThomasV+10−21 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10974 from SomberNight/202609_nostr_psbt_xpub

This commit only adds a long code comment explaining a design choice in Electrum's PSBT-over-Nostr plugin. It does not change any program behavior. The comment documents that the plugin derives each cosigner's Nostr secret key from their B…

Documentation-only changeExplicit design tradeoff disclosure: cosigners can derive each other's Nostr secret keys from shared xpubsNo functional code change
46408a78by ThomasV+13−01 file
No security note in commit
Low 42 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10980 from spesmilo/add_input_from_network_do_not_ignore_exceptions

This is a one-line bugfix in Electrum's transaction handling. Previously, the code accidentally swallowed (hid) almost all exceptions when fetching extra transaction data from the network, only re-raising errors that were both network-rela…

Exception swallowing bug fixedNetwork/transaction input enrichment logic changedSilent failure mode removed
bb9d3280by ghost43+1−11 file
No security note in commit
Moderate 60 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10970 from f321x/fix_bolt11_bugs_2

This commit fixes several bugs in Electrum's handling of BOLT11 Lightning invoices. The most user-visible fixes are: stricter validation of invoice amounts (rejecting zero, negative, sub-millisatoshi, and leading-zero amounts), correct pad…

Stricter BOLT11 amount validation prevents acceptance of zero, negative, sub-millisatoshi, and leading-zero amountsFixed int_to_data5 padding bug that corrupted small timestamp values during invoice round-tripMalformed 'r' routing tags now raise exceptions instead of being silently skipped
4b92c0f2by ghost43+82−939 files
No security note in commit
Moderate 61 AI analysisMessage 80 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

add_info_from_network: do not swallow exceptions

Electrum's transaction builder had a bug where it would ignore certain consistency errors when fetching extra transaction data from the network. A malicious or misbehaving server could supply a wrong input amount, and Electrum would silent…

Swallowed exception leading to use of attacker-controlled input valuePSBT input consistency check bypassedPotential malicious Electrum server influence on transaction signing
3f67b21bby ThomasV+1−11 file
Vendor flagged security relevance
Informational 15 AI analysisMessage 60 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

bolt11: remove tag arg from get_routing_info

This is a small code cleanup change. A function that reads routing hints from Lightning invoices no longer takes a tag argument because only one type of routing hint ('r') is now supported. All callers are updated accordingly. There is no …

e78fba28by f321x+12−127 files
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10940 from accumulator/fix_10937

This commit tightens how Electrum parses Bitcoin payment requests (BOLT11 lightning invoices and BIP21 URIs). It turns previously uncaught internal errors into proper validation failures, rejects malformed invoice fields that used to be si…

Stricter input validation for externally supplied BOLT11 invoices and BIP21 URIsPreviously uncaught exceptions (ValueError, UnicodeDecodeError, ecc errors) are now wrapped in domain-specific decode exceptionsMalformed fallback addresses are skipped rather than aborting or crashing
a57ef6e7by Felix+707−9610 files
No security note in commit
Low 40 AI analysisMessage 36 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

bolt11: followup #10940

This commit tightens how Electrum parses BOLT11 Lightning invoices. It now rejects duplicate 'n' (node pubkey) tags instead of silently keeping only the first one, and it rejects invoice timestamps that are negative or too far in the futur…

Stricter validation of invoice timestamp boundsDuplicate 'n' tag now raises an exception instead of being silently droppedFollow-up to prior PR #10940, indicating a recent area of security-sensitive review
3026fbdbby f321x+14−232 files
No security note in commit
Low 32 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10737 from sashazykov/hw-close-wallet-thread-leak

This commit fixes a shutdown bug in Electrum's hardware wallet support. Previously, if disconnecting from a hardware wallet failed, the cleanup thread could keep running, which could crash the application when closing. The fix stops the th…

Process abort/crash at shutdown due to leaked QThreadException during cleanup not handled, potentially causing abnormal terminationHardware wallet client close made best-effort with error logging
5b77ca46by Felix+9−22 files
No security note in commit
Informational 23 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10958 from SomberNight/202609_deps

This commit is a routine dependency update for the Electrum Bitcoin wallet. It bumps versions of Python, OpenSSL, secp256k1, and various Python packages used in builds and runtime. The commit itself does not fix any known security bug in E…

Dependency version bumps for cryptographic libraries (OpenSSL, libsecp256k1, electrum-ecc)Routine maintenance commit with no explicit security claimHash-only changes in deterministic requirements files
8bd8c3fbby ghost43+57−5612 files
No security note in commit
Informational 21 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10965 from SomberNight/202609_header_checkpoints

This commit only adds new Bitcoin block header checkpoints to Electrum's built-in chain data files. Checkpoints are hardcoded reference points that help the wallet verify it is following the real blockchain and not a fake one. Updating the…

Hardcoded blockchain checkpoints extended for all supported networksNo executable code or cryptographic logic changedNo bug fix, privilege change, or input validation change present
9e0b7e64by ghost43+276−04 files
No security note in commit
Informational 15 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

update block header checkpoints

This commit simply refreshes Electrum's built-in list of Bitcoin blockchain checkpoints. Checkpoints are known-good block hashes that help the wallet verify it is following the real chain. The update adds newer checkpoints for mainnet, sig…

e11c579bby SomberNight+276−04 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-priorityandroid: make QR code scanner e2e compatibleby f321x · 9871931b · Aug 27, 2025 · 1 fileMessage 60 · AdequateInformational 18Details
Commit message · f321x

android: make QR code scanner e2e compatible

Makes the Java QR code scanner edge-to-edge compatible by padding the
hintTextView and the pasteButton.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 18/100

This commit adjusts the Android QR code scanner screen so its buttons and text don't get hidden behind the phone's status bar or navigation gestures on newer Android versions (Android 15+). It is a user-interface compatibility fix, not a security patch.

Security candidateqml: add padding to ElDialog for android e2eby f321x · 5f018091 · Aug 27, 2025 · 13 filesMessage 45 · ThinInformational 18Details
Commit message · f321x

qml: add padding to ElDialog for android e2e

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet pathauthentication path
AI analysis · Informational 18/100

This commit adjusts on-screen spacing for the Android version of the Electrum wallet app so that dialog boxes avoid overlapping with the phone's system status and navigation bars. It is a user-interface layout fix, not a security patch. There is no indication it fixes a vulnerability or changes how funds, keys, or passwords are protected.

Lower-priorityqml: pad main view if e2e enforcement is activeby f321x · 53595e1b · Aug 27, 2025 · 1 fileMessage 45 · ThinInformational 20Details
Commit message · f321x

qml: pad main view if e2e enforcement is active

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 20/100

This commit adjusts the Electrum mobile app's main screen layout so that Android's system status bar and navigation bar do not overlap the app's toolbar or bottom controls when the operating system's 'edge-to-edge' display mode is active. It is a UI spacing fix, not a security patch.

Lower-priorityqml: qeapp: add methods to retrive system bar heightsby f321x · 4b30b097 · Aug 27, 2025 · 1 fileMessage 50 · ThinInformational 13Details
Commit message · f321x

qml: qeapp: add methods to retrive system bar heights

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 13/100

This commit adds helper functions to Electrum's mobile QML interface so the app can measure Android status and navigation bar heights. It is a UI/layout change, not a security fix or vulnerability. There is no indication it addresses any security issue.

Lower-priorityandroid: bump target sdk to 35by f321x · c3652727 · Aug 27, 2025 · 1 fileMessage 45 · ThinInformational 11Details
Commit message · f321x

android: bump target sdk to 35

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 11/100

This commit updates a single Android build configuration number from target SDK 34 to 35. It is a routine compatibility/maintenance change with no direct security fix visible in the diff. By itself, it does not patch any vulnerability, though staying current with Android SDK targets is generally good security hygiene.

Lower-prioritydon't sys.exit() from run_offline_command, this leads to wait on lock that never releases.by Sander van Grieken · 18f6b889 · Aug 26, 2025 · 1 fileMessage 50 · ThinInformational 24Details
Commit message · Sander van Grieken

don't sys.exit() from run_offline_command, this leads to wait on lock that never releases.

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 24/100

This commit fixes a bug where Electrum's command-line tool would call sys.exit() deep inside an offline command, causing the program to hang while waiting for a lock that never gets released. The fix replaces those abrupt exits with proper exception handling so the caller can clean up and exit cleanly. It is a reliability/bug-fix change rather than a security vulnerability in the traditional sense, though the hang could be annoying or disruptive.

Lower-priorityswaps: add explicit check that (onchain_locktime < LN_locktime)by SomberNight · 835b04d5 · Aug 26, 2025 · 2 filesMessage 98 · StrongLow 29Details
Commit message · SomberNight

swaps: add explicit check that (onchain_locktime < LN_locktime)

This was already implicitly checked. This diff makes the check explicit, and serves as an additional sanity-check.
- for client-forward-swaps, we have
- "cltv safety requirement: (onchain_locktime < LN_locktime), otherwise client is vulnerable"
- server chooses onchain locktime delta = 70
https://github.com/spesmilo/electrum/blob/71255c1e735cdfcd881e045b9f2f6bc6b599f459/electrum/submarine_swaps.py#L701
- client checks that onchain locktime delta is <100
https://github.com/spesmilo/electrum/blob/71255c1e735cdfcd881e045b9f2f6bc6b599f459/electrum/submarine_swaps.py#L887
- client chooses LN locktime delta = 432
https://github.com/spesmilo/electrum/blob/71255c1e735cdfcd881e045b9f2f6bc6b599f459/electrum/submarine_swaps.py#L907
- for client-reverse-swaps, we have
- "cltv safety requirement: (onchain_locktime < LN_locktime), otherwise server is vulnerable"
- server chooses onchain locktime delta = 70
https://github.com/spesmilo/electrum/blob/71255c1e735cdfcd881e045b9f2f6bc6b599f459/electrum/submarine_swaps.py#L598
- server chooses LN locktime delta: unset, i.e. our default of 147
https://github.com/spesmilo/electrum/blob/71255c1e735cdfcd881e045b9f2f6bc6b599f459/electrum/submarine_swaps.py#L612
https://github.com/spesmilo/electrum/blob/71255c1e735cdfcd881e045b9f2f6bc6b599f459/electrum/lnworker.py#L2273

98/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode✓ Links an issue, advisory, or supporting reference✓ Names security-relevant behavior explicitly
AI analysis · Low 29/100

This commit adds an extra safety check in Electrum's submarine-swap feature to make sure the on-chain refund deadline is earlier than the Lightning Network payment deadline. The commit message says this was already implicitly guaranteed by other checks, and the code change just makes it explicit. It also adds clarifying comments about Lightning invoice expiry handling and payment bundles. There is no direct evidence that a real vulnerability was exploitable before this change.

Lower-prioritycontrib/make_download: sort signers, instead of random fs orderby SomberNight · 71255c1e · Aug 25, 2025 · 1 fileMessage 55 · ThinInformational 18Details
Commit message · SomberNight

contrib/make_download: sort signers, instead of random fs order

55/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Names security-relevant behavior explicitly! No meaningful explanatory body
AI analysis · Informational 18/100

This is a tiny build-script change that sorts the list of files in the 'dist' directory alphabetically instead of using whatever order the filesystem happens to return. It makes the generated download page deterministic and easier to review, but it does not fix a vulnerability that can be directly exploited by an attacker.

AI review queuedcontrib: add "set -e" to bash scripts where missingby SomberNight · d9480fe3 · Aug 25, 2025 · 4 filesMessage 50 · ThinInformational 18Details
Commit message · SomberNight

contrib: add "set -e" to bash scripts where missing

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit adds 'set -e' to four helper shell scripts used during Electrum's build and release process. 'set -e' makes a bash script stop immediately if any command fails, rather than continuing with potentially broken or incomplete results. This is a hardening improvement for the build pipeline, not a fix for an active security flaw in the wallet software itself. It reduces the risk that a failed build step goes unnoticed and produces a bad release artifact.

AI review queuedprepare release 4.6.2by SomberNight · c9511264 · Aug 24, 2025 · 2 filesMessage 38 · OpaqueInformational 15Details
Commit message · SomberNight

prepare release 4.6.2

38/100 · OpaqueMessage clarity
✓ Subject identifies a change✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
second-pass: opaque commit message
AI analysis · Informational 15/100

This commit is a routine release-preparation change. It only updates the version number from 4.6.1 to 4.6.2 and adds release notes describing many bug fixes and minor features. There is no code change that could directly introduce or fix a security vulnerability in this specific commit.

AI review queuedupdate localeby SomberNight · f98b6a39 · Aug 23, 2025 · 1 fileMessage 18 · OpaqueInformational 10Details
Commit message · SomberNight

update locale

18/100 · OpaqueMessage clarity
✓ Subject identifies a change! Too few words to establish purpose! No meaningful explanatory body
Why it was queued
translation-only discountsecond-pass: opaque commit message
AI analysis · Informational 10/100

This commit is a routine update to translation/localization files (locale). It changes one line in one language file. There is no indication of any security relevance.

AI review queueddaemon: load_wallet: add force_check_password arg, and use it in qmlby SomberNight · 92bdc4d4 · Aug 23, 2025 · 3 filesMessage 81 · StrongLow 29Details
Commit message · SomberNight

daemon: load_wallet: add force_check_password arg, and use it in qml

- fix: qml gui errors when trying to open a wallets with only keystore-encryption
- fixes https://github.com/spesmilo/electrum/issues/10171
- qml gui to prompt for password on wallet open even if wallet is not storage-encrypted

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
second-pass: broader security terminology
AI analysis · Low 29/100

This commit fixes a bug in Electrum's mobile-style QML user interface where wallets protected only by a keystore password (not file encryption) could be opened without prompting for or checking the password. The change adds an optional force_check_password flag to the wallet loading code and uses it in the QML GUI so users are always asked for the password before the wallet opens. It is a defensive fix, not an active remote exploit.

Lower-priorityutils/memory_leak: add helpers using 3rd-party package "objgraph"by SomberNight · 41269b9c · Aug 23, 2025 · 1 fileMessage 65 · AdequateInformational 15Details
Commit message · SomberNight

utils/memory_leak: add helpers using 3rd-party package "objgraph"

we will not start depending on "objgraph", to be clear

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit adds optional developer-only debugging helpers for investigating memory leaks. The new code is not used automatically by Electrum; it is only meant to be run manually from the Qt console by developers. It does not change how wallets, networking, or cryptography work, and it introduces no security vulnerability.

Lower-priorityutil: move DebugMem from util to utils/memory_leak.pyby SomberNight · c777c016 · Aug 23, 2025 · 2 filesMessage 50 · ThinInformational 15Details
Commit message · SomberNight

util: move DebugMem from util to utils/memory_leak.py

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit simply moves an internal developer-only debugging helper class (DebugMem) from one file to another. It is not a security fix and does not change any user-facing behavior. The code is used only for diagnosing memory leaks during development.

Lower-priorityutil: fix DebugMem helperby SomberNight · 23a82f32 · Aug 23, 2025 · 3 filesMessage 58 · ThinInformational 18Details
Commit message · SomberNight

util: fix DebugMem helper

```
28.99 | I | util.DebugMem | Start memscan
29.10 | E | plugin.Plugins |
Traceback (most recent call last):
File "...\electrum\util.py", line 405, in run_jobs
job.run()
File "...\electrum\util.py", line 376, in run
self.mem_stats()
File "...\electrum\util.py", line 368, in mem_stats
if isinstance(obj, class_):
File "...\Python310\lib\abc.py", line 119, in __instancecheck__
return _abc_instancecheck(cls, instance)
File "...\electrum\simple_config.py", line 609, in __getattribute__
raise AttributeError()
AttributeError
```

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
AI analysis · Informational 18/100

This commit fixes an internal developer-only debugging tool (DebugMem) that crashes when scanning Python objects. The crash happens because some objects raise an AttributeError during Python's normal type-checking process. The fix simply catches that error and treats the object as not matching the requested type. The affected code is commented out by default and only used for memory-leak debugging, so it does not affect normal Electrum users or their wallets.

Lower-priorityswaps: trivial rename WITNESS_TEMPLATE_REVERSE_SWAPby SomberNight · 7989d646 · Aug 23, 2025 · 1 fileMessage 40 · ThinInformational 15Details
Commit message · SomberNight

swaps: trivial rename WITNESS_TEMPLATE_REVERSE_SWAP

40/100 · ThinMessage clarity
✓ Specific, descriptive subject! No meaningful explanatory body
AI analysis · Informational 15/100

This commit is a simple variable rename from WITNESS_TEMPLATE_REVERSE_SWAP to WITNESS_TEMPLATE_SWAP, plus a comment update explaining the historical naming. The actual swap script logic, structure, and values are unchanged. There is no security issue here.

Lower-priorityswaps: add check for blockchain().is_tip_stale()by SomberNight · 08f041f3 · Aug 23, 2025 · 1 fileMessage 45 · ThinModerate 58Details
Commit message · SomberNight

swaps: add check for blockchain().is_tip_stale()

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Moderate 58/100

This change adds safety checks to Electrum's submarine swap feature so it refuses to create or accept swaps if the wallet's view of the Bitcoin blockchain is outdated ('stale tip'). If the wallet acted on old blockchain data, swap locktimes could be set dangerously far in the future or too close to the present, which could let an attacker lock up funds unfairly or prevent a refund. The patch is defensive and partial: it stops the risky action but does not by itself fix whatever caused the stale tip.

Lower-prioritylnworker: rewrite payment_bundles: lower cpu-time-complexityby SomberNight · 9e7c332b · Aug 23, 2025 · 2 filesMessage 50 · ThinInformational 12Details
Commit message · SomberNight

lnworker: rewrite payment_bundles: lower cpu-time-complexity

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 12/100

This commit is a performance refactor, not a security fix. It replaces a slow list-based data structure for tracking bundled Lightning payments with two dictionaries that allow faster lookups. There is no indication it addresses a vulnerability or changes security behavior.

Lower-priorityswaps: more clean-up, add comments, more sanity checksby SomberNight · a7afd59d · Aug 23, 2025 · 2 filesMessage 50 · ThinModerate 57Details
Commit message · SomberNight

swaps: more clean-up, add comments, more sanity checks

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Moderate 57/100

This commit tightens safety checks in Electrum's submarine-swap (a way to move Bitcoin between on-chain and Lightning) code. It prevents the same payment hash or prepayment hash from being reused for different swaps, makes sure saved payment records aren't silently overwritten by conflicting data, and verifies the other party's refund public key before accepting a swap invoice. These are defensive hardening changes that reduce the chance of a malicious or buggy swap server/client confusing the wallet into paying or revealing funds incorrectly. The commit message does not call this a security fix, and there is no disclosed vulnerability or CVE.

Lower-priorityswaps: clean-up onchain script constructionby SomberNight · fc362826 · Aug 23, 2025 · 1 fileMessage 45 · ThinLow 32Details
Commit message · SomberNight

swaps: clean-up onchain script construction

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Low 32/100

This commit refactors how Electrum builds and checks the on-chain Bitcoin scripts used in submarine swaps (a way to exchange on-chain and Lightning bitcoins). It introduces a single helper function that both constructs the script and verifies it can be reconstructed exactly from its parts. The change is a defensive clean-up: it makes the code more consistent and adds a self-check that the script matches the expected template, payment hash, locktime, and public keys. There is no direct evidence in the commit that this fixes an active security bug, but it strengthens validation against a malicious or buggy swap server sending a mismatched script.

AI review queuedutil.format_satoshis: floating-point paranoiaby SomberNight · 8d8d1dba · Aug 22, 2025 · 4 filesMessage 45 · ThinLow 46Details
Commit message · SomberNight

util.format_satoshis: floating-point paranoia

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 46/100

This commit tightens how Electrum converts numbers into displayed bitcoin amounts. It removes the ability to pass plain strings into a key formatting helper, and routes integer and float inputs through a safer Decimal conversion to avoid tiny rounding errors that can appear when computers handle decimal numbers. The change also makes one fee calculation explicitly use Decimal arithmetic. The patch is defensive and does not by itself fix a known exploitable bug, but it reduces the risk of incorrect amounts being shown or used in fee calculations.

Lower-priorityswaps: cleanup after successful swapby f321x · 97a0d27f · Aug 22, 2025 · 1 fileMessage 60 · AdequateInformational 19Details
Commit message · f321x

swaps: cleanup after successful swap

unregister hold invoice callback and delete payment bundle. they are not
used anymore.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 19/100

This commit tidies up internal bookkeeping after a Bitcoin/Lightning submarine swap completes. It removes a watcher callback and deletes a payment bundle/hold-invoice that are no longer needed. The change appears to be a cleanup/hygiene fix rather than a direct security patch, but leaving stale callbacks and payment state around could theoretically contribute to memory growth, unexpected re-triggering of events, or minor information leakage about completed swaps.

Lower-priorityswaps: cleanup data after swap gets failedby f321x · c623cca6 · Aug 21, 2025 · 2 filesMessage 68 · AdequateLow 42Details
Commit message · f321x

swaps: cleanup data after swap gets failed

Removes the persisted payment info from lnworker once a swap got failed.
Stops persisting the OnionRoutingFailure as it is sufficient to delete
the payment info to fail potential incoming htlcs.
Deletes stored swap leftovers in lnworker and SwapManager

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 42/100

This commit cleans up leftover data after a failed Lightning submarine swap in the Electrum wallet. Previously, failed swaps could leave stale payment information, routing-failure records, and internal index entries behind. The patch removes those leftovers so they cannot accidentally be reused or misinterpreted later. It is a defensive hardening change rather than a fix for a known active attack.

Lower-prioritytrivial follow-up: add more type-hintsby SomberNight · e5930dd5 · Aug 21, 2025 · 1 fileMessage 45 · ThinInformational 15Details
Commit message · SomberNight

trivial follow-up: add more type-hints

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
AI analysis · Informational 15/100

This commit only adds Python type-hints and renames a loop variable from 'v' to 'sweep_info' for clarity. It does not change any program behavior, logic, or security properties.

Lower-priorityreverse swaps: in the CLI, replace 'server_mining_fee' with 'prepayment', which corresponds to the trusted part of the lightning payment.by ThomasV · 864932c7 · Aug 21, 2025 · 6 filesMessage 73 · AdequateLow 28Details
Commit message · ThomasV

reverse swaps: in the CLI, replace 'server_mining_fee' with
'prepayment', which corresponds to the trusted part of the
lightning payment.

We use 2*sm.mining_fee, where 'mining_fee' is the flat part of
the server fee. However, future protocol should probably allow
to set a value that does not depend on 'mining_fee'.
(note that LND uses a hardcoded amount).

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Low 28/100

This commit renames and doubles a fee parameter used when doing reverse submarine swaps (a way to move funds from Lightning back to on-chain Bitcoin) in the Electrum wallet. The old name suggested it was just the swap provider's mining fee; the new name, 'prepayment', reflects that the user must pay this amount upfront over Lightning and trust the provider to return it if the swap fails. The change is mostly a terminology and parameter refactor, but it also adjusts the safety check so the allowed prepayment equals twice the mining fee rather than twice the prepayment. There is no direct evidence in the commit that this fixes an active security vulnerability.