EL
← All projectsElectrum

Electrum

Long-running lightweight Bitcoin wallet for desktop and mobile platforms.

BitcoinSoftware walletsNormal
Repository coverage

1153 commits in the local evidence base

Every captured commit receives deterministic security triage and a separate communication-quality score. Security candidates and broader second-pass signals receive full-patch Ollama analysis.

92security candidates261second-pass queue1007AI analyses
127commits · 30 days
262commits · 60 days
545commits · 180 days
1002commits · 365 days
Backfill bands
Aug 5 → Feb 6470 seen11 candidatesComplete
Feb 6 → Jun 6346 seen10 candidatesComplete
Jun 6 → Jul 653 seen2 candidatesComplete
Jul 6 → Aug 554 seen3 candidatesComplete
Commit communication

Does the history explain itself?

Message quality measures whether a commit identifies its scope, purpose, rationale, testing, and supporting references. It does not change the security-severity score.

66/100 average clarity
220Strong · 80–100
549Adequate · 60–79
340Thin · 40–59
44Opaque · 0–39
2security candidates with opaque commit messaging
Read the scoring rubric →
Developer activity

Who is changing the project?

Public Git author strings; identities are not independently verified.

DeveloperCommitsCandidatesAnalyzedHigh riskMessage avg.
ThomasV137891162
SomberNight39330362063
f321x40325387070
Sander van Grieken10910101057
ghost4342517069
Felix25410072
user323062
ekzyis222053
accumulator613071
Roman Zeyde515053
Sasha Zykov515075
Aaron Fiore414068
Analysis record

Published AI watches

Last scanned 54 minutes ago

Low 29 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10992 from f321x/dedup_is_seed_wizard

This commit simplifies the seed-validation logic in Electrum's Qt wallet wizard by replacing a local copy of the rules with a call to an existing shared validation method. The change appears to be a code-cleanup refactor that removes dupli…

Refactor of seed-validation logic in wallet creation wizardRemoval of duplicated seed-type checks in favor of centralized validationAdded assertion constraining seed type to 'electrum'
554daca6by ghost43+2−81 file
No security note in commit
Low 29 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10982 from spesmilo/wizard_2fa_seed_redirect

This commit changes Electrum's wallet creation wizard so that if a user tries to restore a normal 'standard' wallet but pastes a seed phrase that actually belongs to a two-factor authentication (2FA) wallet, the wizard automatically redire…

UX-level safety fix preventing wallet-type/seed mismatchState mutation: wizard_data['wallet_type'] changed from 'standard' to '2fa' based on seed typeNo cryptographic, network, or privilege changes
310c9dd0by Felix+102−133 files
No security note in commit
Informational 12 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

qt: wizard: dedup seed validation rules

This commit is a small code cleanup in Electrum's wallet setup wizard. It removes a duplicate copy of the rules used to check whether a recovery seed is valid and instead reuses an existing method. There is no indication this fixes a secur…

89d0de06by f321x+2−81 file
No security note in commit
Informational 15 AI analysisMessage 70 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

tests: wizard: cover standard -> 2fa redirection

This commit only adds and reorganizes automated test code for Electrum's wallet creation wizard. It does not change any production wallet logic, cryptography, or network handling. The tests verify that when a user tries to restore a 'stand…

70b4d27cby f321x+68−91 file
No security note in commit
Informational 15 AI analysisMessage 78 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10988 from f321x/update_security_review_ci_model

This commit updates Electrum's internal CI (continuous integration) script that runs an automated security review using Anthropic's Claude Code tool. It changes the AI model version used for reviews from 'claude-opus-5' to 'claude-opus-5-5…

CI hardening: detects and reports AI model downgrades during automated security reviewNo changes to application code, cryptography, network protocol, or build artifactsNo privilege escalation, injection, or data-exfiltration vectors introduced by the diff
638fbba8by Felix+75−111 file
No security note in commit
Informational 12 AI analysisMessage 90 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

ci: security review: warn if the model got downgraded

This commit updates Electrum's own CI security-review script. It adds detection and warnings when the automated code reviewer (Claude Code) silently falls back to a different AI model, for example after a content-policy refusal. It does no…

CI-only changeNo modification of wallet, crypto, networking, or build artifactsAdds detection for AI model fallback/downgrade in automated security review
ace2ca7aby f321x+74−101 file
No security note in commit
Low 44 AI analysisMessage 68 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10987 from spesmilo/fix_10986

This commit fixes a bug where Electrum failed to recognize certain already-signed Bitcoin transactions as complete. Specifically, for native SegWit inputs, Bitcoin Core can produce a finalized PSBT with a valid witness but an empty scriptS…

Logic error in transaction completeness detectionNative SegWit witness handling edge casePSBT interoperability issue with Bitcoin Core
bef80421by ghost43+11−02 files
No security note in commit
Low 35 AI analysisMessage 81 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

transaction: treat native segwit input with non-empty witness as complete

This commit fixes a bug where Electrum incorrectly treated finalized Bitcoin transactions as incomplete. Some wallet software (like Bitcoin Core and Sparrow) creates native SegWit transactions that omit an empty placeholder field Electrum …

Logic error in transaction completeness detectionPotential denial of service / user funds stuck due to refusal to broadcast valid finalized transactionInteroperability failure with Bitcoin Core and Sparrow PSBT output
e9bb42e6by ThomasV+11−02 files
No security note in commit
Moderate 68 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10981 from spesmilo/do_not_sign_txin_with_witness

This change prevents Electrum from re-signing Bitcoin transaction inputs that already contain a witness (the data proving the input was authorized). The patch fixes a bug where Electrum could incorrectly sign a non-SegWit input as if it we…

Incorrect signature algorithm selection for non-SegWit inputs when witness data is presentPSBT handling edge case where pre-existing witness data influences signing pathPotential invalid signature production during transaction signing
9da4c342by ThomasV+10−21 file
No security note in commit
Informational 15 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10974 from SomberNight/202609_nostr_psbt_xpub

This commit only adds a long code comment explaining a design choice in Electrum's PSBT-over-Nostr plugin. It does not change any program behavior. The comment documents that the plugin derives each cosigner's Nostr secret key from their B…

Documentation-only changeExplicit design tradeoff disclosure: cosigners can derive each other's Nostr secret keys from shared xpubsNo functional code change
46408a78by ThomasV+13−01 file
No security note in commit
Low 42 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10980 from spesmilo/add_input_from_network_do_not_ignore_exceptions

This is a one-line bugfix in Electrum's transaction handling. Previously, the code accidentally swallowed (hid) almost all exceptions when fetching extra transaction data from the network, only re-raising errors that were both network-rela…

Exception swallowing bug fixedNetwork/transaction input enrichment logic changedSilent failure mode removed
bb9d3280by ghost43+1−11 file
No security note in commit
Moderate 60 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10970 from f321x/fix_bolt11_bugs_2

This commit fixes several bugs in Electrum's handling of BOLT11 Lightning invoices. The most user-visible fixes are: stricter validation of invoice amounts (rejecting zero, negative, sub-millisatoshi, and leading-zero amounts), correct pad…

Stricter BOLT11 amount validation prevents acceptance of zero, negative, sub-millisatoshi, and leading-zero amountsFixed int_to_data5 padding bug that corrupted small timestamp values during invoice round-tripMalformed 'r' routing tags now raise exceptions instead of being silently skipped
4b92c0f2by ghost43+82−939 files
No security note in commit
Moderate 61 AI analysisMessage 80 · Strong
EL ElectrumElectrum BitcoinSoftware wallets

add_info_from_network: do not swallow exceptions

Electrum's transaction builder had a bug where it would ignore certain consistency errors when fetching extra transaction data from the network. A malicious or misbehaving server could supply a wrong input amount, and Electrum would silent…

Swallowed exception leading to use of attacker-controlled input valuePSBT input consistency check bypassedPotential malicious Electrum server influence on transaction signing
3f67b21bby ThomasV+1−11 file
Vendor flagged security relevance
Informational 15 AI analysisMessage 60 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

bolt11: remove tag arg from get_routing_info

This is a small code cleanup change. A function that reads routing hints from Lightning invoices no longer takes a tag argument because only one type of routing hint ('r') is now supported. All callers are updated accordingly. There is no …

e78fba28by f321x+12−127 files
No security note in commit
Moderate 62 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10940 from accumulator/fix_10937

This commit tightens how Electrum parses Bitcoin payment requests (BOLT11 lightning invoices and BIP21 URIs). It turns previously uncaught internal errors into proper validation failures, rejects malformed invoice fields that used to be si…

Stricter input validation for externally supplied BOLT11 invoices and BIP21 URIsPreviously uncaught exceptions (ValueError, UnicodeDecodeError, ecc errors) are now wrapped in domain-specific decode exceptionsMalformed fallback addresses are skipped rather than aborting or crashing
a57ef6e7by Felix+707−9610 files
No security note in commit
Low 40 AI analysisMessage 36 · Opaque
EL ElectrumElectrum BitcoinSoftware wallets

bolt11: followup #10940

This commit tightens how Electrum parses BOLT11 Lightning invoices. It now rejects duplicate 'n' (node pubkey) tags instead of silently keeping only the first one, and it rejects invoice timestamps that are negative or too far in the futur…

Stricter validation of invoice timestamp boundsDuplicate 'n' tag now raises an exception instead of being silently droppedFollow-up to prior PR #10940, indicating a recent area of security-sensitive review
3026fbdbby f321x+14−232 files
No security note in commit
Low 32 AI analysisMessage 73 · Adequate
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10737 from sashazykov/hw-close-wallet-thread-leak

This commit fixes a shutdown bug in Electrum's hardware wallet support. Previously, if disconnecting from a hardware wallet failed, the cleanup thread could keep running, which could crash the application when closing. The fix stops the th…

Process abort/crash at shutdown due to leaked QThreadException during cleanup not handled, potentially causing abnormal terminationHardware wallet client close made best-effort with error logging
5b77ca46by Felix+9−22 files
No security note in commit
Informational 23 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10958 from SomberNight/202609_deps

This commit is a routine dependency update for the Electrum Bitcoin wallet. It bumps versions of Python, OpenSSL, secp256k1, and various Python packages used in builds and runtime. The commit itself does not fix any known security bug in E…

Dependency version bumps for cryptographic libraries (OpenSSL, libsecp256k1, electrum-ecc)Routine maintenance commit with no explicit security claimHash-only changes in deterministic requirements files
8bd8c3fbby ghost43+57−5612 files
No security note in commit
Informational 21 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

Merge pull request #10965 from SomberNight/202609_header_checkpoints

This commit only adds new Bitcoin block header checkpoints to Electrum's built-in chain data files. Checkpoints are hardcoded reference points that help the wallet verify it is following the real blockchain and not a fake one. Updating the…

Hardcoded blockchain checkpoints extended for all supported networksNo executable code or cryptographic logic changedNo bug fix, privilege change, or input validation change present
9e0b7e64by ghost43+276−04 files
No security note in commit
Informational 15 AI analysisMessage 58 · Thin
EL ElectrumElectrum BitcoinSoftware wallets

update block header checkpoints

This commit simply refreshes Electrum's built-in list of Bitcoin blockchain checkpoints. Checkpoints are known-good block hashes that help the wallet verify it is following the real chain. The update adds newer checkpoints for mainnet, sig…

e11c579bby SomberNight+276−04 files
No security note in commit
Repository ledger

Explore captured commits

Expand any commit for its author, full message, clarity score, changed files, triage signals, analysis, and source link.

Lower-prioritystorage.write: make os_chmod best-effortby SomberNight · 9d13855c · Sep 5, 2025 · 1 fileMessage 68 · AdequateLow 29Details
Commit message · SomberNight

storage.write: make os_chmod best-effort

closes https://github.com/spesmilo/electrum/issues/8409
closes https://github.com/spesmilo/electrum/pull/8997

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
AI analysis · Low 29/100

This change makes Electrum tolerate a failure when setting restrictive file permissions on a temporary wallet file. Previously, if the operating system refused the permission change (for example on some network file systems), saving a wallet would crash. Now it logs a warning and continues. The security trade-off is that in rare cases a wallet file may be created with slightly looser permissions than intended, but the wallet data is still encrypted by the user's password if the wallet is password-protected.

Security candidateqt confirm_tx_dialog: fix wallet.get_candidates_for_batchingby SomberNight · d01e6b81 · Sep 5, 2025 · 3 filesMessage 81 · StrongLow 34Details
Commit message · SomberNight

qt confirm_tx_dialog: fix wallet.get_candidates_for_batching

I don't understand what the "coins not used" comment meant here.
It was added in the change away from the old config.WALLET_BATCH_RBF option
(https://github.com/spesmilo/electrum/commit/ab14c3e1382c1af48baff73b790aecfbd069eb8a).

The `coins` param *is used* in wallet.get_candidates_for_batching.
Without setting that, the returned set of candidates was restricted to
only base txs that had a large enough change output to cover *all* the newly added outputs.
Instead, it is desirable to allow adding new inputs.

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
Why it was queued
signing boundarysigning or wallet path
AI analysis · Low 34/100

This commit fixes a bug in Electrum's transaction batching feature. Previously, when suggesting which existing transactions could be combined (batched) with a new payment, the code ignored the wallet's available unspent coins. This made the batching suggestions too restrictive and could lead to suboptimal or unexpected transaction construction. The fix passes the available coins into the candidate-selection logic and documents the behavior. There is no direct evidence in the commit of a security vulnerability or exploit.

AI review queuedcommands: add clear error that plugin commands cannot be run with -oby SomberNight · 7455cf9d · Sep 5, 2025 · 1 fileMessage 73 · AdequateInformational 22Details
Commit message · SomberNight

commands: add clear error that plugin commands cannot be run with -o

note that atm none of the plugin commands are explicitly marked with 'n' but all require it.
Also note that 'w' for plugin commands kind of implies 'n' anyway, as the 'load_wallet' hook relies on having a daemon.

```
$ ./run_electrum -o --testnet labels_pull
Password:
1.96 | E | __main__ | error running command (without daemon)
Traceback (most recent call last):
File "/home/user/wspace/electrum/./run_electrum", line 587, in handle_cmd
result = fut.result()
File "/usr/lib/python3.13/concurrent/futures/_base.py", line 456, in result
return self.__get_result()
~~~~~~~~~~~~~~~~~^^
File "/usr/lib/python3.13/concurrent/futures/_base.py", line 401, in __get_result
raise self._exception
File "/home/user/wspace/electrum/./run_electrum", line 267, in run_offline_command
result = await func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/wspace/electrum/electrum/commands.py", line 202, in func_wrapper
return await func(*args, **kwargs)
^^^^^^^^^^^^^^^^^^^^^^^^^^^
File "/home/user/wspace/electrum/electrum/commands.py", line 2214, in func_wrapper
kwargs['plugin'] = daemon._plugins.get_plugin(plugin_name)
^^^^^^^^^^^^^^^
AttributeError: 'NoneType' object has no attribute '_plugins'
```

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
second-pass: broader security terminology
AI analysis · Informational 22/100

This commit fixes a crash in Electrum's command-line tool. When a user ran a plugin-provided command in offline mode (using the -o flag), the program tried to access a daemon object that didn't exist, causing an ugly AttributeError. The patch makes two changes: it automatically marks all plugin commands as requiring a daemon, and it adds an explicit check so the program fails cleanly if a plugin command is somehow run without a daemon. This is a robustness/usability fix rather than a security vulnerability.

AI review queuedkeystore: get_private_keys should not return Noneby SomberNight · 75195b66 · Sep 5, 2025 · 3 filesMessage 68 · AdequateLow 33Details
Commit message · SomberNight

keystore: get_private_keys should not return None

closes https://github.com/spesmilo/electrum/issues/10200

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body✓ Links an issue, advisory, or supporting reference
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 33/100

This commit fixes a small but real bug in Electrum's handling of private key imports. Previously, when a user pasted an empty or invalid list of private keys, the function returned 'None' (meaning 'nothing'). Some parts of the code treated 'None' as if keys were present, which could let an empty or invalid import proceed unexpectedly. The fix makes the function return an empty list instead, so callers correctly recognize there are no valid keys. The direct security impact is limited because the user still has to initiate an import and supply input, but it removes a logic trap that could mishandle private key material.

Lower-priorityswapserver: add commands for statsby f321x · 708aefb0 · Sep 5, 2025 · 1 fileMessage 68 · AdequateInformational 18Details
Commit message · f321x

swapserver: add commands for stats

Adds two command to the swapserver plugin to retrieve some stats so swap
providers can see more easily what is going on on their swapserver.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 18/100

This commit adds two read-only statistics commands to Electrum's swapserver plugin, allowing swap providers to view their swap history and summary. It does not change how swaps are executed, does not move funds, and does not introduce obvious security bugs. The main consideration is that these commands expose swap-related financial data through existing command interfaces, but they appear to use the same access controls as other wallet-lightning ('wl') commands.

Lower-prioritychore: replace calls to asyncio.iscoroutinefunctionby f321x · e7bb75bc · Sep 5, 2025 · 4 filesMessage 97 · StrongInformational 15Details
Commit message · f321x

chore: replace calls to asyncio.iscoroutinefunction

Replace calls to deprecated asyncio.iscoroutinefunction with calls to
inspect.iscoroutinefunction to prevent the following deprecation
warnings from showing up if running with Python 3.14:
```
/home/user/code/electrum-fork/electrum/util.py:1225: DeprecationWarning: 'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction() instead
assert asyncio.iscoroutinefunction(func), 'func needs to be a coroutine'
/home/user/code/electrum-fork/electrum/util.py:507: DeprecationWarning: 'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction() instead
if asyncio.iscoroutinefunction(func):
/home/user/code/electrum-fork/electrum/util.py:1246: DeprecationWarning: 'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction() instead
assert asyncio.iscoroutinefunction(func), 'func needs to be a coroutine'
/home/user/code/electrum-fork/electrum/lnpeer.py:272: DeprecationWarning: 'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction() instead
assert asyncio.iscoroutinefunction(func), 'func needs to be a coroutine'
/home/user/code/electrum-fork/electrum/util.py:1225: DeprecationWarning: 'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction() instead
assert asyncio.iscoroutinefunction(func), 'func needs to be a coroutine'
/home/user/code/electrum-fork/electrum/util.py:507: DeprecationWarning: 'asyncio.iscoroutinefunction' is deprecated and slated for removal in Python 3.16; use inspect.iscoroutinefunction() instead
if asyncio.iscoroutinefunction(func):
```

97/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Explains rationale or failure mode
AI analysis · Informational 15/100

This is a routine cleanup change that swaps one Python built-in check for an equivalent one. It removes future deprecation warnings but does not change what the program actually does or fix any security problem.

Lower-priorityswaps: add type hints to gui swap suggestion flowby f321x · 45bdd6a8 · Sep 4, 2025 · 6 filesMessage 60 · AdequateInformational 15Details
Commit message · f321x

swaps: add type hints to gui swap suggestion flow

Adds type more type hints and clearer variable names to the swap
suggestion flow.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
AI analysis · Informational 15/100

This commit is a code cleanup: it adds type hints and renames a parameter from recv_amount_sat to recv_amount_sat_or_max to reflect that it can be either a number or the special 'max' marker '!'. It also makes the run_swap_dialog method consistently return a boolean. There is no security-relevant behavior change.

Lower-priorityqt: SwapDialog: don't force amount on userby f321x · 3df1af8e · Sep 4, 2025 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · f321x

qt: SwapDialog: don't force amount on user

When a SwapDialog gets initiated with a recv_amount_sat through the
receive tab the Max Button and edits are disabled and the user is forced
to do a swap with the preset amount. Maybe the user wants to do a larger
swap?

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit removes a UI restriction in Electrum's swap dialog. Previously, when opening a submarine swap from the receive tab with a pre-set amount, the amount fields and Max button were disabled, forcing the user to swap exactly that amount. The change keeps those fields editable so users can adjust the swap amount if they want a larger or different swap. It also tweaks an error message to clarify that a swap may not be possible with the current provider. There is no security issue here.

Lower-priorityci: add task to run unittests with frozen depsby SomberNight · b60d2e96 · Sep 3, 2025 · 1 fileMessage 90 · StrongInformational 15Details
Commit message · SomberNight

ci: add task to run unittests with frozen deps

I think it makes sense to run the tests with both the "latest" dependencies,
and with the pinned dependencies that we package for releases.

Testing with latest can reveal changes/issues with new dep versions,
while testing with pinned is testing what users will actually run.
Previously we were only testing with "latest".

90/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only changes the project's continuous integration (CI) configuration. It adds a new automated test job that runs the existing unit tests using the exact pinned dependency versions shipped in Electrum's release binaries, in addition to the existing job that tests with the latest dependencies. There is no change to application code, no bug fix, and no security patch.

Lower-priorityci: tests: move away from tox, just use pytest directlyby SomberNight · 6583a986 · Sep 3, 2025 · 3 filesMessage 100 · StrongInformational 15Details
Commit message · SomberNight

ci: tests: move away from tox, just use pytest directly

- it was originally added in https://github.com/spesmilo/electrum/pull/1334,
with the goal of simplifying running the tests on local dev machines.
However this usage is not documented anywhere, and AFAIK regular contributors
don't use it either.
- tox just adds another layer of abstraction that is not that useful IMO
- I want more control over which electrum-deps are installed, which tox is
(in this case) unhelpfully abstracting away

100/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Uses a recognizable type or scope✓ Provides detailed explanatory context✓ Mentions testing or verification✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100

This commit is a routine cleanup of the project's automated testing setup. It removes the 'tox' tool and runs tests directly with pytest. There is no change to the Electrum wallet application itself, no bug fix, and no security-related change.

Lower-prioritydaemon: get_wallet: handle OSError for weiiird pathsby SomberNight · c68deb25 · Sep 3, 2025 · 2 filesMessage 81 · StrongInformational 24Details
Commit message · SomberNight

daemon: get_wallet: handle OSError for weiiird paths

I think _wallet_key_from_path should not raise.
This is probably the sane way to deal with this.
Though all this is assuming that os.path.realpath can be treated as consistent/stateless.

closes https://github.com/spesmilo/electrum/issues/10182

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 24/100

This commit hardens Electrum's daemon so that unusual or malformed wallet file paths no longer cause the program to crash with an unhandled error. It wraps a filesystem path normalization call in a try/except block and logs a warning instead of raising an exception. The change is defensive and improves robustness, but it does not appear to fix an active security vulnerability.

Security candidatecontrib: shell scripts: add quotes around more variablesby SomberNight · 4a0a3bb3 · Sep 2, 2025 · 11 filesMessage 50 · ThinLow 26Details
Commit message · SomberNight

contrib: shell scripts: add quotes around more variables

50/100 · ThinMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
cryptography-sensitive pathsigning or wallet path
AI analysis · Low 26/100

This commit adds missing quotation marks around variables in a collection of build and release shell scripts. In shell scripting, unquoted variables can split or be interpreted unexpectedly if paths contain spaces or special characters. The change is defensive hardening of the project's build tooling rather than a fix for a specific reported exploit. It reduces the risk of build failures or accidental command injection during release builds, but it does not patch a vulnerability in the wallet software that end users run.

Lower-priorityqml: android: add padding to report dialog in ExcDialogby f321x · debb4da9 · Sep 2, 2025 · 1 fileMessage 81 · StrongInformational 15Details
Commit message · f321x

qml: android: add padding to report dialog in ExcDialog

Adds padding to the report content dialog in the QML ExceptionDialog if
required on android.
Followup https://github.com/spesmilo/electrum/pull/10178

81/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Links an issue, advisory, or supporting reference
AI analysis · Informational 15/100

This commit is a minor user-interface layout fix for the Android version of Electrum. It adds spacing so that the crash/error report dialog does not overlap the Android system status bar at the top or the navigation bar at the bottom. There is no security-relevant change in the code.

AI review queuedqml: add some type hints to qetxfinalizerby SomberNight · c8a14cc2 · Sep 1, 2025 · 3 filesMessage 45 · ThinInformational 15Details
Commit message · SomberNight

qml: add some type hints to qetxfinalizer

45/100 · ThinMessage clarity
✓ Descriptive subject✓ Names a concrete action or component! No meaningful explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit only adds Python type hints and fixes a minor return-value consistency bug in the QML GUI code. It does not change runtime behavior in a security-relevant way, and there is no indication it fixes a vulnerability.

AI review queuedqt: receive tab: also suggest swap for 0 amnt reqby f321x · a62dbb56 · Sep 1, 2025 · 2 filesMessage 80 · StrongInformational 18Details
Commit message · f321x

qt: receive tab: also suggest swap for 0 amnt req

Also suggest a submarine swap if the user creates a 0 amount invoice and
has 0 sat incoming liquidity as it won't be possible to receive
anything.
Users potentially just open a channel, then want to create a lightning invoice
without amount like they are used to from onchain addresses, and then
wonder why receiving doesn't work. So we should at least propose a swap
if there is no inbound liquidity at all.

80/100 · StrongMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Explains rationale or failure mode
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 18/100

This commit is a small user-experience improvement in the Electrum Bitcoin wallet's Qt receive tab. It makes the wallet suggest a 'submarine swap' (a way to gain inbound Lightning capacity) even when the user creates a zero-amount Lightning invoice, if they currently have no incoming liquidity. It also tweaks some help messages shown to users. There is no security vulnerability here.

Lower-priorityswaps: make min swap amount a const varby f321x · 2c67c5e1 · Sep 1, 2025 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · f321x

swaps: make min swap amount a const var

instead of hardcoding 20_000 sat directly in the code, make
MIN_SWAP_AMOUNT_SAT a const variable outside of SwapManager so it can be
used for other code too.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a simple code cleanup: it replaces a hardcoded number (20,000 satoshis) with a named constant variable. The actual value and behavior are unchanged. There is no security issue here.

Lower-priorityqml: adapt exception dialog to edge-to-edge layoutby f321x · 0263b5ec · Aug 28, 2025 · 1 fileMessage 73 · AdequateInformational 15Details
Commit message · f321x

qml: adapt exception dialog to edge-to-edge layout

Even though the exception dialog inherits from ElDialog the padding
didn't work as it overwrites the properties of the ElDialog. So the
padding has to be applied separately to the ExceptionDialog.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 15/100

This commit is a purely cosmetic UI adjustment for Electrum's mobile-style QML interface. It changes how padding is applied to the exception/error dialog so that it displays correctly on modern edge-to-edge phone screens. There is no security relevance.

Lower-priorityandroid: 16kb alignment updatesby Sander van Grieken · 87d82f38 · Aug 28, 2025 · 5 filesMessage 58 · ThinInformational 19Details
Commit message · Sander van Grieken

android: 16kb alignment updates

p4a ref: electrum_20240930_android_16kb_page_alignment
Dockerfile: obtain 16kb aligned NDK r23 from google CI (dl-ndk-ci.sh)
barcode, zxing-cpp: add 16kb align patch
build_tools_util.sh: add function to apply a patch

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
AI analysis · Informational 19/100

This commit updates Electrum's Android build setup so the app works on newer Android devices that require 16 KB memory page alignment. It swaps the Android NDK to a special canary/CI build, adds a small patch to the barcode scanner library, and adds a helper script to apply patches. There is no direct evidence this fixes an active security vulnerability; it appears to be a compatibility/build hardening change.

Lower-prioritylnurl: only sanitize untrusted LNURL errorsby f321x · bcb74069 · Aug 27, 2025 · 1 fileMessage 60 · AdequateModerate 50Details
Commit message · f321x

lnurl: only sanitize untrusted LNURL errors

it is not neccessary to sanitize all LNURLErrors as most are just source
strings.

60/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
defensive validation
AI analysis · Moderate 50/100

This commit tightens how Electrum handles error messages coming from external LNURL services. Previously, every LNURL error was wrapped with a 'do not trust this message' warning. The change splits those errors into two kinds: errors generated from Electrum's own code now display normally, while only errors returned by untrusted LNURL servers are sanitized and flagged as untrusted. It also applies a text-safety utility to the server-provided message before showing it to the user, reducing the chance that a malicious or compromised LNURL server could trick a user through a crafted error string.

AI review queuedqml: use declarative form for invoiceResolved and requestResolved in WalletMainViewby Sander van Grieken · 313c8a13 · Aug 27, 2025 · 2 filesMessage 65 · AdequateInformational 15Details
Commit message · Sander van Grieken

qml: use declarative form for invoiceResolved and requestResolved in WalletMainView

(cherry picked from commit 78b2e3df6c47ad5d5d119cbc2372e62807f372fd)

65/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides an explanatory body
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a minor code-quality refactor in Electrum's mobile/QML user interface. It changes how two internal signals (invoiceResolved and requestResolved) are declared and connected, switching from an imperative connection in Python to a declarative connection in QML. There is no visible security relevance: no input validation, cryptography, network handling, or asset-moving logic is changed.

Lower-priorityqml: lnurlw: bind walletCanReceive to in-liquidityby f321x · c2f5b3ba · Aug 27, 2025 · 1 fileMessage 73 · AdequateInformational 17Details
Commit message · f321x

qml: lnurlw: bind walletCanReceive to in-liquidity

binds the walletCanReceive variable to the available inbound liquidity
so the withdraw button gets enabled when the channels reconnect if the
user opens a lnurlw request dialog before the channels have connected.

73/100 · AdequateMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
AI analysis · Informational 17/100

This is a small user-interface fix in Electrum's mobile-style QML wallet. It makes the 'Withdraw' button correctly enable itself once Lightning channels finish connecting, if the user opened a withdrawal request dialog early. There is no indication this is a security fix; it appears to be a usability/bug-fix for a UI state not updating properly.

AI review queuedqml: separate PI resolving from QEInvoiceParserby f321x · b90090e2 · Aug 27, 2025 · 8 filesMessage 68 · AdequateInformational 10Details
Commit message · f321x

qml: separate PI resolving from QEInvoiceParser

separates the resolving step from the QEInvoiceParser so the 'recipient'
can be resolved first and then either an QEInvoiceParser can be used if
it is a sending request that has been resolved (invoice, address,
lnurlp, ...), or RequestDetails can be used if the resolved 'recipient'
turns out to be a voucher/LNURLW string.

# Conflicts:
# electrum/gui/qml/qeinvoice.py

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 10/100

This commit is a code cleanup in Electrum's mobile/QML user interface. It splits the job of interpreting a payment string (like a Lightning invoice or LNURL link) into two parts: one that resolves/fetches remote details, and one that handles the resulting payment or withdrawal request. There is no indication in the commit that it fixes a security bug or vulnerability; it appears to be a refactor to support voucher/LNURL-withdrawal flows more cleanly.

Lower-prioritytests: add more lnurl testing for PaymentIdentifierby f321x · 72dfc61d · Aug 27, 2025 · 1 fileMessage 83 · StrongInformational 15Details
Commit message · f321x

tests: add more lnurl testing for PaymentIdentifier

adds some more detailed tests to `test_payment_identifier.py` to test
lnurlp and lnurlw separately and mock their resolve.

83/100 · StrongMessage clarity
✓ Specific, descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context✓ Mentions testing or verification
AI analysis · Informational 15/100

This commit only adds new automated tests for how Electrum parses and resolves LNURL payment strings. It does not change any production wallet code, so it cannot introduce a security vulnerability or fix one on its own.

AI review queuedlnurl: implement LNURL-withdrawby f321x · fdeada3f · Aug 27, 2025 · 9 filesMessage 58 · ThinLow 28Details
Commit message · f321x

lnurl: implement LNURL-withdraw

adds handling of lnurl-withdraw payment identifiers which allow users to
withdraw bitcoin from a service by scanning a qr code or pasting the
lnurl-w code as "sending" address.

58/100 · ThinMessage clarity
✓ Descriptive subject✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Low 28/100

This commit adds a new feature to Electrum that lets users withdraw bitcoin from a service by scanning or pasting an LNURL-withdraw code. It is a feature addition, not a fix for a known vulnerability. The code does include some safety checks, such as only allowing HTTPS or .onion callback URLs and warning users not to trust error messages from the LNURL server. However, because this is brand-new code handling real money withdrawals and interacting with external services, it introduces new attack surface. There is no direct evidence in the commit of an exploitable bug, but the change is security-relevant by nature.

AI review queuedqml: LoadingWalletDialog: add some paddingby f321x · f1dfe5e2 · Aug 27, 2025 · 1 fileMessage 68 · AdequateInformational 15Details
Commit message · f321x

qml: LoadingWalletDialog: add some padding

add some padding at the bottom of the LoadingWalletDialog so the
spinning circle is not directly at the bottom of the dialog, looks a bit
nicer this way.

68/100 · AdequateMessage clarity
✓ Descriptive subject✓ Names a concrete action or component✓ Provides detailed explanatory context
Why it was queued
signing or wallet pathsecond-pass: security-sensitive path
AI analysis · Informational 15/100

This commit is a purely cosmetic user-interface tweak. It adds 20 pixels of empty space at the bottom of a loading dialog so the spinning circle is not touching the dialog edge. There is no security relevance.