Electrum

This commit fixes a single typo in a code comment, changing 'treat is as' to 'treat it as'. It does not change any executable code or program behavior.

This commit only updates test helper code to stop using a Python function that will be removed in a future Python version. It does not change Electrum's wallet, networking, or cryptography code, and it does not fix any security bug.

This commit only updates the project's automated testing configuration to add Python 3.14 to the list of versions used during routine tests. It does not change any application code, user-facing behavior, or security-sensitive logic.

This commit only adds Python type-hints to three method signatures in Electrum's Lightning Network worker code. It does not change any runtime behavior, logic, or data handling. There is no security relevance.

This commit is a minor code cleanup that adds Python type-hints and slightly refactors two helper methods. It does not change program behavior or fix any security issue.

This commit is a pure code reorganization: four helper methods were moved from the base Transaction class to the more specific PartialTransaction subclass. The code itself is unchanged, and the commit message explicitly states it is 'move-only'. There is no security fix or behavior change visible in the diff.

This commit removes unused code from Electrum's Qt graphical interface. The deleted block checked whether the wallet had enough funds before opening a transaction confirmation dialog, but it was already marked by the developers as likely broken ('FIXME this check looks broken?') and appears to be dead code. The change does not introduce new behavior; it only cleans up an unused code path and makes a function argument keyword-only.

This commit simply renames a wallet method by adding an underscore prefix, which is a Python convention for 'this is intended for internal use only.' No behavior, logic, or security properties of the code change. It is a cosmetic/private-API marking.

This commit changes how Electrum advertises its Lightning network features. When the wallet is configured to forward payments (including trampoline payments), it now tells other nodes it supports onion messages. This is a protocol-correctness fix: a node that forwards payments should advertise the feature it is actually using. It is not a fix for an active exploit, but it removes a minor inconsistency that could affect interoperability or routing.

This is a routine code update that changes how two parts of Electrum's user interface call an internal Lightning invoice function. The old function signature was replaced with a newer one, so the code was adjusted to match. There is no indication this fixes or introduces a security issue.

This commit is a minor user-interface follow-up that adjusts Android edge-to-edge layout padding for a Lightning withdrawal dialog. It adds one line setting a padding flag to false so the dialog renders correctly on newer Android versions. There is no security relevance in the change itself.

This commit adds a new command-line feature to export the secret 'preimage' for a settled Lightning invoice, and also includes the preimage in the result of checking a held invoice. The preimage is the cryptographic proof that a Lightning payment was received; anyone who knows it can claim the payment. The developers deliberately avoided exposing the preimage in some other command outputs because it could be accidentally shared with a payer or exposed via the payment server. The change itself is a feature addition, not a fix for an active vulnerability, but it touches sensitive secret material.

This commit tightens how Electrum creates Lightning invoices so the stored payment record and the generated invoice always match. Previously, callers passed invoice details separately, creating a risk that the invoice could differ from what Electrum later used to validate incoming payments. Now a single PaymentInfo object is required, and it stores extra fields (expiry and minimum locktime) so validation can rely on it. This is a defensive hardening change, not a fix for a known active exploit.

This commit is a straightforward code reorganization: it moves several Lightning Network HTLC (payment forwarding) helper functions from the peer-specific file (lnpeer.py) into the broader worker file (lnworker.py). The actual logic, checks, and behavior of the functions are preserved almost unchanged. There is no indication this change fixes or introduces a security vulnerability.

This is a tiny code-style change that forces callers to name each argument when creating an OnionPacket object. It does not change what the code does, only how callers must write their arguments. There is no security issue here.

This commit is a simple renaming of an internal label from 'ACCEPTED' to 'COMPLETE' to make the code's meaning clearer. It does not change what the program actually does, only the names used inside the code. There is no security fix or vulnerability here.

This change tightens how Electrum's Lightning code handles onion-routed payment packets. Previously, an unsupported onion packet version would trigger a broad exception while the packet was being decoded. Now the version is stored and checked later in processing, allowing the code to send a proper Lightning protocol failure message back instead of crashing or misbehaving. It is a defensive correctness fix rather than a clear-cut vulnerability patch.

This commit stops a background task called htlc_switch from running for simple Lightning Network gossip-only peers. Previously, this task was started for all peers, including ones that only exchange network routing information and never handle actual payments. The change moves the task start so it only runs for full wallet peers. The commit message frames this as a cleanup because gossip peers don't handle HTLCs (payment channels), not as a security fix. There is no direct evidence in the commit of an exploitable vulnerability.

This commit is a simple code cleanup: it moves two Lightning Network data structures (RecvMPPResolution and ReceivedMPPStatus) from one file to another shared utility file so both lnpeer.py and lnworker.py can use them without circular imports. There is no functional change and no security relevance.

This commit removes an old fallback method Electrum used to check Lightning payment secrets. Previously, when receiving a Lightning payment, Electrum would accept either the current payment secret or a legacy one derived from the payment preimage. The commit drops the legacy fallback. This is a cleanup change that slightly tightens validation, but it is not a clear security fix and could theoretically break payments from very old wallets that still use the legacy secret.

This commit hardens Electrum's Lightning onion routing code against timing attacks. It replaces a normal HMAC comparison with a constant-time one, so an attacker can't learn secrets by measuring how quickly checks fail. It also changes how failed onion error messages are decoded so that the number of hops in a payment route is hidden, matching the Lightning network specification.

This commit is a routine internal refactoring: it converts a Lightning Network data structure called UpdateAddHtlc from using the third-party 'attr' library to Python's built-in 'dataclasses'. It also removes a legacy dictionary-to-object conversion path and adds validation checks when creating these objects. There is no security fix or vulnerability here.

This commit is a straightforward internal code cleanup in Electrum's Lightning payment handling. It converts a simple data container (PaymentInfo) from a NamedTuple to a Python dataclass and adds basic type/length validation when creating these objects. There is no security fix or vulnerability being addressed.

This commit simply tidies up Python import statements in one file. It removes unused imports and merges some import lines. There is no change to program logic, no bug fix, and no security relevance.

This commit is a test-suite cleanup, not a fix for a user-facing security bug. It stops old test objects from leaking between unit tests by clearing a global callback list after each test. That makes tests faster and less error-prone, but it does not change how the real Electrum wallet handles callbacks in production.